From: "Christian König" <christian.koenig@amd.com> To: Rob Clark <robdclark@chromium.org> Cc: David Airlie <airlied@linux.ie>, freedreno@lists.freedesktop.org, Abhinav Kumar <quic_abhinavk@quicinc.com>, ML dri-devel <dri-devel@lists.freedesktop.org>, Sumit Semwal <sumit.semwal@linaro.org>, linux-arm-msm@vger.kernel.org, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Sean Paul <sean@poorly.run> Subject: Re: [PATCH v2] drm/msm: add trace_dma_fence_emit to msm_gpu_submit Date: Tue, 26 Apr 2022 19:08:47 +0200 [thread overview] Message-ID: <215f55f6-97b8-5dd3-a2cc-fe42e19a2769@amd.com> (raw) In-Reply-To: <CAJs_Fx7OQ2OJo3pQ-ETT1827PtfuFsvn984gg8GeDVrqy0Ucug@mail.gmail.com> Am 26.04.22 um 19:05 schrieb Rob Clark: > On Tue, Apr 26, 2022 at 9:42 AM Christian König > <christian.koenig@amd.com> wrote: >> Am 26.04.22 um 18:32 schrieb Chia-I Wu: >>> On Tue, Apr 12, 2022 at 2:26 PM Chia-I Wu <olvaffe@gmail.com> wrote: >>>> In practice, trace_dma_fence_init called from dma_fence_init is good >>>> enough and almost no driver calls trace_dma_fence_emit. But drm_sched >>>> and virtio both have cases where trace_dma_fence_init and >>>> trace_dma_fence_emit can be apart. It is easier for visualization tools >>>> to always use the more correct trace_dma_fence_emit when visualizing >>>> fence timelines. >>>> >>>> v2: improve commit message (Dmitry) >>>> >>>> Signed-off-by: Chia-I Wu <olvaffe@gmail.com> >>>> Cc: Rob Clark <robdclark@chromium.org> >>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>> This has been reviewed. Should we land it? >> No, there are still open discussions about it. > I think if it is needed for trace visualization, that is justification > enough for me > > I don't really see otherwise how a generic trace visualization tool > like perfetto would handle the case that some fence timelines have > separate events but others do not. Well I just send a patch to completely remove the trace point. As I said it absolutely doesn't make sense to use this for visualization, that's what the trace_dma_fence_init trace point is good for. The only use case is for debugging the GPU scheduler and we should probably introduce a separate GPU scheduler specific trace point for this instead if we should ever need it. Regards, Christian. > > BR, > -R > >> Regards, >> Christian. >> >>> (Or, how do I check if it has landed?)
WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <christian.koenig@amd.com> To: Rob Clark <robdclark@chromium.org> Cc: Chia-I Wu <olvaffe@gmail.com>, freedreno@lists.freedesktop.org, ML dri-devel <dri-devel@lists.freedesktop.org>, Sean Paul <sean@poorly.run>, Abhinav Kumar <quic_abhinavk@quicinc.com>, David Airlie <airlied@linux.ie>, Sumit Semwal <sumit.semwal@linaro.org>, linux-arm-msm@vger.kernel.org, Daniel Vetter <daniel@ffwll.ch>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Subject: Re: [PATCH v2] drm/msm: add trace_dma_fence_emit to msm_gpu_submit Date: Tue, 26 Apr 2022 19:08:47 +0200 [thread overview] Message-ID: <215f55f6-97b8-5dd3-a2cc-fe42e19a2769@amd.com> (raw) In-Reply-To: <CAJs_Fx7OQ2OJo3pQ-ETT1827PtfuFsvn984gg8GeDVrqy0Ucug@mail.gmail.com> Am 26.04.22 um 19:05 schrieb Rob Clark: > On Tue, Apr 26, 2022 at 9:42 AM Christian König > <christian.koenig@amd.com> wrote: >> Am 26.04.22 um 18:32 schrieb Chia-I Wu: >>> On Tue, Apr 12, 2022 at 2:26 PM Chia-I Wu <olvaffe@gmail.com> wrote: >>>> In practice, trace_dma_fence_init called from dma_fence_init is good >>>> enough and almost no driver calls trace_dma_fence_emit. But drm_sched >>>> and virtio both have cases where trace_dma_fence_init and >>>> trace_dma_fence_emit can be apart. It is easier for visualization tools >>>> to always use the more correct trace_dma_fence_emit when visualizing >>>> fence timelines. >>>> >>>> v2: improve commit message (Dmitry) >>>> >>>> Signed-off-by: Chia-I Wu <olvaffe@gmail.com> >>>> Cc: Rob Clark <robdclark@chromium.org> >>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>> This has been reviewed. Should we land it? >> No, there are still open discussions about it. > I think if it is needed for trace visualization, that is justification > enough for me > > I don't really see otherwise how a generic trace visualization tool > like perfetto would handle the case that some fence timelines have > separate events but others do not. Well I just send a patch to completely remove the trace point. As I said it absolutely doesn't make sense to use this for visualization, that's what the trace_dma_fence_init trace point is good for. The only use case is for debugging the GPU scheduler and we should probably introduce a separate GPU scheduler specific trace point for this instead if we should ever need it. Regards, Christian. > > BR, > -R > >> Regards, >> Christian. >> >>> (Or, how do I check if it has landed?)
next prev parent reply other threads:[~2022-04-26 17:08 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-12 21:25 [PATCH v2] drm/msm: add trace_dma_fence_emit to msm_gpu_submit Chia-I Wu 2022-04-12 21:25 ` Chia-I Wu 2022-04-26 16:32 ` Chia-I Wu 2022-04-26 16:32 ` Chia-I Wu 2022-04-26 16:42 ` Christian König 2022-04-26 16:42 ` Christian König 2022-04-26 17:05 ` Rob Clark 2022-04-26 17:05 ` Rob Clark 2022-04-26 17:08 ` Christian König [this message] 2022-04-26 17:08 ` Christian König 2022-04-26 17:16 ` Rob Clark 2022-04-26 17:16 ` Rob Clark 2022-04-26 17:20 ` Christian König 2022-04-26 17:20 ` Christian König 2022-04-26 17:40 ` Chia-I Wu 2022-04-26 17:40 ` Chia-I Wu 2022-04-26 18:02 ` Christian König 2022-04-26 18:02 ` Christian König 2022-04-26 18:50 ` Chia-I Wu 2022-04-26 18:50 ` Chia-I Wu 2022-04-27 6:19 ` Christian König 2022-04-27 6:19 ` Christian König 2022-04-27 16:07 ` Rob Clark 2022-04-27 16:07 ` Rob Clark 2022-04-27 17:55 ` Chia-I Wu 2022-04-27 17:55 ` Chia-I Wu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=215f55f6-97b8-5dd3-a2cc-fe42e19a2769@amd.com \ --to=christian.koenig@amd.com \ --cc=airlied@linux.ie \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=quic_abhinavk@quicinc.com \ --cc=robdclark@chromium.org \ --cc=sean@poorly.run \ --cc=sumit.semwal@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.