All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/bridge: make drm_bridge_funcs const
@ 2017-08-08 15:54 Bhumika Goyal
  2017-08-08 16:03 ` Laurent Pinchart
  0 siblings, 1 reply; 3+ messages in thread
From: Bhumika Goyal @ 2017-08-08 15:54 UTC (permalink / raw)
  To: julia.lawall, architt, a.hajda, Laurent.pinchart, airlied,
	dri-devel, linux-kernel
  Cc: Bhumika Goyal

Make these structures const as they are only stored in the funcs field
of drm_bridge structure, which is of type const.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c  | 2 +-
 drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index ee16635..58b4fb2 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -857,7 +857,7 @@ static int adv7511_bridge_attach(struct drm_bridge *bridge)
 	return ret;
 }
 
-static struct drm_bridge_funcs adv7511_bridge_funcs = {
+static const struct drm_bridge_funcs adv7511_bridge_funcs = {
 	.enable = adv7511_bridge_enable,
 	.disable = adv7511_bridge_disable,
 	.mode_set = adv7511_bridge_mode_set,
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
index 36f5ccb..63c7a01 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
@@ -811,7 +811,7 @@ static int dw_mipi_dsi_bridge_attach(struct drm_bridge *bridge)
 	return drm_bridge_attach(bridge->encoder, dsi->panel_bridge, bridge);
 }
 
-static struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = {
+static const struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = {
 	.mode_set     = dw_mipi_dsi_bridge_mode_set,
 	.enable	      = dw_mipi_dsi_bridge_enable,
 	.post_disable = dw_mipi_dsi_bridge_post_disable,
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: make drm_bridge_funcs const
  2017-08-08 15:54 [PATCH] drm/bridge: make drm_bridge_funcs const Bhumika Goyal
@ 2017-08-08 16:03 ` Laurent Pinchart
  2017-08-09 12:36   ` Archit Taneja
  0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2017-08-08 16:03 UTC (permalink / raw)
  To: Bhumika Goyal
  Cc: julia.lawall, architt, a.hajda, airlied, dri-devel, linux-kernel

Hi Bhumika,

Thank you for the patch.

On Tuesday 08 Aug 2017 21:24:10 Bhumika Goyal wrote:
> Make these structures const as they are only stored in the funcs field
> of drm_bridge structure, which is of type const.
> Done using Coccinelle.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/bridge/adv7511/adv7511_drv.c  | 2 +-
>  drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index ee16635..58b4fb2
> 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> @@ -857,7 +857,7 @@ static int adv7511_bridge_attach(struct drm_bridge
> *bridge) return ret;
>  }
> 
> -static struct drm_bridge_funcs adv7511_bridge_funcs = {
> +static const struct drm_bridge_funcs adv7511_bridge_funcs = {
>  	.enable = adv7511_bridge_enable,
>  	.disable = adv7511_bridge_disable,
>  	.mode_set = adv7511_bridge_mode_set,
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index 36f5ccb..63c7a01
> 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> @@ -811,7 +811,7 @@ static int dw_mipi_dsi_bridge_attach(struct drm_bridge
> *bridge) return drm_bridge_attach(bridge->encoder, dsi->panel_bridge,
> bridge); }
> 
> -static struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = {
> +static const struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = {
>  	.mode_set     = dw_mipi_dsi_bridge_mode_set,
>  	.enable	      = dw_mipi_dsi_bridge_enable,
>  	.post_disable = dw_mipi_dsi_bridge_post_disable,

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: make drm_bridge_funcs const
  2017-08-08 16:03 ` Laurent Pinchart
@ 2017-08-09 12:36   ` Archit Taneja
  0 siblings, 0 replies; 3+ messages in thread
From: Archit Taneja @ 2017-08-09 12:36 UTC (permalink / raw)
  To: Laurent Pinchart, Bhumika Goyal
  Cc: julia.lawall, a.hajda, airlied, dri-devel, linux-kernel



On 08/08/2017 09:33 PM, Laurent Pinchart wrote:
> Hi Bhumika,
> 
> Thank you for the patch.
> 
> On Tuesday 08 Aug 2017 21:24:10 Bhumika Goyal wrote:
>> Make these structures const as they are only stored in the funcs field
>> of drm_bridge structure, which is of type const.
>> Done using Coccinelle.
>>
>> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

queued to drm-misc-next

Thanks,
Archit

> 
>> ---
>>   drivers/gpu/drm/bridge/adv7511/adv7511_drv.c  | 2 +-
>>   drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
>> b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index ee16635..58b4fb2
>> 100644
>> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
>> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
>> @@ -857,7 +857,7 @@ static int adv7511_bridge_attach(struct drm_bridge
>> *bridge) return ret;
>>   }
>>
>> -static struct drm_bridge_funcs adv7511_bridge_funcs = {
>> +static const struct drm_bridge_funcs adv7511_bridge_funcs = {
>>   	.enable = adv7511_bridge_enable,
>>   	.disable = adv7511_bridge_disable,
>>   	.mode_set = adv7511_bridge_mode_set,
>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>> b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index 36f5ccb..63c7a01
>> 100644
>> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>> @@ -811,7 +811,7 @@ static int dw_mipi_dsi_bridge_attach(struct drm_bridge
>> *bridge) return drm_bridge_attach(bridge->encoder, dsi->panel_bridge,
>> bridge); }
>>
>> -static struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = {
>> +static const struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = {
>>   	.mode_set     = dw_mipi_dsi_bridge_mode_set,
>>   	.enable	      = dw_mipi_dsi_bridge_enable,
>>   	.post_disable = dw_mipi_dsi_bridge_post_disable,
> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-09 12:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-08 15:54 [PATCH] drm/bridge: make drm_bridge_funcs const Bhumika Goyal
2017-08-08 16:03 ` Laurent Pinchart
2017-08-09 12:36   ` Archit Taneja

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.