From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: lujialin4@huawei.com, Mauro Carvalho Chehab <mchehab@kernel.org>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Lu Jialin <lujialin4@huawei.com>
Cc: linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] media: sun8i: Fix PM reference leak in deinterlace_start_streaming()
Date: Sun, 11 Apr 2021 20:18:41 +0200 [thread overview]
Message-ID: <2184866.DZomrXFPLt@kista> (raw)
In-Reply-To: <20210408133630.56299-1-lujialin4@huawei.com>
Dne četrtek, 08. april 2021 ob 15:36:30 CEST je Lu Jialin napisal(a):
>
> pm_runtime_get_sync will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here.
> Fix it by replacing it with pm_runtime_resume_and_get to keep usage
> counter balanced.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Lu Jialin <lujialin4@huawei.com>
Acked-by: Jernej Skrabec <jernej.skrabec@siol.net>
Best regards,
Jernej
WARNING: multiple messages have this Message-ID (diff)
From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: lujialin4@huawei.com, Mauro Carvalho Chehab <mchehab@kernel.org>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Lu Jialin <lujialin4@huawei.com>
Cc: linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] media: sun8i: Fix PM reference leak in deinterlace_start_streaming()
Date: Sun, 11 Apr 2021 20:18:41 +0200 [thread overview]
Message-ID: <2184866.DZomrXFPLt@kista> (raw)
In-Reply-To: <20210408133630.56299-1-lujialin4@huawei.com>
Dne četrtek, 08. april 2021 ob 15:36:30 CEST je Lu Jialin napisal(a):
>
> pm_runtime_get_sync will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here.
> Fix it by replacing it with pm_runtime_resume_and_get to keep usage
> counter balanced.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Lu Jialin <lujialin4@huawei.com>
Acked-by: Jernej Skrabec <jernej.skrabec@siol.net>
Best regards,
Jernej
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-11 18:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 13:36 [PATCH -next] media: sun8i: Fix PM reference leak in deinterlace_start_streaming() Lu Jialin
2021-04-08 13:36 ` Lu Jialin
2021-04-11 18:18 ` Jernej Škrabec [this message]
2021-04-11 18:18 ` Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2184866.DZomrXFPLt@kista \
--to=jernej.skrabec@siol.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=lujialin4@huawei.com \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.