All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>,
	Markus Armbruster <armbru@redhat.com>
Cc: Valeriy Vdovin <valeriy.vdovin@virtuozzo.com>,
	qemu-devel@nongnu.org,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Eric Blake <eblake@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Laurent Vivier <lvivier@redhat.com>,
	kvm@vger.kernel.org, Denis Lunev <den@openvz.org>,
	Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Subject: Re: [PATCH v12] qapi: introduce 'query-x86-cpuid' QMP command.
Date: Wed, 11 Aug 2021 08:09:55 +0200	[thread overview]
Message-ID: <2191952f-6989-771a-1f0a-ece58262d141@redhat.com> (raw)
In-Reply-To: <20210810185644.iyqt3iao2qdqd5jk@habkost.net>

On 10/08/2021 20.56, Eduardo Habkost wrote:
> On Sat, Aug 07, 2021 at 04:22:42PM +0200, Markus Armbruster wrote:
>> Is this intended to be a stable interface?  Interfaces intended just for
>> debugging usually aren't.
> 
> I don't think we need to make it a stable interface, but I won't
> mind if we declare it stable.

If we don't feel 100% certain yet, it's maybe better to introduce this with 
a "x-" prefix first, isn't it? I.e. "x-query-x86-cpuid" ... then it's clear 
that this is only experimental/debugging/not-stable yet. Just my 0.02 €.

  Thomas


WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>,
	Markus Armbruster <armbru@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
	Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	qemu-devel@nongnu.org,
	Valeriy Vdovin <valeriy.vdovin@virtuozzo.com>,
	Denis Lunev <den@openvz.org>, Paolo Bonzini <pbonzini@redhat.com>,
	Eric Blake <eblake@redhat.com>
Subject: Re: [PATCH v12] qapi: introduce 'query-x86-cpuid' QMP command.
Date: Wed, 11 Aug 2021 08:09:55 +0200	[thread overview]
Message-ID: <2191952f-6989-771a-1f0a-ece58262d141@redhat.com> (raw)
In-Reply-To: <20210810185644.iyqt3iao2qdqd5jk@habkost.net>

On 10/08/2021 20.56, Eduardo Habkost wrote:
> On Sat, Aug 07, 2021 at 04:22:42PM +0200, Markus Armbruster wrote:
>> Is this intended to be a stable interface?  Interfaces intended just for
>> debugging usually aren't.
> 
> I don't think we need to make it a stable interface, but I won't
> mind if we declare it stable.

If we don't feel 100% certain yet, it's maybe better to introduce this with 
a "x-" prefix first, isn't it? I.e. "x-query-x86-cpuid" ... then it's clear 
that this is only experimental/debugging/not-stable yet. Just my 0.02 €.

  Thomas



  reply	other threads:[~2021-08-11  6:10 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28 12:54 [PATCH v12] qapi: introduce 'query-x86-cpuid' QMP command Valeriy Vdovin
2021-07-28 13:25 ` [PATCH-for-6.2 " Philippe Mathieu-Daudé
2021-07-28 13:25   ` Philippe Mathieu-Daudé
2021-08-07 14:22 ` [PATCH " Markus Armbruster
2021-08-07 14:22   ` Markus Armbruster
2021-08-10 18:56   ` Eduardo Habkost
2021-08-10 18:56     ` Eduardo Habkost
2021-08-11  6:09     ` Thomas Huth [this message]
2021-08-11  6:09       ` Thomas Huth
2021-08-11 13:40       ` Eduardo Habkost
2021-08-11 13:40         ` Eduardo Habkost
2021-08-11 13:44         ` Thomas Huth
2021-08-11 13:44           ` Thomas Huth
2021-08-11 13:58           ` Eduardo Habkost
2021-08-11 13:58             ` Eduardo Habkost
2021-08-23 13:35             ` Markus Armbruster
2021-08-23 13:35               ` Markus Armbruster
2021-08-23 15:55               ` Eduardo Habkost
2021-08-23 15:55                 ` Eduardo Habkost
2021-08-24  6:48                 ` Markus Armbruster
2021-08-24  6:48                   ` Markus Armbruster
2021-09-03  9:33                   ` Valeriy Vdovin
2021-09-03  9:33                     ` Valeriy Vdovin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2191952f-6989-771a-1f0a-ece58262d141@redhat.com \
    --to=thuth@redhat.com \
    --cc=armbru@redhat.com \
    --cc=den@openvz.org \
    --cc=eblake@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lvivier@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=valeriy.vdovin@virtuozzo.com \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.