* [PATCH] pnfs: Fix a problem where we gratuitously start doing I/O through the MDS
@ 2019-07-18 19:40 Trond Myklebust
2019-07-19 0:45 ` Sasha Levin
0 siblings, 1 reply; 4+ messages in thread
From: Trond Myklebust @ 2019-07-18 19:40 UTC (permalink / raw)
To: linux-nfs
If the client has to stop in pnfs_update_layout() to wait for another
layoutget to complete, it currently exits and defaults to I/O through
the MDS if the layoutget was successful.
Fixes: d03360aaf5cc ("pNFS: Ensure we return the error if someone kills...")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Cc: stable@vger.kernel.org # v4.20+
---
fs/nfs/pnfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
index 5b9145c62fd9..758917463700 100644
--- a/fs/nfs/pnfs.c
+++ b/fs/nfs/pnfs.c
@@ -1890,7 +1890,7 @@ pnfs_update_layout(struct inode *ino,
spin_unlock(&ino->i_lock);
lseg = ERR_PTR(wait_var_event_killable(&lo->plh_outstanding,
!atomic_read(&lo->plh_outstanding)));
- if (IS_ERR(lseg) || !list_empty(&lo->plh_segs))
+ if (IS_ERR(lseg))
goto out_put_layout_hdr;
pnfs_put_layout_hdr(lo);
goto lookup_again;
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] pnfs: Fix a problem where we gratuitously start doing I/O through the MDS
2019-07-18 19:40 [PATCH] pnfs: Fix a problem where we gratuitously start doing I/O through the MDS Trond Myklebust
@ 2019-07-19 0:45 ` Sasha Levin
2019-07-19 0:54 ` Trond Myklebust
0 siblings, 1 reply; 4+ messages in thread
From: Sasha Levin @ 2019-07-19 0:45 UTC (permalink / raw)
To: Sasha Levin, Trond Myklebust, linux-nfs; +Cc: stable
Hi,
[This is an automated email]
This commit has been processed because it contains a "Fixes:" tag,
fixing commit: d03360aaf5cc pNFS: Ensure we return the error if someone kills a waiting layoutget.
The bot has tested the following trees: v5.2.1, v5.1.18, v4.19.59.
v5.2.1: Build OK!
v5.1.18: Build OK!
v4.19.59: Failed to apply! Possible dependencies:
400417b05f3e ("pNFS: Fix a typo in pnfs_update_layout")
NOTE: The patch will not be queued to stable trees until it is upstream.
How should we proceed with this patch?
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pnfs: Fix a problem where we gratuitously start doing I/O through the MDS
2019-07-19 0:45 ` Sasha Levin
@ 2019-07-19 0:54 ` Trond Myklebust
2019-07-23 9:57 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Trond Myklebust @ 2019-07-19 0:54 UTC (permalink / raw)
To: Sasha Levin, linux-nfs; +Cc: stable
Hi Sasha,
On Fri, 2019-07-19 at 00:45 +0000, Sasha Levin wrote:
> Hi,
>
> [This is an automated email]
>
> This commit has been processed because it contains a "Fixes:" tag,
> fixing commit: d03360aaf5cc pNFS: Ensure we return the error if
> someone kills a waiting layoutget.
>
> The bot has tested the following trees: v5.2.1, v5.1.18, v4.19.59.
>
> v5.2.1: Build OK!
> v5.1.18: Build OK!
> v4.19.59: Failed to apply! Possible dependencies:
> 400417b05f3e ("pNFS: Fix a typo in pnfs_update_layout")
>
>
> NOTE: The patch will not be queued to stable trees until it is
> upstream.
>
> How should we proceed with this patch?
>
Please apply both patches.
i.e. Please apply
400417b05f3e ("pNFS: Fix a typo in pnfs_update_layout")
58bbeab425c6 ("pnfs: Fix a problem where we gratuitously start doing
I/O through the MDS")
Thanks
Trond
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pnfs: Fix a problem where we gratuitously start doing I/O through the MDS
2019-07-19 0:54 ` Trond Myklebust
@ 2019-07-23 9:57 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2019-07-23 9:57 UTC (permalink / raw)
To: Trond Myklebust; +Cc: Sasha Levin, linux-nfs, stable
On Thu, Jul 18, 2019 at 08:54:53PM -0400, Trond Myklebust wrote:
> Hi Sasha,
>
> On Fri, 2019-07-19 at 00:45 +0000, Sasha Levin wrote:
> > Hi,
> >
> > [This is an automated email]
> >
> > This commit has been processed because it contains a "Fixes:" tag,
> > fixing commit: d03360aaf5cc pNFS: Ensure we return the error if
> > someone kills a waiting layoutget.
> >
> > The bot has tested the following trees: v5.2.1, v5.1.18, v4.19.59.
> >
> > v5.2.1: Build OK!
> > v5.1.18: Build OK!
> > v4.19.59: Failed to apply! Possible dependencies:
> > 400417b05f3e ("pNFS: Fix a typo in pnfs_update_layout")
> >
> >
> > NOTE: The patch will not be queued to stable trees until it is
> > upstream.
> >
> > How should we proceed with this patch?
> >
>
> Please apply both patches.
> i.e. Please apply
>
> 400417b05f3e ("pNFS: Fix a typo in pnfs_update_layout")
> 58bbeab425c6 ("pnfs: Fix a problem where we gratuitously start doing
> I/O through the MDS")
Now done, thanks.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-23 9:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-18 19:40 [PATCH] pnfs: Fix a problem where we gratuitously start doing I/O through the MDS Trond Myklebust
2019-07-19 0:45 ` Sasha Levin
2019-07-19 0:54 ` Trond Myklebust
2019-07-23 9:57 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.