Re: [PATCH] station: only log station_autoconnect_start if autoconnecting

Re: [PATCH] station: only log station_autoconnect_start if autoconnecting

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

Hi James,

On 2/10/22 14:54, James Prestwood wrote:
> This debug print was before any checks which could bail out prior to
> autoconnect starting. This was confusing because debug logs would
> contain multiple "station_autoconnect_start()" prints making you think
> autoconnect was started several times.
> ---
>   src/station.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 

Applied, thanks.

Regards,
-Denis

[PATCH] station: only log station_autoconnect_start if autoconnecting

[James Prestwood]

[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]

This debug print was before any checks which could bail out prior to
autoconnect starting. This was confusing because debug logs would
contain multiple "station_autoconnect_start()" prints making you think
autoconnect was started several times.
---
 src/station.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/station.c b/src/station.c
index 8e2cabd0..6dc0074c 100644
--- a/src/station.c
+++ b/src/station.c
@@ -248,8 +248,6 @@ static int station_autoconnect_next(struct station *station)
 
 static void station_autoconnect_start(struct station *station)
 {
-	l_debug("");
-
 	if (!station->autoconnect_can_start)
 		return;
 
@@ -265,6 +263,8 @@ static void station_autoconnect_start(struct station *station)
 	if (L_WARN_ON(station->autoconnect_list))
 		l_queue_destroy(station->autoconnect_list, NULL);
 
+	l_debug("");
+
 	station->autoconnect_list = l_queue_new();
 	station_network_foreach(station, network_add_foreach, station);
 	station_autoconnect_next(station);
-- 
2.34.1