* Re: [PATCH] ARM: omap2plus_defconfig: Fix selected panels after generic panel changes
@ 2019-10-06 14:53 ` Laurent Pinchart
0 siblings, 0 replies; 24+ messages in thread
From: Laurent Pinchart @ 2019-10-06 14:53 UTC (permalink / raw)
To: H. Nikolaus Schaller
Cc: Linux-OMAP, Tony Lindgren, Jyri Sarha, Tomi Valkeinen,
Discussions about the Letux Kernel, linux-arm-kernel
Hi Nikolaus,
On Sat, Oct 05, 2019 at 12:50:37PM +0200, H. Nikolaus Schaller wrote:
> > Am 04.10.2019 um 10:41 schrieb Tomi Valkeinen <tomi.valkeinen@ti.com>:
> >
> > On 03/10/2019 19:55, Tony Lindgren wrote:
> >> The old omapdrm panels got removed for v5.4 in favor of generic panels,
> >> and the Kconfig options changed. Let's update omap2plus_defconfig
> >> accordingly so the same panels are still enabled.
> >> Cc: Jyri Sarha <jsarha@ti.com>
> >> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> >> Signed-off-by: Tony Lindgren <tony@atomide.com>
> >> ---
> >> arch/arm/configs/omap2plus_defconfig | 12 ++++++------
> >> 1 file changed, 6 insertions(+), 6 deletions(-)
> >> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> >> --- a/arch/arm/configs/omap2plus_defconfig
> >> +++ b/arch/arm/configs/omap2plus_defconfig
> >> @@ -356,14 +356,14 @@ CONFIG_DRM_OMAP_CONNECTOR_HDMI=m
> >> CONFIG_DRM_OMAP_CONNECTOR_ANALOG_TV=m
> >> CONFIG_DRM_OMAP_PANEL_DPI=m
> >> CONFIG_DRM_OMAP_PANEL_DSI_CM=m
> >> -CONFIG_DRM_OMAP_PANEL_SONY_ACX565AKM=m
> >> -CONFIG_DRM_OMAP_PANEL_LGPHILIPS_LB035Q02=m
> >> -CONFIG_DRM_OMAP_PANEL_SHARP_LS037V7DW01=m
> >> -CONFIG_DRM_OMAP_PANEL_TPO_TD028TTEC1=m
> >> -CONFIG_DRM_OMAP_PANEL_TPO_TD043MTEA1=m
> >> -CONFIG_DRM_OMAP_PANEL_NEC_NL8048HL11=m
> >> CONFIG_DRM_TILCDC=m
> >> CONFIG_DRM_PANEL_SIMPLE=m
> >> +CONFIG_DRM_PANEL_LG_LB035Q02=m
> >> +CONFIG_DRM_PANEL_NEC_NL8048HL11=m
> >> +CONFIG_DRM_PANEL_SHARP_LS037V7DW01=m
> >> +CONFIG_DRM_PANEL_SONY_ACX565AKM=m
> >> +CONFIG_DRM_PANEL_TPO_TD028TTEC1=m
> >> +CONFIG_DRM_PANEL_TPO_TD043MTEA1=m
> >> CONFIG_FB=y
> >> CONFIG_FIRMWARE_EDID=y
> >> CONFIG_FB_MODE_HELPERS=y
> >
> > Sorry, I didn't remember to update these. Some additions:
> >
> > These can be dropped, they no longer exist:
> >
> > CONFIG_DRM_OMAP_ENCODER_TFP410=m
> > CONFIG_DRM_OMAP_CONNECTOR_DVI=m
> > CONFIG_DRM_OMAP_PANEL_DPI=m
>
> After being hit by the __always_inline issue [1] I am now
> back with being able to test v5.4-rc1.
>
> Now this patch fixes the build problem, but we still have
> one: panel drivers are no longer automatically loaded at
> boot. We now need to manually modprobe them.
>
> This has been observed with GTA04 (TD028TTEC1) and OpenPandora
> (TD043MTEA1). So moving the drivers seems to have changed/broken
> something with DT based driver matching.
That's really weird, the driver name, the SPI device table and the OF
device table are the same (except for the "omapdss," prefix that we
don't add anymore in omapdss-boot-init.c). Would you be able to
investigate what broke ?
> [1]: https://lkml.org/lkml/2019/10/2/201
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH] ARM: omap2plus_defconfig: Fix selected panels after generic panel changes
2019-10-06 14:53 ` Laurent Pinchart
@ 2019-10-06 15:07 ` H. Nikolaus Schaller
-1 siblings, 0 replies; 24+ messages in thread
From: H. Nikolaus Schaller @ 2019-10-06 15:07 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Linux-OMAP, Tony Lindgren, Jyri Sarha, Tomi Valkeinen,
Discussions about the Letux Kernel, linux-arm-kernel
Hi Laurent,
> Am 06.10.2019 um 16:53 schrieb Laurent Pinchart <laurent.pinchart@ideasonboard.com>:
>
> Hi Nikolaus,
>
> On Sat, Oct 05, 2019 at 12:50:37PM +0200, H. Nikolaus Schaller wrote:
>>> Am 04.10.2019 um 10:41 schrieb Tomi Valkeinen <tomi.valkeinen@ti.com>:
>>>
>>> On 03/10/2019 19:55, Tony Lindgren wrote:
>>>> The old omapdrm panels got removed for v5.4 in favor of generic panels,
>>>> and the Kconfig options changed. Let's update omap2plus_defconfig
>>>> accordingly so the same panels are still enabled.
>>>> Cc: Jyri Sarha <jsarha@ti.com>
>>>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>>> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
>>>> Signed-off-by: Tony Lindgren <tony@atomide.com>
>>>> ---
>>>> arch/arm/configs/omap2plus_defconfig | 12 ++++++------
>>>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>>> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
>>>> --- a/arch/arm/configs/omap2plus_defconfig
>>>> +++ b/arch/arm/configs/omap2plus_defconfig
>>>> @@ -356,14 +356,14 @@ CONFIG_DRM_OMAP_CONNECTOR_HDMI=m
>>>> CONFIG_DRM_OMAP_CONNECTOR_ANALOG_TV=m
>>>> CONFIG_DRM_OMAP_PANEL_DPI=m
>>>> CONFIG_DRM_OMAP_PANEL_DSI_CM=m
>>>> -CONFIG_DRM_OMAP_PANEL_SONY_ACX565AKM=m
>>>> -CONFIG_DRM_OMAP_PANEL_LGPHILIPS_LB035Q02=m
>>>> -CONFIG_DRM_OMAP_PANEL_SHARP_LS037V7DW01=m
>>>> -CONFIG_DRM_OMAP_PANEL_TPO_TD028TTEC1=m
>>>> -CONFIG_DRM_OMAP_PANEL_TPO_TD043MTEA1=m
>>>> -CONFIG_DRM_OMAP_PANEL_NEC_NL8048HL11=m
>>>> CONFIG_DRM_TILCDC=m
>>>> CONFIG_DRM_PANEL_SIMPLE=m
>>>> +CONFIG_DRM_PANEL_LG_LB035Q02=m
>>>> +CONFIG_DRM_PANEL_NEC_NL8048HL11=m
>>>> +CONFIG_DRM_PANEL_SHARP_LS037V7DW01=m
>>>> +CONFIG_DRM_PANEL_SONY_ACX565AKM=m
>>>> +CONFIG_DRM_PANEL_TPO_TD028TTEC1=m
>>>> +CONFIG_DRM_PANEL_TPO_TD043MTEA1=m
>>>> CONFIG_FB=y
>>>> CONFIG_FIRMWARE_EDID=y
>>>> CONFIG_FB_MODE_HELPERS=y
>>>
>>> Sorry, I didn't remember to update these. Some additions:
>>>
>>> These can be dropped, they no longer exist:
>>>
>>> CONFIG_DRM_OMAP_ENCODER_TFP410=m
>>> CONFIG_DRM_OMAP_CONNECTOR_DVI=m
>>> CONFIG_DRM_OMAP_PANEL_DPI=m
>>
>> After being hit by the __always_inline issue [1] I am now
>> back with being able to test v5.4-rc1.
>>
>> Now this patch fixes the build problem, but we still have
>> one: panel drivers are no longer automatically loaded at
>> boot. We now need to manually modprobe them.
>>
>> This has been observed with GTA04 (TD028TTEC1) and OpenPandora
>> (TD043MTEA1). So moving the drivers seems to have changed/broken
>> something with DT based driver matching.
>
> That's really weird, the driver name, the SPI device table and the OF
> device table are the same
Yes, that is what I wonder as well. The panels are child nodes of
the SPI nodes and should be probed through the SPI bus.
> (except for the "omapdss," prefix that we
> don't add anymore in omapdss-boot-init.c). Would you be able to
> investigate what broke ?
Yes, they have been removed from the omapdss_of_fixups_whitelist
but that shouldn't make a difference... And other generic dpi panels
work on other omap3 boards.
Most likely something with deferred probing?
I'll try to find clues in the next days.
BR,
Nikolaus
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH] ARM: omap2plus_defconfig: Fix selected panels after generic panel changes
@ 2019-10-06 15:07 ` H. Nikolaus Schaller
0 siblings, 0 replies; 24+ messages in thread
From: H. Nikolaus Schaller @ 2019-10-06 15:07 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Linux-OMAP, Tony Lindgren, Jyri Sarha, Tomi Valkeinen,
Discussions about the Letux Kernel, linux-arm-kernel
Hi Laurent,
> Am 06.10.2019 um 16:53 schrieb Laurent Pinchart <laurent.pinchart@ideasonboard.com>:
>
> Hi Nikolaus,
>
> On Sat, Oct 05, 2019 at 12:50:37PM +0200, H. Nikolaus Schaller wrote:
>>> Am 04.10.2019 um 10:41 schrieb Tomi Valkeinen <tomi.valkeinen@ti.com>:
>>>
>>> On 03/10/2019 19:55, Tony Lindgren wrote:
>>>> The old omapdrm panels got removed for v5.4 in favor of generic panels,
>>>> and the Kconfig options changed. Let's update omap2plus_defconfig
>>>> accordingly so the same panels are still enabled.
>>>> Cc: Jyri Sarha <jsarha@ti.com>
>>>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>>> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
>>>> Signed-off-by: Tony Lindgren <tony@atomide.com>
>>>> ---
>>>> arch/arm/configs/omap2plus_defconfig | 12 ++++++------
>>>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>>> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
>>>> --- a/arch/arm/configs/omap2plus_defconfig
>>>> +++ b/arch/arm/configs/omap2plus_defconfig
>>>> @@ -356,14 +356,14 @@ CONFIG_DRM_OMAP_CONNECTOR_HDMI=m
>>>> CONFIG_DRM_OMAP_CONNECTOR_ANALOG_TV=m
>>>> CONFIG_DRM_OMAP_PANEL_DPI=m
>>>> CONFIG_DRM_OMAP_PANEL_DSI_CM=m
>>>> -CONFIG_DRM_OMAP_PANEL_SONY_ACX565AKM=m
>>>> -CONFIG_DRM_OMAP_PANEL_LGPHILIPS_LB035Q02=m
>>>> -CONFIG_DRM_OMAP_PANEL_SHARP_LS037V7DW01=m
>>>> -CONFIG_DRM_OMAP_PANEL_TPO_TD028TTEC1=m
>>>> -CONFIG_DRM_OMAP_PANEL_TPO_TD043MTEA1=m
>>>> -CONFIG_DRM_OMAP_PANEL_NEC_NL8048HL11=m
>>>> CONFIG_DRM_TILCDC=m
>>>> CONFIG_DRM_PANEL_SIMPLE=m
>>>> +CONFIG_DRM_PANEL_LG_LB035Q02=m
>>>> +CONFIG_DRM_PANEL_NEC_NL8048HL11=m
>>>> +CONFIG_DRM_PANEL_SHARP_LS037V7DW01=m
>>>> +CONFIG_DRM_PANEL_SONY_ACX565AKM=m
>>>> +CONFIG_DRM_PANEL_TPO_TD028TTEC1=m
>>>> +CONFIG_DRM_PANEL_TPO_TD043MTEA1=m
>>>> CONFIG_FB=y
>>>> CONFIG_FIRMWARE_EDID=y
>>>> CONFIG_FB_MODE_HELPERS=y
>>>
>>> Sorry, I didn't remember to update these. Some additions:
>>>
>>> These can be dropped, they no longer exist:
>>>
>>> CONFIG_DRM_OMAP_ENCODER_TFP410=m
>>> CONFIG_DRM_OMAP_CONNECTOR_DVI=m
>>> CONFIG_DRM_OMAP_PANEL_DPI=m
>>
>> After being hit by the __always_inline issue [1] I am now
>> back with being able to test v5.4-rc1.
>>
>> Now this patch fixes the build problem, but we still have
>> one: panel drivers are no longer automatically loaded at
>> boot. We now need to manually modprobe them.
>>
>> This has been observed with GTA04 (TD028TTEC1) and OpenPandora
>> (TD043MTEA1). So moving the drivers seems to have changed/broken
>> something with DT based driver matching.
>
> That's really weird, the driver name, the SPI device table and the OF
> device table are the same
Yes, that is what I wonder as well. The panels are child nodes of
the SPI nodes and should be probed through the SPI bus.
> (except for the "omapdss," prefix that we
> don't add anymore in omapdss-boot-init.c). Would you be able to
> investigate what broke ?
Yes, they have been removed from the omapdss_of_fixups_whitelist
but that shouldn't make a difference... And other generic dpi panels
work on other omap3 boards.
Most likely something with deferred probing?
I'll try to find clues in the next days.
BR,
Nikolaus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Letux-kernel] [PATCH] ARM: omap2plus_defconfig: Fix selected panels after generic panel changes
2019-10-06 14:53 ` Laurent Pinchart
@ 2019-10-06 20:39 ` Andreas Kemnade
-1 siblings, 0 replies; 24+ messages in thread
From: Andreas Kemnade @ 2019-10-06 20:39 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Discussions about the Letux Kernel, Tony Lindgren,
H. Nikolaus Schaller, Jyri Sarha, Tomi Valkeinen, Linux-OMAP,
linux-arm-kernel
On Sun, 6 Oct 2019 17:53:48 +0300
Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> Hi Nikolaus,
>
> On Sat, Oct 05, 2019 at 12:50:37PM +0200, H. Nikolaus Schaller wrote:
> > > Am 04.10.2019 um 10:41 schrieb Tomi Valkeinen <tomi.valkeinen@ti.com>:
> > >
> > > On 03/10/2019 19:55, Tony Lindgren wrote:
> > >> The old omapdrm panels got removed for v5.4 in favor of generic panels,
> > >> and the Kconfig options changed. Let's update omap2plus_defconfig
> > >> accordingly so the same panels are still enabled.
> > >> Cc: Jyri Sarha <jsarha@ti.com>
> > >> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > >> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > >> Signed-off-by: Tony Lindgren <tony@atomide.com>
> > >> ---
> > >> arch/arm/configs/omap2plus_defconfig | 12 ++++++------
> > >> 1 file changed, 6 insertions(+), 6 deletions(-)
> > >> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> > >> --- a/arch/arm/configs/omap2plus_defconfig
> > >> +++ b/arch/arm/configs/omap2plus_defconfig
> > >> @@ -356,14 +356,14 @@ CONFIG_DRM_OMAP_CONNECTOR_HDMI=m
> > >> CONFIG_DRM_OMAP_CONNECTOR_ANALOG_TV=m
> > >> CONFIG_DRM_OMAP_PANEL_DPI=m
> > >> CONFIG_DRM_OMAP_PANEL_DSI_CM=m
> > >> -CONFIG_DRM_OMAP_PANEL_SONY_ACX565AKM=m
> > >> -CONFIG_DRM_OMAP_PANEL_LGPHILIPS_LB035Q02=m
> > >> -CONFIG_DRM_OMAP_PANEL_SHARP_LS037V7DW01=m
> > >> -CONFIG_DRM_OMAP_PANEL_TPO_TD028TTEC1=m
> > >> -CONFIG_DRM_OMAP_PANEL_TPO_TD043MTEA1=m
> > >> -CONFIG_DRM_OMAP_PANEL_NEC_NL8048HL11=m
> > >> CONFIG_DRM_TILCDC=m
> > >> CONFIG_DRM_PANEL_SIMPLE=m
> > >> +CONFIG_DRM_PANEL_LG_LB035Q02=m
> > >> +CONFIG_DRM_PANEL_NEC_NL8048HL11=m
> > >> +CONFIG_DRM_PANEL_SHARP_LS037V7DW01=m
> > >> +CONFIG_DRM_PANEL_SONY_ACX565AKM=m
> > >> +CONFIG_DRM_PANEL_TPO_TD028TTEC1=m
> > >> +CONFIG_DRM_PANEL_TPO_TD043MTEA1=m
> > >> CONFIG_FB=y
> > >> CONFIG_FIRMWARE_EDID=y
> > >> CONFIG_FB_MODE_HELPERS=y
> > >
> > > Sorry, I didn't remember to update these. Some additions:
> > >
> > > These can be dropped, they no longer exist:
> > >
> > > CONFIG_DRM_OMAP_ENCODER_TFP410=m
> > > CONFIG_DRM_OMAP_CONNECTOR_DVI=m
> > > CONFIG_DRM_OMAP_PANEL_DPI=m
> >
> > After being hit by the __always_inline issue [1] I am now
> > back with being able to test v5.4-rc1.
> >
> > Now this patch fixes the build problem, but we still have
> > one: panel drivers are no longer automatically loaded at
> > boot. We now need to manually modprobe them.
> >
> > This has been observed with GTA04 (TD028TTEC1) and OpenPandora
> > (TD043MTEA1). So moving the drivers seems to have changed/broken
> > something with DT based driver matching.
>
> That's really weird, the driver name, the SPI device table and the OF
> device table are the same (except for the "omapdss," prefix that we
> don't add anymore in omapdss-boot-init.c). Would you be able to
> investigate what broke ?
>
in earlier times:
root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias
spi:tpo,td028ttec1
now in 5.4-rc1:
root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias
spi:td028ttec1
root@gta04:~# modinfo /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
filename: /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
license: GPL
description: Toppoly TD028TTEC1 panel driver
author: H. Nikolaus Schaller <hns@goldelico.com>
srcversion: 6B3E224BCD3D76253CF361C
alias: of:N*T*Ctoppoly,td028ttec1C*
alias: of:N*T*Ctoppoly,td028ttec1
alias: of:N*T*Ctpo,td028ttec1C*
alias: of:N*T*Ctpo,td028ttec1
alias: spi:toppoly,td028ttec1
alias: spi:tpo,td028ttec1
depends: drm
intree: Y
name: panel_tpo_td028ttec1
vermagic: 5.4.0-rc1-letux+ SMP preempt mod_unload ARMv7 p2v8
That alias is not in the list.
Regards,
Andreas
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Letux-kernel] [PATCH] ARM: omap2plus_defconfig: Fix selected panels after generic panel changes
@ 2019-10-06 20:39 ` Andreas Kemnade
0 siblings, 0 replies; 24+ messages in thread
From: Andreas Kemnade @ 2019-10-06 20:39 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Discussions about the Letux Kernel, Tony Lindgren,
H. Nikolaus Schaller, Jyri Sarha, Tomi Valkeinen, Linux-OMAP,
linux-arm-kernel
On Sun, 6 Oct 2019 17:53:48 +0300
Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> Hi Nikolaus,
>
> On Sat, Oct 05, 2019 at 12:50:37PM +0200, H. Nikolaus Schaller wrote:
> > > Am 04.10.2019 um 10:41 schrieb Tomi Valkeinen <tomi.valkeinen@ti.com>:
> > >
> > > On 03/10/2019 19:55, Tony Lindgren wrote:
> > >> The old omapdrm panels got removed for v5.4 in favor of generic panels,
> > >> and the Kconfig options changed. Let's update omap2plus_defconfig
> > >> accordingly so the same panels are still enabled.
> > >> Cc: Jyri Sarha <jsarha@ti.com>
> > >> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > >> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > >> Signed-off-by: Tony Lindgren <tony@atomide.com>
> > >> ---
> > >> arch/arm/configs/omap2plus_defconfig | 12 ++++++------
> > >> 1 file changed, 6 insertions(+), 6 deletions(-)
> > >> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> > >> --- a/arch/arm/configs/omap2plus_defconfig
> > >> +++ b/arch/arm/configs/omap2plus_defconfig
> > >> @@ -356,14 +356,14 @@ CONFIG_DRM_OMAP_CONNECTOR_HDMI=m
> > >> CONFIG_DRM_OMAP_CONNECTOR_ANALOG_TV=m
> > >> CONFIG_DRM_OMAP_PANEL_DPI=m
> > >> CONFIG_DRM_OMAP_PANEL_DSI_CM=m
> > >> -CONFIG_DRM_OMAP_PANEL_SONY_ACX565AKM=m
> > >> -CONFIG_DRM_OMAP_PANEL_LGPHILIPS_LB035Q02=m
> > >> -CONFIG_DRM_OMAP_PANEL_SHARP_LS037V7DW01=m
> > >> -CONFIG_DRM_OMAP_PANEL_TPO_TD028TTEC1=m
> > >> -CONFIG_DRM_OMAP_PANEL_TPO_TD043MTEA1=m
> > >> -CONFIG_DRM_OMAP_PANEL_NEC_NL8048HL11=m
> > >> CONFIG_DRM_TILCDC=m
> > >> CONFIG_DRM_PANEL_SIMPLE=m
> > >> +CONFIG_DRM_PANEL_LG_LB035Q02=m
> > >> +CONFIG_DRM_PANEL_NEC_NL8048HL11=m
> > >> +CONFIG_DRM_PANEL_SHARP_LS037V7DW01=m
> > >> +CONFIG_DRM_PANEL_SONY_ACX565AKM=m
> > >> +CONFIG_DRM_PANEL_TPO_TD028TTEC1=m
> > >> +CONFIG_DRM_PANEL_TPO_TD043MTEA1=m
> > >> CONFIG_FB=y
> > >> CONFIG_FIRMWARE_EDID=y
> > >> CONFIG_FB_MODE_HELPERS=y
> > >
> > > Sorry, I didn't remember to update these. Some additions:
> > >
> > > These can be dropped, they no longer exist:
> > >
> > > CONFIG_DRM_OMAP_ENCODER_TFP410=m
> > > CONFIG_DRM_OMAP_CONNECTOR_DVI=m
> > > CONFIG_DRM_OMAP_PANEL_DPI=m
> >
> > After being hit by the __always_inline issue [1] I am now
> > back with being able to test v5.4-rc1.
> >
> > Now this patch fixes the build problem, but we still have
> > one: panel drivers are no longer automatically loaded at
> > boot. We now need to manually modprobe them.
> >
> > This has been observed with GTA04 (TD028TTEC1) and OpenPandora
> > (TD043MTEA1). So moving the drivers seems to have changed/broken
> > something with DT based driver matching.
>
> That's really weird, the driver name, the SPI device table and the OF
> device table are the same (except for the "omapdss," prefix that we
> don't add anymore in omapdss-boot-init.c). Would you be able to
> investigate what broke ?
>
in earlier times:
root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias
spi:tpo,td028ttec1
now in 5.4-rc1:
root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias
spi:td028ttec1
root@gta04:~# modinfo /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
filename: /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
license: GPL
description: Toppoly TD028TTEC1 panel driver
author: H. Nikolaus Schaller <hns@goldelico.com>
srcversion: 6B3E224BCD3D76253CF361C
alias: of:N*T*Ctoppoly,td028ttec1C*
alias: of:N*T*Ctoppoly,td028ttec1
alias: of:N*T*Ctpo,td028ttec1C*
alias: of:N*T*Ctpo,td028ttec1
alias: spi:toppoly,td028ttec1
alias: spi:tpo,td028ttec1
depends: drm
intree: Y
name: panel_tpo_td028ttec1
vermagic: 5.4.0-rc1-letux+ SMP preempt mod_unload ARMv7 p2v8
That alias is not in the list.
Regards,
Andreas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Letux-kernel] [PATCH] ARM: omap2plus_defconfig: Fix selected panels after generic panel changes
2019-10-06 20:39 ` Andreas Kemnade
@ 2019-10-07 4:40 ` Andreas Kemnade
-1 siblings, 0 replies; 24+ messages in thread
From: Andreas Kemnade @ 2019-10-07 4:40 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Discussions about the Letux Kernel, Tony Lindgren, Jyri Sarha,
Tomi Valkeinen, Linux-OMAP, linux-arm-kernel
On Sun, 6 Oct 2019 22:39:58 +0200
Andreas Kemnade <andreas@kemnade.info> wrote:
> On Sun, 6 Oct 2019 17:53:48 +0300
> Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
>
> > Hi Nikolaus,
> >
> > On Sat, Oct 05, 2019 at 12:50:37PM +0200, H. Nikolaus Schaller wrote:
> > > > Am 04.10.2019 um 10:41 schrieb Tomi Valkeinen <tomi.valkeinen@ti.com>:
> > > >
> > > > On 03/10/2019 19:55, Tony Lindgren wrote:
> > > >> The old omapdrm panels got removed for v5.4 in favor of generic panels,
> > > >> and the Kconfig options changed. Let's update omap2plus_defconfig
> > > >> accordingly so the same panels are still enabled.
> > > >> Cc: Jyri Sarha <jsarha@ti.com>
> > > >> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > >> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > > >> Signed-off-by: Tony Lindgren <tony@atomide.com>
> > > >> ---
> > > >> arch/arm/configs/omap2plus_defconfig | 12 ++++++------
> > > >> 1 file changed, 6 insertions(+), 6 deletions(-)
> > > >> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> > > >> --- a/arch/arm/configs/omap2plus_defconfig
> > > >> +++ b/arch/arm/configs/omap2plus_defconfig
> > > >> @@ -356,14 +356,14 @@ CONFIG_DRM_OMAP_CONNECTOR_HDMI=m
> > > >> CONFIG_DRM_OMAP_CONNECTOR_ANALOG_TV=m
> > > >> CONFIG_DRM_OMAP_PANEL_DPI=m
> > > >> CONFIG_DRM_OMAP_PANEL_DSI_CM=m
> > > >> -CONFIG_DRM_OMAP_PANEL_SONY_ACX565AKM=m
> > > >> -CONFIG_DRM_OMAP_PANEL_LGPHILIPS_LB035Q02=m
> > > >> -CONFIG_DRM_OMAP_PANEL_SHARP_LS037V7DW01=m
> > > >> -CONFIG_DRM_OMAP_PANEL_TPO_TD028TTEC1=m
> > > >> -CONFIG_DRM_OMAP_PANEL_TPO_TD043MTEA1=m
> > > >> -CONFIG_DRM_OMAP_PANEL_NEC_NL8048HL11=m
> > > >> CONFIG_DRM_TILCDC=m
> > > >> CONFIG_DRM_PANEL_SIMPLE=m
> > > >> +CONFIG_DRM_PANEL_LG_LB035Q02=m
> > > >> +CONFIG_DRM_PANEL_NEC_NL8048HL11=m
> > > >> +CONFIG_DRM_PANEL_SHARP_LS037V7DW01=m
> > > >> +CONFIG_DRM_PANEL_SONY_ACX565AKM=m
> > > >> +CONFIG_DRM_PANEL_TPO_TD028TTEC1=m
> > > >> +CONFIG_DRM_PANEL_TPO_TD043MTEA1=m
> > > >> CONFIG_FB=y
> > > >> CONFIG_FIRMWARE_EDID=y
> > > >> CONFIG_FB_MODE_HELPERS=y
> > > >
> > > > Sorry, I didn't remember to update these. Some additions:
> > > >
> > > > These can be dropped, they no longer exist:
> > > >
> > > > CONFIG_DRM_OMAP_ENCODER_TFP410=m
> > > > CONFIG_DRM_OMAP_CONNECTOR_DVI=m
> > > > CONFIG_DRM_OMAP_PANEL_DPI=m
> > >
> > > After being hit by the __always_inline issue [1] I am now
> > > back with being able to test v5.4-rc1.
> > >
> > > Now this patch fixes the build problem, but we still have
> > > one: panel drivers are no longer automatically loaded at
> > > boot. We now need to manually modprobe them.
> > >
> > > This has been observed with GTA04 (TD028TTEC1) and OpenPandora
> > > (TD043MTEA1). So moving the drivers seems to have changed/broken
> > > something with DT based driver matching.
> >
> > That's really weird, the driver name, the SPI device table and the OF
> > device table are the same (except for the "omapdss," prefix that we
> > don't add anymore in omapdss-boot-init.c). Would you be able to
> > investigate what broke ?
> >
> in earlier times:
>
> root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias
> spi:tpo,td028ttec1
>
> now in 5.4-rc1:
> root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias
> spi:td028ttec1
>
> root@gta04:~# modinfo /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
> filename: /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
> license: GPL
> description: Toppoly TD028TTEC1 panel driver
> author: H. Nikolaus Schaller <hns@goldelico.com>
> srcversion: 6B3E224BCD3D76253CF361C
> alias: of:N*T*Ctoppoly,td028ttec1C*
> alias: of:N*T*Ctoppoly,td028ttec1
> alias: of:N*T*Ctpo,td028ttec1C*
> alias: of:N*T*Ctpo,td028ttec1
> alias: spi:toppoly,td028ttec1
> alias: spi:tpo,td028ttec1
> depends: drm
> intree: Y
> name: panel_tpo_td028ttec1
> vermagic: 5.4.0-rc1-letux+ SMP preempt mod_unload ARMv7 p2v8
>
> That alias is not in the list.
>
some more research:
in former times
of_modalias_node() has stripped the omapdss prefix, result: modalias=spi:tpo,td028ttec1
now it strips the tpo prefix because there is no omapdss prefix anymore.
Regards,
Andreas
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Letux-kernel] [PATCH] ARM: omap2plus_defconfig: Fix selected panels after generic panel changes
@ 2019-10-07 4:40 ` Andreas Kemnade
0 siblings, 0 replies; 24+ messages in thread
From: Andreas Kemnade @ 2019-10-07 4:40 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Discussions about the Letux Kernel, Tony Lindgren, Jyri Sarha,
Tomi Valkeinen, Linux-OMAP, linux-arm-kernel
On Sun, 6 Oct 2019 22:39:58 +0200
Andreas Kemnade <andreas@kemnade.info> wrote:
> On Sun, 6 Oct 2019 17:53:48 +0300
> Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
>
> > Hi Nikolaus,
> >
> > On Sat, Oct 05, 2019 at 12:50:37PM +0200, H. Nikolaus Schaller wrote:
> > > > Am 04.10.2019 um 10:41 schrieb Tomi Valkeinen <tomi.valkeinen@ti.com>:
> > > >
> > > > On 03/10/2019 19:55, Tony Lindgren wrote:
> > > >> The old omapdrm panels got removed for v5.4 in favor of generic panels,
> > > >> and the Kconfig options changed. Let's update omap2plus_defconfig
> > > >> accordingly so the same panels are still enabled.
> > > >> Cc: Jyri Sarha <jsarha@ti.com>
> > > >> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > >> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > > >> Signed-off-by: Tony Lindgren <tony@atomide.com>
> > > >> ---
> > > >> arch/arm/configs/omap2plus_defconfig | 12 ++++++------
> > > >> 1 file changed, 6 insertions(+), 6 deletions(-)
> > > >> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> > > >> --- a/arch/arm/configs/omap2plus_defconfig
> > > >> +++ b/arch/arm/configs/omap2plus_defconfig
> > > >> @@ -356,14 +356,14 @@ CONFIG_DRM_OMAP_CONNECTOR_HDMI=m
> > > >> CONFIG_DRM_OMAP_CONNECTOR_ANALOG_TV=m
> > > >> CONFIG_DRM_OMAP_PANEL_DPI=m
> > > >> CONFIG_DRM_OMAP_PANEL_DSI_CM=m
> > > >> -CONFIG_DRM_OMAP_PANEL_SONY_ACX565AKM=m
> > > >> -CONFIG_DRM_OMAP_PANEL_LGPHILIPS_LB035Q02=m
> > > >> -CONFIG_DRM_OMAP_PANEL_SHARP_LS037V7DW01=m
> > > >> -CONFIG_DRM_OMAP_PANEL_TPO_TD028TTEC1=m
> > > >> -CONFIG_DRM_OMAP_PANEL_TPO_TD043MTEA1=m
> > > >> -CONFIG_DRM_OMAP_PANEL_NEC_NL8048HL11=m
> > > >> CONFIG_DRM_TILCDC=m
> > > >> CONFIG_DRM_PANEL_SIMPLE=m
> > > >> +CONFIG_DRM_PANEL_LG_LB035Q02=m
> > > >> +CONFIG_DRM_PANEL_NEC_NL8048HL11=m
> > > >> +CONFIG_DRM_PANEL_SHARP_LS037V7DW01=m
> > > >> +CONFIG_DRM_PANEL_SONY_ACX565AKM=m
> > > >> +CONFIG_DRM_PANEL_TPO_TD028TTEC1=m
> > > >> +CONFIG_DRM_PANEL_TPO_TD043MTEA1=m
> > > >> CONFIG_FB=y
> > > >> CONFIG_FIRMWARE_EDID=y
> > > >> CONFIG_FB_MODE_HELPERS=y
> > > >
> > > > Sorry, I didn't remember to update these. Some additions:
> > > >
> > > > These can be dropped, they no longer exist:
> > > >
> > > > CONFIG_DRM_OMAP_ENCODER_TFP410=m
> > > > CONFIG_DRM_OMAP_CONNECTOR_DVI=m
> > > > CONFIG_DRM_OMAP_PANEL_DPI=m
> > >
> > > After being hit by the __always_inline issue [1] I am now
> > > back with being able to test v5.4-rc1.
> > >
> > > Now this patch fixes the build problem, but we still have
> > > one: panel drivers are no longer automatically loaded at
> > > boot. We now need to manually modprobe them.
> > >
> > > This has been observed with GTA04 (TD028TTEC1) and OpenPandora
> > > (TD043MTEA1). So moving the drivers seems to have changed/broken
> > > something with DT based driver matching.
> >
> > That's really weird, the driver name, the SPI device table and the OF
> > device table are the same (except for the "omapdss," prefix that we
> > don't add anymore in omapdss-boot-init.c). Would you be able to
> > investigate what broke ?
> >
> in earlier times:
>
> root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias
> spi:tpo,td028ttec1
>
> now in 5.4-rc1:
> root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias
> spi:td028ttec1
>
> root@gta04:~# modinfo /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
> filename: /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
> license: GPL
> description: Toppoly TD028TTEC1 panel driver
> author: H. Nikolaus Schaller <hns@goldelico.com>
> srcversion: 6B3E224BCD3D76253CF361C
> alias: of:N*T*Ctoppoly,td028ttec1C*
> alias: of:N*T*Ctoppoly,td028ttec1
> alias: of:N*T*Ctpo,td028ttec1C*
> alias: of:N*T*Ctpo,td028ttec1
> alias: spi:toppoly,td028ttec1
> alias: spi:tpo,td028ttec1
> depends: drm
> intree: Y
> name: panel_tpo_td028ttec1
> vermagic: 5.4.0-rc1-letux+ SMP preempt mod_unload ARMv7 p2v8
>
> That alias is not in the list.
>
some more research:
in former times
of_modalias_node() has stripped the omapdss prefix, result: modalias=spi:tpo,td028ttec1
now it strips the tpo prefix because there is no omapdss prefix anymore.
Regards,
Andreas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Letux-kernel] [PATCH] ARM: omap2plus_defconfig: Fix selected panels after generic panel changes
2019-10-07 4:40 ` Andreas Kemnade
@ 2019-10-07 14:29 ` Tomi Valkeinen
-1 siblings, 0 replies; 24+ messages in thread
From: Tomi Valkeinen @ 2019-10-07 14:29 UTC (permalink / raw)
To: Andreas Kemnade, Laurent Pinchart
Cc: Tony Lindgren, Linux-OMAP, Discussions about the Letux Kernel,
linux-arm-kernel, Jyri Sarha
On 07/10/2019 07:40, Andreas Kemnade wrote:
>>> That's really weird, the driver name, the SPI device table and the OF
>>> device table are the same (except for the "omapdss," prefix that we
>>> don't add anymore in omapdss-boot-init.c). Would you be able to
>>> investigate what broke ?
>>>
>> in earlier times:
>>
>> root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias
>> spi:tpo,td028ttec1
>>
>> now in 5.4-rc1:
>> root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias
>> spi:td028ttec1
>>
>> root@gta04:~# modinfo /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
>> filename: /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
>> license: GPL
>> description: Toppoly TD028TTEC1 panel driver
>> author: H. Nikolaus Schaller <hns@goldelico.com>
>> srcversion: 6B3E224BCD3D76253CF361C
>> alias: of:N*T*Ctoppoly,td028ttec1C*
>> alias: of:N*T*Ctoppoly,td028ttec1
>> alias: of:N*T*Ctpo,td028ttec1C*
>> alias: of:N*T*Ctpo,td028ttec1
>> alias: spi:toppoly,td028ttec1
>> alias: spi:tpo,td028ttec1
>> depends: drm
>> intree: Y
>> name: panel_tpo_td028ttec1
>> vermagic: 5.4.0-rc1-letux+ SMP preempt mod_unload ARMv7 p2v8
>>
>> That alias is not in the list.
>>
> some more research:
> in former times
> of_modalias_node() has stripped the omapdss prefix, result: modalias=spi:tpo,td028ttec1
> now it strips the tpo prefix because there is no omapdss prefix anymore.
I haven't studied this more yet, but yes, I can see of_modalias_node
stripping the vendor prefix on purpose. I do wonder how this is supposed
to work, it would make more sense to me to keep the vendor prefix.
Is the spi_device_id supposed to be without vendor prefix? With a quick
grep, this seems to be the case.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Letux-kernel] [PATCH] ARM: omap2plus_defconfig: Fix selected panels after generic panel changes
@ 2019-10-07 14:29 ` Tomi Valkeinen
0 siblings, 0 replies; 24+ messages in thread
From: Tomi Valkeinen @ 2019-10-07 14:29 UTC (permalink / raw)
To: Andreas Kemnade, Laurent Pinchart
Cc: Tony Lindgren, Linux-OMAP, Discussions about the Letux Kernel,
linux-arm-kernel, Jyri Sarha
On 07/10/2019 07:40, Andreas Kemnade wrote:
>>> That's really weird, the driver name, the SPI device table and the OF
>>> device table are the same (except for the "omapdss," prefix that we
>>> don't add anymore in omapdss-boot-init.c). Would you be able to
>>> investigate what broke ?
>>>
>> in earlier times:
>>
>> root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias
>> spi:tpo,td028ttec1
>>
>> now in 5.4-rc1:
>> root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias
>> spi:td028ttec1
>>
>> root@gta04:~# modinfo /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
>> filename: /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
>> license: GPL
>> description: Toppoly TD028TTEC1 panel driver
>> author: H. Nikolaus Schaller <hns@goldelico.com>
>> srcversion: 6B3E224BCD3D76253CF361C
>> alias: of:N*T*Ctoppoly,td028ttec1C*
>> alias: of:N*T*Ctoppoly,td028ttec1
>> alias: of:N*T*Ctpo,td028ttec1C*
>> alias: of:N*T*Ctpo,td028ttec1
>> alias: spi:toppoly,td028ttec1
>> alias: spi:tpo,td028ttec1
>> depends: drm
>> intree: Y
>> name: panel_tpo_td028ttec1
>> vermagic: 5.4.0-rc1-letux+ SMP preempt mod_unload ARMv7 p2v8
>>
>> That alias is not in the list.
>>
> some more research:
> in former times
> of_modalias_node() has stripped the omapdss prefix, result: modalias=spi:tpo,td028ttec1
> now it strips the tpo prefix because there is no omapdss prefix anymore.
I haven't studied this more yet, but yes, I can see of_modalias_node
stripping the vendor prefix on purpose. I do wonder how this is supposed
to work, it would make more sense to me to keep the vendor prefix.
Is the spi_device_id supposed to be without vendor prefix? With a quick
grep, this seems to be the case.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Letux-kernel] [PATCH] ARM: omap2plus_defconfig: Fix selected panels after generic panel changes
2019-10-07 14:29 ` Tomi Valkeinen
@ 2019-10-07 16:09 ` Andreas Kemnade
-1 siblings, 0 replies; 24+ messages in thread
From: Andreas Kemnade @ 2019-10-07 16:09 UTC (permalink / raw)
To: Tomi Valkeinen
Cc: Discussions about the Letux Kernel, Tony Lindgren, Jyri Sarha,
Laurent Pinchart, Linux-OMAP, linux-arm-kernel
On Mon, 7 Oct 2019 17:29:20 +0300
Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> On 07/10/2019 07:40, Andreas Kemnade wrote:
>
> >>> That's really weird, the driver name, the SPI device table and the OF
> >>> device table are the same (except for the "omapdss," prefix that we
> >>> don't add anymore in omapdss-boot-init.c). Would you be able to
> >>> investigate what broke ?
> >>>
> >> in earlier times:
> >>
> >> root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias
> >> spi:tpo,td028ttec1
> >>
> >> now in 5.4-rc1:
> >> root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias
> >> spi:td028ttec1
> >>
> >> root@gta04:~# modinfo /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
> >> filename: /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
> >> license: GPL
> >> description: Toppoly TD028TTEC1 panel driver
> >> author: H. Nikolaus Schaller <hns@goldelico.com>
> >> srcversion: 6B3E224BCD3D76253CF361C
> >> alias: of:N*T*Ctoppoly,td028ttec1C*
> >> alias: of:N*T*Ctoppoly,td028ttec1
> >> alias: of:N*T*Ctpo,td028ttec1C*
> >> alias: of:N*T*Ctpo,td028ttec1
> >> alias: spi:toppoly,td028ttec1
> >> alias: spi:tpo,td028ttec1
> >> depends: drm
> >> intree: Y
> >> name: panel_tpo_td028ttec1
> >> vermagic: 5.4.0-rc1-letux+ SMP preempt mod_unload ARMv7 p2v8
> >>
> >> That alias is not in the list.
> >>
> > some more research:
> > in former times
> > of_modalias_node() has stripped the omapdss prefix, result: modalias=spi:tpo,td028ttec1
> > now it strips the tpo prefix because there is no omapdss prefix anymore.
>
> I haven't studied this more yet, but yes, I can see of_modalias_node
> stripping the vendor prefix on purpose. I do wonder how this is supposed
> to work, it would make more sense to me to keep the vendor prefix.
>
> Is the spi_device_id supposed to be without vendor prefix? With a quick
> grep, this seems to be the case.
>
as it is done in drivers/spi/spi.c we have no influence from drm side.
So we must live with it. Also checked several drivers, no vendor-prefix
there.
Regards,
Andreas
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Letux-kernel] [PATCH] ARM: omap2plus_defconfig: Fix selected panels after generic panel changes
@ 2019-10-07 16:09 ` Andreas Kemnade
0 siblings, 0 replies; 24+ messages in thread
From: Andreas Kemnade @ 2019-10-07 16:09 UTC (permalink / raw)
To: Tomi Valkeinen
Cc: Discussions about the Letux Kernel, Tony Lindgren, Jyri Sarha,
Laurent Pinchart, Linux-OMAP, linux-arm-kernel
On Mon, 7 Oct 2019 17:29:20 +0300
Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> On 07/10/2019 07:40, Andreas Kemnade wrote:
>
> >>> That's really weird, the driver name, the SPI device table and the OF
> >>> device table are the same (except for the "omapdss," prefix that we
> >>> don't add anymore in omapdss-boot-init.c). Would you be able to
> >>> investigate what broke ?
> >>>
> >> in earlier times:
> >>
> >> root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias
> >> spi:tpo,td028ttec1
> >>
> >> now in 5.4-rc1:
> >> root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias
> >> spi:td028ttec1
> >>
> >> root@gta04:~# modinfo /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
> >> filename: /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
> >> license: GPL
> >> description: Toppoly TD028TTEC1 panel driver
> >> author: H. Nikolaus Schaller <hns@goldelico.com>
> >> srcversion: 6B3E224BCD3D76253CF361C
> >> alias: of:N*T*Ctoppoly,td028ttec1C*
> >> alias: of:N*T*Ctoppoly,td028ttec1
> >> alias: of:N*T*Ctpo,td028ttec1C*
> >> alias: of:N*T*Ctpo,td028ttec1
> >> alias: spi:toppoly,td028ttec1
> >> alias: spi:tpo,td028ttec1
> >> depends: drm
> >> intree: Y
> >> name: panel_tpo_td028ttec1
> >> vermagic: 5.4.0-rc1-letux+ SMP preempt mod_unload ARMv7 p2v8
> >>
> >> That alias is not in the list.
> >>
> > some more research:
> > in former times
> > of_modalias_node() has stripped the omapdss prefix, result: modalias=spi:tpo,td028ttec1
> > now it strips the tpo prefix because there is no omapdss prefix anymore.
>
> I haven't studied this more yet, but yes, I can see of_modalias_node
> stripping the vendor prefix on purpose. I do wonder how this is supposed
> to work, it would make more sense to me to keep the vendor prefix.
>
> Is the spi_device_id supposed to be without vendor prefix? With a quick
> grep, this seems to be the case.
>
as it is done in drivers/spi/spi.c we have no influence from drm side.
So we must live with it. Also checked several drivers, no vendor-prefix
there.
Regards,
Andreas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Letux-kernel] [PATCH] ARM: omap2plus_defconfig: Fix selected panels after generic panel changes
2019-10-07 16:09 ` Andreas Kemnade
@ 2019-10-07 17:08 ` Laurent Pinchart
-1 siblings, 0 replies; 24+ messages in thread
From: Laurent Pinchart @ 2019-10-07 17:08 UTC (permalink / raw)
To: Andreas Kemnade
Cc: Linux-OMAP, Tony Lindgren, Jyri Sarha, Tomi Valkeinen,
Discussions about the Letux Kernel, linux-arm-kernel
On Mon, Oct 07, 2019 at 06:09:57PM +0200, Andreas Kemnade wrote:
> On Mon, 7 Oct 2019 17:29:20 +0300 Tomi Valkeinen wrote:
> > On 07/10/2019 07:40, Andreas Kemnade wrote:
> >
> >>>> That's really weird, the driver name, the SPI device table and the OF
> >>>> device table are the same (except for the "omapdss," prefix that we
> >>>> don't add anymore in omapdss-boot-init.c). Would you be able to
> >>>> investigate what broke ?
> >>>>
> >>> in earlier times:
> >>>
> >>> root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias
> >>> spi:tpo,td028ttec1
> >>>
> >>> now in 5.4-rc1:
> >>> root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias
> >>> spi:td028ttec1
> >>>
> >>> root@gta04:~# modinfo /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
> >>> filename: /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
> >>> license: GPL
> >>> description: Toppoly TD028TTEC1 panel driver
> >>> author: H. Nikolaus Schaller <hns@goldelico.com>
> >>> srcversion: 6B3E224BCD3D76253CF361C
> >>> alias: of:N*T*Ctoppoly,td028ttec1C*
> >>> alias: of:N*T*Ctoppoly,td028ttec1
> >>> alias: of:N*T*Ctpo,td028ttec1C*
> >>> alias: of:N*T*Ctpo,td028ttec1
> >>> alias: spi:toppoly,td028ttec1
> >>> alias: spi:tpo,td028ttec1
> >>> depends: drm
> >>> intree: Y
> >>> name: panel_tpo_td028ttec1
> >>> vermagic: 5.4.0-rc1-letux+ SMP preempt mod_unload ARMv7 p2v8
> >>>
> >>> That alias is not in the list.
> >>>
> >> some more research:
> >> in former times
> >> of_modalias_node() has stripped the omapdss prefix, result: modalias=spi:tpo,td028ttec1
> >> now it strips the tpo prefix because there is no omapdss prefix anymore.
> >
> > I haven't studied this more yet, but yes, I can see of_modalias_node
> > stripping the vendor prefix on purpose. I do wonder how this is supposed
> > to work, it would make more sense to me to keep the vendor prefix.
> >
> > Is the spi_device_id supposed to be without vendor prefix? With a quick
> > grep, this seems to be the case.
>
> as it is done in drivers/spi/spi.c we have no influence from drm side.
> So we must live with it. Also checked several drivers, no vendor-prefix
> there.
I *think* SPI drivers are not supposed to include any prefix. The fix
would then simply be to strip the prefix from the SPI table (leaving it
there for the OF table of course). I've submitted a patch series to do
so.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [Letux-kernel] [PATCH] ARM: omap2plus_defconfig: Fix selected panels after generic panel changes
@ 2019-10-07 17:08 ` Laurent Pinchart
0 siblings, 0 replies; 24+ messages in thread
From: Laurent Pinchart @ 2019-10-07 17:08 UTC (permalink / raw)
To: Andreas Kemnade
Cc: Linux-OMAP, Tony Lindgren, Jyri Sarha, Tomi Valkeinen,
Discussions about the Letux Kernel, linux-arm-kernel
On Mon, Oct 07, 2019 at 06:09:57PM +0200, Andreas Kemnade wrote:
> On Mon, 7 Oct 2019 17:29:20 +0300 Tomi Valkeinen wrote:
> > On 07/10/2019 07:40, Andreas Kemnade wrote:
> >
> >>>> That's really weird, the driver name, the SPI device table and the OF
> >>>> device table are the same (except for the "omapdss," prefix that we
> >>>> don't add anymore in omapdss-boot-init.c). Would you be able to
> >>>> investigate what broke ?
> >>>>
> >>> in earlier times:
> >>>
> >>> root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias
> >>> spi:tpo,td028ttec1
> >>>
> >>> now in 5.4-rc1:
> >>> root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias
> >>> spi:td028ttec1
> >>>
> >>> root@gta04:~# modinfo /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
> >>> filename: /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
> >>> license: GPL
> >>> description: Toppoly TD028TTEC1 panel driver
> >>> author: H. Nikolaus Schaller <hns@goldelico.com>
> >>> srcversion: 6B3E224BCD3D76253CF361C
> >>> alias: of:N*T*Ctoppoly,td028ttec1C*
> >>> alias: of:N*T*Ctoppoly,td028ttec1
> >>> alias: of:N*T*Ctpo,td028ttec1C*
> >>> alias: of:N*T*Ctpo,td028ttec1
> >>> alias: spi:toppoly,td028ttec1
> >>> alias: spi:tpo,td028ttec1
> >>> depends: drm
> >>> intree: Y
> >>> name: panel_tpo_td028ttec1
> >>> vermagic: 5.4.0-rc1-letux+ SMP preempt mod_unload ARMv7 p2v8
> >>>
> >>> That alias is not in the list.
> >>>
> >> some more research:
> >> in former times
> >> of_modalias_node() has stripped the omapdss prefix, result: modalias=spi:tpo,td028ttec1
> >> now it strips the tpo prefix because there is no omapdss prefix anymore.
> >
> > I haven't studied this more yet, but yes, I can see of_modalias_node
> > stripping the vendor prefix on purpose. I do wonder how this is supposed
> > to work, it would make more sense to me to keep the vendor prefix.
> >
> > Is the spi_device_id supposed to be without vendor prefix? With a quick
> > grep, this seems to be the case.
>
> as it is done in drivers/spi/spi.c we have no influence from drm side.
> So we must live with it. Also checked several drivers, no vendor-prefix
> there.
I *think* SPI drivers are not supposed to include any prefix. The fix
would then simply be to strip the prefix from the SPI table (leaving it
there for the OF table of course). I've submitted a patch series to do
so.
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread