[PATCH] ACPI: suppress compiler warnings

[PATCH] ACPI: suppress compiler warnings

[Andy Shevchenko]

This patch fixes following compiler warnings:

drivers/acpi/csrt.c:135:116: warning: no previous prototype for ‘acpi_csrt_init’ [-Wmissing-prototypes]

drivers/acpi/container.c:183:116: warning: no previous prototype for ‘acpi_container_init’ [-Wmissing-prototypes]

drivers/pci/pcie/portdrv_acpi.c:34:5: warning: no previous prototype for ‘pcie_port_acpi_setup’ [-Wmissing-prototypes]

drivers/acpi/battery.c:149:52: warning: no previous prototype for ‘acpi_battery_present’ [-Wmissing-prototypes]

drivers/acpi/button.c:220:5: warning: no previous prototype for ‘acpi_lid_notifier_register’ [-Wmissing-prototypes]
drivers/acpi/button.c:226:5: warning: no previous prototype for ‘acpi_lid_notifier_unregister’ [-Wmissing-prototypes]
drivers/acpi/button.c:232:5: warning: no previous prototype for ‘acpi_lid_open’ [-Wmissing-prototypes]

drivers/acpi/processor_throttling.c: In function ‘acpi_processor_throttling_init’:
drivers/acpi/processor_throttling.c:216:40: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/acpi/battery.c              | 2 +-
 drivers/acpi/button.c               | 1 +
 drivers/acpi/container.c            | 2 ++
 drivers/acpi/csrt.c                 | 2 ++
 drivers/acpi/processor_throttling.c | 3 ++-
 drivers/pci/pcie/portdrv_acpi.c     | 1 +
 6 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
index c5cd5b5..0cc384b 100644
--- a/drivers/acpi/battery.c
+++ b/drivers/acpi/battery.c
@@ -146,7 +146,7 @@ struct acpi_battery {
 
 #define to_acpi_battery(x) container_of(x, struct acpi_battery, bat)
 
-inline int acpi_battery_present(struct acpi_battery *battery)
+static inline int acpi_battery_present(struct acpi_battery *battery)
 {
 	return battery->device->status.battery_present;
 }
diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c
index 86c7d54..92a659a 100644
--- a/drivers/acpi/button.c
+++ b/drivers/acpi/button.c
@@ -33,6 +33,7 @@
 #include <linux/slab.h>
 #include <acpi/acpi_bus.h>
 #include <acpi/acpi_drivers.h>
+#include <acpi/button.h>
 
 #define PREFIX "ACPI: "
 
diff --git a/drivers/acpi/container.c b/drivers/acpi/container.c
index 5523ba7..6624c01 100644
--- a/drivers/acpi/container.c
+++ b/drivers/acpi/container.c
@@ -35,6 +35,8 @@
 #include <acpi/acpi_bus.h>
 #include <acpi/acpi_drivers.h>
 
+#include "internal.h"
+
 #define PREFIX "ACPI: "
 
 #define _COMPONENT			ACPI_CONTAINER_COMPONENT
diff --git a/drivers/acpi/csrt.c b/drivers/acpi/csrt.c
index 5c15a91..8392052 100644
--- a/drivers/acpi/csrt.c
+++ b/drivers/acpi/csrt.c
@@ -19,6 +19,8 @@
 #include <linux/platform_device.h>
 #include <linux/sizes.h>
 
+#include "internal.h"
+
 ACPI_MODULE_NAME("CSRT");
 
 static int __init acpi_csrt_parse_shared_info(struct platform_device *pdev,
diff --git a/drivers/acpi/processor_throttling.c b/drivers/acpi/processor_throttling.c
index 1d02b7b..e7dd2c1 100644
--- a/drivers/acpi/processor_throttling.c
+++ b/drivers/acpi/processor_throttling.c
@@ -211,9 +211,10 @@ err_ret:
  */
 void acpi_processor_throttling_init(void)
 {
-	if (acpi_processor_update_tsd_coord())
+	if (acpi_processor_update_tsd_coord()) {
 		ACPI_DEBUG_PRINT((ACPI_DB_INFO,
 			"Assume no T-state coordination\n"));
+	}
 
 	return;
 }
diff --git a/drivers/pci/pcie/portdrv_acpi.c b/drivers/pci/pcie/portdrv_acpi.c
index a86b56e..b4d2894 100644
--- a/drivers/pci/pcie/portdrv_acpi.c
+++ b/drivers/pci/pcie/portdrv_acpi.c
@@ -17,6 +17,7 @@
 
 #include "aer/aerdrv.h"
 #include "../pci.h"
+#include "portdrv.h"
 
 /**
  * pcie_port_acpi_setup - Request the BIOS to release control of PCIe services.
-- 
1.8.2.rc0.22.gb3600c3

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ACPI: suppress compiler warnings

[Rafael J. Wysocki]

On Friday, March 08, 2013 03:23:11 PM Andy Shevchenko wrote:
> This patch fixes following compiler warnings:
> 
> drivers/acpi/csrt.c:135:116: warning: no previous prototype for ‘acpi_csrt_init’ [-Wmissing-prototypes]
> 
> drivers/acpi/container.c:183:116: warning: no previous prototype for ‘acpi_container_init’ [-Wmissing-prototypes]
> 
> drivers/pci/pcie/portdrv_acpi.c:34:5: warning: no previous prototype for ‘pcie_port_acpi_setup’ [-Wmissing-prototypes]
> 
> drivers/acpi/battery.c:149:52: warning: no previous prototype for ‘acpi_battery_present’ [-Wmissing-prototypes]
> 
> drivers/acpi/button.c:220:5: warning: no previous prototype for ‘acpi_lid_notifier_register’ [-Wmissing-prototypes]
> drivers/acpi/button.c:226:5: warning: no previous prototype for ‘acpi_lid_notifier_unregister’ [-Wmissing-prototypes]
> drivers/acpi/button.c:232:5: warning: no previous prototype for ‘acpi_lid_open’ [-Wmissing-prototypes]
> 
> drivers/acpi/processor_throttling.c: In function ‘acpi_processor_throttling_init’:
> drivers/acpi/processor_throttling.c:216:40: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Please split this into separate per-file patches.

Also it would be good to know what config options are triggering the warnings
in each case.

Thanks,
Rafael


> ---
>  drivers/acpi/battery.c              | 2 +-
>  drivers/acpi/button.c               | 1 +
>  drivers/acpi/container.c            | 2 ++
>  drivers/acpi/csrt.c                 | 2 ++
>  drivers/acpi/processor_throttling.c | 3 ++-
>  drivers/pci/pcie/portdrv_acpi.c     | 1 +
>  6 files changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
> index c5cd5b5..0cc384b 100644
> --- a/drivers/acpi/battery.c
> +++ b/drivers/acpi/battery.c
> @@ -146,7 +146,7 @@ struct acpi_battery {
>  
>  #define to_acpi_battery(x) container_of(x, struct acpi_battery, bat)
>  
> -inline int acpi_battery_present(struct acpi_battery *battery)
> +static inline int acpi_battery_present(struct acpi_battery *battery)
>  {
>  	return battery->device->status.battery_present;
>  }
> diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c
> index 86c7d54..92a659a 100644
> --- a/drivers/acpi/button.c
> +++ b/drivers/acpi/button.c
> @@ -33,6 +33,7 @@
>  #include <linux/slab.h>
>  #include <acpi/acpi_bus.h>
>  #include <acpi/acpi_drivers.h>
> +#include <acpi/button.h>
>  
>  #define PREFIX "ACPI: "
>  
> diff --git a/drivers/acpi/container.c b/drivers/acpi/container.c
> index 5523ba7..6624c01 100644
> --- a/drivers/acpi/container.c
> +++ b/drivers/acpi/container.c
> @@ -35,6 +35,8 @@
>  #include <acpi/acpi_bus.h>
>  #include <acpi/acpi_drivers.h>
>  
> +#include "internal.h"
> +
>  #define PREFIX "ACPI: "
>  
>  #define _COMPONENT			ACPI_CONTAINER_COMPONENT
> diff --git a/drivers/acpi/csrt.c b/drivers/acpi/csrt.c
> index 5c15a91..8392052 100644
> --- a/drivers/acpi/csrt.c
> +++ b/drivers/acpi/csrt.c
> @@ -19,6 +19,8 @@
>  #include <linux/platform_device.h>
>  #include <linux/sizes.h>
>  
> +#include "internal.h"
> +
>  ACPI_MODULE_NAME("CSRT");
>  
>  static int __init acpi_csrt_parse_shared_info(struct platform_device *pdev,
> diff --git a/drivers/acpi/processor_throttling.c b/drivers/acpi/processor_throttling.c
> index 1d02b7b..e7dd2c1 100644
> --- a/drivers/acpi/processor_throttling.c
> +++ b/drivers/acpi/processor_throttling.c
> @@ -211,9 +211,10 @@ err_ret:
>   */
>  void acpi_processor_throttling_init(void)
>  {
> -	if (acpi_processor_update_tsd_coord())
> +	if (acpi_processor_update_tsd_coord()) {
>  		ACPI_DEBUG_PRINT((ACPI_DB_INFO,
>  			"Assume no T-state coordination\n"));
> +	}
>  
>  	return;
>  }
> diff --git a/drivers/pci/pcie/portdrv_acpi.c b/drivers/pci/pcie/portdrv_acpi.c
> index a86b56e..b4d2894 100644
> --- a/drivers/pci/pcie/portdrv_acpi.c
> +++ b/drivers/pci/pcie/portdrv_acpi.c
> @@ -17,6 +17,7 @@
>  
>  #include "aer/aerdrv.h"
>  #include "../pci.h"
> +#include "portdrv.h"
>  
>  /**
>   * pcie_port_acpi_setup - Request the BIOS to release control of PCIe services.
> 
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ACPI: suppress compiler warnings

[Andy Shevchenko]

On Mon, 2013-03-11 at 04:31 +0100, Rafael J. Wysocki wrote: 
> On Friday, March 08, 2013 03:23:11 PM Andy Shevchenko wrote:
> > This patch fixes following compiler warnings:
> > 
> > drivers/acpi/csrt.c:135:116: warning: no previous prototype for ‘acpi_csrt_init’ [-Wmissing-prototypes]
> > 
> > drivers/acpi/container.c:183:116: warning: no previous prototype for ‘acpi_container_init’ [-Wmissing-prototypes]
> > 
> > drivers/pci/pcie/portdrv_acpi.c:34:5: warning: no previous prototype for ‘pcie_port_acpi_setup’ [-Wmissing-prototypes]
> > 
> > drivers/acpi/battery.c:149:52: warning: no previous prototype for ‘acpi_battery_present’ [-Wmissing-prototypes]
> > 
> > drivers/acpi/button.c:220:5: warning: no previous prototype for ‘acpi_lid_notifier_register’ [-Wmissing-prototypes]
> > drivers/acpi/button.c:226:5: warning: no previous prototype for ‘acpi_lid_notifier_unregister’ [-Wmissing-prototypes]
> > drivers/acpi/button.c:232:5: warning: no previous prototype for ‘acpi_lid_open’ [-Wmissing-prototypes]
> > 
> > drivers/acpi/processor_throttling.c: In function ‘acpi_processor_throttling_init’:
> > drivers/acpi/processor_throttling.c:216:40: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Please split this into separate per-file patches.

Done.

> Also it would be good to know what config options are triggering the warnings
> in each case.

You mean 'compiler option', do you?
Anyway, please, review patch v2 series.


-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html