Re: [PATCH v11 4/5] bond: unit tests

[Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>]

Hi Declan,

2014-06-29 18:49, Declan Doherty:
> +ifeq ($(CONFIG_RTE_LIBRTE_PMD_BOND),y)
> +SRCS-$(CONFIG_RTE_APP_TEST) += virtual_pmd.c
> +SRCS-$(CONFIG_RTE_APP_TEST) += packet_burst_generator.c
> +SRCS-$(CONFIG_RTE_APP_TEST) += test_link_bonding.c
> +endif
>  ifeq ($(CONFIG_RTE_APP_TEST),y)
>  SRCS-$(CONFIG_RTE_LIBRTE_ACL) += test_acl.c
>  SRCS-$(CONFIG_RTE_LIBRTE_PMD_RING) += test_pmd_ring.c

I think there is a cleaner way to fix build without bonding.
See my patch proposal below:

 SRCS-$(CONFIG_RTE_APP_TEST) += virtual_pmd.c
 SRCS-$(CONFIG_RTE_APP_TEST) += packet_burst_generator.c
-SRCS-$(CONFIG_RTE_APP_TEST) += test_link_bonding.c
 ifeq ($(CONFIG_RTE_APP_TEST),y)
 SRCS-$(CONFIG_RTE_LIBRTE_ACL) += test_acl.c
+SRCS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += test_link_bonding.c
 SRCS-$(CONFIG_RTE_LIBRTE_PMD_RING) += test_pmd_ring.c

-- 
Thomas