Re: [PATCH v7 6/6] Link Bonding Library doxygen additions

[Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>]

2014-06-25 14:19, Doherty, Declan:
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> > Sent: Wednesday, June 25, 2014 2:44 PM
> > To: Doherty, Declan
> > Cc: dev-VfR2kkLFssw@public.gmane.org
> > Subject: Re: [PATCH v7 6/6] Link Bonding Library doxygen additions
> > 
> > Hi Declan,
> > 
> > Since bonding library is a PMD, there should have no need of integrate it
> > in the API documentation.
> > I hadn't time to review it yet, so I would miss something.
> > Do you mean it can be used directly by the application with a specific
> > API?
> > In this case, you could explain it in the commit log.
> 
> Hi Thomas, the bonding library has a  API which supports creation and
> management of bonded devices directly from within applications, but more
> importantly provides the APIs required to dynamically add and remove slaves
> from a bonded device, this functionality will be required to support live
> migration of VMs using bonded ports in a future releases.

OK. Could I suggest to split rte_eth_bond.c in 2 files?
1 file for the library matching the API and 1 file for the PMD layer?
I feel it would be easier to read and maintain.

Thanks
-- 
Thomas