[BUG] git-2.36.0-rc0 - t6200 fails due to library/path issues

[BUG] git-2.36.0-rc0 - t6200 fails due to library/path issues

[rsbecker]

t6200 makes assumptions that ssh-keygen to be used is located in
/usr/local/bin. This causes problems when we have multiple OpenSSL
installations - which we do - 3 of them. Our environment supplies OpenSSL
1.1 in /usr/local-ssl1.1, with a corresponding version of ssh-agent in a
different directory. There needs to be a mechanism to override the
ssh-keygen so that tests will work in this situation.

*** RLD ERROR ***: Unresolved Text Symbol OPENSSL_add_all_algorithms_noconf
in file /usr/local/bin/ssh-keygen.

*** RLD ERROR ***: Unresolved Text Symbol EVP_MD_CTX_cleanup in file
/usr/local/bin/ssh-keygen.

*** RLD ERROR ***: Unresolved Text Symbol SSLeay in file
/usr/local/bin/ssh-keygen.

*** RLD ERROR ***: Unresolved Text Symbol EVP_MD_block_size in file
/usr/local/bin/ssh-keygen.

*** RLD ERROR ***: Unresolved Text Symbol EVP_MD_CTX_init in file
/usr/local/bin/ssh-keygen.

I do not know why the test is forcing SSH in /usr/local/bin - it is not
something coming from our environment, which has PATH set correctly.

Thanks,
Randall

Re: [BUG] git-2.36.0-rc0 - t6200 fails due to library/path issues

[Ævar Arnfjörð Bjarmason]

On Wed, Apr 06 2022, rsbecker@nexbridge.com wrote:

> t6200 makes assumptions that ssh-keygen to be used is located in
> /usr/local/bin. This causes problems when we have multiple OpenSSL
> installations - which we do - 3 of them. Our environment supplies OpenSSL
> 1.1 in /usr/local-ssl1.1, with a corresponding version of ssh-agent in a
> different directory. There needs to be a mechanism to override the
> ssh-keygen so that tests will work in this situation.
>
> *** RLD ERROR ***: Unresolved Text Symbol OPENSSL_add_all_algorithms_noconf
> in file /usr/local/bin/ssh-keygen.
>
> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_CTX_cleanup in file
> /usr/local/bin/ssh-keygen.
>
> *** RLD ERROR ***: Unresolved Text Symbol SSLeay in file
> /usr/local/bin/ssh-keygen.
>
> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_block_size in file
> /usr/local/bin/ssh-keygen.
>
> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_CTX_init in file
> /usr/local/bin/ssh-keygen.
>
> I do not know why the test is forcing SSH in /usr/local/bin - it is not
> something coming from our environment, which has PATH set correctly.

Is it:

	SANE_TOOL_PATH = /usr/coreutils/bin:/usr/local/bin

In the nonstop section in config.mak.uname along with:
	
	Makefile:ifdef SANE_TOOL_PATH
	Makefile:SANE_TOOL_PATH_SQ = $(subst ','\'',$(SANE_TOOL_PATH))
	Makefile:BROKEN_PATH_FIX = 's|^\# @@BROKEN_PATH_FIX@@$$|git_broken_path_fix "$(SANE_TOOL_PATH_SQ)"|'
	Makefile:PATH := $(SANE_TOOL_PATH):${PATH}
	Makefile-else
	Makefile-BROKEN_PATH_FIX = '/^\# @@BROKEN_PATH_FIX@@$$/d'
	Makefile-endif
	
?

RE: [BUG] git-2.36.0-rc0 - t6200 fails due to library/path issues

[rsbecker]

On April 6, 2022 9:52 AM, Ævar Arnfjörð Bjarmason wrote:
>On Wed, Apr 06 2022, rsbecker@nexbridge.com wrote:
>
>> t6200 makes assumptions that ssh-keygen to be used is located in
>> /usr/local/bin. This causes problems when we have multiple OpenSSL
>> installations - which we do - 3 of them. Our environment supplies
>> OpenSSL
>> 1.1 in /usr/local-ssl1.1, with a corresponding version of ssh-agent in
>> a different directory. There needs to be a mechanism to override the
>> ssh-keygen so that tests will work in this situation.
>>
>> *** RLD ERROR ***: Unresolved Text Symbol
>> OPENSSL_add_all_algorithms_noconf in file /usr/local/bin/ssh-keygen.
>>
>> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_CTX_cleanup in file
>> /usr/local/bin/ssh-keygen.
>>
>> *** RLD ERROR ***: Unresolved Text Symbol SSLeay in file
>> /usr/local/bin/ssh-keygen.
>>
>> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_block_size in file
>> /usr/local/bin/ssh-keygen.
>>
>> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_CTX_init in file
>> /usr/local/bin/ssh-keygen.
>>
>> I do not know why the test is forcing SSH in /usr/local/bin - it is
>> not something coming from our environment, which has PATH set correctly.
>
>Is it:
>
>	SANE_TOOL_PATH = /usr/coreutils/bin:/usr/local/bin
>
>In the nonstop section in config.mak.uname along with:
>
>	Makefile:ifdef SANE_TOOL_PATH
>	Makefile:SANE_TOOL_PATH_SQ = $(subst ','\'',$(SANE_TOOL_PATH))
>	Makefile:BROKEN_PATH_FIX = 's|^\#
>@@BROKEN_PATH_FIX@@$$|git_broken_path_fix "$(SANE_TOOL_PATH_SQ)"|'
>	Makefile:PATH := $(SANE_TOOL_PATH):${PATH}
>	Makefile-else
>	Makefile-BROKEN_PATH_FIX = '/^\# @@BROKEN_PATH_FIX@@$$/d'
>	Makefile-endif
>
>?

OIC. Can I change the PATH value when running the tests without changing config.mak.uname?

RE: [BUG] git-2.36.0-rc0 - t6200 fails due to library/path issues

[rsbecker]

On April 6, 2022 9:52 AM, Ævar Arnfjörð Bjarmason wrote:
>On Wed, Apr 06 2022, rsbecker@nexbridge.com wrote:
>
>> t6200 makes assumptions that ssh-keygen to be used is located in
>> /usr/local/bin. This causes problems when we have multiple OpenSSL
>> installations - which we do - 3 of them. Our environment supplies
>> OpenSSL
>> 1.1 in /usr/local-ssl1.1, with a corresponding version of ssh-agent in
>> a different directory. There needs to be a mechanism to override the
>> ssh-keygen so that tests will work in this situation.
>>
>> *** RLD ERROR ***: Unresolved Text Symbol
>> OPENSSL_add_all_algorithms_noconf in file /usr/local/bin/ssh-keygen.
>>
>> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_CTX_cleanup in file
>> /usr/local/bin/ssh-keygen.
>>
>> *** RLD ERROR ***: Unresolved Text Symbol SSLeay in file
>> /usr/local/bin/ssh-keygen.
>>
>> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_block_size in file
>> /usr/local/bin/ssh-keygen.
>>
>> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_CTX_init in file
>> /usr/local/bin/ssh-keygen.
>>
>> I do not know why the test is forcing SSH in /usr/local/bin - it is
>> not something coming from our environment, which has PATH set correctly.
>
>Is it:
>
>	SANE_TOOL_PATH = /usr/coreutils/bin:/usr/local/bin
>
>In the nonstop section in config.mak.uname along with:
>
>	Makefile:ifdef SANE_TOOL_PATH
>	Makefile:SANE_TOOL_PATH_SQ = $(subst ','\'',$(SANE_TOOL_PATH))
>	Makefile:BROKEN_PATH_FIX = 's|^\#
>@@BROKEN_PATH_FIX@@$$|git_broken_path_fix "$(SANE_TOOL_PATH_SQ)"|'
>	Makefile:PATH := $(SANE_TOOL_PATH):${PATH}
>	Makefile-else
>	Makefile-BROKEN_PATH_FIX = '/^\# @@BROKEN_PATH_FIX@@$$/d'
>	Makefile-endif
>
>?

I should also point out that we have not previously had path problems like this (2.35.1 and before going back years).

Re: [BUG] git-2.36.0-rc0 - t6200 fails due to library/path issues

[Junio C Hamano]

<rsbecker@nexbridge.com> writes:

> t6200 makes assumptions that ssh-keygen to be used is located in
> /usr/local/bin. This causes problems when we have multiple OpenSSL
> installations - which we do - 3 of them. Our environment supplies OpenSSL
> 1.1 in /usr/local-ssl1.1, with a corresponding version of ssh-agent in a
> different directory. There needs to be a mechanism to override the
> ssh-keygen so that tests will work in this situation.
>
> *** RLD ERROR ***: Unresolved Text Symbol OPENSSL_add_all_algorithms_noconf
> in file /usr/local/bin/ssh-keygen.
>
> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_CTX_cleanup in file
> /usr/local/bin/ssh-keygen.
>
> *** RLD ERROR ***: Unresolved Text Symbol SSLeay in file
> /usr/local/bin/ssh-keygen.
>
> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_block_size in file
> /usr/local/bin/ssh-keygen.
>
> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_CTX_init in file
> /usr/local/bin/ssh-keygen.
>
> I do not know why the test is forcing SSH in /usr/local/bin - it is not
> something coming from our environment, which has PATH set correctly.

Indeed that is curious, as the only hits to usr/local in t/ is this one:

    $ git grep usr/local t/
    t/test-lib.sh:test FreeBSD != $uname_s || GIT_UNZIP=${GIT_UNZIP:-/usr/local/bin/unzip}

RE: [BUG] git-2.36.0-rc0 - t6200 fails due to library/path issues

[rsbecker]

On April 6, 2022 1:39 PM, Junio C Hamano wrote:
><rsbecker@nexbridge.com> writes:
>
>> t6200 makes assumptions that ssh-keygen to be used is located in
>> /usr/local/bin. This causes problems when we have multiple OpenSSL
>> installations - which we do - 3 of them. Our environment supplies
>> OpenSSL
>> 1.1 in /usr/local-ssl1.1, with a corresponding version of ssh-agent in
>> a different directory. There needs to be a mechanism to override the
>> ssh-keygen so that tests will work in this situation.
>>
>> *** RLD ERROR ***: Unresolved Text Symbol
>> OPENSSL_add_all_algorithms_noconf in file /usr/local/bin/ssh-keygen.
>>
>> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_CTX_cleanup in file
>> /usr/local/bin/ssh-keygen.
>>
>> *** RLD ERROR ***: Unresolved Text Symbol SSLeay in file
>> /usr/local/bin/ssh-keygen.
>>
>> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_block_size in file
>> /usr/local/bin/ssh-keygen.
>>
>> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_CTX_init in file
>> /usr/local/bin/ssh-keygen.
>>
>> I do not know why the test is forcing SSH in /usr/local/bin - it is
>> not something coming from our environment, which has PATH set correctly.
>
>Indeed that is curious, as the only hits to usr/local in t/ is this one:
>
>    $ git grep usr/local t/
>    t/test-lib.sh:test FreeBSD != $uname_s || GIT_UNZIP=${GIT_UNZIP:-
>/usr/local/bin/unzip}

I think it's coming from the NonStop definition in config.mak.uname, but I
need to be able to override the PATH to pick up the correct OpenSSH for the
OpenSSL build. We have 12 different OpenSSL builds at this point and 3
OpenSSH builds - which will likely go to 6 within the year. The complexity
is wacky but needed because we cannot set up a VM for NonStop with the
hardware we have.