All of lore.kernel.org
 help / color / mirror / Atom feed
* [OSSTEST PATCH] cs-bisection-step: Limit size of revision log included in reports
       [not found] <565C3490.2070904@citrix.com>
@ 2015-11-30 13:41 ` Ian Jackson
  2015-11-30 13:57   ` Ian Campbell
  0 siblings, 1 reply; 3+ messages in thread
From: Ian Jackson @ 2015-11-30 13:41 UTC (permalink / raw)
  To: xen-devel; +Cc: Ian Jackson, Ian Campbell, David Vrabel

There is a limit in cr-daily-branch, but none in cs-bisection-step.

adhoc-revtuple-generator could usefully have this built in but that's
not so simple, so do it again here.  We already slurp the whole thing
into core so from a resource usage point of view we might as well do
the length check here too.

Reported-by: David Vrabel <david.vrabel@citrix.com>
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 cs-bisection-step |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/cs-bisection-step b/cs-bisection-step
index e51babd..928a147 100755
--- a/cs-bisection-step
+++ b/cs-bisection-step
@@ -898,6 +898,11 @@ END
 		    "./adhoc-revtuple-generator -S @revtuplegenargs $rts";
                 my $revinfo= `$revrune`;
                 if (!$?) {
+		    if (length($revinfo) > 24000) {
+			$revinfo = <<END;
+(Revision log too long, ommitted.)
+END
+		    }
                     summary_report("",$revinfo,-1);
                 }
             }
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [OSSTEST PATCH] cs-bisection-step: Limit size of revision log included in reports
  2015-11-30 13:41 ` [OSSTEST PATCH] cs-bisection-step: Limit size of revision log included in reports Ian Jackson
@ 2015-11-30 13:57   ` Ian Campbell
  2015-11-30 14:03     ` Ian Jackson
  0 siblings, 1 reply; 3+ messages in thread
From: Ian Campbell @ 2015-11-30 13:57 UTC (permalink / raw)
  To: Ian Jackson, xen-devel; +Cc: David Vrabel

On Mon, 2015-11-30 at 13:41 +0000, Ian Jackson wrote:
> There is a limit in cr-daily-branch, but none in cs-bisection-step.
> 
> adhoc-revtuple-generator could usefully have this built in but that's
> not so simple, so do it again here.  We already slurp the whole thing
> into core so from a resource usage point of view we might as well do
> the length check here too.
> 
> Reported-by: David Vrabel <david.vrabel@citrix.com>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

> +(Revision log too long, ommitted.)

My MUA's spell checker thinks it is "omitted".

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [OSSTEST PATCH] cs-bisection-step: Limit size of revision log included in reports
  2015-11-30 13:57   ` Ian Campbell
@ 2015-11-30 14:03     ` Ian Jackson
  0 siblings, 0 replies; 3+ messages in thread
From: Ian Jackson @ 2015-11-30 14:03 UTC (permalink / raw)
  To: Ian Campbell; +Cc: xen-devel, Ian Jackson, David Vrabel

Ian Campbell writes ("Re: [OSSTEST PATCH] cs-bisection-step: Limit size of revision log included in reports"):
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> > +(Revision log too long, ommitted.)
> 
> My MUA's spell checker thinks it is "omitted".

Thanks.  I have ommittedd the spurrious lettter.

Ian.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-11-30 14:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <565C3490.2070904@citrix.com>
2015-11-30 13:41 ` [OSSTEST PATCH] cs-bisection-step: Limit size of revision log included in reports Ian Jackson
2015-11-30 13:57   ` Ian Campbell
2015-11-30 14:03     ` Ian Jackson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.