From: David Howells <dhowells@redhat.com>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: dhowells@redhat.com, viro@zeniv.linux.org.uk, miklos@szeredi.hu,
linux-fsdevel@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Paul Moore <paul@paul-moore.com>, SELinux <selinux@tycho.nsa.gov>
Subject: Re: [PATCH 5/8] SELinux: Stub in copy-up handling
Date: Thu, 18 Jun 2015 17:51:15 +0100 [thread overview]
Message-ID: <2213.1434646275@warthog.procyon.org.uk> (raw)
In-Reply-To: <5582D953.2030209@tycho.nsa.gov>
Stephen Smalley <sds@tycho.nsa.gov> wrote:
> I'm not sure we never want to copy up the SELinux attribute. See my
> other email about ecryptfs and supporting per-file labeling and
> consistent access control over the upper and lower inodes.
Yes. That's why there are two operations. inode_copy_up() should set the
label appropriately and inode_copy_up_xattr() should prevent the label set by
inode_copy_up() from being clobbered.
Note that inode_copy_up() has access to the lower file label and can perform
some sort of incantation to transmute it before applying it.
David
WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells@redhat.com>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: miklos@szeredi.hu, linux-unionfs@vger.kernel.org,
linux-kernel@vger.kernel.org, dhowells@redhat.com,
linux-security-module@vger.kernel.org, viro@zeniv.linux.org.uk,
SELinux <selinux@tycho.nsa.gov>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 5/8] SELinux: Stub in copy-up handling
Date: Thu, 18 Jun 2015 17:51:15 +0100 [thread overview]
Message-ID: <2213.1434646275@warthog.procyon.org.uk> (raw)
In-Reply-To: <5582D953.2030209@tycho.nsa.gov>
Stephen Smalley <sds@tycho.nsa.gov> wrote:
> I'm not sure we never want to copy up the SELinux attribute. See my
> other email about ecryptfs and supporting per-file labeling and
> consistent access control over the upper and lower inodes.
Yes. That's why there are two operations. inode_copy_up() should set the
label appropriately and inode_copy_up_xattr() should prevent the label set by
inode_copy_up() from being clobbered.
Note that inode_copy_up() has access to the lower file label and can perform
some sort of incantation to transmute it before applying it.
David
next prev parent reply other threads:[~2015-06-18 16:51 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 13:32 [PATCH 0/8] Security: Provide unioned file support David Howells
2015-06-18 13:32 ` [PATCH 1/8] overlay: Call ovl_drop_write() earlier in ovl_dentry_open() David Howells
2015-06-18 13:32 ` [PATCH 2/8] overlayfs: Make f_path always point to the overlay and f_inode to the underlay David Howells
2015-07-20 12:42 ` Konstantin Khlebnikov
2015-07-21 13:28 ` Konstantin Khlebnikov
2015-06-18 13:32 ` [PATCH 3/8] Security: Provide copy-up security hooks for unioned files David Howells
2015-06-18 13:32 ` [PATCH 4/8] Overlayfs: Use copy-up security hooks David Howells
2015-06-18 13:32 ` [PATCH 5/8] SELinux: Stub in copy-up handling David Howells
2015-06-18 14:44 ` Stephen Smalley
2015-06-18 14:44 ` Stephen Smalley
2015-06-18 15:34 ` Casey Schaufler
2015-06-18 16:51 ` David Howells [this message]
2015-06-18 16:51 ` David Howells
2015-06-18 13:33 ` [PATCH 6/8] SELinux: Handle opening of a unioned file David Howells
2015-06-18 14:54 ` Stephen Smalley
2015-06-18 14:54 ` Stephen Smalley
2015-06-18 15:04 ` David Howells
2015-06-18 15:04 ` David Howells
2015-06-18 13:33 ` [PATCH 7/8] SELinux: Create a common helper to determine an inode label David Howells
2015-06-18 14:56 ` Stephen Smalley
2015-06-18 14:56 ` Stephen Smalley
2015-06-18 15:13 ` David Howells
2015-06-18 15:13 ` David Howells
2015-06-18 15:20 ` Stephen Smalley
2015-06-18 15:20 ` Stephen Smalley
2015-06-18 15:32 ` David Howells
2015-06-18 15:32 ` David Howells
2015-06-18 15:47 ` Stephen Smalley
2015-06-18 15:47 ` Stephen Smalley
2015-06-18 15:47 ` Stephen Smalley
2015-06-18 15:47 ` Stephen Smalley
2015-06-18 13:33 ` [PATCH 8/8] SELinux: Check against union label for file operations David Howells
2015-06-19 7:20 ` [PATCH 0/8] Security: Provide unioned file support Al Viro
2015-06-19 7:52 ` Miklos Szeredi
2015-06-19 7:59 ` Al Viro
2015-06-19 8:11 ` Miklos Szeredi
2015-06-19 8:29 ` Al Viro
2015-06-19 8:36 ` Miklos Szeredi
2015-06-19 14:04 ` David Howells
2015-06-19 14:04 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2213.1434646275@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=paul@paul-moore.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.