* [PATCH] meson: put custom CFLAGS after default CFLAGS
@ 2022-02-10 11:44 Konstantin Khlebnikov
2022-02-10 11:52 ` Philippe Mathieu-Daudé via
0 siblings, 1 reply; 3+ messages in thread
From: Konstantin Khlebnikov @ 2022-02-10 11:44 UTC (permalink / raw)
To: qemu-devel; +Cc: yc-core
Flags passed to configure must be at the end to override defaults.
Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
---
meson.build | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/meson.build b/meson.build
index 5f43355071..d94f3ee3e3 100644
--- a/meson.build
+++ b/meson.build
@@ -3293,13 +3293,13 @@ if targetos == 'windows'
summary_info += {'Windows SDK': config_host['WIN_SDK']}
endif
endif
-summary_info += {'CFLAGS': ' '.join(get_option('c_args')
- + ['-O' + get_option('optimization')]
- + (get_option('debug') ? ['-g'] : []))}
+summary_info += {'CFLAGS': ' '.join(['-O' + get_option('optimization')]
+ + (get_option('debug') ? ['-g'] : [])
+ + get_option('c_args'))}
if link_language == 'cpp'
- summary_info += {'CXXFLAGS': ' '.join(get_option('cpp_args')
- + ['-O' + get_option('optimization')]
- + (get_option('debug') ? ['-g'] : []))}
+ summary_info += {'CXXFLAGS': ' '.join(['-O' + get_option('optimization')]
+ + (get_option('debug') ? ['-g'] : [])
+ + get_option('cpp_args'))}
endif
link_args = get_option(link_language + '_link_args')
if link_args.length() > 0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] meson: put custom CFLAGS after default CFLAGS
2022-02-10 11:44 [PATCH] meson: put custom CFLAGS after default CFLAGS Konstantin Khlebnikov
@ 2022-02-10 11:52 ` Philippe Mathieu-Daudé via
2022-02-10 11:56 ` Konstantin Khlebnikov
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé via @ 2022-02-10 11:52 UTC (permalink / raw)
To: Konstantin Khlebnikov, qemu-devel; +Cc: yc-core, Paolo Bonzini
Hi Konstantin,
On 10/2/22 12:44, Konstantin Khlebnikov wrote:
> Flags passed to configure must be at the end to override defaults.
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
> ---
> meson.build | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index 5f43355071..d94f3ee3e3 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -3293,13 +3293,13 @@ if targetos == 'windows'
> summary_info += {'Windows SDK': config_host['WIN_SDK']}
> endif
> endif
> -summary_info += {'CFLAGS': ' '.join(get_option('c_args')
> - + ['-O' + get_option('optimization')]
> - + (get_option('debug') ? ['-g'] : []))}
> +summary_info += {'CFLAGS': ' '.join(['-O' + get_option('optimization')]
> + + (get_option('debug') ? ['-g'] : [])
> + + get_option('c_args'))}
> if link_language == 'cpp'
> - summary_info += {'CXXFLAGS': ' '.join(get_option('cpp_args')
> - + ['-O' + get_option('optimization')]
> - + (get_option('debug') ? ['-g'] : []))}
> + summary_info += {'CXXFLAGS': ' '.join(['-O' + get_option('optimization')]
> + + (get_option('debug') ? ['-g'] : [])
> + + get_option('cpp_args'))}
These are just informative... What is your problem? AFAIU This patch
doesn't have any logical impact on the build system.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] meson: put custom CFLAGS after default CFLAGS
2022-02-10 11:52 ` Philippe Mathieu-Daudé via
@ 2022-02-10 11:56 ` Konstantin Khlebnikov
0 siblings, 0 replies; 3+ messages in thread
From: Konstantin Khlebnikov @ 2022-02-10 11:56 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Paolo Bonzini, yc-core
[-- Attachment #1: Type: text/html, Size: 1903 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-10 12:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-10 11:44 [PATCH] meson: put custom CFLAGS after default CFLAGS Konstantin Khlebnikov
2022-02-10 11:52 ` Philippe Mathieu-Daudé via
2022-02-10 11:56 ` Konstantin Khlebnikov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.