* [PATCH] [media] cx24120: do not allow an invalid delivery system types
@ 2016-09-03 17:04 Colin King
2016-09-05 18:20 ` Jemma Denson
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2016-09-03 17:04 UTC (permalink / raw)
To: Jemma Denson, Patrick Boettcher, Mauro Carvalho Chehab, linux-media
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
cx24120_set_frontend currently allows invalid delivery system types
other than SYS_DVBS2 and SYS_DVBS. Fix this by returning -EINVAL
for invalid values.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/media/dvb-frontends/cx24120.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/dvb-frontends/cx24120.c b/drivers/media/dvb-frontends/cx24120.c
index 066ee38..3112a32 100644
--- a/drivers/media/dvb-frontends/cx24120.c
+++ b/drivers/media/dvb-frontends/cx24120.c
@@ -1154,8 +1154,7 @@ static int cx24120_set_frontend(struct dvb_frontend *fe)
dev_dbg(&state->i2c->dev,
"delivery system(%d) not supported\n",
c->delivery_system);
- ret = -EINVAL;
- break;
+ return -EINVAL;
}
state->dnxt.delsys = c->delivery_system;
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [media] cx24120: do not allow an invalid delivery system types
2016-09-03 17:04 [PATCH] [media] cx24120: do not allow an invalid delivery system types Colin King
@ 2016-09-05 18:20 ` Jemma Denson
0 siblings, 0 replies; 2+ messages in thread
From: Jemma Denson @ 2016-09-05 18:20 UTC (permalink / raw)
To: Colin King, Patrick Boettcher, Mauro Carvalho Chehab, linux-media
Cc: linux-kernel
On 03/09/16 18:04, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> cx24120_set_frontend currently allows invalid delivery system types
> other than SYS_DVBS2 and SYS_DVBS. Fix this by returning -EINVAL
> for invalid values.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/media/dvb-frontends/cx24120.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Yes, that's needed, thanks!
Acked-by: Jemma Denson <jdenson@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-05 18:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-03 17:04 [PATCH] [media] cx24120: do not allow an invalid delivery system types Colin King
2016-09-05 18:20 ` Jemma Denson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.