All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/bridge: ti-tfp410: Update drm_connector_init_with_ddc() error message
@ 2019-08-14  9:23 Geert Uytterhoeven
  2019-08-14  9:50 ` Neil Armstrong
  0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2019-08-14  9:23 UTC (permalink / raw)
  To: Andrzej Pietrasiewicz, Andrzej Hajda, Neil Armstrong,
	David Airlie, Daniel Vetter
  Cc: Jernej Skrabec, Geert Uytterhoeven, Laurent Pinchart, dri-devel,
	Jonas Karlman

The code was changed to call drm_connector_init_with_ddc() instead of
drm_connector_init(), but the corresponding error message was not
updated.

Fixes: cfb444552926989f ("drm/bridge: ti-tfp410: Provide ddc symlink in connector sysfs directory")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/gpu/drm/bridge/ti-tfp410.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c
index 61cc2354ef1bfe7e..be6c99cac41953e9 100644
--- a/drivers/gpu/drm/bridge/ti-tfp410.c
+++ b/drivers/gpu/drm/bridge/ti-tfp410.c
@@ -139,7 +139,8 @@ static int tfp410_attach(struct drm_bridge *bridge)
 					  dvi->connector_type,
 					  dvi->ddc);
 	if (ret) {
-		dev_err(dvi->dev, "drm_connector_init() failed: %d\n", ret);
+		dev_err(dvi->dev, "drm_connector_init_with_ddc() failed: %d\n",
+			ret);
 		return ret;
 	}
 
-- 
2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/bridge: ti-tfp410: Update drm_connector_init_with_ddc() error message
  2019-08-14  9:23 [PATCH] drm/bridge: ti-tfp410: Update drm_connector_init_with_ddc() error message Geert Uytterhoeven
@ 2019-08-14  9:50 ` Neil Armstrong
  0 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2019-08-14  9:50 UTC (permalink / raw)
  To: Geert Uytterhoeven, Andrzej Pietrasiewicz, Andrzej Hajda,
	David Airlie, Daniel Vetter
  Cc: Jernej Skrabec, Laurent Pinchart, dri-devel, Jonas Karlman

On 14/08/2019 11:23, Geert Uytterhoeven wrote:
> The code was changed to call drm_connector_init_with_ddc() instead of
> drm_connector_init(), but the corresponding error message was not
> updated.
> 
> Fixes: cfb444552926989f ("drm/bridge: ti-tfp410: Provide ddc symlink in connector sysfs directory")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/gpu/drm/bridge/ti-tfp410.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c
> index 61cc2354ef1bfe7e..be6c99cac41953e9 100644
> --- a/drivers/gpu/drm/bridge/ti-tfp410.c
> +++ b/drivers/gpu/drm/bridge/ti-tfp410.c
> @@ -139,7 +139,8 @@ static int tfp410_attach(struct drm_bridge *bridge)
>  					  dvi->connector_type,
>  					  dvi->ddc);
>  	if (ret) {
> -		dev_err(dvi->dev, "drm_connector_init() failed: %d\n", ret);
> +		dev_err(dvi->dev, "drm_connector_init_with_ddc() failed: %d\n",
> +			ret);
>  		return ret;
>  	}
>  
> 

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] drm/bridge: ti-tfp410: Update drm_connector_init_with_ddc() error message
@ 2019-10-25  9:24 ` Geert Uytterhoeven
  0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2019-10-25  9:24 UTC (permalink / raw)
  To: Andrzej Hajda, Neil Armstrong, David Airlie, Daniel Vetter
  Cc: dri-devel, linux-kernel, Geert Uytterhoeven

The code was changed to call drm_connector_init_with_ddc() instead of
drm_connector_init(), but the corresponding error message was not
updated.

Fixes: cfb444552926989f ("drm/bridge: ti-tfp410: Provide ddc symlink in connector sysfs directory")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
---
v2:
  - Add Reviewed-by.
---
 drivers/gpu/drm/bridge/ti-tfp410.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c
index aa3198dc9903cefb..5ca4c0417c186e6e 100644
--- a/drivers/gpu/drm/bridge/ti-tfp410.c
+++ b/drivers/gpu/drm/bridge/ti-tfp410.c
@@ -140,7 +140,8 @@ static int tfp410_attach(struct drm_bridge *bridge)
 					  dvi->connector_type,
 					  dvi->ddc);
 	if (ret) {
-		dev_err(dvi->dev, "drm_connector_init() failed: %d\n", ret);
+		dev_err(dvi->dev, "drm_connector_init_with_ddc() failed: %d\n",
+			ret);
 		return ret;
 	}
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] drm/bridge: ti-tfp410: Update drm_connector_init_with_ddc() error message
@ 2019-10-25  9:24 ` Geert Uytterhoeven
  0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2019-10-25  9:24 UTC (permalink / raw)
  To: Andrzej Hajda, Neil Armstrong, David Airlie, Daniel Vetter
  Cc: Geert Uytterhoeven, linux-kernel, dri-devel

The code was changed to call drm_connector_init_with_ddc() instead of
drm_connector_init(), but the corresponding error message was not
updated.

Fixes: cfb444552926989f ("drm/bridge: ti-tfp410: Provide ddc symlink in connector sysfs directory")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
---
v2:
  - Add Reviewed-by.
---
 drivers/gpu/drm/bridge/ti-tfp410.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c
index aa3198dc9903cefb..5ca4c0417c186e6e 100644
--- a/drivers/gpu/drm/bridge/ti-tfp410.c
+++ b/drivers/gpu/drm/bridge/ti-tfp410.c
@@ -140,7 +140,8 @@ static int tfp410_attach(struct drm_bridge *bridge)
 					  dvi->connector_type,
 					  dvi->ddc);
 	if (ret) {
-		dev_err(dvi->dev, "drm_connector_init() failed: %d\n", ret);
+		dev_err(dvi->dev, "drm_connector_init_with_ddc() failed: %d\n",
+			ret);
 		return ret;
 	}
 
-- 
2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-10-28  8:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-14  9:23 [PATCH] drm/bridge: ti-tfp410: Update drm_connector_init_with_ddc() error message Geert Uytterhoeven
2019-08-14  9:50 ` Neil Armstrong
2019-10-25  9:24 Geert Uytterhoeven
2019-10-25  9:24 ` Geert Uytterhoeven

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.