All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: nico@linaro.org
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
	josh@joshtriplett.org, nicolas.pitre@linaro.org,
	mingo@kernel.org, hpa@zytor.com, richardcochran@gmail.com,
	pebolle@tiscali.nl, ecree@solarflare.com, john.stultz@linaro.org,
	mmarek@suse.com, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:timers/core] ptp_clock: Allow for it to be optional
Date: Thu, 17 Nov 2016 17:44:05 +0100	[thread overview]
Message-ID: <22431516.ipZiDAzsn3@wuerfel> (raw)
In-Reply-To: <tip-d1cbfd771ce8297fa11e89f315392de6056a2181@git.kernel.org>

On Wednesday, November 16, 2016 12:32:03 AM CET tip-bot for Nicolas Pitre wrote:
> Commit-ID:  d1cbfd771ce8297fa11e89f315392de6056a2181
> Gitweb:     http://git.kernel.org/tip/d1cbfd771ce8297fa11e89f315392de6056a2181
> Author:     Nicolas Pitre <nicolas.pitre@linaro.org>
> AuthorDate: Fri, 11 Nov 2016 00:10:07 -0500
> Committer:  Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Wed, 16 Nov 2016 09:26:34 +0100
> 
> ptp_clock: Allow for it to be optional
> 
> In order to break the hard dependency between the PTP clock subsystem and
> ethernet drivers capable of being clock providers, this patch provides
> simple PTP stub functions to allow linkage of those drivers into the
> kernel even when the PTP subsystem is configured out. Drivers must be
> ready to accept NULL from ptp_clock_register() in that case.
> 
> And to make it possible for PTP to be configured out, the select statement
> in those driver's Kconfig menu entries is converted to the new "imply"
> statement. This way the PTP subsystem may have Kconfig dependencies of
> its own, such as POSIX_TIMERS, without having to make those ethernet
> drivers unavailable if POSIX timers are cconfigured out. And when support
> for POSIX timers is selected again then the default config option for PTP
> clock support will automatically be adjusted accordingly.
> 
> The pch_gbe driver is a bit special as it relies on extra code in
> drivers/ptp/ptp_pch.c. Therefore we let the make process descend into
> drivers/ptp/ even if PTP_1588_CLOCK is unselected.
> 
> Signed-off-by: Nicolas Pitre <nico@linaro.org>
> Acked-by: Richard Cochran <richardcochran@gmail.com>
> Acked-by: Edward Cree <ecree@solarflare.com>
> Acked-by: Thomas Gleixner <tglx@linutronix.de>
> Acked-by: John Stultz <john.stultz@linaro.org>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> Cc: Paul Bolle <pebolle@tiscali.nl>
> Cc: linux-kbuild@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: Michal Marek <mmarek@suse.com>
> Link: http://lkml.kernel.org/r/1478841010-28605-4-git-send-email-nicolas.pitre@linaro.org
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Just for reference to anyone looking for the failure:

drivers/net/ethernet/amd/Kconfig:183: syntax error
drivers/net/ethernet/amd/Kconfig:182: unknown option "imply"
drivers/net/ethernet/adi/Kconfig:62: syntax error
drivers/net/ethernet/adi/Kconfig:61: unknown option "imply"
drivers/net/ethernet/broadcom/Kconfig:114: syntax error
drivers/net/ethernet/broadcom/Kconfig:113: unknown option "imply"
drivers/net/ethernet/broadcom/Kconfig:124: syntax error
drivers/net/ethernet/broadcom/Kconfig:123: unknown option "imply"
drivers/net/ethernet/cavium/Kconfig:57: syntax error
drivers/net/ethernet/cavium/Kconfig:56: unknown option "imply"
drivers/net/ethernet/freescale/Kconfig:29: syntax error
drivers/net/ethernet/freescale/Kconfig:28: unknown option "imply"
drivers/net/ethernet/intel/Kconfig:62: syntax error
drivers/net/ethernet/intel/Kconfig:61: unknown option "imply"
drivers/net/ethernet/intel/Kconfig:87: syntax error
drivers/net/ethernet/intel/Kconfig:86: unknown option "imply"
drivers/net/ethernet/intel/Kconfig:160: syntax error
drivers/net/ethernet/intel/Kconfig:159: unknown option "imply"
drivers/net/ethernet/intel/Kconfig:217: syntax error
drivers/net/ethernet/intel/Kconfig:216: unknown option "imply"
drivers/net/ethernet/intel/Kconfig:268: syntax error
drivers/net/ethernet/intel/Kconfig:267: unknown option "imply"
drivers/net/ethernet/mellanox/mlx4/Kconfig:11: syntax error
drivers/net/ethernet/mellanox/mlx4/Kconfig:10: unknown option "imply"
drivers/net/ethernet/mellanox/mlx5/core/Kconfig:18: syntax error
drivers/net/ethernet/mellanox/mlx5/core/Kconfig:17: unknown option "imply"
drivers/net/ethernet/renesas/Kconfig:41: syntax error
drivers/net/ethernet/renesas/Kconfig:40: unknown option "imply"
drivers/net/ethernet/samsung/Kconfig:25: syntax error
drivers/net/ethernet/samsung/Kconfig:24: unknown option "imply"
drivers/net/ethernet/sfc/Kconfig:9: syntax error
drivers/net/ethernet/sfc/Kconfig:8: unknown option "imply"
drivers/net/ethernet/stmicro/stmmac/Kconfig:8: syntax error
drivers/net/ethernet/stmicro/stmmac/Kconfig:7: unknown option "imply"
drivers/net/ethernet/ti/Kconfig:80: syntax error
drivers/net/ethernet/ti/Kconfig:79: unknown option "imply"
drivers/net/ethernet/tile/Kconfig:13: syntax error
drivers/net/ethernet/tile/Kconfig:12: unknown option "imply"
drivers/ptp/Kconfig:80: syntax error
drivers/ptp/Kconfig:79: unknown option "imply"

It was introduced in linux-next today, but it only happens if you
don't do a 'make clean' or 'make mrproper'. Apparently patch 1
of the series changes kconfig but that change does not trigger
a rebuild of the kconfig binary for me. After removing kconfig
from the object directory, it works again.

I also ran into a problem with CONFIG_TIMERFD enabled but
CONFIG_POSIX_TIMERS turned off. This could be related to some
of my own patches though, haven't tried if that happens
with just your patches applied.

	Arnd

  reply	other threads:[~2016-11-17 17:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-11  5:10 [PATCH v4 0/6] make POSIX timers optional with some Kconfig help Nicolas Pitre
2016-11-11  5:10 ` [PATCH v4 1/6] kconfig: introduce the "imply" keyword Nicolas Pitre
2016-11-16  8:30   ` [tip:timers/core] Kconfig: Introduce " tip-bot for Nicolas Pitre
2016-11-11  5:10 ` [PATCH v4 2/6] kconfig: regenerate *.c_shipped files after previous changes Nicolas Pitre
2016-11-16  8:31   ` [tip:timers/core] Kconfig: Regenerate " tip-bot for Nicolas Pitre
2016-11-11  5:10 ` [PATCH v4 3/6] ptp_clock: allow for it to be optional Nicolas Pitre
2016-11-16  8:32   ` [tip:timers/core] ptp_clock: Allow " tip-bot for Nicolas Pitre
2016-11-17 16:44     ` Arnd Bergmann [this message]
2016-11-18  0:48       ` Nicolas Pitre
2016-11-18  9:15         ` Arnd Bergmann
2016-11-11  5:10 ` [PATCH v4 4/6] timer: move sys_alarm from timer.c to itimer.c Nicolas Pitre
2016-11-16  8:32   ` [tip:timers/core] timer: Move " tip-bot for Nicolas Pitre
2016-11-11  5:10 ` [PATCH v4 5/6] posix_cpu_timers_exit: wrong place to collect entropy Nicolas Pitre
2016-11-16  8:33   ` [tip:timers/core] posix_cpu_timers: Move the add_device_randomness() call to a proper place tip-bot for Nicolas Pitre
2016-11-11  5:10 ` [PATCH v4 6/6] posix-timers: make it configurable Nicolas Pitre
2016-11-16  0:48   ` John Stultz
2016-11-16  8:33   ` [tip:timers/core] posix-timers: Make them configurable tip-bot for Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22431516.ipZiDAzsn3@wuerfel \
    --to=arnd@arndb.de \
    --cc=ecree@solarflare.com \
    --cc=hpa@zytor.com \
    --cc=john.stultz@linaro.org \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mmarek@suse.com \
    --cc=nico@linaro.org \
    --cc=nicolas.pitre@linaro.org \
    --cc=pebolle@tiscali.nl \
    --cc=richardcochran@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.