All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xenstore: dont increment bool variable
@ 2017-04-05 13:56 Juergen Gross
  2017-04-05 14:05 ` Ian Jackson
  0 siblings, 1 reply; 2+ messages in thread
From: Juergen Gross @ 2017-04-05 13:56 UTC (permalink / raw)
  To: xen-devel; +Cc: Juergen Gross, wei.liu2, ian.jackson

Instead of incrementing a bool variable just set it to true.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/xenstore/xenstored_domain.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c
index 4edd14eb4f..f41cf46ced 100644
--- a/tools/xenstore/xenstored_domain.c
+++ b/tools/xenstore/xenstored_domain.c
@@ -934,7 +934,8 @@ void wrl_apply_debit_actual(struct domain *domain)
 	      (long)domain->wrl_credit, (long)wrl_reserve);
 
 	if (domain->wrl_credit < 0) {
-		if (!domain->wrl_delay_logged++) {
+		if (!domain->wrl_delay_logged) {
+			domain->wrl_delay_logged = true;
 			WRL_LOG(now, "domain %ld is affected",
 				(long)domain->domid);
 		} else if (!wrl_log_last_warning) {
-- 
2.12.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] xenstore: dont increment bool variable
  2017-04-05 13:56 [PATCH] xenstore: dont increment bool variable Juergen Gross
@ 2017-04-05 14:05 ` Ian Jackson
  0 siblings, 0 replies; 2+ messages in thread
From: Ian Jackson @ 2017-04-05 14:05 UTC (permalink / raw)
  To: Juergen Gross; +Cc: xen-devel, wei.liu2

Juergen Gross writes ("[PATCH] xenstore: dont increment bool variable"):
> Instead of incrementing a bool variable just set it to true.

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

I will commit this to staging.  Also, I will squash it into the XSA206
fixes as I push them to the stable branches.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-05 14:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-05 13:56 [PATCH] xenstore: dont increment bool variable Juergen Gross
2017-04-05 14:05 ` Ian Jackson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.