From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: "Ankit Jindal" <ankit.jindal@linaro.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
"Varka Bhadram" <varkabhadram@gmail.com>,
"Russell King - ARM Linux" <linux@arm.linux.org.uk>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Anup Patel" <anup@brainfault.org>,
"Guenter Roeck" <linux@roeck-us.net>,
patches@apm.com, "Rob Herring" <robh+dt@kernel.org>,
"Hans J. Koch" <hjk@hansjkoch.de>,
"Tushar Jagad" <tushar.jagad@linaro.org>,
"Kumar Gala" <galak@codeaurora.org>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [PATCH v5 5/6] Documentation: dt-bindings: Add binding info for X-Gene QMTM UIO driver
Date: Mon, 17 Nov 2014 12:17:16 +0100 [thread overview]
Message-ID: <2279061.naADrHDgyn@wuerfel> (raw)
In-Reply-To: <1416220572-13381-6-git-send-email-ankit.jindal@linaro.org>
On Monday 17 November 2014 16:06:11 Ankit Jindal wrote:
> +
> + qmtm1_uio: qmtm_uio@1f200000 {
> + compatible = "apm,xgene-qmtm";
> + status = "disabled";
> + reg = <0x0 0x1f200000 0x0 0x10000>,
> + <0x0 0x1b000000 0x0 0x400000>;
> + reg-names = "csr", "fabric";
> + qpool-memory = <&qmtm1_uio_qpool>;
> + clocks = <&qmtm1clk 0>;
> + num-queues = <0x400>;
> + devid = <1>;
> + };
> +
To make my previous review comments clearer:
NAK
Do not create device nodes that are meant for a specific use case in
software and that are not usable for the common case. I don't think
it makes any sense to keep on submitting a UIO driver for this until
we have a proper network driver that uses this so we can make sure we
have a working binding.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: "Ankit Jindal"
<ankit.jindal-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Varka Bhadram"
<varkabhadram-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Russell King - ARM Linux"
<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
"Greg Kroah-Hartman"
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
"Anup Patel" <anup-aa5cPYPs4nSSZfiimGR9Ow@public.gmane.org>,
"Guenter Roeck" <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
patches-qTEPVZfXA3Y@public.gmane.org,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Hans J. Koch" <hjk-vqZO0P4V72/QD6PfKP4TzA@public.gmane.org>,
"Tushar Jagad"
<tushar.jagad-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"Kumar Gala" <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"Andreas Färber" <afaerber-l3A5Bk7waGM@public.gmane.org>
Subject: Re: [PATCH v5 5/6] Documentation: dt-bindings: Add binding info for X-Gene QMTM UIO driver
Date: Mon, 17 Nov 2014 12:17:16 +0100 [thread overview]
Message-ID: <2279061.naADrHDgyn@wuerfel> (raw)
In-Reply-To: <1416220572-13381-6-git-send-email-ankit.jindal-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
On Monday 17 November 2014 16:06:11 Ankit Jindal wrote:
> +
> + qmtm1_uio: qmtm_uio@1f200000 {
> + compatible = "apm,xgene-qmtm";
> + status = "disabled";
> + reg = <0x0 0x1f200000 0x0 0x10000>,
> + <0x0 0x1b000000 0x0 0x400000>;
> + reg-names = "csr", "fabric";
> + qpool-memory = <&qmtm1_uio_qpool>;
> + clocks = <&qmtm1clk 0>;
> + num-queues = <0x400>;
> + devid = <1>;
> + };
> +
To make my previous review comments clearer:
NAK
Do not create device nodes that are meant for a specific use case in
software and that are not usable for the common case. I don't think
it makes any sense to keep on submitting a UIO driver for this until
we have a proper network driver that uses this so we can make sure we
have a working binding.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 5/6] Documentation: dt-bindings: Add binding info for X-Gene QMTM UIO driver
Date: Mon, 17 Nov 2014 12:17:16 +0100 [thread overview]
Message-ID: <2279061.naADrHDgyn@wuerfel> (raw)
In-Reply-To: <1416220572-13381-6-git-send-email-ankit.jindal@linaro.org>
On Monday 17 November 2014 16:06:11 Ankit Jindal wrote:
> +
> + qmtm1_uio: qmtm_uio at 1f200000 {
> + compatible = "apm,xgene-qmtm";
> + status = "disabled";
> + reg = <0x0 0x1f200000 0x0 0x10000>,
> + <0x0 0x1b000000 0x0 0x400000>;
> + reg-names = "csr", "fabric";
> + qpool-memory = <&qmtm1_uio_qpool>;
> + clocks = <&qmtm1clk 0>;
> + num-queues = <0x400>;
> + devid = <1>;
> + };
> +
To make my previous review comments clearer:
NAK
Do not create device nodes that are meant for a specific use case in
software and that are not usable for the common case. I don't think
it makes any sense to keep on submitting a UIO driver for this until
we have a proper network driver that uses this so we can make sure we
have a working binding.
Arnd
next prev parent reply other threads:[~2014-11-17 11:19 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 10:36 [PATCH v5 0/6] UIO driver for APM X-Gene QMTM Ankit Jindal
2014-11-17 10:36 ` Ankit Jindal
2014-11-17 10:36 ` [PATCH v5 1/6] uio: code style cleanup Ankit Jindal
2014-11-17 10:36 ` Ankit Jindal
2014-11-17 10:36 ` [PATCH v5 2/6] uio: Add new UIO_MEM_PHYS_CACHE type for mem regions Ankit Jindal
2014-11-17 10:36 ` Ankit Jindal
2014-11-27 0:01 ` Greg Kroah-Hartman
2014-11-27 0:01 ` Greg Kroah-Hartman
2014-12-08 12:43 ` Ankit Jindal
2014-12-08 12:43 ` Ankit Jindal
2014-12-08 12:43 ` Ankit Jindal
2014-11-17 10:36 ` [PATCH v5 3/6] Documentation: Update documentation for UIO_MEM_PHYS_CACHE Ankit Jindal
2014-11-17 10:36 ` Ankit Jindal
2014-11-17 10:36 ` [PATCH v5 4/6] uio: Add X-Gene QMTM UIO driver Ankit Jindal
2014-11-17 10:36 ` Ankit Jindal
2014-11-17 10:36 ` Ankit Jindal
2014-11-17 10:36 ` [PATCH v5 5/6] Documentation: dt-bindings: Add binding info for " Ankit Jindal
2014-11-17 10:36 ` Ankit Jindal
2014-11-17 10:43 ` Andreas Färber
2014-11-17 10:43 ` Andreas Färber
2014-11-17 10:43 ` Andreas Färber
2014-11-17 11:17 ` Arnd Bergmann [this message]
2014-11-17 11:17 ` Arnd Bergmann
2014-11-17 11:17 ` Arnd Bergmann
2014-11-18 9:29 ` Ankit Jindal
2014-11-18 9:29 ` Ankit Jindal
2014-11-18 9:29 ` Ankit Jindal
2014-11-18 13:10 ` Arnd Bergmann
2014-11-18 13:10 ` Arnd Bergmann
2014-11-18 13:10 ` Arnd Bergmann
2014-12-08 12:42 ` Ankit Jindal
2014-12-08 12:42 ` Ankit Jindal
2014-12-08 17:15 ` Rob Herring
2014-12-08 17:15 ` Rob Herring
2014-12-09 6:33 ` Ankit Jindal
2014-12-09 6:33 ` Ankit Jindal
2014-12-09 6:33 ` Ankit Jindal
2014-11-17 10:36 ` [PATCH v5 6/6] MAINTAINERS: Add entry for APM " Ankit Jindal
2014-11-17 10:36 ` Ankit Jindal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2279061.naADrHDgyn@wuerfel \
--to=arnd@arndb.de \
--cc=afaerber@suse.de \
--cc=ankit.jindal@linaro.org \
--cc=anup@brainfault.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=hjk@hansjkoch.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@roeck-us.net \
--cc=patches@apm.com \
--cc=robh+dt@kernel.org \
--cc=tushar.jagad@linaro.org \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.