* [PATCH] PM / wakeirq: report a wakeup_event on dedicated wekup irq
@ 2017-02-13 20:43 Tony Lindgren
2017-02-15 23:45 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Tony Lindgren @ 2017-02-13 20:43 UTC (permalink / raw)
To: Rafael J . Wysocki, Alan Stern
Cc: Brian Norris, Dmitry Torokhov, Greg Kroah-Hartman,
Grygorii Strashko, Len Brown, Nishanth Menon, Pavel Machek,
Ulf Hansson, linux-pm, linux-kernel, linux-omap, Tero Kristo
From: Grygorii Strashko <grygorii.strashko@ti.com>
There are two reasons for reporting wakeup event when dedicated wakeup
IRQ is triggered:
- wakeup events accounting, so proper statistical data will be
displayed in sysfs and debugfs;
- there are small window when System is entering suspend during which
dedicated wakeup IRQ can be lost:
dpm_suspend_noirq()
|- device_wakeup_arm_wake_irqs()
|- dev_pm_arm_wake_irq(X)
|- IRQ is enabled and marked as wakeup source
[1]...
|- suspend_device_irqs()
|- suspend_device_irq(X)
|- irqd_set(X, IRQD_WAKEUP_ARMED);
|- wakup IRQ armed
The wakeup IRQ can be lost if it's triggered at point [1]
and not armed yet.
Hence, fix above cases by adding simple pm_wakeup_event() call in
handle_threaded_wake_irq().
Fixes: 4990d4fe327b ("PM / Wakeirq: Add automated device wake IRQ
handling")
Cc: Brian Norris <briannorris@chromium.org>
Cc: Tero Kristo <t-kristo@ti.com>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Tested-by: Keerthy <j-keerthy@ti.com>
[tony@atomide.com: added missing return to avoid warnings]
Tested-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
drivers/base/power/wakeirq.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/base/power/wakeirq.c b/drivers/base/power/wakeirq.c
--- a/drivers/base/power/wakeirq.c
+++ b/drivers/base/power/wakeirq.c
@@ -141,6 +141,13 @@ static irqreturn_t handle_threaded_wake_irq(int irq, void *_wirq)
struct wake_irq *wirq = _wirq;
int res;
+ /* Maybe abort suspend? */
+ if (irqd_is_wakeup_set(irq_get_irq_data(irq))) {
+ pm_wakeup_event(wirq->dev, 0);
+
+ return IRQ_HANDLED;
+ }
+
/* We don't want RPM_ASYNC or RPM_NOWAIT here */
res = pm_runtime_resume(wirq->dev);
if (res < 0)
--
2.11.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] PM / wakeirq: report a wakeup_event on dedicated wekup irq
2017-02-13 20:43 [PATCH] PM / wakeirq: report a wakeup_event on dedicated wekup irq Tony Lindgren
@ 2017-02-15 23:45 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2017-02-15 23:45 UTC (permalink / raw)
To: Tony Lindgren
Cc: Rafael J . Wysocki, Alan Stern, Brian Norris, Dmitry Torokhov,
Greg Kroah-Hartman, Grygorii Strashko, Len Brown, Nishanth Menon,
Pavel Machek, Ulf Hansson, linux-pm, linux-kernel, linux-omap,
Tero Kristo
On Monday, February 13, 2017 12:43:22 PM Tony Lindgren wrote:
> From: Grygorii Strashko <grygorii.strashko@ti.com>
>
> There are two reasons for reporting wakeup event when dedicated wakeup
> IRQ is triggered:
>
> - wakeup events accounting, so proper statistical data will be
> displayed in sysfs and debugfs;
>
> - there are small window when System is entering suspend during which
> dedicated wakeup IRQ can be lost:
>
> dpm_suspend_noirq()
> |- device_wakeup_arm_wake_irqs()
> |- dev_pm_arm_wake_irq(X)
> |- IRQ is enabled and marked as wakeup source
> [1]...
> |- suspend_device_irqs()
> |- suspend_device_irq(X)
> |- irqd_set(X, IRQD_WAKEUP_ARMED);
> |- wakup IRQ armed
>
> The wakeup IRQ can be lost if it's triggered at point [1]
> and not armed yet.
>
> Hence, fix above cases by adding simple pm_wakeup_event() call in
> handle_threaded_wake_irq().
>
> Fixes: 4990d4fe327b ("PM / Wakeirq: Add automated device wake IRQ
> handling")
> Cc: Brian Norris <briannorris@chromium.org>
> Cc: Tero Kristo <t-kristo@ti.com>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> Tested-by: Keerthy <j-keerthy@ti.com>
> [tony@atomide.com: added missing return to avoid warnings]
> Tested-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Applied (along with the other two wakeirq fixes).
Thanks,
Rafael
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-15 23:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-13 20:43 [PATCH] PM / wakeirq: report a wakeup_event on dedicated wekup irq Tony Lindgren
2017-02-15 23:45 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.