Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches

Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches

[Programmingkid]

> On Dec 23, 2018, at 3:52 PM, qemu-devel-request@nongnu.org wrote:
> 
> Message: 4
> Date: Sun, 23 Dec 2018 21:51:36 +0100
> From: "=?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?="
> 	<dirty.ice.hu@gmail.com>
> To: qemu-devel@nongnu.org
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Subject: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches
> Message-ID: <cover.1545598229.git.DirtY.iCE.hu@gmail.com>
> Content-Type: text/plain; charset=UTF-8
> 
> Hi,
> 
> I've updated my audio patchset to the current git master. Other than that not
> much happened since my last update [1], fixed a few small problems that I
> noticed while rebasing my patches.
> 
> Please review.

<snip>

Hi I would like to run your patches. Do you have a repository that I may clone? 

Also have you been able to test these patches using a Mac OS X guest yet? 

Thank you.

Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches

[Kővágó Zoltán]

Hi,

I've pushed it to my github (modulo some random fixes not yet on the
mailing list):
https://github.com/DirtYiCE/qemu/tree/audio-51-2018

I don't have a mac so I have no idea whether it works or not.

Regards,
Zoltan

On 2018-12-26 12:24, Programmingkid wrote:
> 
>> On Dec 23, 2018, at 3:52 PM, qemu-devel-request@nongnu.org wrote:
>>
>> Message: 4
>> Date: Sun, 23 Dec 2018 21:51:36 +0100
>> From: "=?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?="
>> 	<dirty.ice.hu@gmail.com>
>> To: qemu-devel@nongnu.org
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Subject: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches
>> Message-ID: <cover.1545598229.git.DirtY.iCE.hu@gmail.com>
>> Content-Type: text/plain; charset=UTF-8
>>
>> Hi,
>>
>> I've updated my audio patchset to the current git master. Other than that not
>> much happened since my last update [1], fixed a few small problems that I
>> noticed while rebasing my patches.
>>
>> Please review.
> 
> <snip>
> 
> Hi I would like to run your patches. Do you have a repository that I may clone? 
> 
> Also have you been able to test these patches using a Mac OS X guest yet? 
> 
> Thank you.
> 

Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches

[Philippe Mathieu-Daudé]

Hi John,

On 12/26/18 12:24 PM, Programmingkid wrote:
>> On Dec 23, 2018, at 3:52 PM, qemu-devel-request@nongnu.org wrote:
>>
>> Message: 4
>> Date: Sun, 23 Dec 2018 21:51:36 +0100
>> From: "=?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?="
>> 	<dirty.ice.hu@gmail.com>
>> To: qemu-devel@nongnu.org
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Subject: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches
>> Message-ID: <cover.1545598229.git.DirtY.iCE.hu@gmail.com>

                ^ [*]

>> Content-Type: text/plain; charset=UTF-8
>>
> <snip>
> 
> Hi I would like to run your patches. Do you have a repository that I may clone? 

Usually you can take series posted to the list via patchew, using the
following pattern:

https://github.com/patchew-project/qemu/releases/tag/patchew/$MESSAGE_ID

using the cover mail message ID without the angle brackets < >.

Here this would be:

https://github.com/patchew-project/qemu/releases/tag/patchew/cover.1545598229.git.DirtY.iCE.hu@gmail.com

but sadly patchew failed at applying this series :/

Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches

[Programmingkid]

> On Dec 27, 2018, at 8:33 AM, Kővágó Zoltán <dirty.ice.hu@gmail.com> wrote:
> 
> Hi,
> 
> I've pushed it to my github (modulo some random fixes not yet on the
> mailing list):
> https://github.com/DirtYiCE/qemu/tree/audio-51-2018
> 
> I don't have a mac so I have no idea whether it works or not.
> 
> Regards,
> Zoltan
> 
> On 2018-12-26 12:24, Programmingkid wrote:
>> 
>>> On Dec 23, 2018, at 3:52 PM, qemu-devel-request@nongnu.org wrote:
>>> 
>>> Message: 4
>>> Date: Sun, 23 Dec 2018 21:51:36 +0100
>>> From: "=?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?="
>>> 	<dirty.ice.hu@gmail.com>
>>> To: qemu-devel@nongnu.org
>>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>>> Subject: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches
>>> Message-ID: <cover.1545598229.git.DirtY.iCE.hu@gmail.com>
>>> Content-Type: text/plain; charset=UTF-8
>>> 
>>> Hi,
>>> 
>>> I've updated my audio patchset to the current git master. Other than that not
>>> much happened since my last update [1], fixed a few small problems that I
>>> noticed while rebasing my patches.
>>> 
>>> Please review.
>> 
>> <snip>
>> 
>> Hi I would like to run your patches. Do you have a repository that I may clone? 
>> 
>> Also have you been able to test these patches using a Mac OS X guest yet? 
>> 
>> Thank you.
>> 
> 

Hi, thanks for the link. This is what I did:

 - git clone https://github.com/DirtYiCE/qemu.git
 - git checkout audio-51-2018
 - ./configure --target-list=ppc-softmmu
 - make -j 4

The result was unfortunately some errors:

  CC      audio/coreaudio.o
audio/coreaudio.c:413:49: error: unknown type name 'HWVocieOut'; did you mean
      'HWVoiceOut'?
COREAUDIO_WRAPPER_FUNC(get_buffer_out, void *, (HWVocieOut *hw, size_t *size),
                                                ^~~~~~~~~~
                                                HWVoiceOut


audio/coreaudio.c:578:29: error: passing 'struct audio_pcm_info' to parameter of
      incompatible type 'struct audio_pcm_info *'; take the address with &
        coreaudio_get_flags(hw->info, as);
                            ^~~~~~~~
                            &

Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches

[Kővágó Zoltán]

On 2018-12-28 01:46, Programmingkid wrote:
> 
>> On Dec 27, 2018, at 8:33 AM, Kővágó Zoltán <dirty.ice.hu@gmail.com> wrote:
>>
>> Hi,
>>
>> I've pushed it to my github (modulo some random fixes not yet on the
>> mailing list):
>> https://github.com/DirtYiCE/qemu/tree/audio-51-2018
>>
>> I don't have a mac so I have no idea whether it works or not.
>>
>> Regards,
>> Zoltan
>>
>> On 2018-12-26 12:24, Programmingkid wrote:
>>>
>>>> On Dec 23, 2018, at 3:52 PM, qemu-devel-request@nongnu.org wrote:
>>>>
>>>> Message: 4
>>>> Date: Sun, 23 Dec 2018 21:51:36 +0100
>>>> From: "=?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?="
>>>> 	<dirty.ice.hu@gmail.com>
>>>> To: qemu-devel@nongnu.org
>>>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>>>> Subject: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches
>>>> Message-ID: <cover.1545598229.git.DirtY.iCE.hu@gmail.com>
>>>> Content-Type: text/plain; charset=UTF-8
>>>>
>>>> Hi,
>>>>
>>>> I've updated my audio patchset to the current git master. Other than that not
>>>> much happened since my last update [1], fixed a few small problems that I
>>>> noticed while rebasing my patches.
>>>>
>>>> Please review.
>>>
>>> <snip>
>>>
>>> Hi I would like to run your patches. Do you have a repository that I may clone? 
>>>
>>> Also have you been able to test these patches using a Mac OS X guest yet? 
>>>
>>> Thank you.
>>>
>>
> 
> Hi, thanks for the link. This is what I did:
> 
>  - git clone https://github.com/DirtYiCE/qemu.git
>  - git checkout audio-51-2018
>  - ./configure --target-list=ppc-softmmu
>  - make -j 4
> 
> The result was unfortunately some errors:
> 
>   CC      audio/coreaudio.o
> audio/coreaudio.c:413:49: error: unknown type name 'HWVocieOut'; did you mean
>       'HWVoiceOut'?
> COREAUDIO_WRAPPER_FUNC(get_buffer_out, void *, (HWVocieOut *hw, size_t *size),
>                                                 ^~~~~~~~~~
>                                                 HWVoiceOut
> 
> 
> audio/coreaudio.c:578:29: error: passing 'struct audio_pcm_info' to parameter of
>       incompatible type 'struct audio_pcm_info *'; take the address with &
>         coreaudio_get_flags(hw->info, as);
>                             ^~~~~~~~
>                             &
> 
> 

Hi,

I pushed an updated version, it should fix the compile errors (hopefully).

Regards,
Zoltan

Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches

[Programmingkid]

> On Dec 28, 2018, at 3:05 PM, Kővágó Zoltán <dirty.ice.hu@gmail.com> wrote:
> 
> On 2018-12-28 01:46, Programmingkid wrote:
>> 
>>> On Dec 27, 2018, at 8:33 AM, Kővágó Zoltán <dirty.ice.hu@gmail.com> wrote:
>>> 
>>> Hi,
>>> 
>>> I've pushed it to my github (modulo some random fixes not yet on the
>>> mailing list):
>>> https://github.com/DirtYiCE/qemu/tree/audio-51-2018
>>> 
>>> I don't have a mac so I have no idea whether it works or not.
>>> 
>>> Regards,
>>> Zoltan
>>> 
>>> On 2018-12-26 12:24, Programmingkid wrote:
>>>> 
>>>>> On Dec 23, 2018, at 3:52 PM, qemu-devel-request@nongnu.org wrote:
>>>>> 
>>>>> Message: 4
>>>>> Date: Sun, 23 Dec 2018 21:51:36 +0100
>>>>> From: "=?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?="
>>>>> 	<dirty.ice.hu@gmail.com>
>>>>> To: qemu-devel@nongnu.org
>>>>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>>>>> Subject: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches
>>>>> Message-ID: <cover.1545598229.git.DirtY.iCE.hu@gmail.com>
>>>>> Content-Type: text/plain; charset=UTF-8
>>>>> 
>>>>> Hi,
>>>>> 
>>>>> I've updated my audio patchset to the current git master. Other than that not
>>>>> much happened since my last update [1], fixed a few small problems that I
>>>>> noticed while rebasing my patches.
>>>>> 
>>>>> Please review.
>>>> 
>>>> <snip>
>>>> 
>>>> Hi I would like to run your patches. Do you have a repository that I may clone? 
>>>> 
>>>> Also have you been able to test these patches using a Mac OS X guest yet? 
>>>> 
>>>> Thank you.
>>>> 
>>> 
>> 
>> Hi, thanks for the link. This is what I did:
>> 
>> - git clone https://github.com/DirtYiCE/qemu.git
>> - git checkout audio-51-2018
>> - ./configure --target-list=ppc-softmmu
>> - make -j 4
>> 
>> The result was unfortunately some errors:
>> 
>>  CC      audio/coreaudio.o
>> audio/coreaudio.c:413:49: error: unknown type name 'HWVocieOut'; did you mean
>>      'HWVoiceOut'?
>> COREAUDIO_WRAPPER_FUNC(get_buffer_out, void *, (HWVocieOut *hw, size_t *size),
>>                                                ^~~~~~~~~~
>>                                                HWVoiceOut
>> 
>> 
>> audio/coreaudio.c:578:29: error: passing 'struct audio_pcm_info' to parameter of
>>      incompatible type 'struct audio_pcm_info *'; take the address with &
>>        coreaudio_get_flags(hw->info, as);
>>                            ^~~~~~~~
>>                            &
>> 
>> 
> 
> Hi,
> 
> I pushed an updated version, it should fix the compile errors (hopefully).
> 
> Regards,
> Zoltan

Thank you for the update. I tested this series using a Mac OS 10.4 and Windows 2000 guest. Both were using a USB sound card. The sound that comes out of my speakers is demonic! It is the loudest, scariest sound I have ever heard. I'm sorry but this patch series ruins the USB sound card.

I am happy to test out any future updates that you make this patch series. 

Thank you.

Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches

[Zoltán Kővágó]

On 2018-12-29 01:12, Programmingkid wrote:
> 
>> On Dec 28, 2018, at 3:05 PM, Kővágó Zoltán <dirty.ice.hu@gmail.com> wrote:
>>
>> On 2018-12-28 01:46, Programmingkid wrote:
>>>
>>>> On Dec 27, 2018, at 8:33 AM, Kővágó Zoltán <dirty.ice.hu@gmail.com> wrote:
>>>>
>>>> Hi,
>>>>
>>>> I've pushed it to my github (modulo some random fixes not yet on the
>>>> mailing list):
>>>> https://github.com/DirtYiCE/qemu/tree/audio-51-2018
>>>>
>>>> I don't have a mac so I have no idea whether it works or not.
>>>>
>>>> Regards,
>>>> Zoltan
>>>>
>>>> On 2018-12-26 12:24, Programmingkid wrote:
>>>>>
>>>>>> On Dec 23, 2018, at 3:52 PM, qemu-devel-request@nongnu.org wrote:
>>>>>>
>>>>>> Message: 4
>>>>>> Date: Sun, 23 Dec 2018 21:51:36 +0100
>>>>>> From: "=?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?="
>>>>>> 	<dirty.ice.hu@gmail.com>
>>>>>> To: qemu-devel@nongnu.org
>>>>>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>>>>>> Subject: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches
>>>>>> Message-ID: <cover.1545598229.git.DirtY.iCE.hu@gmail.com>
>>>>>> Content-Type: text/plain; charset=UTF-8
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I've updated my audio patchset to the current git master. Other than that not
>>>>>> much happened since my last update [1], fixed a few small problems that I
>>>>>> noticed while rebasing my patches.
>>>>>>
>>>>>> Please review.
>>>>>
>>>>> <snip>
>>>>>
>>>>> Hi I would like to run your patches. Do you have a repository that I may clone? 
>>>>>
>>>>> Also have you been able to test these patches using a Mac OS X guest yet? 
>>>>>
>>>>> Thank you.
>>>>>
>>>>
>>>
>>> Hi, thanks for the link. This is what I did:
>>>
>>> - git clone https://github.com/DirtYiCE/qemu.git
>>> - git checkout audio-51-2018
>>> - ./configure --target-list=ppc-softmmu
>>> - make -j 4
>>>
>>> The result was unfortunately some errors:
>>>
>>>  CC      audio/coreaudio.o
>>> audio/coreaudio.c:413:49: error: unknown type name 'HWVocieOut'; did you mean
>>>      'HWVoiceOut'?
>>> COREAUDIO_WRAPPER_FUNC(get_buffer_out, void *, (HWVocieOut *hw, size_t *size),
>>>                                                ^~~~~~~~~~
>>>                                                HWVoiceOut
>>>
>>>
>>> audio/coreaudio.c:578:29: error: passing 'struct audio_pcm_info' to parameter of
>>>      incompatible type 'struct audio_pcm_info *'; take the address with &
>>>        coreaudio_get_flags(hw->info, as);
>>>                            ^~~~~~~~
>>>                            &
>>>
>>>
>>
>> Hi,
>>
>> I pushed an updated version, it should fix the compile errors (hopefully).
>>
>> Regards,
>> Zoltan
> 
> Thank you for the update. I tested this series using a Mac OS 10.4 and Windows 2000 guest. Both were using a USB sound card. The sound that comes out of my speakers is demonic! It is the loudest, scariest sound I have ever heard. I'm sorry but this patch series ruins the USB sound card.
> 
> I am happy to test out any future updates that you make this patch series. 
> 
> Thank you.
> 

I'm sorry to hear that. Could you please test it with some other card,
like the hda? Even though usb works fine for me on Linux with alsa so
the problem is probably with the coreaudio backend.

Regards,
Zoltan

Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches

[Programmingkid]

> On Dec 28, 2018, at 7:19 PM, Zoltán Kővágó <dirty.ice.hu@gmail.com> wrote:
> 
> On 2018-12-29 01:12, Programmingkid wrote:
>> 
>>> On Dec 28, 2018, at 3:05 PM, Kővágó Zoltán <dirty.ice.hu@gmail.com> wrote:
>>> 
>>> On 2018-12-28 01:46, Programmingkid wrote:
>>>> 
>>>>> On Dec 27, 2018, at 8:33 AM, Kővágó Zoltán <dirty.ice.hu@gmail.com> wrote:
>>>>> 
>>>>> Hi,
>>>>> 
>>>>> I've pushed it to my github (modulo some random fixes not yet on the
>>>>> mailing list):
>>>>> https://github.com/DirtYiCE/qemu/tree/audio-51-2018
>>>>> 
>>>>> I don't have a mac so I have no idea whether it works or not.
>>>>> 
>>>>> Regards,
>>>>> Zoltan
>>>>> 
>>>>> On 2018-12-26 12:24, Programmingkid wrote:
>>>>>> 
>>>>>>> On Dec 23, 2018, at 3:52 PM, qemu-devel-request@nongnu.org wrote:
>>>>>>> 
>>>>>>> Message: 4
>>>>>>> Date: Sun, 23 Dec 2018 21:51:36 +0100
>>>>>>> From: "=?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?="
>>>>>>> 	<dirty.ice.hu@gmail.com>
>>>>>>> To: qemu-devel@nongnu.org
>>>>>>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>>>>>>> Subject: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches
>>>>>>> Message-ID: <cover.1545598229.git.DirtY.iCE.hu@gmail.com>
>>>>>>> Content-Type: text/plain; charset=UTF-8
>>>>>>> 
>>>>>>> Hi,
>>>>>>> 
>>>>>>> I've updated my audio patchset to the current git master. Other than that not
>>>>>>> much happened since my last update [1], fixed a few small problems that I
>>>>>>> noticed while rebasing my patches.
>>>>>>> 
>>>>>>> Please review.
>>>>>> 
>>>>>> <snip>
>>>>>> 
>>>>>> Hi I would like to run your patches. Do you have a repository that I may clone? 
>>>>>> 
>>>>>> Also have you been able to test these patches using a Mac OS X guest yet? 
>>>>>> 
>>>>>> Thank you.
>>>>>> 
>>>>> 
>>>> 
>>>> Hi, thanks for the link. This is what I did:
>>>> 
>>>> - git clone https://github.com/DirtYiCE/qemu.git
>>>> - git checkout audio-51-2018
>>>> - ./configure --target-list=ppc-softmmu
>>>> - make -j 4
>>>> 
>>>> The result was unfortunately some errors:
>>>> 
>>>> CC      audio/coreaudio.o
>>>> audio/coreaudio.c:413:49: error: unknown type name 'HWVocieOut'; did you mean
>>>>     'HWVoiceOut'?
>>>> COREAUDIO_WRAPPER_FUNC(get_buffer_out, void *, (HWVocieOut *hw, size_t *size),
>>>>                                               ^~~~~~~~~~
>>>>                                               HWVoiceOut
>>>> 
>>>> 
>>>> audio/coreaudio.c:578:29: error: passing 'struct audio_pcm_info' to parameter of
>>>>     incompatible type 'struct audio_pcm_info *'; take the address with &
>>>>       coreaudio_get_flags(hw->info, as);
>>>>                           ^~~~~~~~
>>>>                           &
>>>> 
>>>> 
>>> 
>>> Hi,
>>> 
>>> I pushed an updated version, it should fix the compile errors (hopefully).
>>> 
>>> Regards,
>>> Zoltan
>> 
>> Thank you for the update. I tested this series using a Mac OS 10.4 and Windows 2000 guest. Both were using a USB sound card. The sound that comes out of my speakers is demonic! It is the loudest, scariest sound I have ever heard. I'm sorry but this patch series ruins the USB sound card.
>> 
>> I am happy to test out any future updates that you make this patch series. 
>> 
>> Thank you.
>> 
> 
> I'm sorry to hear that. Could you please test it with some other card,
> like the hda? Even though usb works fine for me on Linux with alsa so
> the problem is probably with the coreaudio backend.
> 
> Regards,
> Zoltan

I tried ac97 with a Windows 2000 guest in qemu-system-i386 - same demonic sound.
With the above configuration but with an es1370 sound card I heard the same sound. I kept seeing "es1370: warning: non looping mode" being printed in the terminal. This problem might need its own patch.
Using the sb16 sound card I heard the same unsettling sound.

I could not test the HDA driver due to problems with my Windows 7 VM.  

Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches

[Kővágó Zoltán]

On 2018-12-29 01:49, Programmingkid wrote:
> 
>> On Dec 28, 2018, at 7:19 PM, Zoltán Kővágó <dirty.ice.hu@gmail.com> wrote:
>>
>> On 2018-12-29 01:12, Programmingkid wrote:
>>>
>>>> On Dec 28, 2018, at 3:05 PM, Kővágó Zoltán <dirty.ice.hu@gmail.com> wrote:
>>>>
>>>> On 2018-12-28 01:46, Programmingkid wrote:
>>>>>
>>>>>> On Dec 27, 2018, at 8:33 AM, Kővágó Zoltán <dirty.ice.hu@gmail.com> wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I've pushed it to my github (modulo some random fixes not yet on the
>>>>>> mailing list):
>>>>>> https://github.com/DirtYiCE/qemu/tree/audio-51-2018
>>>>>>
>>>>>> I don't have a mac so I have no idea whether it works or not.
>>>>>>
>>>>>> Regards,
>>>>>> Zoltan
>>>>>>
>>>>>> On 2018-12-26 12:24, Programmingkid wrote:
>>>>>>>
>>>>>>>> On Dec 23, 2018, at 3:52 PM, qemu-devel-request@nongnu.org wrote:
>>>>>>>>
>>>>>>>> Message: 4
>>>>>>>> Date: Sun, 23 Dec 2018 21:51:36 +0100
>>>>>>>> From: "=?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?="
>>>>>>>> 	<dirty.ice.hu@gmail.com>
>>>>>>>> To: qemu-devel@nongnu.org
>>>>>>>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>>>>>>>> Subject: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches
>>>>>>>> Message-ID: <cover.1545598229.git.DirtY.iCE.hu@gmail.com>
>>>>>>>> Content-Type: text/plain; charset=UTF-8
>>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> I've updated my audio patchset to the current git master. Other than that not
>>>>>>>> much happened since my last update [1], fixed a few small problems that I
>>>>>>>> noticed while rebasing my patches.
>>>>>>>>
>>>>>>>> Please review.
>>>>>>>
>>>>>>> <snip>
>>>>>>>
>>>>>>> Hi I would like to run your patches. Do you have a repository that I may clone? 
>>>>>>>
>>>>>>> Also have you been able to test these patches using a Mac OS X guest yet? 
>>>>>>>
>>>>>>> Thank you.
>>>>>>>
>>>>>>
>>>>>
>>>>> Hi, thanks for the link. This is what I did:
>>>>>
>>>>> - git clone https://github.com/DirtYiCE/qemu.git
>>>>> - git checkout audio-51-2018
>>>>> - ./configure --target-list=ppc-softmmu
>>>>> - make -j 4
>>>>>
>>>>> The result was unfortunately some errors:
>>>>>
>>>>> CC      audio/coreaudio.o
>>>>> audio/coreaudio.c:413:49: error: unknown type name 'HWVocieOut'; did you mean
>>>>>     'HWVoiceOut'?
>>>>> COREAUDIO_WRAPPER_FUNC(get_buffer_out, void *, (HWVocieOut *hw, size_t *size),
>>>>>                                               ^~~~~~~~~~
>>>>>                                               HWVoiceOut
>>>>>
>>>>>
>>>>> audio/coreaudio.c:578:29: error: passing 'struct audio_pcm_info' to parameter of
>>>>>     incompatible type 'struct audio_pcm_info *'; take the address with &
>>>>>       coreaudio_get_flags(hw->info, as);
>>>>>                           ^~~~~~~~
>>>>>                           &
>>>>>
>>>>>
>>>>
>>>> Hi,
>>>>
>>>> I pushed an updated version, it should fix the compile errors (hopefully).
>>>>
>>>> Regards,
>>>> Zoltan
>>>
>>> Thank you for the update. I tested this series using a Mac OS 10.4 and Windows 2000 guest. Both were using a USB sound card. The sound that comes out of my speakers is demonic! It is the loudest, scariest sound I have ever heard. I'm sorry but this patch series ruins the USB sound card.
>>>
>>> I am happy to test out any future updates that you make this patch series. 
>>>
>>> Thank you.
>>>
>>
>> I'm sorry to hear that. Could you please test it with some other card,
>> like the hda? Even though usb works fine for me on Linux with alsa so
>> the problem is probably with the coreaudio backend.
>>
>> Regards,
>> Zoltan
> 
> I tried ac97 with a Windows 2000 guest in qemu-system-i386 - same demonic sound.
> With the above configuration but with an es1370 sound card I heard the same sound. I kept seeing "es1370: warning: non looping mode" being printed in the terminal. This problem might need its own patch.
> Using the sb16 sound card I heard the same unsettling sound.
> 
> I could not test the HDA driver due to problems with my Windows 7 VM.  
> 


I have a feeling that bf870a0cf5e2c2dd7438e65473b4fca1fb0ca5d1
(coreaudio: port to the new audio backend api) is the commit which
breaks it, but without a mac I don't know how could I debug it. The way
it initializes coreaudio changed a bit, that can cause problems.
Could you please test whether this commit is the culprit or not?

Regards,
Zoltan

Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches

[Zoltán Kővágó]

On 2019-01-01 17:17, Programmingkid wrote:
> 
>> On Jan 1, 2019, at 7:27 AM, Zoltán Kővágó <dirty.ice.hu@gmail.com> wrote:
>>
>> On 2019-01-01 05:24, Programmingkid wrote:
>>>> On 2018-12-29 01:49, Programmingkid wrote:
>> [snip]
>>>>>
>>>>> I tried ac97 with a Windows 2000 guest in qemu-system-i386 - same demonic sound.
>>>>> With the above configuration but with an es1370 sound card I heard the same sound. I kept seeing "es1370: warning: non looping mode" being printed in the terminal. This problem might need its own patch.
>>>>> Using the sb16 sound card I heard the same unsettling sound.
>>>>>
>>>>> I could not test the HDA driver due to problems with my Windows 7 VM.  
>>>>>
>>>>
>>>>
>>>> I have a feeling that bf870a0cf5e2c2dd7438e65473b4fca1fb0ca5d1
>>>> (coreaudio: port to the new audio backend api) is the commit which
>>>> breaks it, but without a mac I don't know how could I debug it. The way
>>>> it initializes coreaudio changed a bit, that can cause problems.
>>>> Could you please test whether this commit is the culprit or not?
>>>>
>>>> Regards,
>>>> Zoltan
>>>
>>>
>>> Hi how do you want me to test your theory? Revert the patch? If I did I don't think QEMU would still compile. 
>>
>> No, don't revert it, that would generate too many conflicts. Just
>>
>> git checkout bf870a0c
> 
> This causes the very disturbing sound to play.
> 
>>
>> and
>>
>> git checkout bf870a0c~
> 
> This also causes the very disturbing sound to play.
> 
>>
>> should give you two versions that you can compare.
>>
>> Regards,
>> Zoltan
> 
> Thank you.
> 

That's worrying, since before that commit I didn't really do any big
refactoring on coreaudio itself, and without a Mac I have no idea how
could I debug it.
Could you at least try a git bisect and figure out which commit broke it?

Thanks,
Zoltan

Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches

[Programmingkid]

> On Jan 1, 2019, at 7:27 AM, Zoltán Kővágó <dirty.ice.hu@gmail.com> wrote:
> 
> On 2019-01-01 05:24, Programmingkid wrote:
>>> On 2018-12-29 01:49, Programmingkid wrote:
> [snip]
>>>> 
>>>> I tried ac97 with a Windows 2000 guest in qemu-system-i386 - same demonic sound.
>>>> With the above configuration but with an es1370 sound card I heard the same sound. I kept seeing "es1370: warning: non looping mode" being printed in the terminal. This problem might need its own patch.
>>>> Using the sb16 sound card I heard the same unsettling sound.
>>>> 
>>>> I could not test the HDA driver due to problems with my Windows 7 VM.  
>>>> 
>>> 
>>> 
>>> I have a feeling that bf870a0cf5e2c2dd7438e65473b4fca1fb0ca5d1
>>> (coreaudio: port to the new audio backend api) is the commit which
>>> breaks it, but without a mac I don't know how could I debug it. The way
>>> it initializes coreaudio changed a bit, that can cause problems.
>>> Could you please test whether this commit is the culprit or not?
>>> 
>>> Regards,
>>> Zoltan
>> 
>> 
>> Hi how do you want me to test your theory? Revert the patch? If I did I don't think QEMU would still compile. 
> 
> No, don't revert it, that would generate too many conflicts. Just
> 
> git checkout bf870a0c

This causes the very disturbing sound to play.

> 
> and
> 
> git checkout bf870a0c~

This also causes the very disturbing sound to play.

> 
> should give you two versions that you can compare.
> 
> Regards,
> Zoltan

Thank you.

Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches

[Zoltán Kővágó]

On 2019-01-01 05:24, Programmingkid wrote:
>> On 2018-12-29 01:49, Programmingkid wrote:
[snip]
>>>
>>> I tried ac97 with a Windows 2000 guest in qemu-system-i386 - same demonic sound.
>>> With the above configuration but with an es1370 sound card I heard the same sound. I kept seeing "es1370: warning: non looping mode" being printed in the terminal. This problem might need its own patch.
>>> Using the sb16 sound card I heard the same unsettling sound.
>>>
>>> I could not test the HDA driver due to problems with my Windows 7 VM.  
>>>
>>
>>
>> I have a feeling that bf870a0cf5e2c2dd7438e65473b4fca1fb0ca5d1
>> (coreaudio: port to the new audio backend api) is the commit which
>> breaks it, but without a mac I don't know how could I debug it. The way
>> it initializes coreaudio changed a bit, that can cause problems.
>> Could you please test whether this commit is the culprit or not?
>>
>> Regards,
>> Zoltan
> 
> 
> Hi how do you want me to test your theory? Revert the patch? If I did I don't think QEMU would still compile. 

No, don't revert it, that would generate too many conflicts. Just

git checkout bf870a0c

and

git checkout bf870a0c~

should give you two versions that you can compare.

Regards,
Zoltan

Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches

[Programmingkid]

> On Dec 31, 2018, at 12:00 PM, qemu-devel-request@nongnu.org wrote:
> 
> Message: 2
> Date: Mon, 31 Dec 2018 16:50:47 +0100
> From: "=?UTF-8?B?S8WRdsOhZ8OzIFpvbHTDoW4=?=" <dirty.ice.hu@gmail.com>
> To: Programmingkid <programmingkidx@gmail.com>
> Cc: QEMU Developers <qemu-devel@nongnu.org>, Gerd Hoffmann
> 	<kraxel@redhat.com>
> Subject: Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches
> Message-ID: <d6966a53-3e5e-83c4-7900-38784969744a@gmail.com>
> Content-Type: text/plain; charset=utf-8
> 
> On 2018-12-29 01:49, Programmingkid wrote:
>> 
>>> On Dec 28, 2018, at 7:19 PM, Zolt?n K?v?g? <dirty.ice.hu@gmail.com> wrote:
>>> 
>>> On 2018-12-29 01:12, Programmingkid wrote:
>>>> 
>>>>> On Dec 28, 2018, at 3:05 PM, K?v?g? Zolt?n <dirty.ice.hu@gmail.com> wrote:
>>>>> 
>>>>> On 2018-12-28 01:46, Programmingkid wrote:
>>>>>> 
>>>>>>> On Dec 27, 2018, at 8:33 AM, K?v?g? Zolt?n <dirty.ice.hu@gmail.com> wrote:
>>>>>>> 
>>>>>>> Hi,
>>>>>>> 
>>>>>>> I've pushed it to my github (modulo some random fixes not yet on the
>>>>>>> mailing list):
>>>>>>> https://github.com/DirtYiCE/qemu/tree/audio-51-2018
>>>>>>> 
>>>>>>> I don't have a mac so I have no idea whether it works or not.
>>>>>>> 
>>>>>>> Regards,
>>>>>>> Zoltan
>>>>>>> 
>>>>>>> On 2018-12-26 12:24, Programmingkid wrote:
>>>>>>>> 
>>>>>>>>> On Dec 23, 2018, at 3:52 PM, qemu-devel-request@nongnu.org wrote:
>>>>>>>>> 
>>>>>>>>> Message: 4
>>>>>>>>> Date: Sun, 23 Dec 2018 21:51:36 +0100
>>>>>>>>> From: "=?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?="
>>>>>>>>> 	<dirty.ice.hu@gmail.com>
>>>>>>>>> To: qemu-devel@nongnu.org
>>>>>>>>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>>>>>>>>> Subject: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches
>>>>>>>>> Message-ID: <cover.1545598229.git.DirtY.iCE.hu@gmail.com>
>>>>>>>>> Content-Type: text/plain; charset=UTF-8
>>>>>>>>> 
>>>>>>>>> Hi,
>>>>>>>>> 
>>>>>>>>> I've updated my audio patchset to the current git master. Other than that not
>>>>>>>>> much happened since my last update [1], fixed a few small problems that I
>>>>>>>>> noticed while rebasing my patches.
>>>>>>>>> 
>>>>>>>>> Please review.
>>>>>>>> 
>>>>>>>> <snip>
>>>>>>>> 
>>>>>>>> Hi I would like to run your patches. Do you have a repository that I may clone? 
>>>>>>>> 
>>>>>>>> Also have you been able to test these patches using a Mac OS X guest yet? 
>>>>>>>> 
>>>>>>>> Thank you.
>>>>>>>> 
>>>>>>> 
>>>>>> 
>>>>>> Hi, thanks for the link. This is what I did:
>>>>>> 
>>>>>> - git clone https://github.com/DirtYiCE/qemu.git
>>>>>> - git checkout audio-51-2018
>>>>>> - ./configure --target-list=ppc-softmmu
>>>>>> - make -j 4
>>>>>> 
>>>>>> The result was unfortunately some errors:
>>>>>> 
>>>>>> CC      audio/coreaudio.o
>>>>>> audio/coreaudio.c:413:49: error: unknown type name 'HWVocieOut'; did you mean
>>>>>>   'HWVoiceOut'?
>>>>>> COREAUDIO_WRAPPER_FUNC(get_buffer_out, void *, (HWVocieOut *hw, size_t *size),
>>>>>>                                             ^~~~~~~~~~
>>>>>>                                             HWVoiceOut
>>>>>> 
>>>>>> 
>>>>>> audio/coreaudio.c:578:29: error: passing 'struct audio_pcm_info' to parameter of
>>>>>>   incompatible type 'struct audio_pcm_info *'; take the address with &
>>>>>>     coreaudio_get_flags(hw->info, as);
>>>>>>                         ^~~~~~~~
>>>>>>                         &
>>>>>> 
>>>>>> 
>>>>> 
>>>>> Hi,
>>>>> 
>>>>> I pushed an updated version, it should fix the compile errors (hopefully).
>>>>> 
>>>>> Regards,
>>>>> Zoltan
>>>> 
>>>> Thank you for the update. I tested this series using a Mac OS 10.4 and Windows 2000 guest. Both were using a USB sound card. The sound that comes out of my speakers is demonic! It is the loudest, scariest sound I have ever heard. I'm sorry but this patch series ruins the USB sound card.
>>>> 
>>>> I am happy to test out any future updates that you make this patch series. 
>>>> 
>>>> Thank you.
>>>> 
>>> 
>>> I'm sorry to hear that. Could you please test it with some other card,
>>> like the hda? Even though usb works fine for me on Linux with alsa so
>>> the problem is probably with the coreaudio backend.
>>> 
>>> Regards,
>>> Zoltan
>> 
>> I tried ac97 with a Windows 2000 guest in qemu-system-i386 - same demonic sound.
>> With the above configuration but with an es1370 sound card I heard the same sound. I kept seeing "es1370: warning: non looping mode" being printed in the terminal. This problem might need its own patch.
>> Using the sb16 sound card I heard the same unsettling sound.
>> 
>> I could not test the HDA driver due to problems with my Windows 7 VM.  
>> 
> 
> 
> I have a feeling that bf870a0cf5e2c2dd7438e65473b4fca1fb0ca5d1
> (coreaudio: port to the new audio backend api) is the commit which
> breaks it, but without a mac I don't know how could I debug it. The way
> it initializes coreaudio changed a bit, that can cause problems.
> Could you please test whether this commit is the culprit or not?
> 
> Regards,
> Zoltan


Hi how do you want me to test your theory? Revert the patch? If I did I don't think QEMU would still compile. 

Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches

[Philippe Mathieu-Daudé]

Hi Zoltán,

On 12/23/18 9:51 PM, Kővágó, Zoltán wrote:
> I've updated my audio patchset to the current git master. Other than that not
> much happened since my last update [1], fixed a few small problems that I
> noticed while rebasing my patches.

For a such series with refactors and typedefs changes, I recommend you
to use/setup the scripts/git.orderfile script: Headers are showed first,
then the sources, which makes review easier (no need to constantly scroll).
No need to resend, but if you have to respin, this will be appreciated.

Regards,

Phil.

[Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches

[Kővágó, Zoltán]

Hi,

I've updated my audio patchset to the current git master. Other than that not
much happened since my last update [1], fixed a few small problems that I
noticed while rebasing my patches.

Please review.

[1]: https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg02451.html

Kővágó, Zoltán (52):
  qapi: support alternates in OptsVisitor
  qapi: support nested structs in OptsVisitor
  qapi: qapi for audio backends
  audio: use qapi AudioFormat instead of audfmt_e
  audio: -audiodev command line option: documentation
  audio: -audiodev command line option basic implementation
  alsaaudio: port to -audiodev config
  coreaudio: port to -audiodev config
  dsoundaudio: port to -audiodev config
  noaudio: port to -audiodev config
  ossaudio: port to -audiodev config
  paaudio: port to -audiodev config
  sdlaudio: port to -audiodev config
  spiceaudio: port to -audiodev config
  wavaudio: port to -audiodev config
  audio: -audiodev command line option: cleanup
  audio: reduce glob_audio_state usage
  audio: basic support for multi backend audio
  audio: add audiodev properties to frontends
  audio: audiodev= parameters no longer optional when -audiodev present
  paaudio: do not move stream when sink/source name is specified
  paaudio: properly disconnect streams in fini_*
  audio: remove audio_MIN, audio_MAX
  audio: do not run each backend in audio_run
  paaudio: fix playback glitches
  audio: remove read and write pcm_ops
  audio: use size_t where makes sense
  audio: api for mixeng code free backends
  alsaaudio: port to the new audio backend api
  coreaudio: port to the new audio backend api
  dsoundaudio: port to the new audio backend api
  noaudio: port to the new audio backend api
  ossaudio: port to the new audio backend api
  paaudio: port to the new audio backend api
  sdlaudio: port to the new audio backend api
  spiceaudio: port to the new audio backend api
  wavaudio: port to the new audio backend api
  audio: remove remains of the old backend api
  audio: unify input and output mixeng buffer management
  audio: remove hw->samples, buffer_size_in/out pcm_ops
  audio: common rate control code for timer based outputs
  audio: split ctl_* functions into enable_* and volume_*
  audio: add mixeng option (documentation)
  audio: make mixeng optional
  paaudio: get/put_buffer functions
  audio: support more than two channels in volume setting
  audio: replace shift in audio_pcm_info with bytes_per_frame
  audio: basic support for multichannel audio
  paaudio: channel-map option
  usb-audio: do not count on avail bytes actually available
  usb-audio: support more than two channels of audio
  usbaudio: change playback counters to 64 bit

 Makefile.objs                           |    6 +-
 audio/Makefile.objs                     |    3 +-
 audio/alsaaudio.c                       |  755 ++++-------
 audio/audio.c                           | 1561 ++++++++++++-----------
 audio/audio.h                           |   78 +-
 audio/audio_int.h                       |  131 +-
 audio/audio_legacy.c                    |  342 +++++
 audio/audio_pt_int.c                    |  174 ---
 audio/audio_pt_int.h                    |   22 -
 audio/audio_template.h                  |  112 +-
 audio/audio_win_int.c                   |   18 +-
 audio/coreaudio.c                       |  198 ++-
 audio/dsound_template.h                 |   63 +-
 audio/dsoundaudio.c                     |  449 ++-----
 audio/mixeng.h                          |   11 +-
 audio/noaudio.c                         |   98 +-
 audio/ossaudio.c                        |  594 ++++-----
 audio/paaudio.c                         |  881 ++++++-------
 audio/rate_template.h                   |    2 +-
 audio/sdlaudio.c                        |  218 ++--
 audio/spiceaudio.c                      |  286 ++---
 audio/wavaudio.c                        |  158 +--
 audio/wavcapture.c                      |    8 +-
 configure                               |    5 -
 hmp-commands.hx                         |   11 +-
 hw/acpi/core.c                          |    2 +-
 hw/arm/omap2.c                          |    2 +-
 hw/audio/ac97.c                         |   13 +-
 hw/audio/adlib.c                        |    7 +-
 hw/audio/cs4231a.c                      |   11 +-
 hw/audio/es1370.c                       |   17 +-
 hw/audio/gus.c                          |    9 +-
 hw/audio/hda-codec.c                    |   35 +-
 hw/audio/lm4549.c                       |    6 +-
 hw/audio/milkymist-ac97.c               |   16 +-
 hw/audio/pcspk.c                        |    5 +-
 hw/audio/pl041.c                        |    1 +
 hw/audio/sb16.c                         |   17 +-
 hw/audio/wm8750.c                       |   14 +-
 hw/core/qdev-properties-system.c        |   57 +
 hw/display/xlnx_dp.c                    |    2 +-
 hw/input/tsc210x.c                      |    2 +-
 hw/usb/dev-audio.c                      |  460 ++++++-
 include/hw/qdev-properties.h            |    3 +
 include/qapi/opts-visitor.h             |    9 +-
 include/sysemu/replay.h                 |    4 +-
 monitor.c                               |   12 +-
 net/net.c                               |    2 +-
 numa.c                                  |    2 +-
 qapi/audio.json                         |  261 ++++
 qapi/opts-visitor.c                     |  145 ++-
 qapi/qapi-schema.json                   |    1 +
 qemu-options.hx                         |  242 +++-
 qom/object_interfaces.c                 |    2 +-
 replay/replay-audio.c                   |   16 +-
 tests/qapi-schema/qapi-schema-test.json |    9 +-
 tests/qapi-schema/qapi-schema-test.out  |    4 +
 tests/test-opts-visitor.c               |   43 +-
 ui/vnc.c                                |   41 +-
 ui/vnc.h                                |    2 +
 vl.c                                    |   11 +-
 61 files changed, 3921 insertions(+), 3748 deletions(-)
 create mode 100644 audio/audio_legacy.c
 delete mode 100644 audio/audio_pt_int.c
 delete mode 100644 audio/audio_pt_int.h
 create mode 100644 qapi/audio.json

-- 
2.20.1