* [PATCH v2 1/2] ARM: dts: sunxi: Fix GPIO LED node names
@ 2022-12-31 22:58 ` Samuel Holland
0 siblings, 0 replies; 10+ messages in thread
From: Samuel Holland @ 2022-12-31 22:58 UTC (permalink / raw)
To: Chen-Yu Tsai, Jernej Skrabec
Cc: Samuel Holland, Krzysztof Kozlowski, Rob Herring, devicetree,
linux-arm-kernel, linux-kernel, linux-sunxi
These board devicetrees fail to validate because the gpio-leds schema
requires its child nodes to have "led" in the node name.
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
Changes in v2:
- Use the recommended enumerator pattern for LED node names
arch/arm/boot/dts/sun5i-gr8-chip-pro.dts | 2 +-
arch/arm/boot/dts/sun5i-r8-chip.dts | 2 +-
arch/arm/boot/dts/sun6i-a31s-sina31s.dts | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts b/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
index a32cde3e32eb..5c3562b85a5b 100644
--- a/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
+++ b/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
@@ -70,7 +70,7 @@ chosen {
leds {
compatible = "gpio-leds";
- status {
+ led-0 {
label = "chip-pro:white:status";
gpios = <&axp_gpio 2 GPIO_ACTIVE_HIGH>;
default-state = "on";
diff --git a/arch/arm/boot/dts/sun5i-r8-chip.dts b/arch/arm/boot/dts/sun5i-r8-chip.dts
index 4bf4943d4eb7..fd37bd1f3920 100644
--- a/arch/arm/boot/dts/sun5i-r8-chip.dts
+++ b/arch/arm/boot/dts/sun5i-r8-chip.dts
@@ -70,7 +70,7 @@ chosen {
leds {
compatible = "gpio-leds";
- status {
+ led-0 {
label = "chip:white:status";
gpios = <&axp_gpio 2 GPIO_ACTIVE_HIGH>;
default-state = "on";
diff --git a/arch/arm/boot/dts/sun6i-a31s-sina31s.dts b/arch/arm/boot/dts/sun6i-a31s-sina31s.dts
index 0af48e143b66..56956352914d 100644
--- a/arch/arm/boot/dts/sun6i-a31s-sina31s.dts
+++ b/arch/arm/boot/dts/sun6i-a31s-sina31s.dts
@@ -67,7 +67,7 @@ hdmi_con_in: endpoint {
leds {
compatible = "gpio-leds";
- status {
+ led-0 {
label = "sina31s:status:usr";
gpios = <&pio 7 13 GPIO_ACTIVE_HIGH>; /* PH13 */
};
--
2.37.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v2 2/2] ARM: dts: sun8i: nanopi-duo2: Fix regulator GPIO reference
2022-12-31 22:58 ` Samuel Holland
@ 2022-12-31 22:58 ` Samuel Holland
-1 siblings, 0 replies; 10+ messages in thread
From: Samuel Holland @ 2022-12-31 22:58 UTC (permalink / raw)
To: Chen-Yu Tsai, Jernej Skrabec
Cc: Samuel Holland, Krzysztof Kozlowski, Rob Herring, devicetree,
linux-arm-kernel, linux-kernel, linux-sunxi, Andre Przywara,
Karl Palsson, Maxime Ripard
The property named in the schema is 'enable-gpios', not 'enable-gpio'.
This makes no difference at runtime, because the regulator is marked as
always-on, but it breaks validation.
Fixes: 4701fc6e5dd9 ("ARM: dts: sun8i: add FriendlyARM NanoPi Duo2")
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
(no changes since v1)
arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts
index 43641cb82398..343b02b97155 100644
--- a/arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts
+++ b/arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts
@@ -57,7 +57,7 @@ reg_vdd_cpux: vdd-cpux-regulator {
regulator-ramp-delay = <50>; /* 4ms */
enable-active-high;
- enable-gpio = <&r_pio 0 8 GPIO_ACTIVE_HIGH>; /* PL8 */
+ enable-gpios = <&r_pio 0 8 GPIO_ACTIVE_HIGH>; /* PL8 */
gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */
gpios-states = <0x1>;
states = <1100000 0>, <1300000 1>;
--
2.37.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v2 2/2] ARM: dts: sun8i: nanopi-duo2: Fix regulator GPIO reference
@ 2022-12-31 22:58 ` Samuel Holland
0 siblings, 0 replies; 10+ messages in thread
From: Samuel Holland @ 2022-12-31 22:58 UTC (permalink / raw)
To: Chen-Yu Tsai, Jernej Skrabec
Cc: Samuel Holland, Krzysztof Kozlowski, Rob Herring, devicetree,
linux-arm-kernel, linux-kernel, linux-sunxi, Andre Przywara,
Karl Palsson, Maxime Ripard
The property named in the schema is 'enable-gpios', not 'enable-gpio'.
This makes no difference at runtime, because the regulator is marked as
always-on, but it breaks validation.
Fixes: 4701fc6e5dd9 ("ARM: dts: sun8i: add FriendlyARM NanoPi Duo2")
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
(no changes since v1)
arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts
index 43641cb82398..343b02b97155 100644
--- a/arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts
+++ b/arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts
@@ -57,7 +57,7 @@ reg_vdd_cpux: vdd-cpux-regulator {
regulator-ramp-delay = <50>; /* 4ms */
enable-active-high;
- enable-gpio = <&r_pio 0 8 GPIO_ACTIVE_HIGH>; /* PL8 */
+ enable-gpios = <&r_pio 0 8 GPIO_ACTIVE_HIGH>; /* PL8 */
gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */
gpios-states = <0x1>;
states = <1100000 0>, <1300000 1>;
--
2.37.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: sunxi: Fix GPIO LED node names
2022-12-31 22:58 ` Samuel Holland
@ 2023-01-03 11:08 ` Andre Przywara
-1 siblings, 0 replies; 10+ messages in thread
From: Andre Przywara @ 2023-01-03 11:08 UTC (permalink / raw)
To: Samuel Holland
Cc: Chen-Yu Tsai, Jernej Skrabec, Krzysztof Kozlowski, Rob Herring,
devicetree, linux-arm-kernel, linux-kernel, linux-sunxi
On Sat, 31 Dec 2022 16:58:53 -0600
Samuel Holland <samuel@sholland.org> wrote:
> These board devicetrees fail to validate because the gpio-leds schema
> requires its child nodes to have "led" in the node name.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> ---
>
> Changes in v2:
> - Use the recommended enumerator pattern for LED node names
>
> arch/arm/boot/dts/sun5i-gr8-chip-pro.dts | 2 +-
> arch/arm/boot/dts/sun5i-r8-chip.dts | 2 +-
> arch/arm/boot/dts/sun6i-a31s-sina31s.dts | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts b/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
> index a32cde3e32eb..5c3562b85a5b 100644
> --- a/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
> +++ b/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
> @@ -70,7 +70,7 @@ chosen {
> leds {
> compatible = "gpio-leds";
>
> - status {
> + led-0 {
> label = "chip-pro:white:status";
> gpios = <&axp_gpio 2 GPIO_ACTIVE_HIGH>;
> default-state = "on";
> diff --git a/arch/arm/boot/dts/sun5i-r8-chip.dts b/arch/arm/boot/dts/sun5i-r8-chip.dts
> index 4bf4943d4eb7..fd37bd1f3920 100644
> --- a/arch/arm/boot/dts/sun5i-r8-chip.dts
> +++ b/arch/arm/boot/dts/sun5i-r8-chip.dts
> @@ -70,7 +70,7 @@ chosen {
> leds {
> compatible = "gpio-leds";
>
> - status {
> + led-0 {
> label = "chip:white:status";
> gpios = <&axp_gpio 2 GPIO_ACTIVE_HIGH>;
> default-state = "on";
> diff --git a/arch/arm/boot/dts/sun6i-a31s-sina31s.dts b/arch/arm/boot/dts/sun6i-a31s-sina31s.dts
> index 0af48e143b66..56956352914d 100644
> --- a/arch/arm/boot/dts/sun6i-a31s-sina31s.dts
> +++ b/arch/arm/boot/dts/sun6i-a31s-sina31s.dts
> @@ -67,7 +67,7 @@ hdmi_con_in: endpoint {
> leds {
> compatible = "gpio-leds";
>
> - status {
> + led-0 {
> label = "sina31s:status:usr";
> gpios = <&pio 7 13 GPIO_ACTIVE_HIGH>; /* PH13 */
> };
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2 1/2] ARM: dts: sunxi: Fix GPIO LED node names
@ 2023-01-03 11:08 ` Andre Przywara
0 siblings, 0 replies; 10+ messages in thread
From: Andre Przywara @ 2023-01-03 11:08 UTC (permalink / raw)
To: Samuel Holland
Cc: Chen-Yu Tsai, Jernej Skrabec, Krzysztof Kozlowski, Rob Herring,
devicetree, linux-arm-kernel, linux-kernel, linux-sunxi
On Sat, 31 Dec 2022 16:58:53 -0600
Samuel Holland <samuel@sholland.org> wrote:
> These board devicetrees fail to validate because the gpio-leds schema
> requires its child nodes to have "led" in the node name.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> ---
>
> Changes in v2:
> - Use the recommended enumerator pattern for LED node names
>
> arch/arm/boot/dts/sun5i-gr8-chip-pro.dts | 2 +-
> arch/arm/boot/dts/sun5i-r8-chip.dts | 2 +-
> arch/arm/boot/dts/sun6i-a31s-sina31s.dts | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts b/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
> index a32cde3e32eb..5c3562b85a5b 100644
> --- a/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
> +++ b/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
> @@ -70,7 +70,7 @@ chosen {
> leds {
> compatible = "gpio-leds";
>
> - status {
> + led-0 {
> label = "chip-pro:white:status";
> gpios = <&axp_gpio 2 GPIO_ACTIVE_HIGH>;
> default-state = "on";
> diff --git a/arch/arm/boot/dts/sun5i-r8-chip.dts b/arch/arm/boot/dts/sun5i-r8-chip.dts
> index 4bf4943d4eb7..fd37bd1f3920 100644
> --- a/arch/arm/boot/dts/sun5i-r8-chip.dts
> +++ b/arch/arm/boot/dts/sun5i-r8-chip.dts
> @@ -70,7 +70,7 @@ chosen {
> leds {
> compatible = "gpio-leds";
>
> - status {
> + led-0 {
> label = "chip:white:status";
> gpios = <&axp_gpio 2 GPIO_ACTIVE_HIGH>;
> default-state = "on";
> diff --git a/arch/arm/boot/dts/sun6i-a31s-sina31s.dts b/arch/arm/boot/dts/sun6i-a31s-sina31s.dts
> index 0af48e143b66..56956352914d 100644
> --- a/arch/arm/boot/dts/sun6i-a31s-sina31s.dts
> +++ b/arch/arm/boot/dts/sun6i-a31s-sina31s.dts
> @@ -67,7 +67,7 @@ hdmi_con_in: endpoint {
> leds {
> compatible = "gpio-leds";
>
> - status {
> + led-0 {
> label = "sina31s:status:usr";
> gpios = <&pio 7 13 GPIO_ACTIVE_HIGH>; /* PH13 */
> };
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: sunxi: Fix GPIO LED node names
2022-12-31 22:58 ` Samuel Holland
@ 2023-01-05 16:23 ` Jernej Škrabec
-1 siblings, 0 replies; 10+ messages in thread
From: Jernej Škrabec @ 2023-01-05 16:23 UTC (permalink / raw)
To: Chen-Yu Tsai, Samuel Holland
Cc: Samuel Holland, Krzysztof Kozlowski, Rob Herring, devicetree,
linux-arm-kernel, linux-kernel, linux-sunxi
Dne sobota, 31. december 2022 ob 23:58:53 CET je Samuel Holland napisal(a):
> These board devicetrees fail to validate because the gpio-leds schema
> requires its child nodes to have "led" in the node name.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: sunxi: Fix GPIO LED node names
@ 2023-01-05 16:23 ` Jernej Škrabec
0 siblings, 0 replies; 10+ messages in thread
From: Jernej Škrabec @ 2023-01-05 16:23 UTC (permalink / raw)
To: Chen-Yu Tsai, Samuel Holland
Cc: Samuel Holland, Krzysztof Kozlowski, Rob Herring, devicetree,
linux-arm-kernel, linux-kernel, linux-sunxi
Dne sobota, 31. december 2022 ob 23:58:53 CET je Samuel Holland napisal(a):
> These board devicetrees fail to validate because the gpio-leds schema
> requires its child nodes to have "led" in the node name.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: sunxi: Fix GPIO LED node names
2022-12-31 22:58 ` Samuel Holland
@ 2023-01-08 21:03 ` Jernej Škrabec
-1 siblings, 0 replies; 10+ messages in thread
From: Jernej Škrabec @ 2023-01-08 21:03 UTC (permalink / raw)
To: Chen-Yu Tsai, Samuel Holland
Cc: Samuel Holland, Krzysztof Kozlowski, Rob Herring, devicetree,
linux-arm-kernel, linux-kernel, linux-sunxi
Dne sobota, 31. december 2022 ob 23:58:53 CET je Samuel Holland napisal(a):
> These board devicetrees fail to validate because the gpio-leds schema
> requires its child nodes to have "led" in the node name.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Applied both, thanks!
Best regards,
Jernej
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: sunxi: Fix GPIO LED node names
@ 2023-01-08 21:03 ` Jernej Škrabec
0 siblings, 0 replies; 10+ messages in thread
From: Jernej Škrabec @ 2023-01-08 21:03 UTC (permalink / raw)
To: Chen-Yu Tsai, Samuel Holland
Cc: Samuel Holland, Krzysztof Kozlowski, Rob Herring, devicetree,
linux-arm-kernel, linux-kernel, linux-sunxi
Dne sobota, 31. december 2022 ob 23:58:53 CET je Samuel Holland napisal(a):
> These board devicetrees fail to validate because the gpio-leds schema
> requires its child nodes to have "led" in the node name.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Applied both, thanks!
Best regards,
Jernej
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread