All of lore.kernel.org
 help / color / mirror / Atom feed
From: idanb <idanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>,
	Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
Cc: leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	hch-jcswGhMUV9g@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH 2/2] nvme-rdma: Add remote_invalidation module parameter
Date: Mon, 30 Oct 2017 14:35:42 +0200	[thread overview]
Message-ID: <22964904-2537-51c3-bf39-5b2197aec5b9@mellanox.com> (raw)
In-Reply-To: <360f892f-b88d-0947-1590-ab1d64d4da13-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>


On 10/30/2017 12:33 PM, Sagi Grimberg wrote:
>
>
>>>> I agree we should fix this, nevertheless I don't expect this to 
>>>> create an IO rate issue for long queue depths.
>>>> Indeed we will have a tradeoff here of latency vs rate.
>>>
>>> I suggest we hold back with this one for now, I have fixes for
>>> the local invalidate flow. Once we get them in we can see if
>>> this approach makes a difference, and if so, we need to expose
>>> it through a generic mechanism.
>>
>> I suggest that you'll post the patches to the list and we'll investigate
>> the latency implications, if the implications are negligible, we have a
>> win here for small IOs.
>>
>> When will you be able to post your patches?
>
> I can post them now, but I prefer to test them first ;)

Sounds good, we will check once you'll post them.
I expect no impact on IOPs,  just latency.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: idanb@mellanox.com (idanb)
Subject: [PATCH 2/2] nvme-rdma: Add remote_invalidation module parameter
Date: Mon, 30 Oct 2017 14:35:42 +0200	[thread overview]
Message-ID: <22964904-2537-51c3-bf39-5b2197aec5b9@mellanox.com> (raw)
In-Reply-To: <360f892f-b88d-0947-1590-ab1d64d4da13@grimberg.me>


On 10/30/2017 12:33 PM, Sagi Grimberg wrote:
>
>
>>>> I agree we should fix this, nevertheless I don't expect this to 
>>>> create an IO rate issue for long queue depths.
>>>> Indeed we will have a tradeoff here of latency vs rate.
>>>
>>> I suggest we hold back with this one for now, I have fixes for
>>> the local invalidate flow. Once we get them in we can see if
>>> this approach makes a difference, and if so, we need to expose
>>> it through a generic mechanism.
>>
>> I suggest that you'll post the patches to the list and we'll investigate
>> the latency implications, if the implications are negligible, we have a
>> win here for small IOs.
>>
>> When will you be able to post your patches?
>
> I can post them now, but I prefer to test them first ;)

Sounds good, we will check once you'll post them.
I expect no impact on IOPs,  just latency.

  parent reply	other threads:[~2017-10-30 12:35 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-29 16:38 [PATCH 0/2] Performance Improvents for Secured Mode NVMe over Fabrics and other RDMA ULPs idanb-VPRAkNaXOzVWk0Htik3J/w
2017-10-29 16:38 ` idanb
     [not found] ` <1509295101-14081-1-git-send-email-idanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-10-29 16:38   ` [PATCH 1/2] IB/mlx5: posting klm/mtt list inline in the send queue for reg_wr idanb-VPRAkNaXOzVWk0Htik3J/w
2017-10-29 16:38     ` idanb
     [not found]     ` <1509295101-14081-2-git-send-email-idanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-10-29 17:09       ` Sagi Grimberg
2017-10-29 17:09         ` Sagi Grimberg
2018-04-19 21:11     ` roland
2018-04-20  2:04       ` Doug Ledford
2018-04-20 19:07         ` Max Gurtovoy
2017-10-29 16:38   ` [PATCH 2/2] nvme-rdma: Add remote_invalidation module parameter idanb-VPRAkNaXOzVWk0Htik3J/w
2017-10-29 16:38     ` idanb
     [not found]     ` <1509295101-14081-3-git-send-email-idanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-10-29 17:52       ` Jason Gunthorpe
2017-10-29 17:52         ` Jason Gunthorpe
     [not found]         ` <20171029175237.GD4488-uk2M96/98Pc@public.gmane.org>
2017-10-30  8:14           ` Sagi Grimberg
2017-10-30  8:14             ` Sagi Grimberg
     [not found]             ` <740c93f4-164e-d4e3-97b1-313a0420ae81-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-10-30  8:38               ` idanb
2017-10-30  8:38                 ` idanb
     [not found]                 ` <7e038d80-de95-8fb7-e313-825e40c03e88-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-10-30  9:44                   ` Sagi Grimberg
2017-10-30  9:44                     ` Sagi Grimberg
     [not found]                     ` <38523e67-fa00-dd03-5b6f-34cd6f863c8f-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-10-30 10:31                       ` idanb
2017-10-30 10:31                         ` idanb
     [not found]                         ` <5783e083-93d4-8e72-c380-03fc54a0291b-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-10-30 10:33                           ` Sagi Grimberg
2017-10-30 10:33                             ` Sagi Grimberg
     [not found]                             ` <360f892f-b88d-0947-1590-ab1d64d4da13-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-10-30 12:35                               ` idanb [this message]
2017-10-30 12:35                                 ` idanb
2017-10-29 18:24       ` Chuck Lever
2017-10-29 18:24         ` Chuck Lever
     [not found]         ` <87A0B150-CE67-4C8C-914E-53F66411E1BB-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-10-30 18:18           ` Chuck Lever
2017-10-30 18:18             ` Chuck Lever
2017-10-30  8:11       ` Sagi Grimberg
2017-10-30  8:11         ` Sagi Grimberg
     [not found]         ` <4423f96f-bf42-3603-aa6a-fa259a1d09d1-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-10-30  8:45           ` idanb
2017-10-30  8:45             ` idanb
2017-10-29 16:59   ` [PATCH 0/2] Performance Improvents for Secured Mode NVMe over Fabrics and other RDMA ULPs Sagi Grimberg
2017-10-29 16:59     ` Sagi Grimberg
     [not found]     ` <e1ba4993-5c77-4754-967c-4da8ec34bf77-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-10-29 17:09       ` Max Gurtovoy
2017-10-29 17:09         ` Max Gurtovoy
     [not found]         ` <8cb59a0a-c902-0c0e-27a8-fdf9b98982ac-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-10-29 17:43           ` Leon Romanovsky
2017-10-29 17:43             ` Leon Romanovsky
     [not found]             ` <AM0PR0502MB38906F57CD68C3707F8FE765C5580@AM0PR0502MB3890.eurprd05.prod.outlook.com>
     [not found]               ` <AM0PR0502MB38906F57CD68C3707F8FE765C5580-EJTefJAZ6OmxAoLrISMGDMDSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-10-30  5:21                 ` Leon Romanovsky
2017-10-30  5:21                   ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22964904-2537-51c3-bf39-5b2197aec5b9@mellanox.com \
    --to=idanb-vpraknaxozvwk0htik3j/w@public.gmane.org \
    --cc=hch-jcswGhMUV9g@public.gmane.org \
    --cc=jgg-uk2M96/98Pc@public.gmane.org \
    --cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.