From: Srinivas Kandagatla <srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> To: Archit Taneja <architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>, Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org> Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH 2/2] phy: msm8996-pcie-phy: Add support to msm8996 pcie phy Date: Fri, 16 Sep 2016 17:48:08 +0100 [thread overview] Message-ID: <2296a3a9-164a-c46c-ef98-2bd2d97039c8@linaro.org> (raw) In-Reply-To: <57D82403.9080004-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> On 13/09/16 17:06, Archit Taneja wrote: > > > On 9/7/2016 4:25 PM, Srinivas Kandagatla wrote: >> This patch adds support to msm8996 pcie phy which supports 3 ports, >> Port A, Port B and Port C. >> >> Each port is independent and connected to a pcie host controller, >> there is >> also a common block which is shared across all the 3 ports. >> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> >> --- >> drivers/phy/Kconfig | 7 + >> drivers/phy/Makefile | 1 + >> drivers/phy/phy-qcom-msm8996-pcie.c | 492 >> ++++++++++++++++++++++++++++++++++++ >> +#define PCIE_LANE_PCS_BASE 0x1400 > > I've seen the reg offsets of another SoC using the same > IP, but the above offsets aren't the same relative to the > phy base. We might want to create more reg properties in > DT to accommodate register maps on other SoCs. Yep, I got some more info on this from Vivek and It looks like this IP has been reused on other Host controllers and SOCs. So plan is to write a common driver for all of them. Thanks, srini -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> To: Archit Taneja <architt@codeaurora.org>, Kishon Vijay Abraham I <kishon@ti.com> Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 2/2] phy: msm8996-pcie-phy: Add support to msm8996 pcie phy Date: Fri, 16 Sep 2016 17:48:08 +0100 [thread overview] Message-ID: <2296a3a9-164a-c46c-ef98-2bd2d97039c8@linaro.org> (raw) In-Reply-To: <57D82403.9080004@codeaurora.org> On 13/09/16 17:06, Archit Taneja wrote: > > > On 9/7/2016 4:25 PM, Srinivas Kandagatla wrote: >> This patch adds support to msm8996 pcie phy which supports 3 ports, >> Port A, Port B and Port C. >> >> Each port is independent and connected to a pcie host controller, >> there is >> also a common block which is shared across all the 3 ports. >> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> --- >> drivers/phy/Kconfig | 7 + >> drivers/phy/Makefile | 1 + >> drivers/phy/phy-qcom-msm8996-pcie.c | 492 >> ++++++++++++++++++++++++++++++++++++ >> +#define PCIE_LANE_PCS_BASE 0x1400 > > I've seen the reg offsets of another SoC using the same > IP, but the above offsets aren't the same relative to the > phy base. We might want to create more reg properties in > DT to accommodate register maps on other SoCs. Yep, I got some more info on this from Vivek and It looks like this IP has been reused on other Host controllers and SOCs. So plan is to write a common driver for all of them. Thanks, srini
next prev parent reply other threads:[~2016-09-16 16:48 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-09-07 10:55 [PATCH 0/2] phy: Add support msm8996/apq8096 pcie phy Srinivas Kandagatla 2016-09-07 10:55 ` [PATCH 1/2] dt-bindings: msm8996-pcie-phy: add support for msm8996 " Srinivas Kandagatla [not found] ` <1473245733-17260-2-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-09-12 22:51 ` Stephen Boyd 2016-09-12 22:51 ` Stephen Boyd 2016-09-16 16:51 ` Srinivas Kandagatla 2016-09-16 13:52 ` Rob Herring 2016-09-16 13:52 ` Rob Herring 2016-09-16 16:45 ` Srinivas Kandagatla 2016-09-07 10:55 ` [PATCH 2/2] phy: msm8996-pcie-phy: Add support to " Srinivas Kandagatla 2016-09-13 16:06 ` Archit Taneja [not found] ` <57D82403.9080004-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2016-09-16 16:48 ` Srinivas Kandagatla [this message] 2016-09-16 16:48 ` Srinivas Kandagatla 2016-09-16 14:14 ` Stanimir Varbanov 2016-09-16 16:49 ` Srinivas Kandagatla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2296a3a9-164a-c46c-ef98-2bd2d97039c8@linaro.org \ --to=srinivas.kandagatla-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \ --cc=architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=kishon-l0cyMroinI0@public.gmane.org \ --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.