[PATCH 0/2] osstest: followup from the PVH toolstack series

[PATCH 0/2] osstest: followup from the PVH toolstack series

[Roger Pau Monne]

Hello,

The two patches in this series modify osstest in order to fix the PVH
tests, and also switch HVM guests to use the 'type' option (note that
the builder option is kept for compatibility reasons).

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 1/2] osstest: fix PVH DomU tests

[Roger Pau Monne]

The pvh=1 xl option was removed, so switch the PVH tests to use
type='pvh' instead.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Ian.Jackson@eu.citrix.com
---
 ts-debian-fixup | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ts-debian-fixup b/ts-debian-fixup
index 571b2509..80c35da5 100755
--- a/ts-debian-fixup
+++ b/ts-debian-fixup
@@ -136,8 +136,8 @@ sub otherfixupcfg () {
 
     my $pvh = guest_var($gho,'pvh',undef);
     if ($pvh) {
-	$cfg =~ s/^pvh\b.*//mg;
-	$cfg .= "\npvh=$pvh\n";
+	$cfg =~ s/^type=\b.*//mg;
+	$cfg .= "\ntype='pvh'\n";
     }
 
     # PCI passthrough
-- 
2.13.5 (Apple Git-94)


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 1/2] osstest: fix PVH DomU tests

[Ian Jackson]

Roger Pau Monne writes ("[PATCH 1/2] osstest: fix PVH DomU tests"):
> The pvh=1 xl option was removed, so switch the PVH tests to use
> type='pvh' instead.

What will be the effect of this on old Xen branches ?
I think it might stop the pvh tests from working in those branches.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 1/2] osstest: fix PVH DomU tests

[Roger Pau Monné]

On Fri, Sep 29, 2017 at 03:35:24PM +0000, Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH 1/2] osstest: fix PVH DomU tests"):
> > The pvh=1 xl option was removed, so switch the PVH tests to use
> > type='pvh' instead.
> 
> What will be the effect of this on old Xen branches ?

PVHv1 is also removed from the Linux kernel, so it's just a matter of
time until those start failing, if they are not failing already.

> I think it might stop the pvh tests from working in those branches.

This change will just turn the PVH tests into PV test on old branches,
because type=pvh will be ignored and the guest is going to boot in PV
mode.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 1/2] osstest: fix PVH DomU tests

[Ian Jackson]

Roger Pau Monné writes ("Re: [PATCH 1/2] osstest: fix PVH DomU tests"):
> On Fri, Sep 29, 2017 at 03:35:24PM +0000, Ian Jackson wrote:
> > I think it might stop the pvh tests from working in those branches.
> 
> This change will just turn the PVH tests into PV test on old branches,
> because type=pvh will be ignored and the guest is going to boot in PV
> mode.

That's not brilliant.  Can we make this change conditional and/or drop
the pvh tests for older branches ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 1/2] osstest: fix PVH DomU tests

[Roger Pau Monné]

On Fri, Sep 29, 2017 at 05:19:52PM +0000, Ian Jackson wrote:
> Roger Pau Monné writes ("Re: [PATCH 1/2] osstest: fix PVH DomU tests"):
> > On Fri, Sep 29, 2017 at 03:35:24PM +0000, Ian Jackson wrote:
> > > I think it might stop the pvh tests from working in those branches.
> > 
> > This change will just turn the PVH tests into PV test on old branches,
> > because type=pvh will be ignored and the guest is going to boot in PV
> > mode.
> 
> That's not brilliant.  Can we make this change conditional and/or drop
> the pvh tests for older branches ?

IMHO we should drop the PVH tests for older branches (ie: PVHv1
tests). This has already been removed from current Linux and Xen, so
it makes no sense to continue testing them.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 2/2] osstest: use type='hvm' for HVM guests

[Roger Pau Monne]

The previous builder='hvm' is also kept for compatibility with older
Xen releases. Note that the type option is ignored in previous Xen
versions.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Ian.Jackson@eu.citrix.com
---
 Osstest/TestSupport.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index a5cca391..66625e6f 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -2089,6 +2089,7 @@ sub more_prepareguest_hvm ($$$$;@) {
     my $cfg = <<END;
 $kernel
 builder     = 'hvm'
+type        = 'hvm'
 #
 disk        = [
 		$disks
-- 
2.13.5 (Apple Git-94)


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 2/2] osstest: use type='hvm' for HVM guests

[Ian Jackson]

Roger Pau Monne writes ("[PATCH 2/2] osstest: use type='hvm' for HVM guests"):
> The previous builder='hvm' is also kept for compatibility with older
> Xen releases. Note that the type option is ignored in previous Xen
> versions.

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel