Build failures due to libtdb racing with libbsd

Build failures due to libtdb racing with libbsd

[Ulf Magnusson]

Hello,

I get libtdb build failures like the following. The failing file
varies between runs.

ERROR: oe_runmake failed
ERROR: Function failed: do_compile
Log data follows:
| DEBUG: Executing shell function do_compile
| NOTE: make -j 16 -e MAKEFLAGS=
| WAF_MAKE=1 PATH=buildtools/bin:../../buildtools/bin:$PATH waf build
| Checking project rules ...
| Project rules pass
| [  1/100] Generating tdb.vscript
| [  2/100] Compiling lib/replace/replace.c
| [  3/100] Compiling lib/replace/cwrap.c
| [  4/100] Generating PKGCONFIG_tdb.pc
| [  5/100] Compiling lib/replace/replace.c
| [  6/100] Compiling lib/replace/test/testsuite.c
| [  7/100] Compiling lib/replace/test/strptime.c
| [  8/100] Compiling lib/replace/test/os2_delete.c
| [  9/100] Compiling lib/replace/test/getifaddrs.c
| [ 10/100] Compiling common/check.c
| [ 11/100] Compiling common/error.c
| [ 12/100] Compiling common/tdb.c
| [ 13/100] Compiling common/traverse.c
| [ 14/100] Compiling common/freelistcheck.c
| [ 15/100] Compiling common/lock.c
| [ 16/100] Compiling common/dump.c
| [ 17/100] Compiling common/freelist.c
| [ 18/100] Compiling common/io.c
| [ 19/100] Compiling common/open.c
| [ 20/100] Compiling common/transaction.c
| [ 21/100] Compiling common/hash.c
| [ 22/100] Compiling common/summary.c
| [ 23/100] Compiling common/rescue.c
| [ 24/100] Compiling common/mutex.c
| [ 25/100] Compiling tools/tdbtorture.c
| In file included from ../tools/tdbtorture.c:5:0:
| ../lib/replace/replace.h:151:24: fatal error: bsd/string.h: No such
file or directory
|  #include <bsd/string.h>
|                         ^
| compilation terminated.
| Build failed:  -> task failed (err #1):
|     {task: cc tdbtorture.c -> tdbtorture_5.o}
| make: *** [all] Error 1
| WARNING: exit code 1 from a shell command.
| ERROR: oe_runmake failed
| ERROR: Function failed: do_compile
NOTE: recipe libtdb-1.3.0-r0: task do_compile: Failed

The problem seems to be a race with building libbsd (and unlucky
timing in my build). Adding libbsd to DEPENDS fixes the problem.

For some added context, libtdb uses a nonstandard ./configure from the
Samba project based on a configuration utility called Waf that I'm a
complete noob on. Perhaps there is some way to disable libbsd support
instead.

Cheers,
Ulf

Re: Build failures due to libtdb racing with libbsd

[Ulf Magnusson]

On Wed, Apr 13, 2016 at 11:41 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote:
> Hello,
>
> I get libtdb build failures like the following. The failing file
> varies between runs.
>
> ERROR: oe_runmake failed
> ERROR: Function failed: do_compile
> Log data follows:
> | DEBUG: Executing shell function do_compile
> | NOTE: make -j 16 -e MAKEFLAGS=
> | WAF_MAKE=1 PATH=buildtools/bin:../../buildtools/bin:$PATH waf build
> | Checking project rules ...
> | Project rules pass
> | [  1/100] Generating tdb.vscript
> | [  2/100] Compiling lib/replace/replace.c
> | [  3/100] Compiling lib/replace/cwrap.c
> | [  4/100] Generating PKGCONFIG_tdb.pc
> | [  5/100] Compiling lib/replace/replace.c
> | [  6/100] Compiling lib/replace/test/testsuite.c
> | [  7/100] Compiling lib/replace/test/strptime.c
> | [  8/100] Compiling lib/replace/test/os2_delete.c
> | [  9/100] Compiling lib/replace/test/getifaddrs.c
> | [ 10/100] Compiling common/check.c
> | [ 11/100] Compiling common/error.c
> | [ 12/100] Compiling common/tdb.c
> | [ 13/100] Compiling common/traverse.c
> | [ 14/100] Compiling common/freelistcheck.c
> | [ 15/100] Compiling common/lock.c
> | [ 16/100] Compiling common/dump.c
> | [ 17/100] Compiling common/freelist.c
> | [ 18/100] Compiling common/io.c
> | [ 19/100] Compiling common/open.c
> | [ 20/100] Compiling common/transaction.c
> | [ 21/100] Compiling common/hash.c
> | [ 22/100] Compiling common/summary.c
> | [ 23/100] Compiling common/rescue.c
> | [ 24/100] Compiling common/mutex.c
> | [ 25/100] Compiling tools/tdbtorture.c
> | In file included from ../tools/tdbtorture.c:5:0:
> | ../lib/replace/replace.h:151:24: fatal error: bsd/string.h: No such
> file or directory
> |  #include <bsd/string.h>
> |                         ^
> | compilation terminated.
> | Build failed:  -> task failed (err #1):
> |     {task: cc tdbtorture.c -> tdbtorture_5.o}
> | make: *** [all] Error 1
> | WARNING: exit code 1 from a shell command.
> | ERROR: oe_runmake failed
> | ERROR: Function failed: do_compile
> NOTE: recipe libtdb-1.3.0-r0: task do_compile: Failed
>
> The problem seems to be a race with building libbsd (and unlucky
> timing in my build). Adding libbsd to DEPENDS fixes the problem.
>
> For some added context, libtdb uses a nonstandard ./configure from the
> Samba project based on a configuration utility called Waf that I'm a
> complete noob on. Perhaps there is some way to disable libbsd support
> instead.
>
> Cheers,
> Ulf

I also found this fix which doesn't seem to have been merged - seems to
be a similar issue, though for a different dependency:
http://lists.openembedded.org/pipermail/openembedded-devel/2015-November/104623.html

Cheers,
Ulf

Re: Build failures due to libtdb racing with libbsd

[Jens Rehsack]

[-- Attachment #1: Type: text/plain, Size: 2925 bytes --]


> Am 13.04.2016 um 11:41 schrieb Ulf Magnusson <ulfalizer@gmail.com>:
> 
> Hello,
> 
> I get libtdb build failures like the following. The failing file
> varies between runs.
> 
> ERROR: oe_runmake failed
> ERROR: Function failed: do_compile
> Log data follows:
> | DEBUG: Executing shell function do_compile
> | NOTE: make -j 16 -e MAKEFLAGS=
> | WAF_MAKE=1 PATH=buildtools/bin:../../buildtools/bin:$PATH waf build
> | Checking project rules ...
> | Project rules pass
> | [  1/100] Generating tdb.vscript
> | [  2/100] Compiling lib/replace/replace.c
> | [  3/100] Compiling lib/replace/cwrap.c
> | [  4/100] Generating PKGCONFIG_tdb.pc
> | [  5/100] Compiling lib/replace/replace.c
> | [  6/100] Compiling lib/replace/test/testsuite.c
> | [  7/100] Compiling lib/replace/test/strptime.c
> | [  8/100] Compiling lib/replace/test/os2_delete.c
> | [  9/100] Compiling lib/replace/test/getifaddrs.c
> | [ 10/100] Compiling common/check.c
> | [ 11/100] Compiling common/error.c
> | [ 12/100] Compiling common/tdb.c
> | [ 13/100] Compiling common/traverse.c
> | [ 14/100] Compiling common/freelistcheck.c
> | [ 15/100] Compiling common/lock.c
> | [ 16/100] Compiling common/dump.c
> | [ 17/100] Compiling common/freelist.c
> | [ 18/100] Compiling common/io.c
> | [ 19/100] Compiling common/open.c
> | [ 20/100] Compiling common/transaction.c
> | [ 21/100] Compiling common/hash.c
> | [ 22/100] Compiling common/summary.c
> | [ 23/100] Compiling common/rescue.c
> | [ 24/100] Compiling common/mutex.c
> | [ 25/100] Compiling tools/tdbtorture.c
> | In file included from ../tools/tdbtorture.c:5:0:
> | ../lib/replace/replace.h:151:24: fatal error: bsd/string.h: No such
> file or directory
> |  #include <bsd/string.h>
> |                         ^
> | compilation terminated.
> | Build failed:  -> task failed (err #1):
> |     {task: cc tdbtorture.c -> tdbtorture_5.o}
> | make: *** [all] Error 1
> | WARNING: exit code 1 from a shell command.
> | ERROR: oe_runmake failed
> | ERROR: Function failed: do_compile
> NOTE: recipe libtdb-1.3.0-r0: task do_compile: Failed
> 
> The problem seems to be a race with building libbsd (and unlucky
> timing in my build). Adding libbsd to DEPENDS fixes the problem.
> 
> For some added context, libtdb uses a nonstandard ./configure from the
> Samba project based on a configuration utility called Waf that I'm a
> complete noob on. Perhaps there is some way to disable libbsd support
> instead.

It is not reasonable to disable libbsd support. When disabled, samba4 will
statically link own copies of the missing functions - better rely on
maintained stuff ...

I completely lost any track which samba patch has been applied and which
is missing. IIRC, I send some patches after analyzing requirement of
each of those dependencies and kept hard dependency of libbsd.

Cheers
--
Jens Rehsack - rehsack@gmail.com


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 859 bytes --]

Re: Build failures due to libtdb racing with libbsd

[Ulf Magnusson]

On Wed, Apr 13, 2016 at 11:34 AM, Burton, Ross <ross.burton@intel.com> wrote:
>
> On 13 April 2016 at 10:07, Ulf Magnusson <ulfalizer@gmail.com> wrote:
>>
>> The problem seems to be a race with building libbsd (and unlucky
>> timing in my build). Adding libbsd to DEPENDS fixes the problem.
>>
>> For some added context, libtdb uses a nonstandard ./configure from the
>> Samba project based on a configuration utility called Waf that I'm a
>> complete noob on. Perhaps there is some way to disable libbsd support
>> instead.
>
>
> This recipe is in meta-oe so this should be on the oe-devel list, not
> oe-core
>
> And yes, it looks like tdb has a floating dependency on libbsd.  Someone
> would need to determine if it's best to depend on libbsd always, or tell tbd
> to not use libbsd even if it can find it at build time.
>
> Ross

Okay, I'll send a copy to oe-devel.

Cheers,
Ulf

Re: Build failures due to libtdb racing with libbsd

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 747 bytes --]

On 13 April 2016 at 10:07, Ulf Magnusson <ulfalizer@gmail.com> wrote:

> The problem seems to be a race with building libbsd (and unlucky
> timing in my build). Adding libbsd to DEPENDS fixes the problem.
>
> For some added context, libtdb uses a nonstandard ./configure from the
> Samba project based on a configuration utility called Waf that I'm a
> complete noob on. Perhaps there is some way to disable libbsd support
> instead.
>

This recipe is in meta-oe so this should be on the oe-devel list, not
oe-core

And yes, it looks like tdb has a floating dependency on libbsd.  Someone
would need to determine if it's best to depend on libbsd always, or tell
tbd to not use libbsd even if it can find it at build time.

Ross

[-- Attachment #2: Type: text/html, Size: 1230 bytes --]

Re: Build failures due to libtdb racing with libbsd

[Ulf Magnusson]

On Wed, Apr 13, 2016 at 11:07 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote:
> Hello,
>
> I get libtdb build failures like the following. The failing file
> varies between runs.
>
> ERROR: oe_runmake failed
> ERROR: Function failed: do_compile
> Log data follows:
> | DEBUG: Executing shell function do_compile
> | NOTE: make -j 16 -e MAKEFLAGS=
> | WAF_MAKE=1 PATH=buildtools/bin:../../buildtools/bin:$PATH waf build
> | Checking project rules ...
> | Project rules pass
> | [  1/100] Generating tdb.vscript
> | [  2/100] Compiling lib/replace/replace.c
> | [  3/100] Compiling lib/replace/cwrap.c
> | [  4/100] Generating PKGCONFIG_tdb.pc
> | [  5/100] Compiling lib/replace/replace.c
> | [  6/100] Compiling lib/replace/test/testsuite.c
> | [  7/100] Compiling lib/replace/test/strptime.c
> | [  8/100] Compiling lib/replace/test/os2_delete.c
> | [  9/100] Compiling lib/replace/test/getifaddrs.c
> | [ 10/100] Compiling common/check.c
> | [ 11/100] Compiling common/error.c
> | [ 12/100] Compiling common/tdb.c
> | [ 13/100] Compiling common/traverse.c
> | [ 14/100] Compiling common/freelistcheck.c
> | [ 15/100] Compiling common/lock.c
> | [ 16/100] Compiling common/dump.c
> | [ 17/100] Compiling common/freelist.c
> | [ 18/100] Compiling common/io.c
> | [ 19/100] Compiling common/open.c
> | [ 20/100] Compiling common/transaction.c
> | [ 21/100] Compiling common/hash.c
> | [ 22/100] Compiling common/summary.c
> | [ 23/100] Compiling common/rescue.c
> | [ 24/100] Compiling common/mutex.c
> | [ 25/100] Compiling tools/tdbtorture.c
> | In file included from ../tools/tdbtorture.c:5:0:
> | ../lib/replace/replace.h:151:24: fatal error: bsd/string.h: No such
> file or directory
> |  #include <bsd/string.h>
> |                         ^
> | compilation terminated.
> | Build failed:  -> task failed (err #1):
> |     {task: cc tdbtorture.c -> tdbtorture_5.o}
> | make: *** [all] Error 1
> | WARNING: exit code 1 from a shell command.
> | ERROR: oe_runmake failed
> | ERROR: Function failed: do_compile
> NOTE: recipe libtdb-1.3.0-r0: task do_compile: Failed
>
> The problem seems to be a race with building libbsd (and unlucky
> timing in my build). Adding libbsd to DEPENDS fixes the problem.
>
> For some added context, libtdb uses a nonstandard ./configure from the
> Samba project based on a configuration utility called Waf that I'm a
> complete noob on. Perhaps there is some way to disable libbsd support
> instead.
>
> Cheers,
> Ulf

I also found this fix which doesn't seem to have been merged - seems to
be a similar issue, though for a different dependency:
http://lists.openembedded.org/pipermail/openembedded-devel/2015-November/104623.html


Cheers,
Ulf

Build failures due to libtdb racing with libbsd

[Ulf Magnusson]

Hello,

I get libtdb build failures like the following. The failing file
varies between runs.

ERROR: oe_runmake failed
ERROR: Function failed: do_compile
Log data follows:
| DEBUG: Executing shell function do_compile
| NOTE: make -j 16 -e MAKEFLAGS=
| WAF_MAKE=1 PATH=buildtools/bin:../../buildtools/bin:$PATH waf build
| Checking project rules ...
| Project rules pass
| [  1/100] Generating tdb.vscript
| [  2/100] Compiling lib/replace/replace.c
| [  3/100] Compiling lib/replace/cwrap.c
| [  4/100] Generating PKGCONFIG_tdb.pc
| [  5/100] Compiling lib/replace/replace.c
| [  6/100] Compiling lib/replace/test/testsuite.c
| [  7/100] Compiling lib/replace/test/strptime.c
| [  8/100] Compiling lib/replace/test/os2_delete.c
| [  9/100] Compiling lib/replace/test/getifaddrs.c
| [ 10/100] Compiling common/check.c
| [ 11/100] Compiling common/error.c
| [ 12/100] Compiling common/tdb.c
| [ 13/100] Compiling common/traverse.c
| [ 14/100] Compiling common/freelistcheck.c
| [ 15/100] Compiling common/lock.c
| [ 16/100] Compiling common/dump.c
| [ 17/100] Compiling common/freelist.c
| [ 18/100] Compiling common/io.c
| [ 19/100] Compiling common/open.c
| [ 20/100] Compiling common/transaction.c
| [ 21/100] Compiling common/hash.c
| [ 22/100] Compiling common/summary.c
| [ 23/100] Compiling common/rescue.c
| [ 24/100] Compiling common/mutex.c
| [ 25/100] Compiling tools/tdbtorture.c
| In file included from ../tools/tdbtorture.c:5:0:
| ../lib/replace/replace.h:151:24: fatal error: bsd/string.h: No such
file or directory
|  #include <bsd/string.h>
|                         ^
| compilation terminated.
| Build failed:  -> task failed (err #1):
|     {task: cc tdbtorture.c -> tdbtorture_5.o}
| make: *** [all] Error 1
| WARNING: exit code 1 from a shell command.
| ERROR: oe_runmake failed
| ERROR: Function failed: do_compile
NOTE: recipe libtdb-1.3.0-r0: task do_compile: Failed

The problem seems to be a race with building libbsd (and unlucky
timing in my build). Adding libbsd to DEPENDS fixes the problem.

For some added context, libtdb uses a nonstandard ./configure from the
Samba project based on a configuration utility called Waf that I'm a
complete noob on. Perhaps there is some way to disable libbsd support
instead.

Cheers,
Ulf