All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 -next] vdpa: mlx5: change Kconfig depends to fix build errors
@ 2020-09-17 19:45 ` Randy Dunlap
  0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2020-09-17 19:45 UTC (permalink / raw)
  To: virtualization, netdev, LKML, Stephen Rothwell,
	Michael S. Tsirkin, Jason Wang, Saeed Mahameed, Leon Romanovsky

From: Randy Dunlap <rdunlap@infradead.org>

drivers/vdpa/mlx5/ uses vhost_iotlb*() interfaces, so add a dependency
on VHOST to eliminate build errors.

ld: drivers/vdpa/mlx5/core/mr.o: in function `add_direct_chain':
mr.c:(.text+0x106): undefined reference to `vhost_iotlb_itree_first'
ld: mr.c:(.text+0x1cf): undefined reference to `vhost_iotlb_itree_next'
ld: mr.c:(.text+0x30d): undefined reference to `vhost_iotlb_itree_first'
ld: mr.c:(.text+0x3e8): undefined reference to `vhost_iotlb_itree_next'
ld: drivers/vdpa/mlx5/core/mr.o: in function `_mlx5_vdpa_create_mr':
mr.c:(.text+0x908): undefined reference to `vhost_iotlb_itree_first'
ld: mr.c:(.text+0x9e6): undefined reference to `vhost_iotlb_itree_next'
ld: drivers/vdpa/mlx5/core/mr.o: in function `mlx5_vdpa_handle_set_map':
mr.c:(.text+0xf1d): undefined reference to `vhost_iotlb_itree_first'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>
Cc: virtualization@lists.linux-foundation.org
Cc: Saeed Mahameed <saeedm@nvidia.com>
Cc: Leon Romanovsky <leonro@nvidia.com>
Cc: netdev@vger.kernel.org
---
v2: change from select to depends (Saeed)

 drivers/vdpa/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20200917.orig/drivers/vdpa/Kconfig
+++ linux-next-20200917/drivers/vdpa/Kconfig
@@ -31,7 +31,7 @@ config IFCVF
 
 config MLX5_VDPA
 	bool "MLX5 VDPA support library for ConnectX devices"
-	depends on MLX5_CORE
+	depends on VHOST && MLX5_CORE
 	default n
 	help
 	  Support library for Mellanox VDPA drivers. Provides code that is


^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH v2 -next] vdpa: mlx5: change Kconfig depends to fix build errors
@ 2020-09-17 19:45 ` Randy Dunlap
  0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2020-09-17 19:45 UTC (permalink / raw)
  To: virtualization, netdev, LKML, Stephen Rothwell,
	Michael S. Tsirkin, Jason Wang, Saeed Mahameed, Leon Romanovsky

From: Randy Dunlap <rdunlap@infradead.org>

drivers/vdpa/mlx5/ uses vhost_iotlb*() interfaces, so add a dependency
on VHOST to eliminate build errors.

ld: drivers/vdpa/mlx5/core/mr.o: in function `add_direct_chain':
mr.c:(.text+0x106): undefined reference to `vhost_iotlb_itree_first'
ld: mr.c:(.text+0x1cf): undefined reference to `vhost_iotlb_itree_next'
ld: mr.c:(.text+0x30d): undefined reference to `vhost_iotlb_itree_first'
ld: mr.c:(.text+0x3e8): undefined reference to `vhost_iotlb_itree_next'
ld: drivers/vdpa/mlx5/core/mr.o: in function `_mlx5_vdpa_create_mr':
mr.c:(.text+0x908): undefined reference to `vhost_iotlb_itree_first'
ld: mr.c:(.text+0x9e6): undefined reference to `vhost_iotlb_itree_next'
ld: drivers/vdpa/mlx5/core/mr.o: in function `mlx5_vdpa_handle_set_map':
mr.c:(.text+0xf1d): undefined reference to `vhost_iotlb_itree_first'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>
Cc: virtualization@lists.linux-foundation.org
Cc: Saeed Mahameed <saeedm@nvidia.com>
Cc: Leon Romanovsky <leonro@nvidia.com>
Cc: netdev@vger.kernel.org
---
v2: change from select to depends (Saeed)

 drivers/vdpa/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20200917.orig/drivers/vdpa/Kconfig
+++ linux-next-20200917/drivers/vdpa/Kconfig
@@ -31,7 +31,7 @@ config IFCVF
 
 config MLX5_VDPA
 	bool "MLX5 VDPA support library for ConnectX devices"
-	depends on MLX5_CORE
+	depends on VHOST && MLX5_CORE
 	default n
 	help
 	  Support library for Mellanox VDPA drivers. Provides code that is

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2 -next] vdpa: mlx5: change Kconfig depends to fix build errors
  2020-09-17 19:45 ` Randy Dunlap
@ 2020-09-18  2:16   ` Jason Wang
  -1 siblings, 0 replies; 4+ messages in thread
From: Jason Wang @ 2020-09-18  2:16 UTC (permalink / raw)
  To: Randy Dunlap, virtualization, netdev, LKML, Stephen Rothwell,
	Michael S. Tsirkin, Saeed Mahameed, Leon Romanovsky


On 2020/9/18 上午3:45, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> drivers/vdpa/mlx5/ uses vhost_iotlb*() interfaces, so add a dependency
> on VHOST to eliminate build errors.
>
> ld: drivers/vdpa/mlx5/core/mr.o: in function `add_direct_chain':
> mr.c:(.text+0x106): undefined reference to `vhost_iotlb_itree_first'
> ld: mr.c:(.text+0x1cf): undefined reference to `vhost_iotlb_itree_next'
> ld: mr.c:(.text+0x30d): undefined reference to `vhost_iotlb_itree_first'
> ld: mr.c:(.text+0x3e8): undefined reference to `vhost_iotlb_itree_next'
> ld: drivers/vdpa/mlx5/core/mr.o: in function `_mlx5_vdpa_create_mr':
> mr.c:(.text+0x908): undefined reference to `vhost_iotlb_itree_first'
> ld: mr.c:(.text+0x9e6): undefined reference to `vhost_iotlb_itree_next'
> ld: drivers/vdpa/mlx5/core/mr.o: in function `mlx5_vdpa_handle_set_map':
> mr.c:(.text+0xf1d): undefined reference to `vhost_iotlb_itree_first'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: virtualization@lists.linux-foundation.org
> Cc: Saeed Mahameed <saeedm@nvidia.com>
> Cc: Leon Romanovsky <leonro@nvidia.com>
> Cc: netdev@vger.kernel.org
> ---
> v2: change from select to depends (Saeed)
>
>   drivers/vdpa/Kconfig |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20200917.orig/drivers/vdpa/Kconfig
> +++ linux-next-20200917/drivers/vdpa/Kconfig
> @@ -31,7 +31,7 @@ config IFCVF
>   
>   config MLX5_VDPA
>   	bool "MLX5 VDPA support library for ConnectX devices"
> -	depends on MLX5_CORE
> +	depends on VHOST && MLX5_CORE


It looks to me that depending on VHOST is too heavyweight.

I guess what it really needs is VHOST_IOTLB. So we can use select 
VHOST_IOTLB here.

Thanks


>   	default n
>   	help
>   	  Support library for Mellanox VDPA drivers. Provides code that is
>


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2 -next] vdpa: mlx5: change Kconfig depends to fix build errors
@ 2020-09-18  2:16   ` Jason Wang
  0 siblings, 0 replies; 4+ messages in thread
From: Jason Wang @ 2020-09-18  2:16 UTC (permalink / raw)
  To: Randy Dunlap, virtualization, netdev, LKML, Stephen Rothwell,
	Michael S. Tsirkin, Saeed Mahameed, Leon Romanovsky


On 2020/9/18 上午3:45, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> drivers/vdpa/mlx5/ uses vhost_iotlb*() interfaces, so add a dependency
> on VHOST to eliminate build errors.
>
> ld: drivers/vdpa/mlx5/core/mr.o: in function `add_direct_chain':
> mr.c:(.text+0x106): undefined reference to `vhost_iotlb_itree_first'
> ld: mr.c:(.text+0x1cf): undefined reference to `vhost_iotlb_itree_next'
> ld: mr.c:(.text+0x30d): undefined reference to `vhost_iotlb_itree_first'
> ld: mr.c:(.text+0x3e8): undefined reference to `vhost_iotlb_itree_next'
> ld: drivers/vdpa/mlx5/core/mr.o: in function `_mlx5_vdpa_create_mr':
> mr.c:(.text+0x908): undefined reference to `vhost_iotlb_itree_first'
> ld: mr.c:(.text+0x9e6): undefined reference to `vhost_iotlb_itree_next'
> ld: drivers/vdpa/mlx5/core/mr.o: in function `mlx5_vdpa_handle_set_map':
> mr.c:(.text+0xf1d): undefined reference to `vhost_iotlb_itree_first'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: virtualization@lists.linux-foundation.org
> Cc: Saeed Mahameed <saeedm@nvidia.com>
> Cc: Leon Romanovsky <leonro@nvidia.com>
> Cc: netdev@vger.kernel.org
> ---
> v2: change from select to depends (Saeed)
>
>   drivers/vdpa/Kconfig |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20200917.orig/drivers/vdpa/Kconfig
> +++ linux-next-20200917/drivers/vdpa/Kconfig
> @@ -31,7 +31,7 @@ config IFCVF
>   
>   config MLX5_VDPA
>   	bool "MLX5 VDPA support library for ConnectX devices"
> -	depends on MLX5_CORE
> +	depends on VHOST && MLX5_CORE


It looks to me that depending on VHOST is too heavyweight.

I guess what it really needs is VHOST_IOTLB. So we can use select 
VHOST_IOTLB here.

Thanks


>   	default n
>   	help
>   	  Support library for Mellanox VDPA drivers. Provides code that is
>

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-18  2:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17 19:45 [PATCH v2 -next] vdpa: mlx5: change Kconfig depends to fix build errors Randy Dunlap
2020-09-17 19:45 ` Randy Dunlap
2020-09-18  2:16 ` Jason Wang
2020-09-18  2:16   ` Jason Wang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.