All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xilinx: zynqmp: increase CONFIG_SYS_SPL_MALLOC_SIZE to 16MB
@ 2021-07-06 23:43 Ricardo Salveti
  2021-07-07 10:07 ` Michal Simek
  0 siblings, 1 reply; 2+ messages in thread
From: Ricardo Salveti @ 2021-07-06 23:43 UTC (permalink / raw)
  To: u-boot; +Cc: michal.simek

commit 03f1f78a9b44 ("spl: fit: Prefer a malloc()'d buffer for loading
images")' changed the way buffer allocation worked for SPL to a more
flexible method.

For xilinx zynqmp the 1MB buffer is not necessarily enough when dealing
with complex fit images (e.g. containing FPGA/TF-A/OP-TEE/U-Boot
proper), which can easily reach up to 10MB, so increase the default
CONFIG_SYS_SPL_MALLOC_SIZE size to 16MB to cover more advanced
scenarios.

Signed-off-by: Ricardo Salveti <ricardo@foundries.io>
---
 include/configs/xilinx_zynqmp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/configs/xilinx_zynqmp.h b/include/configs/xilinx_zynqmp.h
index cadaf1a9631..bfe8a204279 100644
--- a/include/configs/xilinx_zynqmp.h
+++ b/include/configs/xilinx_zynqmp.h
@@ -261,7 +261,7 @@
 #endif
 
 #define CONFIG_SYS_SPL_MALLOC_START	0x20000000
-#define CONFIG_SYS_SPL_MALLOC_SIZE	0x100000
+#define CONFIG_SYS_SPL_MALLOC_SIZE	0x1000000
 
 #ifdef CONFIG_SPL_SYS_MALLOC_SIMPLE
 # error "Disable CONFIG_SPL_SYS_MALLOC_SIMPLE. Full malloc needs to be used"
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] xilinx: zynqmp: increase CONFIG_SYS_SPL_MALLOC_SIZE to 16MB
  2021-07-06 23:43 [PATCH] xilinx: zynqmp: increase CONFIG_SYS_SPL_MALLOC_SIZE to 16MB Ricardo Salveti
@ 2021-07-07 10:07 ` Michal Simek
  0 siblings, 0 replies; 2+ messages in thread
From: Michal Simek @ 2021-07-07 10:07 UTC (permalink / raw)
  To: Ricardo Salveti, u-boot; +Cc: michal.simek



On 7/7/21 1:43 AM, Ricardo Salveti wrote:
> commit 03f1f78a9b44 ("spl: fit: Prefer a malloc()'d buffer for loading
> images")' changed the way buffer allocation worked for SPL to a more
> flexible method.
> 
> For xilinx zynqmp the 1MB buffer is not necessarily enough when dealing
> with complex fit images (e.g. containing FPGA/TF-A/OP-TEE/U-Boot
> proper), which can easily reach up to 10MB, so increase the default
> CONFIG_SYS_SPL_MALLOC_SIZE size to 16MB to cover more advanced
> scenarios.
> 
> Signed-off-by: Ricardo Salveti <ricardo@foundries.io>
> ---
>  include/configs/xilinx_zynqmp.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/configs/xilinx_zynqmp.h b/include/configs/xilinx_zynqmp.h
> index cadaf1a9631..bfe8a204279 100644
> --- a/include/configs/xilinx_zynqmp.h
> +++ b/include/configs/xilinx_zynqmp.h
> @@ -261,7 +261,7 @@
>  #endif
>  
>  #define CONFIG_SYS_SPL_MALLOC_START	0x20000000
> -#define CONFIG_SYS_SPL_MALLOC_SIZE	0x100000
> +#define CONFIG_SYS_SPL_MALLOC_SIZE	0x1000000
>  
>  #ifdef CONFIG_SPL_SYS_MALLOC_SIMPLE
>  # error "Disable CONFIG_SPL_SYS_MALLOC_SIMPLE. Full malloc needs to be used"
> 

Applied.
M

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-07 10:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-06 23:43 [PATCH] xilinx: zynqmp: increase CONFIG_SYS_SPL_MALLOC_SIZE to 16MB Ricardo Salveti
2021-07-07 10:07 ` Michal Simek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.