* [PATCH] usb:dwc:core.h Fixed warning of documentation
@ 2023-03-29 3:29 ` Piyush Thange
0 siblings, 0 replies; 4+ messages in thread
From: Piyush Thange @ 2023-03-29 3:29 UTC (permalink / raw)
To: Thinh.Nguyen, gregkh, linux-usb, linux-kernel
Cc: linux-kernel-mentees, shuah, Piyush Thange
While compiling documentation a following warning is generated.
Function parameter or member 'resume_hs_terminations' not described
in 'dwc3'
One more warning arises in the same file as follows
Function parameter or member 'gfladj_refclk_lpm_sel' not described
in 'dwc3'
I need some insights on this.
Signed-off-by: Piyush Thange <pthange19@gmail.com>
---
drivers/usb/dwc3/core.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 582ebd9cf9c2..4743e918dcaf 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -1098,7 +1098,7 @@ struct dwc3_scratchpad_array {
* change quirk.
* @dis_tx_ipgap_linecheck_quirk: set if we disable u2mac linestate
* check during HS transmit.
- * @resume-hs-terminations: Set if we enable quirk for fixing improper crc
+ * @resume_hs_terminations: Set if we enable quirk for fixing improper crc
* generation after resume from suspend.
* @parkmode_disable_ss_quirk: set if we need to disable all SuperSpeed
* instances in park mode.
--
2.40.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] usb:dwc:core.h Fixed warning of documentation
@ 2023-03-29 3:29 ` Piyush Thange
0 siblings, 0 replies; 4+ messages in thread
From: Piyush Thange @ 2023-03-29 3:29 UTC (permalink / raw)
To: Thinh.Nguyen, gregkh, linux-usb, linux-kernel; +Cc: shuah, linux-kernel-mentees
While compiling documentation a following warning is generated.
Function parameter or member 'resume_hs_terminations' not described
in 'dwc3'
One more warning arises in the same file as follows
Function parameter or member 'gfladj_refclk_lpm_sel' not described
in 'dwc3'
I need some insights on this.
Signed-off-by: Piyush Thange <pthange19@gmail.com>
---
drivers/usb/dwc3/core.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 582ebd9cf9c2..4743e918dcaf 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -1098,7 +1098,7 @@ struct dwc3_scratchpad_array {
* change quirk.
* @dis_tx_ipgap_linecheck_quirk: set if we disable u2mac linestate
* check during HS transmit.
- * @resume-hs-terminations: Set if we enable quirk for fixing improper crc
+ * @resume_hs_terminations: Set if we enable quirk for fixing improper crc
* generation after resume from suspend.
* @parkmode_disable_ss_quirk: set if we need to disable all SuperSpeed
* instances in park mode.
--
2.40.0
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usb:dwc:core.h Fixed warning of documentation
2023-03-29 3:29 ` Piyush Thange
@ 2023-03-29 3:36 ` Randy Dunlap
-1 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2023-03-29 3:36 UTC (permalink / raw)
To: Piyush Thange, Thinh.Nguyen, gregkh, linux-usb, linux-kernel
Cc: linux-kernel-mentees, shuah
Hi--
On 3/28/23 20:29, Piyush Thange wrote:
> While compiling documentation a following warning is generated.
> Function parameter or member 'resume_hs_terminations' not described
> in 'dwc3'
This one appears to be fixed already.
> One more warning arises in the same file as follows
> Function parameter or member 'gfladj_refclk_lpm_sel' not described
> in 'dwc3'
>
> I need some insights on this.
The second one needs a line added, probably just after:
* @parkmode_disable_ss_quirk: set if we need to disable all SuperSpeed
* instances in park mode.
like
* @gfladj_refclk_lpm_sel: {some description here}
Thanks.
> Signed-off-by: Piyush Thange <pthange19@gmail.com>
> ---
> drivers/usb/dwc3/core.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index 582ebd9cf9c2..4743e918dcaf 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -1098,7 +1098,7 @@ struct dwc3_scratchpad_array {
> * change quirk.
> * @dis_tx_ipgap_linecheck_quirk: set if we disable u2mac linestate
> * check during HS transmit.
> - * @resume-hs-terminations: Set if we enable quirk for fixing improper crc
> + * @resume_hs_terminations: Set if we enable quirk for fixing improper crc
> * generation after resume from suspend.
> * @parkmode_disable_ss_quirk: set if we need to disable all SuperSpeed
> * instances in park mode.
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb:dwc:core.h Fixed warning of documentation
@ 2023-03-29 3:36 ` Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2023-03-29 3:36 UTC (permalink / raw)
To: Piyush Thange, Thinh.Nguyen, gregkh, linux-usb, linux-kernel
Cc: shuah, linux-kernel-mentees
Hi--
On 3/28/23 20:29, Piyush Thange wrote:
> While compiling documentation a following warning is generated.
> Function parameter or member 'resume_hs_terminations' not described
> in 'dwc3'
This one appears to be fixed already.
> One more warning arises in the same file as follows
> Function parameter or member 'gfladj_refclk_lpm_sel' not described
> in 'dwc3'
>
> I need some insights on this.
The second one needs a line added, probably just after:
* @parkmode_disable_ss_quirk: set if we need to disable all SuperSpeed
* instances in park mode.
like
* @gfladj_refclk_lpm_sel: {some description here}
Thanks.
> Signed-off-by: Piyush Thange <pthange19@gmail.com>
> ---
> drivers/usb/dwc3/core.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index 582ebd9cf9c2..4743e918dcaf 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -1098,7 +1098,7 @@ struct dwc3_scratchpad_array {
> * change quirk.
> * @dis_tx_ipgap_linecheck_quirk: set if we disable u2mac linestate
> * check during HS transmit.
> - * @resume-hs-terminations: Set if we enable quirk for fixing improper crc
> + * @resume_hs_terminations: Set if we enable quirk for fixing improper crc
> * generation after resume from suspend.
> * @parkmode_disable_ss_quirk: set if we need to disable all SuperSpeed
> * instances in park mode.
--
~Randy
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-29 3:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-29 3:29 [PATCH] usb:dwc:core.h Fixed warning of documentation Piyush Thange
2023-03-29 3:29 ` Piyush Thange
2023-03-29 3:36 ` Randy Dunlap
2023-03-29 3:36 ` Randy Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.