* [PATCH] fs: btrfs: Remove repeated struct declaration
@ 2021-04-01 8:03 Wan Jiabing
2021-04-01 9:15 ` Nikolay Borisov
2021-04-06 19:23 ` David Sterba
0 siblings, 2 replies; 3+ messages in thread
From: Wan Jiabing @ 2021-04-01 8:03 UTC (permalink / raw)
To: Chris Mason, Josef Bacik, David Sterba, linux-btrfs, linux-kernel
Cc: kael_w, Wan Jiabing
struct btrfs_inode is declared twice. One is declared at 67th line.
The blew declaration is not needed. Remove the duplicate.
struct btrfs_fs_info should be declared in the forward declarations.
Move it to the forward declarations.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
fs/btrfs/extent_io.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/btrfs/extent_io.h b/fs/btrfs/extent_io.h
index 824640cb0ace..227215a5722c 100644
--- a/fs/btrfs/extent_io.h
+++ b/fs/btrfs/extent_io.h
@@ -66,6 +66,7 @@ enum {
struct btrfs_root;
struct btrfs_inode;
struct btrfs_io_bio;
+struct btrfs_fs_info;
struct io_failure_record;
struct extent_io_tree;
@@ -270,9 +271,6 @@ struct bio *btrfs_io_bio_alloc(unsigned int nr_iovecs);
struct bio *btrfs_bio_clone(struct bio *bio);
struct bio *btrfs_bio_clone_partial(struct bio *orig, int offset, int size);
-struct btrfs_fs_info;
-struct btrfs_inode;
-
int repair_io_failure(struct btrfs_fs_info *fs_info, u64 ino, u64 start,
u64 length, u64 logical, struct page *page,
unsigned int pg_offset, int mirror_num);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fs: btrfs: Remove repeated struct declaration
2021-04-01 8:03 [PATCH] fs: btrfs: Remove repeated struct declaration Wan Jiabing
@ 2021-04-01 9:15 ` Nikolay Borisov
2021-04-06 19:23 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: Nikolay Borisov @ 2021-04-01 9:15 UTC (permalink / raw)
To: Wan Jiabing, Chris Mason, Josef Bacik, David Sterba, linux-btrfs,
linux-kernel
Cc: kael_w
On 1.04.21 г. 11:03, Wan Jiabing wrote:
> struct btrfs_inode is declared twice. One is declared at 67th line.
> The blew declaration is not needed. Remove the duplicate.
> struct btrfs_fs_info should be declared in the forward declarations.
> Move it to the forward declarations.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fs: btrfs: Remove repeated struct declaration
2021-04-01 8:03 [PATCH] fs: btrfs: Remove repeated struct declaration Wan Jiabing
2021-04-01 9:15 ` Nikolay Borisov
@ 2021-04-06 19:23 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: David Sterba @ 2021-04-06 19:23 UTC (permalink / raw)
To: Wan Jiabing
Cc: Chris Mason, Josef Bacik, David Sterba, linux-btrfs,
linux-kernel, kael_w
On Thu, Apr 01, 2021 at 04:03:39PM +0800, Wan Jiabing wrote:
> struct btrfs_inode is declared twice. One is declared at 67th line.
> The blew declaration is not needed. Remove the duplicate.
> struct btrfs_fs_info should be declared in the forward declarations.
> Move it to the forward declarations.
I've reworded the changelog a bit, patch added to misc-next, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-06 19:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-01 8:03 [PATCH] fs: btrfs: Remove repeated struct declaration Wan Jiabing
2021-04-01 9:15 ` Nikolay Borisov
2021-04-06 19:23 ` David Sterba
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.