All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] thermal: add dependency for THERMAL_DEFAULT_GOV_POWER_ALLOCATOR
@ 2019-12-10 20:41 Arnd Bergmann
  2019-12-10 20:49 ` Daniel Lezcano
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2019-12-10 20:41 UTC (permalink / raw)
  To: Daniel Lezcano, Zhang Rui, Eduardo Valentin
  Cc: Arnd Bergmann, Amit Kucheria, Viresh Kumar, linux-pm, linux-kernel

The THERMAL_GOV_POWER_ALLOCATOR symbol requires CONFIG_ENERGY_MODEL:

WARNING: unmet direct dependencies detected for THERMAL_GOV_POWER_ALLOCATOR
  Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n]
  Selected by [y]:
  - THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice>

Add this as a dependency for THERMAL_DEFAULT_GOV_POWER_ALLOCATOR to
avoid creating invalid configurations.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/thermal/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 59b79fc48266..712bcd668a4d 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -109,6 +109,7 @@ config THERMAL_DEFAULT_GOV_USER_SPACE
 config THERMAL_DEFAULT_GOV_POWER_ALLOCATOR
 	bool "power_allocator"
 	select THERMAL_GOV_POWER_ALLOCATOR
+	depends on ENERGY_MODEL
 	help
 	  Select this if you want to control temperature based on
 	  system and device power allocation. This governor can only
-- 
2.20.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] thermal: add dependency for THERMAL_DEFAULT_GOV_POWER_ALLOCATOR
  2019-12-10 20:41 [PATCH] thermal: add dependency for THERMAL_DEFAULT_GOV_POWER_ALLOCATOR Arnd Bergmann
@ 2019-12-10 20:49 ` Daniel Lezcano
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Lezcano @ 2019-12-10 20:49 UTC (permalink / raw)
  To: Arnd Bergmann, Zhang Rui, Eduardo Valentin
  Cc: Amit Kucheria, Viresh Kumar, linux-pm, linux-kernel

On 10/12/2019 21:41, Arnd Bergmann wrote:
> The THERMAL_GOV_POWER_ALLOCATOR symbol requires CONFIG_ENERGY_MODEL:
> 
> WARNING: unmet direct dependencies detected for THERMAL_GOV_POWER_ALLOCATOR
>   Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n]
>   Selected by [y]:
>   - THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice>
> 
> Add this as a dependency for THERMAL_DEFAULT_GOV_POWER_ALLOCATOR to
> avoid creating invalid configurations.

Hi Arnd,

thanks for the patch. The problem is already fixed.

  -- Daniel

-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-12-10 20:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-10 20:41 [PATCH] thermal: add dependency for THERMAL_DEFAULT_GOV_POWER_ALLOCATOR Arnd Bergmann
2019-12-10 20:49 ` Daniel Lezcano

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.