All of lore.kernel.org
 help / color / mirror / Atom feed
* [isar-cip-core] Build warning when SWUPDATE_BOOTLOAD != efibootguard
@ 2022-06-15 15:03 Bezdeka, Florian
  2022-06-15 20:39 ` Jan Kiszka
  0 siblings, 1 reply; 2+ messages in thread
From: Bezdeka, Florian @ 2022-06-15 15:03 UTC (permalink / raw)
  To: cip-dev; +Cc: Gylstorff, Quirin, jan.kiszka

Hi,

when trying to lift one of our internal ISAR layers to recent isar-cip-
core version I get the following build warning:

WARNING: /work/cip-core/recipes-core/swupdate-handler-
roundrobin/swupdate-handler-roundrobin_0.1.bb: 
Unable to get checksum for swupdate-handler-roundrobin SRC_URI entry
swupdate.handler.u-boot.ini: file could not be found

The swupdate-handler-roundrobin recipe (which is actually never used
here) has a SRC_URI modification (see [1]) that only works when
SWUPDATE_BOOTLOADER is set to efibootguard. For all other values there
is no guarantee that a downstream layer provides such a file.

Is there a way in bitbake to check if a file exists so that we could
add it conditionally to SRC_URI?

Changing the condition to 
	if d.getVar('SWUPDATE_BOOTLOADER') == 'efibootguard'
would require all downstream layers with SWUPDATE_BOOTLOADER !=
efibootguard to add the file manually to SRC_URI, so the pattern
introduced by SWUPDATE_ROUND_ROBIN_HANDLER_CONFIG breaks.

Any ideas?

Best regards,
Florian

[1] https://gitlab.com/cip-project/cip-core/isar-cip-core/-/blob/master/recipes-core/swupdate-handler-roundrobin/swupdate-handler-roundrobin_0.1.bb#L21

-- 
Siemens AG, T CED SES-DE
Corporate Competence Center Embedded Linux


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [isar-cip-core] Build warning when SWUPDATE_BOOTLOAD != efibootguard
  2022-06-15 15:03 [isar-cip-core] Build warning when SWUPDATE_BOOTLOAD != efibootguard Bezdeka, Florian
@ 2022-06-15 20:39 ` Jan Kiszka
  0 siblings, 0 replies; 2+ messages in thread
From: Jan Kiszka @ 2022-06-15 20:39 UTC (permalink / raw)
  To: Bezdeka, Florian (T CED SES-DE), cip-dev; +Cc: Gylstorff, Quirin (T CED SES-DE)

On 15.06.22 17:03, Bezdeka, Florian (T CED SES-DE) wrote:
> Hi,
> 
> when trying to lift one of our internal ISAR layers to recent isar-cip-
> core version I get the following build warning:
> 
> WARNING: /work/cip-core/recipes-core/swupdate-handler-
> roundrobin/swupdate-handler-roundrobin_0.1.bb:
> Unable to get checksum for swupdate-handler-roundrobin SRC_URI entry
> swupdate.handler.u-boot.ini: file could not be found
> 
> The swupdate-handler-roundrobin recipe (which is actually never used
> here) has a SRC_URI modification (see [1]) that only works when
> SWUPDATE_BOOTLOADER is set to efibootguard. For all other values there
> is no guarantee that a downstream layer provides such a file.
> 
> Is there a way in bitbake to check if a file exists so that we could
> add it conditionally to SRC_URI?
> 
> Changing the condition to
>         if d.getVar('SWUPDATE_BOOTLOADER') == 'efibootguard'
> would require all downstream layers with SWUPDATE_BOOTLOADER !=
> efibootguard to add the file manually to SRC_URI, so the pattern
> introduced by SWUPDATE_ROUND_ROBIN_HANDLER_CONFIG breaks.
> 
> Any ideas?
> 

I think we actually have to limit the SRC_URI to the cases we support,
and that is efibootguard for now. There is no such thing as a
if-file-exists entry, unfortunately.

Jan

PS: You likely want to have a look at the swupdate-handler-roundrobin
nevertheless. It may simplify your partition selection logic.

-- 
Siemens AG, Technology
Competence Center Embedded Linux


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-06-15 20:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-15 15:03 [isar-cip-core] Build warning when SWUPDATE_BOOTLOAD != efibootguard Bezdeka, Florian
2022-06-15 20:39 ` Jan Kiszka

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.