From: Mukesh Ojha <quic_mojha@quicinc.com>
To: <williamsukatube@163.com>, <tj@kernel.org>,
<lizefan.x@bytedance.com>, <hannes@cmpxchg.org>,
<cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] cgroup: simplify code in cgroup_apply_control
Date: Mon, 19 Sep 2022 16:19:10 +0530 [thread overview]
Message-ID: <22ef7722-2f60-688d-4cf0-f59f0272a293@quicinc.com> (raw)
In-Reply-To: <20220917084039.3177-1-williamsukatube@163.com>
Hi,
On 9/17/2022 2:10 PM, williamsukatube@163.com wrote:
> From: William Dean <williamsukatube@163.com>
>
> It could directly return 'cgroup_update_dfl_csses' to simplify code.
>
> Signed-off-by: William Dean <williamsukatube@163.com>
> ---
> kernel/cgroup/cgroup.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
> index e4bb5d57f4d1..1958f8bd93d6 100644
> --- a/kernel/cgroup/cgroup.c
> +++ b/kernel/cgroup/cgroup.c
> @@ -3292,11 +3292,7 @@ static int cgroup_apply_control(struct cgroup *cgrp)
> * making the following cgroup_update_dfl_csses() properly update
> * css associations of all tasks in the subtree.
> */
> - ret = cgroup_update_dfl_csses(cgrp);
> - if (ret)
> - return ret;
> -
> - return 0;
> + return cgroup_update_dfl_csses(cgrp);
> }
>
> /**
> --
> 2.25.1
>
LGTM.
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
-Mukesh
WARNING: multiple messages have this Message-ID (diff)
From: Mukesh Ojha <quic_mojha@quicinc.com>
To: williamsukatube@163.com, tj@kernel.org, lizefan.x@bytedance.com,
hannes@cmpxchg.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] cgroup: simplify code in cgroup_apply_control
Date: Mon, 19 Sep 2022 16:19:10 +0530 [thread overview]
Message-ID: <22ef7722-2f60-688d-4cf0-f59f0272a293@quicinc.com> (raw)
In-Reply-To: <20220917084039.3177-1-williamsukatube@163.com>
Hi,
On 9/17/2022 2:10 PM, williamsukatube@163.com wrote:
> From: William Dean <williamsukatube@163.com>
>
> It could directly return 'cgroup_update_dfl_csses' to simplify code.
>
> Signed-off-by: William Dean <williamsukatube@163.com>
> ---
> kernel/cgroup/cgroup.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
> index e4bb5d57f4d1..1958f8bd93d6 100644
> --- a/kernel/cgroup/cgroup.c
> +++ b/kernel/cgroup/cgroup.c
> @@ -3292,11 +3292,7 @@ static int cgroup_apply_control(struct cgroup *cgrp)
> * making the following cgroup_update_dfl_csses() properly update
> * css associations of all tasks in the subtree.
> */
> - ret = cgroup_update_dfl_csses(cgrp);
> - if (ret)
> - return ret;
> -
> - return 0;
> + return cgroup_update_dfl_csses(cgrp);
> }
>
> /**
> --
> 2.25.1
>
LGTM.
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
-Mukesh
next prev parent reply other threads:[~2022-09-19 10:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 8:40 [PATCH -next] cgroup: simplify code in cgroup_apply_control williamsukatube
2022-09-17 8:40 ` williamsukatube-9Onoh4P/yGk
2022-09-19 10:49 ` Mukesh Ojha [this message]
2022-09-19 10:49 ` Mukesh Ojha
2022-09-24 2:52 ` Tejun Heo
2022-09-24 2:52 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22ef7722-2f60-688d-4cf0-f59f0272a293@quicinc.com \
--to=quic_mojha@quicinc.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=tj@kernel.org \
--cc=williamsukatube@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.