All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH] libxc: don't fail domain creation when unpacking initrd fails
Date: Mon, 16 Oct 2017 16:45:52 +0100	[thread overview]
Message-ID: <23012.54320.887251.831620@mariner.uk.xensource.com> (raw)
In-Reply-To: <59E4EB5C0200007800186CF8@prv-mh.provo.novell.com>

Jan Beulich writes ("[PATCH] libxc: don't fail domain creation when unpacking initrd fails"):
> At least Linux kernels have been able to work with gzip-ed initrd for
> quite some time; initrd compressed with other methods aren't even being
> attempted to unpack. Furthermore the unzip-ing routine used here isn't
> capable of dealing with various forms of concatenated files, each of
> which was gzip-ed separately (it is this particular case which has been
> the source of observed VM creation failures).

I'm not sure I really like this approach of attempting to ungzip it
and then falling back.  (And the size-checking logic is not
particularly easy to follow.)

Is there no way to tell that a kernel supports gzipped initrds by
looking at the kernel ?  A heuristic would probably do: it's OK if we
sometimes insist on decompression ourselves, for a subset of old
kernels where it's not needed.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-10-16 16:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-16 15:24 [PATCH] libxc: don't fail domain creation when unpacking initrd fails Jan Beulich
2017-10-16 15:45 ` Ian Jackson [this message]
2017-10-16 16:19   ` Jan Beulich
2017-10-16 16:43     ` Ian Jackson
2017-10-17  6:28       ` Jan Beulich
2017-10-18 14:31       ` Jan Beulich
2017-10-19 15:06         ` Ian Jackson
2017-10-20 15:47           ` Jan Beulich
2017-10-16 16:48     ` Andrew Cooper
2017-10-16 17:01       ` Ian Jackson
2017-10-25  4:09       ` Doug Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23012.54320.887251.831620@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.