From: Doug Goldstein <cardoe@cardoe.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Jan Beulich <JBeulich@suse.com>,
Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH] libxc: don't fail domain creation when unpacking initrd fails
Date: Tue, 24 Oct 2017 23:09:43 -0500 [thread overview]
Message-ID: <f3fa7ea5-aa15-91ff-d7ce-133f91c188f2@cardoe.com> (raw)
In-Reply-To: <6a50108a-18ee-f589-4a0e-f6c6d7d6c72b@citrix.com>
On 10/16/17 11:48 AM, Andrew Cooper wrote:
> On 16/10/17 17:19, Jan Beulich wrote:
>>>>> On 16.10.17 at 17:45, <ian.jackson@eu.citrix.com> wrote:
>
> I've been bitten by this issue several times before, and a fix would be
> nice.
Same here.
>
> IMO, the toolstack should not be making assumptions about the initrd,
> and shouldn't be touching it. It is the users responsibility to provide
> an initrd which its kernel can read.
>
> Furthermore, leaving the decompression to the kernel reduces the dom0
> attack surface.
This. So many this. I do recall bringing this up at a meet up a while
back and the concern was breaking someone's workflow. Maybe we can put a
warning that the behavior is deprecated for X number of releases before
deleting it.
--
Doug Goldstein
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-10-25 4:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 15:24 [PATCH] libxc: don't fail domain creation when unpacking initrd fails Jan Beulich
2017-10-16 15:45 ` Ian Jackson
2017-10-16 16:19 ` Jan Beulich
2017-10-16 16:43 ` Ian Jackson
2017-10-17 6:28 ` Jan Beulich
2017-10-18 14:31 ` Jan Beulich
2017-10-19 15:06 ` Ian Jackson
2017-10-20 15:47 ` Jan Beulich
2017-10-16 16:48 ` Andrew Cooper
2017-10-16 17:01 ` Ian Jackson
2017-10-25 4:09 ` Doug Goldstein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3fa7ea5-aa15-91ff-d7ce-133f91c188f2@cardoe.com \
--to=cardoe@cardoe.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.