* [LTP] [PATCH 1/1] keyctl05: Require root
@ 2024-01-22 6:38 Petr Vorel
2024-01-22 11:17 ` Avinesh Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Petr Vorel @ 2024-01-22 6:38 UTC (permalink / raw)
To: ltp
Modprobe always require root.
Fixes: f4e132233 ("keyctl05: Add modprobe dns_resolver")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
I hate require root for setup work, but in this case is needed in order
to get dns_resolver tested. I'm sorry to forget on this.
Kind regards,
Petr
testcases/kernel/syscalls/keyctl/keyctl05.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/testcases/kernel/syscalls/keyctl/keyctl05.c b/testcases/kernel/syscalls/keyctl/keyctl05.c
index a79a5763b..78ac490da 100644
--- a/testcases/kernel/syscalls/keyctl/keyctl05.c
+++ b/testcases/kernel/syscalls/keyctl/keyctl05.c
@@ -228,6 +228,7 @@ static void do_test(unsigned int i)
}
static struct tst_test test = {
+ .needs_root = 1,
.tcnt = 3,
.setup = setup,
.test = do_test,
--
2.43.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH 1/1] keyctl05: Require root
2024-01-22 6:38 [LTP] [PATCH 1/1] keyctl05: Require root Petr Vorel
@ 2024-01-22 11:17 ` Avinesh Kumar
2024-01-22 13:31 ` Petr Vorel
0 siblings, 1 reply; 3+ messages in thread
From: Avinesh Kumar @ 2024-01-22 11:17 UTC (permalink / raw)
To: ltp
Hi,
Reviewed-by: Avinesh Kumar <akumar@suse.de>
On Monday, January 22, 2024 7:38:30 AM CET Petr Vorel wrote:
> Modprobe always require root.
>
> Fixes: f4e132233 ("keyctl05: Add modprobe dns_resolver")
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> I hate require root for setup work, but in this case is needed in order
> to get dns_resolver tested. I'm sorry to forget on this.
>
> Kind regards,
> Petr
>
> testcases/kernel/syscalls/keyctl/keyctl05.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/testcases/kernel/syscalls/keyctl/keyctl05.c
> b/testcases/kernel/syscalls/keyctl/keyctl05.c index a79a5763b..78ac490da
> 100644
> --- a/testcases/kernel/syscalls/keyctl/keyctl05.c
> +++ b/testcases/kernel/syscalls/keyctl/keyctl05.c
> @@ -228,6 +228,7 @@ static void do_test(unsigned int i)
> }
>
> static struct tst_test test = {
> + .needs_root = 1,
> .tcnt = 3,
> .setup = setup,
> .test = do_test,
Regards,
Avinesh
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH 1/1] keyctl05: Require root
2024-01-22 11:17 ` Avinesh Kumar
@ 2024-01-22 13:31 ` Petr Vorel
0 siblings, 0 replies; 3+ messages in thread
From: Petr Vorel @ 2024-01-22 13:31 UTC (permalink / raw)
To: Avinesh Kumar; +Cc: ltp
Hi Avinesh,
thanks for your review, merged.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-22 13:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-22 6:38 [LTP] [PATCH 1/1] keyctl05: Require root Petr Vorel
2024-01-22 11:17 ` Avinesh Kumar
2024-01-22 13:31 ` Petr Vorel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.