* [PATCH next] drm/msm/dp: add a missing unlock in dp_hpd_plug_handle()
@ 2023-12-04 17:13 ` Harshit Mogalapalli
0 siblings, 0 replies; 8+ messages in thread
From: Harshit Mogalapalli @ 2023-12-04 17:13 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, David Airlie, Daniel Vetter, Bjorn Andersson,
Kuogee Hsieh, Vinod Polimera, Stephen Boyd, linux-arm-msm,
dri-devel, freedreno, linux-kernel
Cc: harshit.m.mogalapalli, kernel-janitors, error27, dan.carpenter
When pm_runtime_resume_and_get() fails, unlock before returning.
Fixes: 5814b8bf086a ("drm/msm/dp: incorporate pm_runtime framework into DP driver")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
---
This is based on static analysis with Smatch. Only compile tested.
---
drivers/gpu/drm/msm/dp/dp_display.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index 61b7103498a7..b57ff6c3215d 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -569,6 +569,7 @@ static int dp_hpd_plug_handle(struct dp_display_private *dp, u32 data)
ret = pm_runtime_resume_and_get(&pdev->dev);
if (ret) {
DRM_ERROR("failed to pm_runtime_resume\n");
+ mutex_unlock(&dp->event_mutex);
return ret;
}
--
2.39.3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH next] drm/msm/dp: add a missing unlock in dp_hpd_plug_handle()
@ 2023-12-04 17:13 ` Harshit Mogalapalli
0 siblings, 0 replies; 8+ messages in thread
From: Harshit Mogalapalli @ 2023-12-04 17:13 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, David Airlie, Daniel Vetter, Bjorn Andersson,
Kuogee Hsieh, Vinod Polimera, Stephen Boyd, linux-arm-msm,
dri-devel, freedreno, linux-kernel
Cc: dan.carpenter, kernel-janitors, error27, harshit.m.mogalapalli
When pm_runtime_resume_and_get() fails, unlock before returning.
Fixes: 5814b8bf086a ("drm/msm/dp: incorporate pm_runtime framework into DP driver")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
---
This is based on static analysis with Smatch. Only compile tested.
---
drivers/gpu/drm/msm/dp/dp_display.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index 61b7103498a7..b57ff6c3215d 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -569,6 +569,7 @@ static int dp_hpd_plug_handle(struct dp_display_private *dp, u32 data)
ret = pm_runtime_resume_and_get(&pdev->dev);
if (ret) {
DRM_ERROR("failed to pm_runtime_resume\n");
+ mutex_unlock(&dp->event_mutex);
return ret;
}
--
2.39.3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH next] drm/msm/dp: add a missing unlock in dp_hpd_plug_handle()
2023-12-04 17:13 ` Harshit Mogalapalli
@ 2023-12-04 19:38 ` Dmitry Baryshkov
-1 siblings, 0 replies; 8+ messages in thread
From: Dmitry Baryshkov @ 2023-12-04 19:38 UTC (permalink / raw)
To: Harshit Mogalapalli
Cc: Rob Clark, Abhinav Kumar, Sean Paul, Marijn Suijten,
David Airlie, Daniel Vetter, Bjorn Andersson, Kuogee Hsieh,
Vinod Polimera, Stephen Boyd, linux-arm-msm, dri-devel,
freedreno, linux-kernel, dan.carpenter, kernel-janitors, error27
On Mon, 4 Dec 2023 at 19:13, Harshit Mogalapalli
<harshit.m.mogalapalli@oracle.com> wrote:
>
> When pm_runtime_resume_and_get() fails, unlock before returning.
>
> Fixes: 5814b8bf086a ("drm/msm/dp: incorporate pm_runtime framework into DP driver")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> ---
> This is based on static analysis with Smatch. Only compile tested.
> ---
> drivers/gpu/drm/msm/dp/dp_display.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH next] drm/msm/dp: add a missing unlock in dp_hpd_plug_handle()
@ 2023-12-04 19:38 ` Dmitry Baryshkov
0 siblings, 0 replies; 8+ messages in thread
From: Dmitry Baryshkov @ 2023-12-04 19:38 UTC (permalink / raw)
To: Harshit Mogalapalli
Cc: freedreno, Bjorn Andersson, error27, Stephen Boyd,
kernel-janitors, Abhinav Kumar, dri-devel, Kuogee Hsieh,
dan.carpenter, linux-arm-msm, Marijn Suijten, Vinod Polimera,
Sean Paul, linux-kernel
On Mon, 4 Dec 2023 at 19:13, Harshit Mogalapalli
<harshit.m.mogalapalli@oracle.com> wrote:
>
> When pm_runtime_resume_and_get() fails, unlock before returning.
>
> Fixes: 5814b8bf086a ("drm/msm/dp: incorporate pm_runtime framework into DP driver")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> ---
> This is based on static analysis with Smatch. Only compile tested.
> ---
> drivers/gpu/drm/msm/dp/dp_display.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH next] drm/msm/dp: add a missing unlock in dp_hpd_plug_handle()
2023-12-04 17:13 ` Harshit Mogalapalli
@ 2023-12-04 19:45 ` Dmitry Baryshkov
-1 siblings, 0 replies; 8+ messages in thread
From: Dmitry Baryshkov @ 2023-12-04 19:45 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Sean Paul, Marijn Suijten,
David Airlie, Daniel Vetter, Bjorn Andersson, Kuogee Hsieh,
Vinod Polimera, Stephen Boyd, linux-arm-msm, dri-devel,
freedreno, linux-kernel, Harshit Mogalapalli
Cc: dan.carpenter, kernel-janitors, error27
On Mon, 04 Dec 2023 09:13:14 -0800, Harshit Mogalapalli wrote:
> When pm_runtime_resume_and_get() fails, unlock before returning.
>
>
Applied, thanks!
[1/1] drm/msm/dp: add a missing unlock in dp_hpd_plug_handle()
https://gitlab.freedesktop.org/lumag/msm/-/commit/801207c18834
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH next] drm/msm/dp: add a missing unlock in dp_hpd_plug_handle()
@ 2023-12-04 19:45 ` Dmitry Baryshkov
0 siblings, 0 replies; 8+ messages in thread
From: Dmitry Baryshkov @ 2023-12-04 19:45 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Sean Paul, Marijn Suijten,
David Airlie, Daniel Vetter, Bjorn Andersson, Kuogee Hsieh,
Vinod Polimera, Stephen Boyd, linux-arm-msm, dri-devel,
freedreno, linux-kernel, Harshit Mogalapalli
Cc: kernel-janitors, error27, dan.carpenter
On Mon, 04 Dec 2023 09:13:14 -0800, Harshit Mogalapalli wrote:
> When pm_runtime_resume_and_get() fails, unlock before returning.
>
>
Applied, thanks!
[1/1] drm/msm/dp: add a missing unlock in dp_hpd_plug_handle()
https://gitlab.freedesktop.org/lumag/msm/-/commit/801207c18834
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Freedreno] [PATCH next] drm/msm/dp: add a missing unlock in dp_hpd_plug_handle()
2023-12-04 17:13 ` Harshit Mogalapalli
@ 2023-12-04 20:25 ` Abhinav Kumar
-1 siblings, 0 replies; 8+ messages in thread
From: Abhinav Kumar @ 2023-12-04 20:25 UTC (permalink / raw)
To: Harshit Mogalapalli, Rob Clark, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, David Airlie, Daniel Vetter, Bjorn Andersson,
Kuogee Hsieh, Vinod Polimera, Stephen Boyd, linux-arm-msm,
dri-devel, freedreno, linux-kernel
Cc: kernel-janitors, error27, dan.carpenter
On 12/4/2023 9:13 AM, Harshit Mogalapalli wrote:
> When pm_runtime_resume_and_get() fails, unlock before returning.
>
> Fixes: 5814b8bf086a ("drm/msm/dp: incorporate pm_runtime framework into DP driver")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> ---
> This is based on static analysis with Smatch. Only compile tested.
> ---
> drivers/gpu/drm/msm/dp/dp_display.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Freedreno] [PATCH next] drm/msm/dp: add a missing unlock in dp_hpd_plug_handle()
@ 2023-12-04 20:25 ` Abhinav Kumar
0 siblings, 0 replies; 8+ messages in thread
From: Abhinav Kumar @ 2023-12-04 20:25 UTC (permalink / raw)
To: Harshit Mogalapalli, Rob Clark, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, David Airlie, Daniel Vetter, Bjorn Andersson,
Kuogee Hsieh, Vinod Polimera, Stephen Boyd, linux-arm-msm,
dri-devel, freedreno, linux-kernel
Cc: kernel-janitors, error27, dan.carpenter
On 12/4/2023 9:13 AM, Harshit Mogalapalli wrote:
> When pm_runtime_resume_and_get() fails, unlock before returning.
>
> Fixes: 5814b8bf086a ("drm/msm/dp: incorporate pm_runtime framework into DP driver")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> ---
> This is based on static analysis with Smatch. Only compile tested.
> ---
> drivers/gpu/drm/msm/dp/dp_display.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-12-04 20:26 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-04 17:13 [PATCH next] drm/msm/dp: add a missing unlock in dp_hpd_plug_handle() Harshit Mogalapalli
2023-12-04 17:13 ` Harshit Mogalapalli
2023-12-04 19:38 ` Dmitry Baryshkov
2023-12-04 19:38 ` Dmitry Baryshkov
2023-12-04 19:45 ` Dmitry Baryshkov
2023-12-04 19:45 ` Dmitry Baryshkov
2023-12-04 20:25 ` [Freedreno] " Abhinav Kumar
2023-12-04 20:25 ` Abhinav Kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.