* NFS: regression in stable kernel 4.9.78 from 4.9.75 @ 2018-01-29 12:22 Wolfgang Walter 2018-01-29 12:37 ` Greg KH 2018-01-29 13:42 ` Wolfgang Walter 0 siblings, 2 replies; 5+ messages in thread From: Wolfgang Walter @ 2018-01-29 12:22 UTC (permalink / raw) To: stable Hello, after upgrading our nfs-server from 4.9.75 to 4.9.78 group permissions stop working (for clients). If you need group permissions to access a file or directory, sometimes access is granted, but rather often denied. Often access to the same object is denied within seconds after access was granted in an earlier access. user permissions work fine. Downgrading to 4.9.75 fixes the issue. We use kerberos. Regards, -- Wolfgang Walter Studentenwerk M�nchen Anstalt des �ffentlichen Rechts ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: NFS: regression in stable kernel 4.9.78 from 4.9.75 2018-01-29 12:22 NFS: regression in stable kernel 4.9.78 from 4.9.75 Wolfgang Walter @ 2018-01-29 12:37 ` Greg KH 2018-01-29 13:42 ` Wolfgang Walter 1 sibling, 0 replies; 5+ messages in thread From: Greg KH @ 2018-01-29 12:37 UTC (permalink / raw) To: Wolfgang Walter; +Cc: stable On Mon, Jan 29, 2018 at 01:22:49PM +0100, Wolfgang Walter wrote: > Hello, > > after upgrading our nfs-server from 4.9.75 to 4.9.78 group permissions stop > working (for clients). If you need group permissions to access a file or > directory, sometimes access is granted, but rather often denied. Often access > to the same object is denied within seconds after access was granted in an > earlier access. user permissions work fine. > > Downgrading to 4.9.75 fixes the issue. Any chance you can use 'git bisect' to find the offending commit? And also, does 4.14 work properly for you? 4.15? thanks, greg k-h ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: NFS: regression in stable kernel 4.9.78 from 4.9.75 2018-01-29 12:22 NFS: regression in stable kernel 4.9.78 from 4.9.75 Wolfgang Walter @ 2018-01-29 13:42 ` Wolfgang Walter 2018-01-29 13:42 ` Wolfgang Walter 1 sibling, 0 replies; 5+ messages in thread From: Wolfgang Walter @ 2018-01-29 13:42 UTC (permalink / raw) To: stable; +Cc: gregkh, Ben Hutchings, linux-kernel Hello! Am Montag, 29. Januar 2018, 13:22:49 schrieb Wolfgang Walter: > Hello, > > after upgrading our nfs-server from 4.9.75 to 4.9.78 group permissions stop > working (for clients). If you need group permissions to access a file or > directory, sometimes access is granted, but rather often denied. Often > access to the same object is denied within seconds after access was granted > in an earlier access. user permissions work fine. > > Downgrading to 4.9.75 fixes the issue. > > We use kerberos. > > Regards, This seems to be fixed in 4.15 with commit 1995266727fa8143897e89b55f5d3c79aa828420: commit 1995266727fa8143897e89b55f5d3c79aa828420 Author: Ben Hutchings <ben.hutchings@codethink.co.uk> Date: Mon Jan 22 20:11:06 2018 +0000 nfsd: auth: Fix gid sorting when rootsquash enabled Commit bdcf0a423ea1 ("kernel: make groups_sort calling a responsibility group_info allocators") appears to break nfsd rootsquash in a pretty major way. It adds a call to groups_sort() inside the loop that copies/squashes gids, which means the valid gids are sorted along with the following garbage. The net result is that the highest numbered valid gids are replaced with any lower-valued garbage gids, possibly including 0. We should sort only once, after filling in all the gids. Fixes: bdcf0a423ea1 ("kernel: make groups_sort calling a responsibility ...") Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk> Acked-by: J. Bruce Fields <bfields@redhat.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> So this should be applied to stables 4.4, 4.9 and 4.14 (and others where bdcf0a423ea1 has been backported to). Regards, -- Wolfgang Walter Studentenwerk München Anstalt des öffentlichen Rechts ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: NFS: regression in stable kernel 4.9.78 from 4.9.75 @ 2018-01-29 13:42 ` Wolfgang Walter 0 siblings, 0 replies; 5+ messages in thread From: Wolfgang Walter @ 2018-01-29 13:42 UTC (permalink / raw) To: stable; +Cc: gregkh, Ben Hutchings, linux-kernel Hello! Am Montag, 29. Januar 2018, 13:22:49 schrieb Wolfgang Walter: > Hello, > > after upgrading our nfs-server from 4.9.75 to 4.9.78 group permissions stop > working (for clients). If you need group permissions to access a file or > directory, sometimes access is granted, but rather often denied. Often > access to the same object is denied within seconds after access was granted > in an earlier access. user permissions work fine. > > Downgrading to 4.9.75 fixes the issue. > > We use kerberos. > > Regards, This seems to be fixed in 4.15 with commit 1995266727fa8143897e89b55f5d3c79aa828420: commit 1995266727fa8143897e89b55f5d3c79aa828420 Author: Ben Hutchings <ben.hutchings@codethink.co.uk> Date: Mon Jan 22 20:11:06 2018 +0000 nfsd: auth: Fix gid sorting when rootsquash enabled Commit bdcf0a423ea1 ("kernel: make groups_sort calling a responsibility group_info allocators") appears to break nfsd rootsquash in a pretty major way. It adds a call to groups_sort() inside the loop that copies/squashes gids, which means the valid gids are sorted along with the following garbage. The net result is that the highest numbered valid gids are replaced with any lower-valued garbage gids, possibly including 0. We should sort only once, after filling in all the gids. Fixes: bdcf0a423ea1 ("kernel: make groups_sort calling a responsibility ...") Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk> Acked-by: J. Bruce Fields <bfields@redhat.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> So this should be applied to stables 4.4, 4.9 and 4.14 (and others where bdcf0a423ea1 has been backported to). Regards, -- Wolfgang Walter Studentenwerk M�nchen Anstalt des �ffentlichen Rechts ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: NFS: regression in stable kernel 4.9.78 from 4.9.75 2018-01-29 13:42 ` Wolfgang Walter (?) @ 2018-01-29 13:54 ` Greg KH -1 siblings, 0 replies; 5+ messages in thread From: Greg KH @ 2018-01-29 13:54 UTC (permalink / raw) To: Wolfgang Walter; +Cc: stable, Ben Hutchings, linux-kernel On Mon, Jan 29, 2018 at 02:42:49PM +0100, Wolfgang Walter wrote: > Hello! > > Am Montag, 29. Januar 2018, 13:22:49 schrieb Wolfgang Walter: > > Hello, > > > > after upgrading our nfs-server from 4.9.75 to 4.9.78 group permissions stop > > working (for clients). If you need group permissions to access a file or > > directory, sometimes access is granted, but rather often denied. Often > > access to the same object is denied within seconds after access was granted > > in an earlier access. user permissions work fine. > > > > Downgrading to 4.9.75 fixes the issue. > > > > We use kerberos. > > > > Regards, > > This seems to be fixed in 4.15 with commit > 1995266727fa8143897e89b55f5d3c79aa828420: > > > commit 1995266727fa8143897e89b55f5d3c79aa828420 > Author: Ben Hutchings <ben.hutchings@codethink.co.uk> > Date: Mon Jan 22 20:11:06 2018 +0000 > > nfsd: auth: Fix gid sorting when rootsquash enabled > > Commit bdcf0a423ea1 ("kernel: make groups_sort calling a responsibility > group_info allocators") appears to break nfsd rootsquash in a pretty > major way. > > It adds a call to groups_sort() inside the loop that copies/squashes > gids, which means the valid gids are sorted along with the following > garbage. The net result is that the highest numbered valid gids are > replaced with any lower-valued garbage gids, possibly including 0. > > We should sort only once, after filling in all the gids. > > Fixes: bdcf0a423ea1 ("kernel: make groups_sort calling a responsibility > ...") > Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk> > Acked-by: J. Bruce Fields <bfields@redhat.com> > Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> > > > So this should be applied to stables 4.4, 4.9 and 4.14 (and others where > bdcf0a423ea1 has been backported to). Ah, good catch, I missed that this had been merged already. Now queued up to all relevant stable trees, thanks so much for the report. greg k-h ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-29 20:15 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-01-29 12:22 NFS: regression in stable kernel 4.9.78 from 4.9.75 Wolfgang Walter 2018-01-29 12:37 ` Greg KH 2018-01-29 13:42 ` Wolfgang Walter 2018-01-29 13:42 ` Wolfgang Walter 2018-01-29 13:54 ` Greg KH
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.