* [PATCH net] net: hns3: Fix a logical vs bitwise typo
@ 2019-03-06 8:12 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2019-03-06 8:12 UTC (permalink / raw)
To: Yisen Zhuang, Yunsheng Lin
Cc: Salil Mehta, David S. Miller, netdev, kernel-janitors
There were a couple logical ORs accidentally mixed in with the bitwise
ORs.
Fixes: e8149933b1fa ("net: hns3: remove hnae3_get_bit in data path")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Very recent bug.
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
index 3cb43b1f1c2e..1e4efc47c7a5 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
@@ -2321,8 +2321,8 @@ static void hns3_rx_checksum(struct hns3_enet_ring *ring, struct sk_buff *skb,
if (!(bd_base_info & BIT(HNS3_RXD_L3L4P_B)))
return;
- if (unlikely(l234info & (BIT(HNS3_RXD_L3E_B) | BIT(HNS3_RXD_L4E_B) ||
- BIT(HNS3_RXD_OL3E_B) ||
+ if (unlikely(l234info & (BIT(HNS3_RXD_L3E_B) | BIT(HNS3_RXD_L4E_B) |
+ BIT(HNS3_RXD_OL3E_B) |
BIT(HNS3_RXD_OL4E_B)))) {
u64_stats_update_begin(&ring->syncp);
ring->stats.l3l4_csum_err++;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH net] net: hns3: Fix a logical vs bitwise typo
@ 2019-03-06 8:12 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2019-03-06 8:12 UTC (permalink / raw)
To: Yisen Zhuang, Yunsheng Lin
Cc: Salil Mehta, David S. Miller, netdev, kernel-janitors
There were a couple logical ORs accidentally mixed in with the bitwise
ORs.
Fixes: e8149933b1fa ("net: hns3: remove hnae3_get_bit in data path")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Very recent bug.
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
index 3cb43b1f1c2e..1e4efc47c7a5 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
@@ -2321,8 +2321,8 @@ static void hns3_rx_checksum(struct hns3_enet_ring *ring, struct sk_buff *skb,
if (!(bd_base_info & BIT(HNS3_RXD_L3L4P_B)))
return;
- if (unlikely(l234info & (BIT(HNS3_RXD_L3E_B) | BIT(HNS3_RXD_L4E_B) ||
- BIT(HNS3_RXD_OL3E_B) ||
+ if (unlikely(l234info & (BIT(HNS3_RXD_L3E_B) | BIT(HNS3_RXD_L4E_B) |
+ BIT(HNS3_RXD_OL3E_B) |
BIT(HNS3_RXD_OL4E_B)))) {
u64_stats_update_begin(&ring->syncp);
ring->stats.l3l4_csum_err++;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net] net: hns3: Fix a logical vs bitwise typo
2019-03-06 8:12 ` Dan Carpenter
@ 2019-03-06 9:13 ` Yunsheng Lin
-1 siblings, 0 replies; 6+ messages in thread
From: Yunsheng Lin @ 2019-03-06 9:13 UTC (permalink / raw)
To: Dan Carpenter, Yisen Zhuang
Cc: Salil Mehta, David S. Miller, netdev, kernel-janitors
On 2019/3/6 16:12, Dan Carpenter wrote:
> There were a couple logical ORs accidentally mixed in with the bitwise
> ORs.
Thanks for the fix.
Reviewed-by: Yunsheng Lin <linyunsheng@huawei.com>
>
> Fixes: e8149933b1fa ("net: hns3: remove hnae3_get_bit in data path")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Very recent bug.
>
> drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> index 3cb43b1f1c2e..1e4efc47c7a5 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> @@ -2321,8 +2321,8 @@ static void hns3_rx_checksum(struct hns3_enet_ring *ring, struct sk_buff *skb,
> if (!(bd_base_info & BIT(HNS3_RXD_L3L4P_B)))
> return;
>
> - if (unlikely(l234info & (BIT(HNS3_RXD_L3E_B) | BIT(HNS3_RXD_L4E_B) ||
> - BIT(HNS3_RXD_OL3E_B) ||
> + if (unlikely(l234info & (BIT(HNS3_RXD_L3E_B) | BIT(HNS3_RXD_L4E_B) |
> + BIT(HNS3_RXD_OL3E_B) |
> BIT(HNS3_RXD_OL4E_B)))) {
> u64_stats_update_begin(&ring->syncp);
> ring->stats.l3l4_csum_err++;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] net: hns3: Fix a logical vs bitwise typo
@ 2019-03-06 9:13 ` Yunsheng Lin
0 siblings, 0 replies; 6+ messages in thread
From: Yunsheng Lin @ 2019-03-06 9:13 UTC (permalink / raw)
To: Dan Carpenter, Yisen Zhuang
Cc: Salil Mehta, David S. Miller, netdev, kernel-janitors
On 2019/3/6 16:12, Dan Carpenter wrote:
> There were a couple logical ORs accidentally mixed in with the bitwise
> ORs.
Thanks for the fix.
Reviewed-by: Yunsheng Lin <linyunsheng@huawei.com>
>
> Fixes: e8149933b1fa ("net: hns3: remove hnae3_get_bit in data path")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Very recent bug.
>
> drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> index 3cb43b1f1c2e..1e4efc47c7a5 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> @@ -2321,8 +2321,8 @@ static void hns3_rx_checksum(struct hns3_enet_ring *ring, struct sk_buff *skb,
> if (!(bd_base_info & BIT(HNS3_RXD_L3L4P_B)))
> return;
>
> - if (unlikely(l234info & (BIT(HNS3_RXD_L3E_B) | BIT(HNS3_RXD_L4E_B) ||
> - BIT(HNS3_RXD_OL3E_B) ||
> + if (unlikely(l234info & (BIT(HNS3_RXD_L3E_B) | BIT(HNS3_RXD_L4E_B) |
> + BIT(HNS3_RXD_OL3E_B) |
> BIT(HNS3_RXD_OL4E_B)))) {
> u64_stats_update_begin(&ring->syncp);
> ring->stats.l3l4_csum_err++;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] net: hns3: Fix a logical vs bitwise typo
2019-03-06 8:12 ` Dan Carpenter
@ 2019-03-06 18:38 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2019-03-06 18:38 UTC (permalink / raw)
To: dan.carpenter
Cc: yisen.zhuang, linyunsheng, salil.mehta, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 6 Mar 2019 11:12:34 +0300
> There were a couple logical ORs accidentally mixed in with the bitwise
> ORs.
>
> Fixes: e8149933b1fa ("net: hns3: remove hnae3_get_bit in data path")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Very recent bug.
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] net: hns3: Fix a logical vs bitwise typo
@ 2019-03-06 18:38 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2019-03-06 18:38 UTC (permalink / raw)
To: dan.carpenter
Cc: yisen.zhuang, linyunsheng, salil.mehta, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 6 Mar 2019 11:12:34 +0300
> There were a couple logical ORs accidentally mixed in with the bitwise
> ORs.
>
> Fixes: e8149933b1fa ("net: hns3: remove hnae3_get_bit in data path")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Very recent bug.
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-06 18:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-06 8:12 [PATCH net] net: hns3: Fix a logical vs bitwise typo Dan Carpenter
2019-03-06 8:12 ` Dan Carpenter
2019-03-06 9:13 ` Yunsheng Lin
2019-03-06 9:13 ` Yunsheng Lin
2019-03-06 18:38 ` David Miller
2019-03-06 18:38 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.