[PATCH v2 1/1] drm: panel-simple: add missing bus flags for Tianma tm070jvhg[30/33]

[PATCH v2 1/1] drm: panel-simple: add missing bus flags for Tianma tm070jvhg[30/33]

[Alexander Stein]

From: Markus Niebel <Markus.Niebel@ew.tq-group.com>

The DE signal is active high on this display, fill in the missing
bus_flags. This aligns panel_desc with its display_timing.

Fixes: 9a2654c0f62a ("drm/panel: Add and fill drm_panel type field")
Fixes: b3bfcdf8a3b6 ("drm/panel: simple: add Tianma TM070JVHG33")

Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
---
Changes in v2:
* Collected Sam's R-b

 drivers/gpu/drm/panel/panel-simple.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 07c627de70534..b5b79f1789519 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -3867,6 +3867,7 @@ static const struct panel_desc tianma_tm070jdhg30 = {
 	},
 	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
 	.connector_type = DRM_MODE_CONNECTOR_LVDS,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
 };
 
 static const struct panel_desc tianma_tm070jvhg33 = {
@@ -3879,6 +3880,7 @@ static const struct panel_desc tianma_tm070jvhg33 = {
 	},
 	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
 	.connector_type = DRM_MODE_CONNECTOR_LVDS,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
 };
 
 static const struct display_timing tianma_tm070rvhg71_timing = {
-- 
2.34.1

Re: [PATCH v2 1/1] drm: panel-simple: add missing bus flags for Tianma tm070jvhg[30/33]

[Alexander Stein]

Hi,

is there something missing? Or can someone pick this?

Thanks
Alexander

Am Donnerstag, 12. Oktober 2023, 10:42:08 CET schrieb Alexander Stein:
> From: Markus Niebel <Markus.Niebel@ew.tq-group.com>
> 
> The DE signal is active high on this display, fill in the missing
> bus_flags. This aligns panel_desc with its display_timing.
> 
> Fixes: 9a2654c0f62a ("drm/panel: Add and fill drm_panel type field")
> Fixes: b3bfcdf8a3b6 ("drm/panel: simple: add Tianma TM070JVHG33")
> 
> Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> Changes in v2:
> * Collected Sam's R-b
> 
>  drivers/gpu/drm/panel/panel-simple.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c
> b/drivers/gpu/drm/panel/panel-simple.c index 07c627de70534..b5b79f1789519
> 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -3867,6 +3867,7 @@ static const struct panel_desc tianma_tm070jdhg30 = {
>  	},
>  	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
>  	.connector_type = DRM_MODE_CONNECTOR_LVDS,
> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
>  };
> 
>  static const struct panel_desc tianma_tm070jvhg33 = {
> @@ -3879,6 +3880,7 @@ static const struct panel_desc tianma_tm070jvhg33 = {
>  	},
>  	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
>  	.connector_type = DRM_MODE_CONNECTOR_LVDS,
> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
>  };
> 
>  static const struct display_timing tianma_tm070rvhg71_timing = {


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/

Re: [PATCH v2 1/1] drm: panel-simple: add missing bus flags for Tianma tm070jvhg[30/33]

[Neil Armstrong]

Hi,

On Thu, 12 Oct 2023 10:42:08 +0200, Alexander Stein wrote:
> The DE signal is active high on this display, fill in the missing
> bus_flags. This aligns panel_desc with its display_timing.
> 
> Fixes: 9a2654c0f62a ("drm/panel: Add and fill drm_panel type field")
> Fixes: b3bfcdf8a3b6 ("drm/panel: simple: add Tianma TM070JVHG33")
> 
> 
> [...]

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes)

[1/1] drm: panel-simple: add missing bus flags for Tianma tm070jvhg[30/33]
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=45dd7df26cee741b31c25ffdd44fb8794eb45ccd

-- 
Neil