* [PATCH v2] mtd: omap_elm: print interrupt resource using %pr
@ 2015-12-18 13:15 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2015-12-18 13:15 UTC (permalink / raw)
To: Brian Norris
Cc: Tony Lindgren, linux-kernel, linux-mtd, linux-omap,
David Woodhouse, linux-arm-kernel, Roger Quadros
When CONFIG_LPAE is set on ARM, resource_size_t is 64-bit wide
and we get a warning about an incorrect format string for printing
the interrupt number in elm_probe:
drivers/mtd/nand/omap_elm.c: In function 'elm_probe':
drivers/mtd/nand/omap_elm.c:417:23: warning: format '%i' expects argument of type 'int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
This patch avoids the type mismatch by printing the interrupt as
a resource using the %pr format string.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
v2: pass correct pointer
diff --git a/drivers/mtd/nand/omap_elm.c b/drivers/mtd/nand/omap_elm.c
index 235ec7992b4c..a3f32f939cc1 100644
--- a/drivers/mtd/nand/omap_elm.c
+++ b/drivers/mtd/nand/omap_elm.c
@@ -414,7 +414,7 @@ static int elm_probe(struct platform_device *pdev)
ret = devm_request_irq(&pdev->dev, irq->start, elm_isr, 0,
pdev->name, info);
if (ret) {
- dev_err(&pdev->dev, "failure requesting irq %i\n", irq->start);
+ dev_err(&pdev->dev, "failure requesting %pr\n", irq);
return ret;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] mtd: omap_elm: print interrupt resource using %pr
@ 2015-12-18 13:15 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2015-12-18 13:15 UTC (permalink / raw)
To: linux-arm-kernel
When CONFIG_LPAE is set on ARM, resource_size_t is 64-bit wide
and we get a warning about an incorrect format string for printing
the interrupt number in elm_probe:
drivers/mtd/nand/omap_elm.c: In function 'elm_probe':
drivers/mtd/nand/omap_elm.c:417:23: warning: format '%i' expects argument of type 'int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
This patch avoids the type mismatch by printing the interrupt as
a resource using the %pr format string.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
v2: pass correct pointer
diff --git a/drivers/mtd/nand/omap_elm.c b/drivers/mtd/nand/omap_elm.c
index 235ec7992b4c..a3f32f939cc1 100644
--- a/drivers/mtd/nand/omap_elm.c
+++ b/drivers/mtd/nand/omap_elm.c
@@ -414,7 +414,7 @@ static int elm_probe(struct platform_device *pdev)
ret = devm_request_irq(&pdev->dev, irq->start, elm_isr, 0,
pdev->name, info);
if (ret) {
- dev_err(&pdev->dev, "failure requesting irq %i\n", irq->start);
+ dev_err(&pdev->dev, "failure requesting %pr\n", irq);
return ret;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] mtd: omap_elm: print interrupt resource using %pr
2015-12-18 13:15 ` Arnd Bergmann
@ 2015-12-18 18:24 ` Brian Norris
-1 siblings, 0 replies; 4+ messages in thread
From: Brian Norris @ 2015-12-18 18:24 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Tony Lindgren, linux-kernel, linux-mtd, linux-omap,
David Woodhouse, linux-arm-kernel, Roger Quadros
On Fri, Dec 18, 2015 at 02:15:17PM +0100, Arnd Bergmann wrote:
> When CONFIG_LPAE is set on ARM, resource_size_t is 64-bit wide
> and we get a warning about an incorrect format string for printing
> the interrupt number in elm_probe:
>
> drivers/mtd/nand/omap_elm.c: In function 'elm_probe':
> drivers/mtd/nand/omap_elm.c:417:23: warning: format '%i' expects argument of type 'int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
>
> This patch avoids the type mismatch by printing the interrupt as
> a resource using the %pr format string.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: pass correct pointer
>
> diff --git a/drivers/mtd/nand/omap_elm.c b/drivers/mtd/nand/omap_elm.c
> index 235ec7992b4c..a3f32f939cc1 100644
> --- a/drivers/mtd/nand/omap_elm.c
> +++ b/drivers/mtd/nand/omap_elm.c
> @@ -414,7 +414,7 @@ static int elm_probe(struct platform_device *pdev)
> ret = devm_request_irq(&pdev->dev, irq->start, elm_isr, 0,
> pdev->name, info);
> if (ret) {
> - dev_err(&pdev->dev, "failure requesting irq %i\n", irq->start);
> + dev_err(&pdev->dev, "failure requesting %pr\n", irq);
FWIW, the printk documentation isn't very specific about the formatting
for %pr. After drilling down to resource_string() in lib/vsprintf.c, it
looks like there is special case handling for various resrouce types,
even though the documentation only shows IORESOURCE_MEM types.
Applied to l2-mtd.git.
> return ret;
> }
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] mtd: omap_elm: print interrupt resource using %pr
@ 2015-12-18 18:24 ` Brian Norris
0 siblings, 0 replies; 4+ messages in thread
From: Brian Norris @ 2015-12-18 18:24 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 18, 2015 at 02:15:17PM +0100, Arnd Bergmann wrote:
> When CONFIG_LPAE is set on ARM, resource_size_t is 64-bit wide
> and we get a warning about an incorrect format string for printing
> the interrupt number in elm_probe:
>
> drivers/mtd/nand/omap_elm.c: In function 'elm_probe':
> drivers/mtd/nand/omap_elm.c:417:23: warning: format '%i' expects argument of type 'int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
>
> This patch avoids the type mismatch by printing the interrupt as
> a resource using the %pr format string.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: pass correct pointer
>
> diff --git a/drivers/mtd/nand/omap_elm.c b/drivers/mtd/nand/omap_elm.c
> index 235ec7992b4c..a3f32f939cc1 100644
> --- a/drivers/mtd/nand/omap_elm.c
> +++ b/drivers/mtd/nand/omap_elm.c
> @@ -414,7 +414,7 @@ static int elm_probe(struct platform_device *pdev)
> ret = devm_request_irq(&pdev->dev, irq->start, elm_isr, 0,
> pdev->name, info);
> if (ret) {
> - dev_err(&pdev->dev, "failure requesting irq %i\n", irq->start);
> + dev_err(&pdev->dev, "failure requesting %pr\n", irq);
FWIW, the printk documentation isn't very specific about the formatting
for %pr. After drilling down to resource_string() in lib/vsprintf.c, it
looks like there is special case handling for various resrouce types,
even though the documentation only shows IORESOURCE_MEM types.
Applied to l2-mtd.git.
> return ret;
> }
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-18 18:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-18 13:15 [PATCH v2] mtd: omap_elm: print interrupt resource using %pr Arnd Bergmann
2015-12-18 13:15 ` Arnd Bergmann
2015-12-18 18:24 ` Brian Norris
2015-12-18 18:24 ` Brian Norris
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.