* [PATCH] acpi: remove a meaningless null check before debugfs_remove
@ 2018-08-18 10:49 ` zhong jiang
0 siblings, 0 replies; 5+ messages in thread
From: zhong jiang @ 2018-08-18 10:49 UTC (permalink / raw)
To: rjw, lenb, linux-kernel, linux-acpi
debugfs_remove has taken null pointer into account. So it is safe
to remove the check before debugfs_remove.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/acpi/custom_method.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/acpi/custom_method.c b/drivers/acpi/custom_method.c
index e967c11..4451877 100644
--- a/drivers/acpi/custom_method.c
+++ b/drivers/acpi/custom_method.c
@@ -92,8 +92,7 @@ static int __init acpi_custom_method_init(void)
static void __exit acpi_custom_method_exit(void)
{
- if (cm_dentry)
- debugfs_remove(cm_dentry);
+ debugfs_remove(cm_dentry);
}
module_init(acpi_custom_method_init);
--
1.7.12.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] acpi: remove a meaningless null check before debugfs_remove
@ 2018-08-18 10:49 ` zhong jiang
0 siblings, 0 replies; 5+ messages in thread
From: zhong jiang @ 2018-08-18 10:49 UTC (permalink / raw)
To: rjw, lenb, linux-kernel, linux-acpi
debugfs_remove has taken null pointer into account. So it is safe
to remove the check before debugfs_remove.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/acpi/custom_method.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/acpi/custom_method.c b/drivers/acpi/custom_method.c
index e967c11..4451877 100644
--- a/drivers/acpi/custom_method.c
+++ b/drivers/acpi/custom_method.c
@@ -92,8 +92,7 @@ static int __init acpi_custom_method_init(void)
static void __exit acpi_custom_method_exit(void)
{
- if (cm_dentry)
- debugfs_remove(cm_dentry);
+ debugfs_remove(cm_dentry);
}
module_init(acpi_custom_method_init);
--
1.7.12.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] acpi: remove a meaningless null check before debugfs_remove
2018-08-18 10:49 ` zhong jiang
@ 2018-09-06 14:28 ` zhong jiang
-1 siblings, 0 replies; 5+ messages in thread
From: zhong jiang @ 2018-09-06 14:28 UTC (permalink / raw)
To: rjw, lenb, linux-kernel, linux-acpi, jkosina, rafael.j.wysocki, rusty
+to maintainers
On 2018/8/18 18:49, zhong jiang wrote:
> debugfs_remove has taken null pointer into account. So it is safe
> to remove the check before debugfs_remove.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/acpi/custom_method.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/custom_method.c b/drivers/acpi/custom_method.c
> index e967c11..4451877 100644
> --- a/drivers/acpi/custom_method.c
> +++ b/drivers/acpi/custom_method.c
> @@ -92,8 +92,7 @@ static int __init acpi_custom_method_init(void)
>
> static void __exit acpi_custom_method_exit(void)
> {
> - if (cm_dentry)
> - debugfs_remove(cm_dentry);
> + debugfs_remove(cm_dentry);
> }
>
> module_init(acpi_custom_method_init);
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] acpi: remove a meaningless null check before debugfs_remove
@ 2018-09-06 14:28 ` zhong jiang
0 siblings, 0 replies; 5+ messages in thread
From: zhong jiang @ 2018-09-06 14:28 UTC (permalink / raw)
To: rjw, lenb, linux-kernel, linux-acpi, jkosina, rafael.j.wysocki, rusty
+to maintainers
On 2018/8/18 18:49, zhong jiang wrote:
> debugfs_remove has taken null pointer into account. So it is safe
> to remove the check before debugfs_remove.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/acpi/custom_method.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/custom_method.c b/drivers/acpi/custom_method.c
> index e967c11..4451877 100644
> --- a/drivers/acpi/custom_method.c
> +++ b/drivers/acpi/custom_method.c
> @@ -92,8 +92,7 @@ static int __init acpi_custom_method_init(void)
>
> static void __exit acpi_custom_method_exit(void)
> {
> - if (cm_dentry)
> - debugfs_remove(cm_dentry);
> + debugfs_remove(cm_dentry);
> }
>
> module_init(acpi_custom_method_init);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] acpi: remove a meaningless null check before debugfs_remove
2018-08-18 10:49 ` zhong jiang
(?)
(?)
@ 2018-09-14 8:37 ` Rafael J. Wysocki
-1 siblings, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2018-09-14 8:37 UTC (permalink / raw)
To: zhong jiang; +Cc: lenb, linux-kernel, linux-acpi
On Saturday, August 18, 2018 12:49:20 PM CEST zhong jiang wrote:
> debugfs_remove has taken null pointer into account. So it is safe
> to remove the check before debugfs_remove.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/acpi/custom_method.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/custom_method.c b/drivers/acpi/custom_method.c
> index e967c11..4451877 100644
> --- a/drivers/acpi/custom_method.c
> +++ b/drivers/acpi/custom_method.c
> @@ -92,8 +92,7 @@ static int __init acpi_custom_method_init(void)
>
> static void __exit acpi_custom_method_exit(void)
> {
> - if (cm_dentry)
> - debugfs_remove(cm_dentry);
> + debugfs_remove(cm_dentry);
> }
>
> module_init(acpi_custom_method_init);
>
Applied, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-09-14 8:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-18 10:49 [PATCH] acpi: remove a meaningless null check before debugfs_remove zhong jiang
2018-08-18 10:49 ` zhong jiang
2018-09-06 14:28 ` zhong jiang
2018-09-06 14:28 ` zhong jiang
2018-09-14 8:37 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.