* [PATCH] target/i386: Fix OUTL debug output
@ 2020-05-17 11:01 Philippe Mathieu-Daudé
2020-05-19 3:39 ` Richard Henderson
0 siblings, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-05-17 11:01 UTC (permalink / raw)
To: qemu-devel
Cc: Eduardo Habkost, Riku Voipio, Philippe Mathieu-Daudé,
Laurent Vivier, Paolo Bonzini, Richard Henderson
Fix OUTL instructions incorrectly displayed as OUTW.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
target/i386/misc_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/misc_helper.c b/target/i386/misc_helper.c
index 7d61221024..b6b1d41b14 100644
--- a/target/i386/misc_helper.c
+++ b/target/i386/misc_helper.c
@@ -70,7 +70,7 @@ target_ulong helper_inw(CPUX86State *env, uint32_t port)
void helper_outl(CPUX86State *env, uint32_t port, uint32_t data)
{
#ifdef CONFIG_USER_ONLY
- fprintf(stderr, "outw: port=0x%04x, data=%08x\n", port, data);
+ fprintf(stderr, "outl: port=0x%04x, data=%08x\n", port, data);
#else
address_space_stl(&address_space_io, port, data,
cpu_get_mem_attrs(env), NULL);
--
2.21.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] target/i386: Fix OUTL debug output
2020-05-17 11:01 [PATCH] target/i386: Fix OUTL debug output Philippe Mathieu-Daudé
@ 2020-05-19 3:39 ` Richard Henderson
2020-05-19 12:23 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 4+ messages in thread
From: Richard Henderson @ 2020-05-19 3:39 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Paolo Bonzini, Richard Henderson, Riku Voipio, Eduardo Habkost,
Laurent Vivier
On 5/17/20 4:01 AM, Philippe Mathieu-Daudé wrote:
> Fix OUTL instructions incorrectly displayed as OUTW.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/i386/misc_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
as far as it goes. We should of course never be printing to stderr, but
logging or tracing.
r~
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] target/i386: Fix OUTL debug output
2020-05-19 3:39 ` Richard Henderson
@ 2020-05-19 12:23 ` Philippe Mathieu-Daudé
2020-05-21 14:06 ` Paolo Bonzini
0 siblings, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-05-19 12:23 UTC (permalink / raw)
To: Richard Henderson, qemu-devel
Cc: Paolo Bonzini, Riku Voipio, Laurent Vivier, Eduardo Habkost,
Richard Henderson
On 5/19/20 5:39 AM, Richard Henderson wrote:
> On 5/17/20 4:01 AM, Philippe Mathieu-Daudé wrote:
>> Fix OUTL instructions incorrectly displayed as OUTW.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> target/i386/misc_helper.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
> as far as it goes. We should of course never be printing to stderr, but
> logging or tracing.
Yes, this is what the cpu_io() functions do in ioport.c, but they use
MEMTXATTRS_UNSPECIFIED.
If we could replace one with another, I'm not sure which one is the
correct one.
Maybe keep cpu_io() from ioport.c but add a MemTxAttrs argument?
Regards,
Phil.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] target/i386: Fix OUTL debug output
2020-05-19 12:23 ` Philippe Mathieu-Daudé
@ 2020-05-21 14:06 ` Paolo Bonzini
0 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2020-05-21 14:06 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Richard Henderson, qemu-devel
Cc: Laurent Vivier, Riku Voipio, Eduardo Habkost, Richard Henderson
On 19/05/20 14:23, Philippe Mathieu-Daudé wrote:
> On 5/19/20 5:39 AM, Richard Henderson wrote:
>> On 5/17/20 4:01 AM, Philippe Mathieu-Daudé wrote:
>>> Fix OUTL instructions incorrectly displayed as OUTW.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>> target/i386/misc_helper.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>>
>> as far as it goes. We should of course never be printing to stderr, but
>> logging or tracing.
>
> Yes, this is what the cpu_io() functions do in ioport.c, but they use
> MEMTXATTRS_UNSPECIFIED.
>
> If we could replace one with another, I'm not sure which one is the
> correct one.
>
> Maybe keep cpu_io() from ioport.c but add a MemTxAttrs argument?
>
> Regards,
>
> Phil.
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-21 14:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-17 11:01 [PATCH] target/i386: Fix OUTL debug output Philippe Mathieu-Daudé
2020-05-19 3:39 ` Richard Henderson
2020-05-19 12:23 ` Philippe Mathieu-Daudé
2020-05-21 14:06 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.