[PATCH] VPMU: add lost Intel processor

[PATCH] VPMU: add lost Intel processor

[Dietmar Hahn]

Hi,

it seems somewhere the Intel processor
cpu family      : 6
model           : 47
model name      : Intel(R) Xeon(R) CPU E7- 8837  @ 2.67GHz
got lost.

Dietmar.


Signed-off-by: Dietmar Hahn <dietmar.hahn@ts.fujitsu.com>

diff --git a/xen/arch/x86/hvm/vmx/vpmu_core2.c b/xen/arch/x86/hvm/vmx/vpmu_core2.c
index 8ad522a..bbe6197 100644
--- a/xen/arch/x86/hvm/vmx/vpmu_core2.c
+++ b/xen/arch/x86/hvm/vmx/vpmu_core2.c
@@ -849,6 +849,7 @@ int vmx_vpmu_initialise(struct vcpu *v, unsigned int vpmu_flags)
         case 0x25: /* 32 nm nehalem, "Clarkdale", "Arrandale" */
         case 0x2c: /* 32 nm nehalem, "Gulftown", "Westmere-EP" */
         case 0x27: /* 32 nm Westmere-EX */
+        case 0x2f: /* 32 nm Westmere-EX */
 
         case 0x3a: /* IvyBridge */
         case 0x3e: /* IvyBridge EP */

-- 
Company details: http://ts.fujitsu.com/imprint.html

Re: [PATCH] VPMU: add lost Intel processor

[Jan Beulich]

>>> On 03.06.15 at 13:44, <dietmar.hahn@ts.fujitsu.com> wrote:
> --- a/xen/arch/x86/hvm/vmx/vpmu_core2.c
> +++ b/xen/arch/x86/hvm/vmx/vpmu_core2.c
> @@ -849,6 +849,7 @@ int vmx_vpmu_initialise(struct vcpu *v, unsigned int vpmu_flags)
>          case 0x25: /* 32 nm nehalem, "Clarkdale", "Arrandale" */
>          case 0x2c: /* 32 nm nehalem, "Gulftown", "Westmere-EP" */
>          case 0x27: /* 32 nm Westmere-EX */
> +        case 0x2f: /* 32 nm Westmere-EX */

Hmm, 0x27 isn't Westmere - commit 6d112f2b50 ("x86/vPMU: change
Intel model numbers from decimal to hex") translated 47 to 0x27. So
the correct fix is to replace that entry.

Jan

[PATCH v2] VPMU: add lost Intel processor

[Alan Robinson]

From: Alan Robinson <Alan.Robinson@ts.fujitsu.com>

commit 6d112f2b50 ("x86/vPMU: change Intel model numbers from decimal
to hex") translated 47 to 0x27, now corrected to 0x2f.

Signed-off-by: Alan Robinson <Alan.Robinson@ts.fujitsu.com>
Signed-off-by: Dietmar Hahn <Dietmar.Hahn@ts.fujitsu.com>

---
Changed since v1:
  (after talking to Dietmar, he's away from his email for a while)
  * removed non existent model number 0x27 as suggested by Jan Beulich
  * included reference to when the problem was introduced (also from Jan)

 xen/arch/x86/hvm/vmx/vpmu_core2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/hvm/vmx/vpmu_core2.c b/xen/arch/x86/hvm/vmx/vpmu_core2.c
index 8ad522a..311f35f 100644
--- a/xen/arch/x86/hvm/vmx/vpmu_core2.c
+++ b/xen/arch/x86/hvm/vmx/vpmu_core2.c
@@ -848,7 +848,7 @@ int vmx_vpmu_initialise(struct vcpu *v, unsigned int vpmu_flags)
         /* Westmere: */
         case 0x25: /* 32 nm nehalem, "Clarkdale", "Arrandale" */
         case 0x2c: /* 32 nm nehalem, "Gulftown", "Westmere-EP" */
-        case 0x27: /* 32 nm Westmere-EX */
+        case 0x2f: /* 32 nm Westmere-EX */
 
         case 0x3a: /* IvyBridge */
         case 0x3e: /* IvyBridge EP */
-- 
2.2.0

Re: [PATCH v2] VPMU: add lost Intel processor

[Konrad Rzeszutek Wilk]

On Mon, Jun 08, 2015 at 12:05:02PM +0200, Alan Robinson wrote:
> From: Alan Robinson <Alan.Robinson@ts.fujitsu.com>
> 
> commit 6d112f2b50 ("x86/vPMU: change Intel model numbers from decimal
> to hex") translated 47 to 0x27, now corrected to 0x2f.
> 
> Signed-off-by: Alan Robinson <Alan.Robinson@ts.fujitsu.com>
> Signed-off-by: Dietmar Hahn <Dietmar.Hahn@ts.fujitsu.com>

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> ---
> Changed since v1:
>   (after talking to Dietmar, he's away from his email for a while)
>   * removed non existent model number 0x27 as suggested by Jan Beulich
>   * included reference to when the problem was introduced (also from Jan)
> 
>  xen/arch/x86/hvm/vmx/vpmu_core2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/x86/hvm/vmx/vpmu_core2.c b/xen/arch/x86/hvm/vmx/vpmu_core2.c
> index 8ad522a..311f35f 100644
> --- a/xen/arch/x86/hvm/vmx/vpmu_core2.c
> +++ b/xen/arch/x86/hvm/vmx/vpmu_core2.c
> @@ -848,7 +848,7 @@ int vmx_vpmu_initialise(struct vcpu *v, unsigned int vpmu_flags)
>          /* Westmere: */
>          case 0x25: /* 32 nm nehalem, "Clarkdale", "Arrandale" */
>          case 0x2c: /* 32 nm nehalem, "Gulftown", "Westmere-EP" */
> -        case 0x27: /* 32 nm Westmere-EX */
> +        case 0x2f: /* 32 nm Westmere-EX */
>  
>          case 0x3a: /* IvyBridge */
>          case 0x3e: /* IvyBridge EP */
> -- 
> 2.2.0
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

Re: [PATCH v2] VPMU: add lost Intel processor

[Tian, Kevin]

> From: Alan Robinson [mailto:alan.robinson@ts.fujitsu.com]
> Sent: Monday, June 08, 2015 6:05 PM
> 
> From: Alan Robinson <Alan.Robinson@ts.fujitsu.com>
> 
> commit 6d112f2b50 ("x86/vPMU: change Intel model numbers from decimal
> to hex") translated 47 to 0x27, now corrected to 0x2f.
> 
> Signed-off-by: Alan Robinson <Alan.Robinson@ts.fujitsu.com>
> Signed-off-by: Dietmar Hahn <Dietmar.Hahn@ts.fujitsu.com>

Acked-by: Kevin Tian <kevin.tian@intel.com>

> 
> ---
> Changed since v1:
>   (after talking to Dietmar, he's away from his email for a while)
>   * removed non existent model number 0x27 as suggested by Jan Beulich
>   * included reference to when the problem was introduced (also from Jan)
> 
>  xen/arch/x86/hvm/vmx/vpmu_core2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/x86/hvm/vmx/vpmu_core2.c
> b/xen/arch/x86/hvm/vmx/vpmu_core2.c
> index 8ad522a..311f35f 100644
> --- a/xen/arch/x86/hvm/vmx/vpmu_core2.c
> +++ b/xen/arch/x86/hvm/vmx/vpmu_core2.c
> @@ -848,7 +848,7 @@ int vmx_vpmu_initialise(struct vcpu *v, unsigned int vpmu_flags)
>          /* Westmere: */
>          case 0x25: /* 32 nm nehalem, "Clarkdale", "Arrandale" */
>          case 0x2c: /* 32 nm nehalem, "Gulftown", "Westmere-EP" */
> -        case 0x27: /* 32 nm Westmere-EX */
> +        case 0x2f: /* 32 nm Westmere-EX */
> 
>          case 0x3a: /* IvyBridge */
>          case 0x3e: /* IvyBridge EP */
> --
> 2.2.0