From: Steen Hegelund <steen.hegelund@microchip.com> To: Rob Herring <robh@kernel.org> Cc: Philipp Zabel <p.zabel@pengutronix.de>, Andrew Lunn <andrew@lunn.ch>, Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>, "Alexandre Belloni" <alexandre.belloni@bootlin.com>, Gregory Clement <gregory.clement@bootlin.com>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org> Subject: Re: [PATCH v4 3/3] arm64: dts: reset: add microchip sparx5 switch reset driver Date: Mon, 8 Feb 2021 14:20:30 +0100 [thread overview] Message-ID: <23616bd06996c1df9480b879d804220269143f44.camel@microchip.com> (raw) In-Reply-To: <20210205223526.GA3869001@robh.at.kernel.org> Hi Rob, On Fri, 2021-02-05 at 16:35 -0600, Rob Herring wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On Wed, Jan 20, 2021 at 09:19:21AM +0100, Steen Hegelund wrote: > > This provides reset driver support for the Microchip Sparx5 PCB134 > > and > > PCB135 reference boards. > > This isn't a compatible change. You need an explanation why that's > okay > if that's intended. I am not entirely sure that I get your point. The change (adding the reset driver) is new, and it is optional (but strongly recommended) for the clients to use it, so will this be a incompatible change? I can certainly add a an explanation. Would that be needed here in the bindings, or where do you suggest? > > > > > Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com> > > --- > > arch/arm64/boot/dts/microchip/sparx5.dtsi | 14 +++++++++++--- > > 1 file changed, 11 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi > > b/arch/arm64/boot/dts/microchip/sparx5.dtsi > > index 380281f312d8..4edbb9fcdce0 100644 > > --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi > > +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi > > @@ -132,9 +132,17 @@ mux: mux-controller { > > }; > > }; > > > > - reset@611010008 { > > - compatible = "microchip,sparx5-chip-reset"; > > - reg = <0x6 0x11010008 0x4>; > > + gcb_ctrl: syscon@611010000 { > > + compatible = "microchip,sparx5-gcb-syscon", > > "syscon"; > > + reg = <0x6 0x11010000 0x10000>; > > + }; > > + > > + reset: reset-controller@0 { > > + compatible = "microchip,sparx5-switch-reset"; > > + reg = <0x6 0x0 0x0>; > > Your register length is 0? > > > + #reset-cells = <1>; > > + cpu-syscon = <&cpu_ctrl>; > > Can't you accomplish the same thing adding these to > "microchip,sparx5-chip-reset"? Or possibly as a child node. > > Define nodes based on h/w blocks, not as containers of things you > happen > to want for some driver. > > > + gcb-syscon = <&gcb_ctrl>; > > }; > > > > uart0: serial@600100000 { > > -- > > 2.29.2 > > Thanks for your comments BR Steen
WARNING: multiple messages have this Message-ID (diff)
From: Steen Hegelund <steen.hegelund@microchip.com> To: Rob Herring <robh@kernel.org> Cc: Andrew Lunn <andrew@lunn.ch>, Alexandre Belloni <alexandre.belloni@bootlin.com>, devicetree@vger.kernel.org, Gregory Clement <gregory.clement@bootlin.com>, linux-kernel@vger.kernel.org, Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>, Philipp Zabel <p.zabel@pengutronix.de>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 3/3] arm64: dts: reset: add microchip sparx5 switch reset driver Date: Mon, 8 Feb 2021 14:20:30 +0100 [thread overview] Message-ID: <23616bd06996c1df9480b879d804220269143f44.camel@microchip.com> (raw) In-Reply-To: <20210205223526.GA3869001@robh.at.kernel.org> Hi Rob, On Fri, 2021-02-05 at 16:35 -0600, Rob Herring wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On Wed, Jan 20, 2021 at 09:19:21AM +0100, Steen Hegelund wrote: > > This provides reset driver support for the Microchip Sparx5 PCB134 > > and > > PCB135 reference boards. > > This isn't a compatible change. You need an explanation why that's > okay > if that's intended. I am not entirely sure that I get your point. The change (adding the reset driver) is new, and it is optional (but strongly recommended) for the clients to use it, so will this be a incompatible change? I can certainly add a an explanation. Would that be needed here in the bindings, or where do you suggest? > > > > > Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com> > > --- > > arch/arm64/boot/dts/microchip/sparx5.dtsi | 14 +++++++++++--- > > 1 file changed, 11 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi > > b/arch/arm64/boot/dts/microchip/sparx5.dtsi > > index 380281f312d8..4edbb9fcdce0 100644 > > --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi > > +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi > > @@ -132,9 +132,17 @@ mux: mux-controller { > > }; > > }; > > > > - reset@611010008 { > > - compatible = "microchip,sparx5-chip-reset"; > > - reg = <0x6 0x11010008 0x4>; > > + gcb_ctrl: syscon@611010000 { > > + compatible = "microchip,sparx5-gcb-syscon", > > "syscon"; > > + reg = <0x6 0x11010000 0x10000>; > > + }; > > + > > + reset: reset-controller@0 { > > + compatible = "microchip,sparx5-switch-reset"; > > + reg = <0x6 0x0 0x0>; > > Your register length is 0? > > > + #reset-cells = <1>; > > + cpu-syscon = <&cpu_ctrl>; > > Can't you accomplish the same thing adding these to > "microchip,sparx5-chip-reset"? Or possibly as a child node. > > Define nodes based on h/w blocks, not as containers of things you > happen > to want for some driver. > > > + gcb-syscon = <&gcb_ctrl>; > > }; > > > > uart0: serial@600100000 { > > -- > > 2.29.2 > > Thanks for your comments BR Steen _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-08 13:24 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-20 8:19 [PATCH v4 0/3] Adding the Sparx5 Switch Reset Driver Steen Hegelund 2021-01-20 8:19 ` Steen Hegelund 2021-01-20 8:19 ` [PATCH v4 1/3] dt-bindings: reset: microchip sparx5 reset driver bindings Steen Hegelund 2021-01-20 8:19 ` Steen Hegelund 2021-01-20 8:19 ` [PATCH v4 2/3] reset: mchp: sparx5: add switch reset driver Steen Hegelund 2021-01-20 8:19 ` Steen Hegelund 2021-01-20 8:19 ` [PATCH v4 3/3] arm64: dts: reset: add microchip sparx5 " Steen Hegelund 2021-01-20 8:19 ` Steen Hegelund 2021-02-05 22:35 ` Rob Herring 2021-02-05 22:35 ` Rob Herring 2021-02-08 7:58 ` Steen Hegelund 2021-02-08 7:58 ` Steen Hegelund 2021-02-08 13:20 ` Steen Hegelund [this message] 2021-02-08 13:20 ` Steen Hegelund 2021-02-08 17:00 ` Rob Herring 2021-02-08 17:00 ` Rob Herring 2021-02-03 8:02 ` [PATCH v4 0/3] Adding the Sparx5 Switch Reset Driver Steen Hegelund 2021-02-03 8:02 ` Steen Hegelund
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=23616bd06996c1df9480b879d804220269143f44.camel@microchip.com \ --to=steen.hegelund@microchip.com \ --cc=UNGLinuxDriver@microchip.com \ --cc=alexandre.belloni@bootlin.com \ --cc=andrew@lunn.ch \ --cc=devicetree@vger.kernel.org \ --cc=gregory.clement@bootlin.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=p.zabel@pengutronix.de \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.