All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] add u-boot properties to sama5d3 pit timer
@ 2021-04-05 17:46 Manuel Reis
  2021-04-06  7:53 ` Eugen.Hristev at microchip.com
  0 siblings, 1 reply; 2+ messages in thread
From: Manuel Reis @ 2021-04-05 17:46 UTC (permalink / raw)
  To: u-boot

pit timer node requires u-boot properties to be recognized

Signed-off-by: Manuel Reis <mluis.reis@gmail.com>
CC: Eugen Hristev <eugen.hristev@microchip.com>
---
 arch/arm/dts/sama5d3.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/dts/sama5d3.dtsi b/arch/arm/dts/sama5d3.dtsi
index 6ed218eaad..3cd30d574d 100644
--- a/arch/arm/dts/sama5d3.dtsi
+++ b/arch/arm/dts/sama5d3.dtsi
@@ -1316,6 +1316,7 @@
 			};
 
 			pit: timer at fffffe30 {
+				u-boot,dm-pre-reloc;
 				compatible = "atmel,at91sam9260-pit";
 				reg = <0xfffffe30 0xf>;
 				interrupts = <3 IRQ_TYPE_LEVEL_HIGH 5>;
-- 
2.27.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] add u-boot properties to sama5d3 pit timer
  2021-04-05 17:46 [PATCH] add u-boot properties to sama5d3 pit timer Manuel Reis
@ 2021-04-06  7:53 ` Eugen.Hristev at microchip.com
  0 siblings, 0 replies; 2+ messages in thread
From: Eugen.Hristev at microchip.com @ 2021-04-06  7:53 UTC (permalink / raw)
  To: u-boot

Hi Manuel,

Subject should be like this :
ARM: dts: at91: sama5d3: ...

On 4/5/21 8:46 PM, Manuel Reis wrote:
> pit timer node requires u-boot properties to be recognized

could you be more specific, where it's required, like we discussed, in 
the early boot process of the SPL , it's not found if the property is 
not present.
> 
> Signed-off-by: Manuel Reis <mluis.reis@gmail.com>
> CC: Eugen Hristev <eugen.hristev@microchip.com>
> ---
>   arch/arm/dts/sama5d3.dtsi | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/dts/sama5d3.dtsi b/arch/arm/dts/sama5d3.dtsi
> index 6ed218eaad..3cd30d574d 100644
> --- a/arch/arm/dts/sama5d3.dtsi
> +++ b/arch/arm/dts/sama5d3.dtsi
> @@ -1316,6 +1316,7 @@
>                          };
> 
>                          pit: timer at fffffe30 {
> +                               u-boot,dm-pre-reloc;

add this as the last property of the node please.

>                                  compatible = "atmel,at91sam9260-pit";
>                                  reg = <0xfffffe30 0xf>;
>                                  interrupts = <3 IRQ_TYPE_LEVEL_HIGH 5>;
> --
> 2.27.0
> 

So, modify the commit, and create your patch using git format-patch -v 2
(to have it as a version 2) and resend.

Thank you for the patch !
Eugen

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-06  7:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-05 17:46 [PATCH] add u-boot properties to sama5d3 pit timer Manuel Reis
2021-04-06  7:53 ` Eugen.Hristev at microchip.com

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.