* [PATCH net-next v2] net: vxlan: Fix kernel coding style
@ 2022-05-20 0:36 Alaa Mohamed
2022-05-20 5:06 ` Roopa Prabhu
2022-05-21 0:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 7+ messages in thread
From: Alaa Mohamed @ 2022-05-20 0:36 UTC (permalink / raw)
To: netdev
Cc: outreachy, roopa, davem, edumazet, kuba, pabeni, linux-kernel,
eng.alaamohamedsoliman.am
The continuation line does not align with the opening bracket
and this patch fix it.
Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
---
changes in v2:
fix the alignment of the "DST, VNI, ifindex and port are mutually exclusive with NH_ID"
string to the open parenthesis of the NL_SET_ERR_MSG macro in vxlan_fdb_parse().
---
drivers/net/vxlan/vxlan_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
index 293082c32a78..29db08f15e38 100644
--- a/drivers/net/vxlan/vxlan_core.c
+++ b/drivers/net/vxlan/vxlan_core.c
@@ -1138,7 +1138,7 @@ static int vxlan_fdb_parse(struct nlattr *tb[], struct vxlan_dev *vxlan,
if (tb[NDA_NH_ID] && (tb[NDA_DST] || tb[NDA_VNI] || tb[NDA_IFINDEX] ||
tb[NDA_PORT])) {
NL_SET_ERR_MSG(extack,
- "DST, VNI, ifindex and port are mutually exclusive with NH_ID");
+ "DST, VNI, ifindex and port are mutually exclusive with NH_ID");
return -EINVAL;
}
@@ -1297,7 +1297,7 @@ int __vxlan_fdb_delete(struct vxlan_dev *vxlan,
static int vxlan_fdb_delete(struct ndmsg *ndm, struct nlattr *tb[],
struct net_device *dev,
const unsigned char *addr, u16 vid,
- struct netlink_ext_ack *extack)
+ struct netlink_ext_ack *extack)
{
struct vxlan_dev *vxlan = netdev_priv(dev);
union vxlan_addr ip;
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH net-next v2] net: vxlan: Fix kernel coding style
2022-05-20 0:36 [PATCH net-next v2] net: vxlan: Fix kernel coding style Alaa Mohamed
@ 2022-05-20 5:06 ` Roopa Prabhu
2022-05-21 0:40 ` Jakub Kicinski
2022-05-21 0:50 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 7+ messages in thread
From: Roopa Prabhu @ 2022-05-20 5:06 UTC (permalink / raw)
To: Alaa Mohamed, netdev
Cc: outreachy, davem, edumazet, kuba, pabeni, linux-kernel
On 5/19/22 17:36, Alaa Mohamed wrote:
> The continuation line does not align with the opening bracket
> and this patch fix it.
>
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> ---
> changes in v2:
> fix the alignment of the "DST, VNI, ifindex and port are mutually exclusive with NH_ID"
> string to the open parenthesis of the NL_SET_ERR_MSG macro in vxlan_fdb_parse().
> ---
> drivers/net/vxlan/vxlan_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
> index 293082c32a78..29db08f15e38 100644
> --- a/drivers/net/vxlan/vxlan_core.c
> +++ b/drivers/net/vxlan/vxlan_core.c
> @@ -1138,7 +1138,7 @@ static int vxlan_fdb_parse(struct nlattr *tb[], struct vxlan_dev *vxlan,
> if (tb[NDA_NH_ID] && (tb[NDA_DST] || tb[NDA_VNI] || tb[NDA_IFINDEX] ||
> tb[NDA_PORT])) {
> NL_SET_ERR_MSG(extack,
> - "DST, VNI, ifindex and port are mutually exclusive with NH_ID");
> + "DST, VNI, ifindex and port are mutually exclusive with NH_ID");
it looks still off by a space.
> return -EINVAL;
> }
this closing brace should line up with the if
>
> @@ -1297,7 +1297,7 @@ int __vxlan_fdb_delete(struct vxlan_dev *vxlan,
> static int vxlan_fdb_delete(struct ndmsg *ndm, struct nlattr *tb[],
> struct net_device *dev,
> const unsigned char *addr, u16 vid,
> - struct netlink_ext_ack *extack)
> + struct netlink_ext_ack *extack)
> {
> struct vxlan_dev *vxlan = netdev_priv(dev);
> union vxlan_addr ip;
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH net-next v2] net: vxlan: Fix kernel coding style
2022-05-20 5:06 ` Roopa Prabhu
@ 2022-05-21 0:40 ` Jakub Kicinski
2022-05-24 0:10 ` Roopa Prabhu
0 siblings, 1 reply; 7+ messages in thread
From: Jakub Kicinski @ 2022-05-21 0:40 UTC (permalink / raw)
To: Roopa Prabhu
Cc: Alaa Mohamed, netdev, outreachy, davem, edumazet, pabeni, linux-kernel
On Thu, 19 May 2022 22:06:53 -0700 Roopa Prabhu wrote:
> > @@ -1138,7 +1138,7 @@ static int vxlan_fdb_parse(struct nlattr *tb[], struct vxlan_dev *vxlan,
> > if (tb[NDA_NH_ID] && (tb[NDA_DST] || tb[NDA_VNI] || tb[NDA_IFINDEX] ||
> > tb[NDA_PORT])) {
> > NL_SET_ERR_MSG(extack,
> > - "DST, VNI, ifindex and port are mutually exclusive with NH_ID");
> > + "DST, VNI, ifindex and port are mutually exclusive with NH_ID");
> it looks still off by a space.
>
> > return -EINVAL;
> > }
>
>
> this closing brace should line up with the if
Let me just fix this myself when applying... There were 3 separate
postings of v2, and they weren't even identical :(
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH net-next v2] net: vxlan: Fix kernel coding style
2022-05-21 0:40 ` Jakub Kicinski
@ 2022-05-24 0:10 ` Roopa Prabhu
0 siblings, 0 replies; 7+ messages in thread
From: Roopa Prabhu @ 2022-05-24 0:10 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Alaa Mohamed, netdev, outreachy, davem, edumazet, pabeni, linux-kernel
On 5/20/22 17:40, Jakub Kicinski wrote:
> On Thu, 19 May 2022 22:06:53 -0700 Roopa Prabhu wrote:
>>> @@ -1138,7 +1138,7 @@ static int vxlan_fdb_parse(struct nlattr *tb[], struct vxlan_dev *vxlan,
>>> if (tb[NDA_NH_ID] && (tb[NDA_DST] || tb[NDA_VNI] || tb[NDA_IFINDEX] ||
>>> tb[NDA_PORT])) {
>>> NL_SET_ERR_MSG(extack,
>>> - "DST, VNI, ifindex and port are mutually exclusive with NH_ID");
>>> + "DST, VNI, ifindex and port are mutually exclusive with NH_ID");
>> it looks still off by a space.
>>
>>> return -EINVAL;
>>> }
>>
>> this closing brace should line up with the if
> Let me just fix this myself when applying... There were 3 separate
> postings of v2, and they weren't even identical :(
thanks Jakub,
Alaa, when you accidentally send the same patch multiple times, you can
reply on the list and leave a note to the maintainer on which ones to
ignore (lets add this to the outreachy kernel patch submission
instructions if not already there)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net-next v2] net: vxlan: Fix kernel coding style
2022-05-20 0:36 [PATCH net-next v2] net: vxlan: Fix kernel coding style Alaa Mohamed
2022-05-20 5:06 ` Roopa Prabhu
@ 2022-05-21 0:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 7+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-05-21 0:50 UTC (permalink / raw)
To: Alaa Mohamed
Cc: netdev, outreachy, roopa, davem, edumazet, kuba, pabeni, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 20 May 2022 02:36:14 +0200 you wrote:
> The continuation line does not align with the opening bracket
> and this patch fix it.
>
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> ---
> changes in v2:
> fix the alignment of the "DST, VNI, ifindex and port are mutually exclusive with NH_ID"
> string to the open parenthesis of the NL_SET_ERR_MSG macro in vxlan_fdb_parse().
>
> [...]
Here is the summary with links:
- [net-next,v2] net: vxlan: Fix kernel coding style
https://git.kernel.org/netdev/net-next/c/c2e10f53455c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH net-next v2] net: vxlan: Fix kernel coding style
@ 2022-05-20 0:24 Alaa Mohamed
0 siblings, 0 replies; 7+ messages in thread
From: Alaa Mohamed @ 2022-05-20 0:24 UTC (permalink / raw)
To: netdev
Cc: outreachy, roopa, davem, edumazet, kuba, pabeni, linux-kernel,
eng.alaamohamedsoliman.am
The continuation line does not align with the opening bracket
and this patch fix it.
Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
---
changes in v2:
fix the alignment of the "DST, VNI, ifindex and port are mutually exclusive with NH_ID"
string to the open parenthesis of the NL_SET_ERR_MSG macro in vxlan_fdb_parse().
---
drivers/net/vxlan/vxlan_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
index 293082c32a78..29db08f15e38 100644
--- a/drivers/net/vxlan/vxlan_core.c
+++ b/drivers/net/vxlan/vxlan_core.c
@@ -1138,7 +1138,7 @@ static int vxlan_fdb_parse(struct nlattr *tb[], struct vxlan_dev *vxlan,
if (tb[NDA_NH_ID] && (tb[NDA_DST] || tb[NDA_VNI] || tb[NDA_IFINDEX] ||
tb[NDA_PORT])) {
NL_SET_ERR_MSG(extack,
- "DST, VNI, ifindex and port are mutually exclusive with NH_ID");
+ "DST, VNI, ifindex and port are mutually exclusive with NH_ID");
return -EINVAL;
}
@@ -1297,7 +1297,7 @@ int __vxlan_fdb_delete(struct vxlan_dev *vxlan,
static int vxlan_fdb_delete(struct ndmsg *ndm, struct nlattr *tb[],
struct net_device *dev,
const unsigned char *addr, u16 vid,
- struct netlink_ext_ack *extack)
+ struct netlink_ext_ack *extack)
{
struct vxlan_dev *vxlan = netdev_priv(dev);
union vxlan_addr ip;
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH net-next v2] net: vxlan: Fix kernel coding style
@ 2022-05-20 0:14 Alaa Mohamed
0 siblings, 0 replies; 7+ messages in thread
From: Alaa Mohamed @ 2022-05-20 0:14 UTC (permalink / raw)
To: netdev
Cc: outreachy, roopa, davem, edumazet, kuba, pabeni, linux-kernel,
eng.alaamohamedsoliman.am
The continuation line does not align with the opening bracket
and this patch fix it.
Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
---
changes in v2:
fix the alignment of the "DST, VNI, ifindex and port are mutually exclusive with NH_ID"
string to the open parenthesis of the NL_SET_ERR_MSG macro in vxlan_fdb_parse().
---
drivers/net/vxlan/vxlan_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
index 293082c32a78..29db08f15e38 100644
--- a/drivers/net/vxlan/vxlan_core.c
+++ b/drivers/net/vxlan/vxlan_core.c
@@ -1138,7 +1138,7 @@ static int vxlan_fdb_parse(struct nlattr *tb[], struct vxlan_dev *vxlan,
if (tb[NDA_NH_ID] && (tb[NDA_DST] || tb[NDA_VNI] || tb[NDA_IFINDEX] ||
tb[NDA_PORT])) {
NL_SET_ERR_MSG(extack,
- "DST, VNI, ifindex and port are mutually exclusive with NH_ID");
+ "DST, VNI, ifindex and port are mutually exclusive with NH_ID");
return -EINVAL;
}
@@ -1297,7 +1297,7 @@ int __vxlan_fdb_delete(struct vxlan_dev *vxlan,
static int vxlan_fdb_delete(struct ndmsg *ndm, struct nlattr *tb[],
struct net_device *dev,
const unsigned char *addr, u16 vid,
- struct netlink_ext_ack *extack)
+ struct netlink_ext_ack *extack)
{
struct vxlan_dev *vxlan = netdev_priv(dev);
union vxlan_addr ip;
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-05-24 0:10 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-20 0:36 [PATCH net-next v2] net: vxlan: Fix kernel coding style Alaa Mohamed
2022-05-20 5:06 ` Roopa Prabhu
2022-05-21 0:40 ` Jakub Kicinski
2022-05-24 0:10 ` Roopa Prabhu
2022-05-21 0:50 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2022-05-20 0:24 Alaa Mohamed
2022-05-20 0:14 Alaa Mohamed
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.