* [Intel-gfx] [PATCH] drm/i915/dp: Prevent setting the LTTPR LT mode if no LTTPRs are detected @ 2021-01-18 18:31 Imre Deak 2021-01-18 20:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork ` (3 more replies) 0 siblings, 4 replies; 9+ messages in thread From: Imre Deak @ 2021-01-18 18:31 UTC (permalink / raw) To: intel-gfx Atm, the driver programs explicitly the default transparent link training mode (0x55) to DP_PHY_REPEATER_MODE even if no LTTPRs are detected. This conforms to the spec (3.6.6.1): "DP upstream devices that do not enable the Non-transparent mode of LTTPRs shall program the PHY_REPEATER_MODE register (DPCD Address F0003h) to 55h (default) prior to link training" however writing the default value to this DPCD register seems to cause occasional link training errors at least for a DELL WD19TB TBT dock, when no LTTPRs are detected. Writing to DP_PHY_REPEATER_MODE will also cause an unnecessary timeout on systems without any LTTPR. To fix the above two issues let's assume that setting the default mode is redundant when no LTTPRs are detected. Keep the existing behavior and program the default mode if more than 8 LTTPRs are detected or in case the read from DP_PHY_REPEATER_CNT returns an invalid value. References: https://gitlab.freedesktop.org/drm/intel/-/issues/2801 Signed-off-by: Imre Deak <imre.deak@intel.com> --- .../drm/i915/display/intel_dp_link_training.c | 36 ++++++++----------- 1 file changed, 15 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c index d8c6d7054d11..fad9e9874c7b 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c @@ -34,18 +34,6 @@ intel_dp_dump_link_status(const u8 link_status[DP_LINK_STATUS_SIZE]) link_status[3], link_status[4], link_status[5]); } -static int intel_dp_lttpr_count(struct intel_dp *intel_dp) -{ - int count = drm_dp_lttpr_count(intel_dp->lttpr_common_caps); - - /* - * Pretend no LTTPRs in case of LTTPR detection error, or - * if too many (>8) LTTPRs are detected. This translates to link - * training in transparent mode. - */ - return count <= 0 ? 0 : count; -} - static void intel_dp_reset_lttpr_count(struct intel_dp *intel_dp) { intel_dp->lttpr_common_caps[DP_PHY_REPEATER_CNT - @@ -142,6 +130,17 @@ int intel_dp_lttpr_init(struct intel_dp *intel_dp) return 0; ret = intel_dp_read_lttpr_common_caps(intel_dp); + if (!ret) + return 0; + + lttpr_count = drm_dp_lttpr_count(intel_dp->lttpr_common_caps); + /* + * Prevent setting LTTPR transparent mode explicitly if no LTTPRs are + * detected as this breaks link training at least on the Dell WD19TB + * dock. + */ + if (lttpr_count == 0) + return 0; /* * See DP Standard v2.0 3.6.6.1. about the explicit disabling of @@ -150,17 +149,12 @@ int intel_dp_lttpr_init(struct intel_dp *intel_dp) */ intel_dp_set_lttpr_transparent_mode(intel_dp, true); - if (!ret) - return 0; - - lttpr_count = intel_dp_lttpr_count(intel_dp); - /* * In case of unsupported number of LTTPRs or failing to switch to * non-transparent mode fall-back to transparent link training mode, * still taking into account any LTTPR common lane- rate/count limits. */ - if (lttpr_count == 0) + if (lttpr_count < 0) return 0; if (!intel_dp_set_lttpr_transparent_mode(intel_dp, false)) { @@ -222,11 +216,11 @@ intel_dp_phy_is_downstream_of_source(struct intel_dp *intel_dp, enum drm_dp_phy dp_phy) { struct drm_i915_private *i915 = dp_to_i915(intel_dp); - int lttpr_count = intel_dp_lttpr_count(intel_dp); + int lttpr_count = drm_dp_lttpr_count(intel_dp->lttpr_common_caps); - drm_WARN_ON_ONCE(&i915->drm, lttpr_count == 0 && dp_phy != DP_PHY_DPRX); + drm_WARN_ON_ONCE(&i915->drm, lttpr_count <= 0 && dp_phy != DP_PHY_DPRX); - return lttpr_count == 0 || dp_phy == DP_PHY_LTTPR(lttpr_count - 1); + return lttpr_count <= 0 || dp_phy == DP_PHY_LTTPR(lttpr_count - 1); } static u8 intel_dp_phy_voltage_max(struct intel_dp *intel_dp, -- 2.25.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: Prevent setting the LTTPR LT mode if no LTTPRs are detected 2021-01-18 18:31 [Intel-gfx] [PATCH] drm/i915/dp: Prevent setting the LTTPR LT mode if no LTTPRs are detected Imre Deak @ 2021-01-18 20:08 ` Patchwork 2021-01-19 1:46 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork ` (2 subsequent siblings) 3 siblings, 0 replies; 9+ messages in thread From: Patchwork @ 2021-01-18 20:08 UTC (permalink / raw) To: Imre Deak; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 2924 bytes --] == Series Details == Series: drm/i915/dp: Prevent setting the LTTPR LT mode if no LTTPRs are detected URL : https://patchwork.freedesktop.org/series/86007/ State : success == Summary == CI Bug Log - changes from CI_DRM_9636 -> Patchwork_19399 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/index.html Known issues ------------ Here are the changes found in Patchwork_19399 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s3: - fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([i915#2411] / [i915#402]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html * igt@gem_mmap_gtt@basic: - fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#402]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/fi-tgl-y/igt@gem_mmap_gtt@basic.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/fi-tgl-y/igt@gem_mmap_gtt@basic.html #### Possible fixes #### * igt@debugfs_test@read_all_entries: - fi-tgl-y: [DMESG-WARN][5] ([i915#402]) -> [PASS][6] +1 similar issue [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/fi-tgl-y/igt@debugfs_test@read_all_entries.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/fi-tgl-y/igt@debugfs_test@read_all_entries.html * igt@kms_chamelium@hdmi-crc-fast: - fi-kbl-7500u: [DMESG-WARN][7] ([i915#2868]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/fi-kbl-7500u/igt@kms_chamelium@hdmi-crc-fast.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/fi-kbl-7500u/igt@kms_chamelium@hdmi-crc-fast.html [i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411 [i915#2868]: https://gitlab.freedesktop.org/drm/intel/issues/2868 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 Participating hosts (44 -> 38) ------------------------------ Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-cml-drallion fi-bdw-samus Build changes ------------- * Linux: CI_DRM_9636 -> Patchwork_19399 CI-20190529: 20190529 CI_DRM_9636: f560ac388c527f2f166897c9091f7b9ad652050f @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5960: ace82fcd5f3623f8dde7c220a825873dc53dfae4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_19399: f21bd65b0c50affc5cbf3e239ff26377e129ae68 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == f21bd65b0c50 drm/i915/dp: Prevent setting the LTTPR LT mode if no LTTPRs are detected == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/index.html [-- Attachment #1.2: Type: text/html, Size: 3750 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dp: Prevent setting the LTTPR LT mode if no LTTPRs are detected 2021-01-18 18:31 [Intel-gfx] [PATCH] drm/i915/dp: Prevent setting the LTTPR LT mode if no LTTPRs are detected Imre Deak 2021-01-18 20:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork @ 2021-01-19 1:46 ` Patchwork 2021-01-29 20:18 ` Imre Deak 2021-01-19 6:47 ` [Intel-gfx] [PATCH] " Almahallawy, Khaled 2021-01-29 20:39 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork 3 siblings, 1 reply; 9+ messages in thread From: Patchwork @ 2021-01-19 1:46 UTC (permalink / raw) To: Imre Deak; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 19452 bytes --] == Series Details == Series: drm/i915/dp: Prevent setting the LTTPR LT mode if no LTTPRs are detected URL : https://patchwork.freedesktop.org/series/86007/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9636_full -> Patchwork_19399_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_19399_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_19399_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_19399_full: ### IGT changes ### #### Possible regressions #### * igt@gem_exec_reloc@basic-many-active@vcs1: - shard-iclb: NOTRUN -> [FAIL][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb2/igt@gem_exec_reloc@basic-many-active@vcs1.html * igt@i915_pm_rps@reset: - shard-snb: [PASS][2] -> [FAIL][3] [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-snb4/igt@i915_pm_rps@reset.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-snb4/igt@i915_pm_rps@reset.html Known issues ------------ Here are the changes found in Patchwork_19399_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_persistence@engines-mixed: - shard-hsw: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#1099]) +2 similar issues [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-hsw2/igt@gem_ctx_persistence@engines-mixed.html * igt@gem_exec_capture@pi@rcs0: - shard-skl: [PASS][5] -> [INCOMPLETE][6] ([i915#2369] / [i915#2502]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl2/igt@gem_exec_capture@pi@rcs0.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl2/igt@gem_exec_capture@pi@rcs0.html * igt@gem_exec_fair@basic-none-solo@rcs0: - shard-kbl: [PASS][7] -> [FAIL][8] ([i915#2842]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-kbl6/igt@gem_exec_fair@basic-none-solo@rcs0.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl7/igt@gem_exec_fair@basic-none-solo@rcs0.html * igt@gem_exec_reloc@basic-wide-active@vcs1: - shard-iclb: NOTRUN -> [FAIL][9] ([i915#2389]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb4/igt@gem_exec_reloc@basic-wide-active@vcs1.html * igt@gem_render_copy@y-tiled-to-vebox-linear: - shard-hsw: NOTRUN -> [SKIP][10] ([fdo#109271]) +158 similar issues [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-hsw2/igt@gem_render_copy@y-tiled-to-vebox-linear.html * igt@gem_workarounds@suspend-resume-fd: - shard-kbl: [PASS][11] -> [DMESG-WARN][12] ([i915#180]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html * igt@kms_async_flips@alternate-sync-async-flip: - shard-skl: [PASS][13] -> [FAIL][14] ([i915#2521]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl2/igt@kms_async_flips@alternate-sync-async-flip.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl2/igt@kms_async_flips@alternate-sync-async-flip.html * igt@kms_chamelium@hdmi-aspect-ratio: - shard-hsw: NOTRUN -> [SKIP][15] ([fdo#109271] / [fdo#111827]) +11 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-hsw2/igt@kms_chamelium@hdmi-aspect-ratio.html * igt@kms_color_chamelium@pipe-a-ctm-green-to-red: - shard-skl: NOTRUN -> [SKIP][16] ([fdo#109271] / [fdo#111827]) +2 similar issues [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/igt@kms_color_chamelium@pipe-a-ctm-green-to-red.html * igt@kms_cursor_crc@pipe-b-cursor-64x64-sliding: - shard-skl: NOTRUN -> [FAIL][17] ([i915#54]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/igt@kms_cursor_crc@pipe-b-cursor-64x64-sliding.html * igt@kms_cursor_crc@pipe-c-cursor-64x21-random: - shard-skl: [PASS][18] -> [FAIL][19] ([i915#54]) +12 similar issues [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@kms_cursor_crc@pipe-c-cursor-64x21-random.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl9/igt@kms_cursor_crc@pipe-c-cursor-64x21-random.html * igt@kms_draw_crc@draw-method-rgb565-render-xtiled: - shard-skl: [PASS][20] -> [DMESG-WARN][21] ([i915#1982]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@kms_draw_crc@draw-method-rgb565-render-xtiled.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl9/igt@kms_draw_crc@draw-method-rgb565-render-xtiled.html * igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2: - shard-glk: [PASS][22] -> [FAIL][23] ([i915#2122]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk1/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk3/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2.html * igt@kms_flip@bo-too-big@a-hdmi-a1: - shard-glk: [PASS][24] -> [DMESG-WARN][25] ([i915#118] / [i915#95]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk6/igt@kms_flip@bo-too-big@a-hdmi-a1.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk1/igt@kms_flip@bo-too-big@a-hdmi-a1.html * igt@kms_flip@flip-vs-suspend-interruptible@a-edp1: - shard-skl: [PASS][26] -> [INCOMPLETE][27] ([i915#198] / [i915#1982]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl10/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl1/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html * igt@kms_flip@flip-vs-suspend@a-dp1: - shard-apl: [PASS][28] -> [DMESG-WARN][29] ([i915#180]) +2 similar issues [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-apl1/igt@kms_flip@flip-vs-suspend@a-dp1.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-apl6/igt@kms_flip@flip-vs-suspend@a-dp1.html * igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1: - shard-skl: [PASS][30] -> [FAIL][31] ([i915#2122]) +4 similar issues [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl5/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl4/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt: - shard-skl: NOTRUN -> [SKIP][32] ([fdo#109271]) +26 similar issues [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt.html * igt@kms_pipe_crc_basic@read-crc-pipe-a: - shard-glk: [PASS][33] -> [FAIL][34] ([i915#53]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk6/igt@kms_pipe_crc_basic@read-crc-pipe-a.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk1/igt@kms_pipe_crc_basic@read-crc-pipe-a.html * igt@kms_plane_alpha_blend@pipe-a-alpha-7efc: - shard-skl: NOTRUN -> [FAIL][35] ([fdo#108145] / [i915#265]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html * igt@kms_psr@psr2_suspend: - shard-iclb: [PASS][36] -> [SKIP][37] ([fdo#109441]) +2 similar issues [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb2/igt@kms_psr@psr2_suspend.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb1/igt@kms_psr@psr2_suspend.html #### Possible fixes #### * igt@feature_discovery@psr2: - shard-iclb: [SKIP][38] ([i915#658]) -> [PASS][39] [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb6/igt@feature_discovery@psr2.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb2/igt@feature_discovery@psr2.html * igt@gem_ctx_persistence@close-replace-race: - shard-glk: [TIMEOUT][40] ([i915#2918]) -> [PASS][41] [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk4/igt@gem_ctx_persistence@close-replace-race.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk6/igt@gem_ctx_persistence@close-replace-race.html * igt@gem_exec_fair@basic-flow@rcs0: - shard-tglb: [FAIL][42] ([i915#2842]) -> [PASS][43] [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-tglb6/igt@gem_exec_fair@basic-flow@rcs0.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-tglb3/igt@gem_exec_fair@basic-flow@rcs0.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-iclb: [FAIL][44] ([i915#2842]) -> [PASS][45] [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb7/igt@gem_exec_fair@basic-none-share@rcs0.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb3/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-none@vcs0: - shard-kbl: [FAIL][46] ([i915#2842]) -> [PASS][47] +2 similar issues [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-kbl2/igt@gem_exec_fair@basic-none@vcs0.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl3/igt@gem_exec_fair@basic-none@vcs0.html * {igt@gem_exec_fair@basic-none@vecs0}: - shard-apl: [FAIL][48] ([i915#2842]) -> [PASS][49] [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-apl8/igt@gem_exec_fair@basic-none@vecs0.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-apl7/igt@gem_exec_fair@basic-none@vecs0.html * {igt@gem_exec_fair@basic-pace-share@rcs0}: - shard-glk: [FAIL][50] ([i915#2842]) -> [PASS][51] +1 similar issue [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk1/igt@gem_exec_fair@basic-pace-share@rcs0.html * {igt@gem_exec_schedule@u-fairslice@rcs0}: - shard-skl: [DMESG-WARN][52] ([i915#1610] / [i915#2803]) -> [PASS][53] [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl10/igt@gem_exec_schedule@u-fairslice@rcs0.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/igt@gem_exec_schedule@u-fairslice@rcs0.html * igt@kms_color@pipe-a-ctm-0-5: - shard-skl: [DMESG-WARN][54] ([i915#1982]) -> [PASS][55] [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@kms_color@pipe-a-ctm-0-5.html [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl9/igt@kms_color@pipe-a-ctm-0-5.html * igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen: - shard-skl: [FAIL][56] ([i915#54]) -> [PASS][57] +3 similar issues [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen.html * igt@kms_cursor_edge_walk@pipe-a-64x64-top-edge: - shard-glk: [DMESG-WARN][58] ([i915#118] / [i915#95]) -> [PASS][59] [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk6/igt@kms_cursor_edge_walk@pipe-a-64x64-top-edge.html [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk1/igt@kms_cursor_edge_walk@pipe-a-64x64-top-edge.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1: - shard-skl: [FAIL][60] ([i915#79]) -> [PASS][61] [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html * igt@kms_flip@flip-vs-expired-vblank@c-dp1: - shard-apl: [FAIL][62] ([i915#79]) -> [PASS][63] [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-apl2/igt@kms_flip@flip-vs-expired-vblank@c-dp1.html [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-apl1/igt@kms_flip@flip-vs-expired-vblank@c-dp1.html * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc: - shard-skl: [FAIL][64] ([fdo#108145] / [i915#265]) -> [PASS][65] [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl3/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html * igt@kms_psr@psr2_sprite_render: - shard-iclb: [SKIP][66] ([fdo#109441]) -> [PASS][67] +1 similar issue [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb6/igt@kms_psr@psr2_sprite_render.html [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb2/igt@kms_psr@psr2_sprite_render.html * igt@perf@short-reads: - shard-skl: [FAIL][68] ([i915#51]) -> [PASS][69] [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl2/igt@perf@short-reads.html [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl2/igt@perf@short-reads.html #### Warnings #### * igt@i915_pm_rc6_residency@rc6-fence: - shard-iclb: [WARN][70] ([i915#2684]) -> [WARN][71] ([i915#2681] / [i915#2684]) [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb2/igt@i915_pm_rc6_residency@rc6-fence.html [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb1/igt@i915_pm_rc6_residency@rc6-fence.html * igt@i915_pm_rc6_residency@rc6-idle: - shard-iclb: [WARN][72] ([i915#1804] / [i915#2684]) -> [WARN][73] ([i915#2684]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb4/igt@i915_pm_rc6_residency@rc6-idle.html [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb2/igt@i915_pm_rc6_residency@rc6-idle.html * igt@runner@aborted: - shard-kbl: [FAIL][74] ([i915#2295] / [i915#2505]) -> ([FAIL][75], [FAIL][76], [FAIL][77]) ([i915#2292] / [i915#2295]) [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-kbl6/igt@runner@aborted.html [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl3/igt@runner@aborted.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl2/igt@runner@aborted.html [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl3/igt@runner@aborted.html - shard-skl: ([FAIL][78], [FAIL][79], [FAIL][80]) ([i915#2029] / [i915#2295] / [i915#2426]) -> [FAIL][81] ([i915#2295]) [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl5/igt@runner@aborted.html [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl10/igt@runner@aborted.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl3/igt@runner@aborted.html [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl3/igt@runner@aborted.html ### Piglit changes ### #### Issues hit #### * spec@ext_framebuffer_multisample_blit_scaled@blit-scaled samples=2: - pig-glk-j5005: NOTRUN -> [WARN][82] ([mesa#1797]) +1 similar issue [82]: None {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804 [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2292]: https://gitlab.freedesktop.org/drm/intel/issues/2292 [i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295 [i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369 [i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389 [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426 [i915#2502]: https://gitlab.freedesktop.org/drm/intel/issues/2502 [i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505 [i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681 [i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684 [i915#2803]: https://gitlab.freedesktop.org/drm/intel/issues/2803 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849 [i915#2918]: https://gitlab.freedesktop.org/drm/intel/issues/2918 [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 [i915#51]: https://gitlab.freedesktop.org/drm/intel/issues/51 [i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53 [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 [mesa#1797]: https://gitlab.freedesktop.org/mesa/mesa/issues/1797 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * Linux: CI_DRM_9636 -> Patchwork_19399 CI-20190529: 20190529 CI_DRM_9636: f560ac388c527f2f166897c9091f7b9ad652050f @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5960: ace82fcd5f3623f8dde7c220a825873dc53dfae4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_19399: f21bd65b0c50affc5cbf3e239ff26377e129ae68 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/index.html [-- Attachment #1.2: Type: text/html, Size: 22872 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dp: Prevent setting the LTTPR LT mode if no LTTPRs are detected 2021-01-19 1:46 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork @ 2021-01-29 20:18 ` Imre Deak 2021-01-29 21:16 ` Vudum, Lakshminarayana 0 siblings, 1 reply; 9+ messages in thread From: Imre Deak @ 2021-01-29 20:18 UTC (permalink / raw) To: intel-gfx, Khaled Almahallawy; +Cc: Lakshminarayana Vudum On Tue, Jan 19, 2021 at 01:46:54AM +0000, Patchwork wrote: > == Series Details == > > Series: drm/i915/dp: Prevent setting the LTTPR LT mode if no LTTPRs are detected > URL : https://patchwork.freedesktop.org/series/86007/ > State : failure Thanks for the review pushed to -din. The failures are unrelated see below. > > == Summary == > > CI Bug Log - changes from CI_DRM_9636_full -> Patchwork_19399_full > ==================================================== > > Summary > ------- > > **FAILURE** > > Serious unknown changes coming with Patchwork_19399_full absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_19399_full, please notify your bug team to allow them > to document this new failure mode, which will reduce false positives in CI. > > > > Possible new issues > ------------------- > > Here are the unknown changes that may have been introduced in Patchwork_19399_full: > > ### IGT changes ### > > #### Possible regressions #### > > * igt@gem_exec_reloc@basic-many-active@vcs1: > - shard-iclb: NOTRUN -> [FAIL][1] > [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb2/igt@gem_exec_reloc@basic-many-active@vcs1.html This looks like https://gitlab.freedesktop.org/drm/intel/-/issues/2389 > > * igt@i915_pm_rps@reset: > - shard-snb: [PASS][2] -> [FAIL][3] > [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-snb4/igt@i915_pm_rps@reset.html > [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-snb4/igt@i915_pm_rps@reset.html There is no DP connected to this machine, so the change makes no difference here. > > > Known issues > ------------ > > Here are the changes found in Patchwork_19399_full that come from known issues: > > ### IGT changes ### > > #### Issues hit #### > > * igt@gem_ctx_persistence@engines-mixed: > - shard-hsw: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#1099]) +2 similar issues > [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-hsw2/igt@gem_ctx_persistence@engines-mixed.html > > * igt@gem_exec_capture@pi@rcs0: > - shard-skl: [PASS][5] -> [INCOMPLETE][6] ([i915#2369] / [i915#2502]) > [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl2/igt@gem_exec_capture@pi@rcs0.html > [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl2/igt@gem_exec_capture@pi@rcs0.html > > * igt@gem_exec_fair@basic-none-solo@rcs0: > - shard-kbl: [PASS][7] -> [FAIL][8] ([i915#2842]) > [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-kbl6/igt@gem_exec_fair@basic-none-solo@rcs0.html > [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl7/igt@gem_exec_fair@basic-none-solo@rcs0.html > > * igt@gem_exec_reloc@basic-wide-active@vcs1: > - shard-iclb: NOTRUN -> [FAIL][9] ([i915#2389]) > [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb4/igt@gem_exec_reloc@basic-wide-active@vcs1.html > > * igt@gem_render_copy@y-tiled-to-vebox-linear: > - shard-hsw: NOTRUN -> [SKIP][10] ([fdo#109271]) +158 similar issues > [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-hsw2/igt@gem_render_copy@y-tiled-to-vebox-linear.html > > * igt@gem_workarounds@suspend-resume-fd: > - shard-kbl: [PASS][11] -> [DMESG-WARN][12] ([i915#180]) > [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html > [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html > > * igt@kms_async_flips@alternate-sync-async-flip: > - shard-skl: [PASS][13] -> [FAIL][14] ([i915#2521]) > [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl2/igt@kms_async_flips@alternate-sync-async-flip.html > [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl2/igt@kms_async_flips@alternate-sync-async-flip.html > > * igt@kms_chamelium@hdmi-aspect-ratio: > - shard-hsw: NOTRUN -> [SKIP][15] ([fdo#109271] / [fdo#111827]) +11 similar issues > [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-hsw2/igt@kms_chamelium@hdmi-aspect-ratio.html > > * igt@kms_color_chamelium@pipe-a-ctm-green-to-red: > - shard-skl: NOTRUN -> [SKIP][16] ([fdo#109271] / [fdo#111827]) +2 similar issues > [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/igt@kms_color_chamelium@pipe-a-ctm-green-to-red.html > > * igt@kms_cursor_crc@pipe-b-cursor-64x64-sliding: > - shard-skl: NOTRUN -> [FAIL][17] ([i915#54]) > [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/igt@kms_cursor_crc@pipe-b-cursor-64x64-sliding.html > > * igt@kms_cursor_crc@pipe-c-cursor-64x21-random: > - shard-skl: [PASS][18] -> [FAIL][19] ([i915#54]) +12 similar issues > [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@kms_cursor_crc@pipe-c-cursor-64x21-random.html > [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl9/igt@kms_cursor_crc@pipe-c-cursor-64x21-random.html > > * igt@kms_draw_crc@draw-method-rgb565-render-xtiled: > - shard-skl: [PASS][20] -> [DMESG-WARN][21] ([i915#1982]) > [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@kms_draw_crc@draw-method-rgb565-render-xtiled.html > [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl9/igt@kms_draw_crc@draw-method-rgb565-render-xtiled.html > > * igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2: > - shard-glk: [PASS][22] -> [FAIL][23] ([i915#2122]) > [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk1/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2.html > [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk3/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2.html > > * igt@kms_flip@bo-too-big@a-hdmi-a1: > - shard-glk: [PASS][24] -> [DMESG-WARN][25] ([i915#118] / [i915#95]) > [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk6/igt@kms_flip@bo-too-big@a-hdmi-a1.html > [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk1/igt@kms_flip@bo-too-big@a-hdmi-a1.html > > * igt@kms_flip@flip-vs-suspend-interruptible@a-edp1: > - shard-skl: [PASS][26] -> [INCOMPLETE][27] ([i915#198] / [i915#1982]) > [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl10/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html > [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl1/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html > > * igt@kms_flip@flip-vs-suspend@a-dp1: > - shard-apl: [PASS][28] -> [DMESG-WARN][29] ([i915#180]) +2 similar issues > [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-apl1/igt@kms_flip@flip-vs-suspend@a-dp1.html > [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-apl6/igt@kms_flip@flip-vs-suspend@a-dp1.html > > * igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1: > - shard-skl: [PASS][30] -> [FAIL][31] ([i915#2122]) +4 similar issues > [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl5/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html > [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl4/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html > > * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt: > - shard-skl: NOTRUN -> [SKIP][32] ([fdo#109271]) +26 similar issues > [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt.html > > * igt@kms_pipe_crc_basic@read-crc-pipe-a: > - shard-glk: [PASS][33] -> [FAIL][34] ([i915#53]) > [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk6/igt@kms_pipe_crc_basic@read-crc-pipe-a.html > [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk1/igt@kms_pipe_crc_basic@read-crc-pipe-a.html > > * igt@kms_plane_alpha_blend@pipe-a-alpha-7efc: > - shard-skl: NOTRUN -> [FAIL][35] ([fdo#108145] / [i915#265]) > [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html > > * igt@kms_psr@psr2_suspend: > - shard-iclb: [PASS][36] -> [SKIP][37] ([fdo#109441]) +2 similar issues > [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb2/igt@kms_psr@psr2_suspend.html > [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb1/igt@kms_psr@psr2_suspend.html > > > #### Possible fixes #### > > * igt@feature_discovery@psr2: > - shard-iclb: [SKIP][38] ([i915#658]) -> [PASS][39] > [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb6/igt@feature_discovery@psr2.html > [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb2/igt@feature_discovery@psr2.html > > * igt@gem_ctx_persistence@close-replace-race: > - shard-glk: [TIMEOUT][40] ([i915#2918]) -> [PASS][41] > [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk4/igt@gem_ctx_persistence@close-replace-race.html > [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk6/igt@gem_ctx_persistence@close-replace-race.html > > * igt@gem_exec_fair@basic-flow@rcs0: > - shard-tglb: [FAIL][42] ([i915#2842]) -> [PASS][43] > [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-tglb6/igt@gem_exec_fair@basic-flow@rcs0.html > [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-tglb3/igt@gem_exec_fair@basic-flow@rcs0.html > > * igt@gem_exec_fair@basic-none-share@rcs0: > - shard-iclb: [FAIL][44] ([i915#2842]) -> [PASS][45] > [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb7/igt@gem_exec_fair@basic-none-share@rcs0.html > [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb3/igt@gem_exec_fair@basic-none-share@rcs0.html > > * igt@gem_exec_fair@basic-none@vcs0: > - shard-kbl: [FAIL][46] ([i915#2842]) -> [PASS][47] +2 similar issues > [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-kbl2/igt@gem_exec_fair@basic-none@vcs0.html > [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl3/igt@gem_exec_fair@basic-none@vcs0.html > > * {igt@gem_exec_fair@basic-none@vecs0}: > - shard-apl: [FAIL][48] ([i915#2842]) -> [PASS][49] > [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-apl8/igt@gem_exec_fair@basic-none@vecs0.html > [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-apl7/igt@gem_exec_fair@basic-none@vecs0.html > > * {igt@gem_exec_fair@basic-pace-share@rcs0}: > - shard-glk: [FAIL][50] ([i915#2842]) -> [PASS][51] +1 similar issue > [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html > [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk1/igt@gem_exec_fair@basic-pace-share@rcs0.html > > * {igt@gem_exec_schedule@u-fairslice@rcs0}: > - shard-skl: [DMESG-WARN][52] ([i915#1610] / [i915#2803]) -> [PASS][53] > [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl10/igt@gem_exec_schedule@u-fairslice@rcs0.html > [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/igt@gem_exec_schedule@u-fairslice@rcs0.html > > * igt@kms_color@pipe-a-ctm-0-5: > - shard-skl: [DMESG-WARN][54] ([i915#1982]) -> [PASS][55] > [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@kms_color@pipe-a-ctm-0-5.html > [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl9/igt@kms_color@pipe-a-ctm-0-5.html > > * igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen: > - shard-skl: [FAIL][56] ([i915#54]) -> [PASS][57] +3 similar issues > [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen.html > [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen.html > > * igt@kms_cursor_edge_walk@pipe-a-64x64-top-edge: > - shard-glk: [DMESG-WARN][58] ([i915#118] / [i915#95]) -> [PASS][59] > [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk6/igt@kms_cursor_edge_walk@pipe-a-64x64-top-edge.html > [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk1/igt@kms_cursor_edge_walk@pipe-a-64x64-top-edge.html > > * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1: > - shard-skl: [FAIL][60] ([i915#79]) -> [PASS][61] > [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html > [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html > > * igt@kms_flip@flip-vs-expired-vblank@c-dp1: > - shard-apl: [FAIL][62] ([i915#79]) -> [PASS][63] > [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-apl2/igt@kms_flip@flip-vs-expired-vblank@c-dp1.html > [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-apl1/igt@kms_flip@flip-vs-expired-vblank@c-dp1.html > > * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc: > - shard-skl: [FAIL][64] ([fdo#108145] / [i915#265]) -> [PASS][65] > [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html > [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl3/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html > > * igt@kms_psr@psr2_sprite_render: > - shard-iclb: [SKIP][66] ([fdo#109441]) -> [PASS][67] +1 similar issue > [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb6/igt@kms_psr@psr2_sprite_render.html > [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb2/igt@kms_psr@psr2_sprite_render.html > > * igt@perf@short-reads: > - shard-skl: [FAIL][68] ([i915#51]) -> [PASS][69] > [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl2/igt@perf@short-reads.html > [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl2/igt@perf@short-reads.html > > > #### Warnings #### > > * igt@i915_pm_rc6_residency@rc6-fence: > - shard-iclb: [WARN][70] ([i915#2684]) -> [WARN][71] ([i915#2681] / [i915#2684]) > [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb2/igt@i915_pm_rc6_residency@rc6-fence.html > [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb1/igt@i915_pm_rc6_residency@rc6-fence.html > > * igt@i915_pm_rc6_residency@rc6-idle: > - shard-iclb: [WARN][72] ([i915#1804] / [i915#2684]) -> [WARN][73] ([i915#2684]) > [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb4/igt@i915_pm_rc6_residency@rc6-idle.html > [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb2/igt@i915_pm_rc6_residency@rc6-idle.html > > * igt@runner@aborted: > - shard-kbl: [FAIL][74] ([i915#2295] / [i915#2505]) -> ([FAIL][75], [FAIL][76], [FAIL][77]) ([i915#2292] / [i915#2295]) > [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-kbl6/igt@runner@aborted.html > [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl3/igt@runner@aborted.html > [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl2/igt@runner@aborted.html > [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl3/igt@runner@aborted.html > - shard-skl: ([FAIL][78], [FAIL][79], [FAIL][80]) ([i915#2029] / [i915#2295] / [i915#2426]) -> [FAIL][81] ([i915#2295]) > [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl5/igt@runner@aborted.html > [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl10/igt@runner@aborted.html > [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl3/igt@runner@aborted.html > [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl3/igt@runner@aborted.html > > > > ### Piglit changes ### > > #### Issues hit #### > > * spec@ext_framebuffer_multisample_blit_scaled@blit-scaled samples=2: > - pig-glk-j5005: NOTRUN -> [WARN][82] ([mesa#1797]) +1 similar issue > [82]: None > > > {name}: This element is suppressed. This means it is ignored when computing > the status of the difference (SUCCESS, WARNING, or FAILURE). > > [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 > [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 > [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 > [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 > [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099 > [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 > [i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610 > [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 > [i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804 > [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198 > [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 > [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029 > [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 > [i915#2292]: https://gitlab.freedesktop.org/drm/intel/issues/2292 > [i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295 > [i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369 > [i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389 > [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426 > [i915#2502]: https://gitlab.freedesktop.org/drm/intel/issues/2502 > [i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505 > [i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521 > [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 > [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681 > [i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684 > [i915#2803]: https://gitlab.freedesktop.org/drm/intel/issues/2803 > [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 > [i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849 > [i915#2918]: https://gitlab.freedesktop.org/drm/intel/issues/2918 > [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 > [i915#51]: https://gitlab.freedesktop.org/drm/intel/issues/51 > [i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53 > [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 > [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 > [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 > [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 > [mesa#1797]: https://gitlab.freedesktop.org/mesa/mesa/issues/1797 > > > Participating hosts (10 -> 10) > ------------------------------ > > No changes in participating hosts > > > Build changes > ------------- > > * Linux: CI_DRM_9636 -> Patchwork_19399 > > CI-20190529: 20190529 > CI_DRM_9636: f560ac388c527f2f166897c9091f7b9ad652050f @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_5960: ace82fcd5f3623f8dde7c220a825873dc53dfae4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools > Patchwork_19399: f21bd65b0c50affc5cbf3e239ff26377e129ae68 @ git://anongit.freedesktop.org/gfx-ci/linux > piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dp: Prevent setting the LTTPR LT mode if no LTTPRs are detected 2021-01-29 20:18 ` Imre Deak @ 2021-01-29 21:16 ` Vudum, Lakshminarayana 0 siblings, 0 replies; 9+ messages in thread From: Vudum, Lakshminarayana @ 2021-01-29 21:16 UTC (permalink / raw) To: Deak, Imre, intel-gfx, Almahallawy, Khaled Re-reported. -----Original Message----- From: Imre Deak <imre.deak@intel.com> Sent: Friday, January 29, 2021 12:18 PM To: intel-gfx@lists.freedesktop.org; Almahallawy, Khaled <khaled.almahallawy@intel.com> Cc: Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com> Subject: Re: ✗ Fi.CI.IGT: failure for drm/i915/dp: Prevent setting the LTTPR LT mode if no LTTPRs are detected On Tue, Jan 19, 2021 at 01:46:54AM +0000, Patchwork wrote: > == Series Details == > > Series: drm/i915/dp: Prevent setting the LTTPR LT mode if no LTTPRs are detected > URL : https://patchwork.freedesktop.org/series/86007/ > State : failure Thanks for the review pushed to -din. The failures are unrelated see below. > > == Summary == > > CI Bug Log - changes from CI_DRM_9636_full -> Patchwork_19399_full > ==================================================== > > Summary > ------- > > **FAILURE** > > Serious unknown changes coming with Patchwork_19399_full absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_19399_full, please notify your bug team to allow them > to document this new failure mode, which will reduce false positives in CI. > > > > Possible new issues > ------------------- > > Here are the unknown changes that may have been introduced in Patchwork_19399_full: > > ### IGT changes ### > > #### Possible regressions #### > > * igt@gem_exec_reloc@basic-many-active@vcs1: > - shard-iclb: NOTRUN -> [FAIL][1] > [1]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb2/i > gt@gem_exec_reloc@basic-many-active@vcs1.html This looks like https://gitlab.freedesktop.org/drm/intel/-/issues/2389 > > * igt@i915_pm_rps@reset: > - shard-snb: [PASS][2] -> [FAIL][3] > [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-snb4/igt@i915_pm_rps@reset.html > [3]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-snb4/ig > t@i915_pm_rps@reset.html There is no DP connected to this machine, so the change makes no difference here. > > > Known issues > ------------ > > Here are the changes found in Patchwork_19399_full that come from known issues: > > ### IGT changes ### > > #### Issues hit #### > > * igt@gem_ctx_persistence@engines-mixed: > - shard-hsw: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#1099]) +2 similar issues > [4]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-hsw2/ig > t@gem_ctx_persistence@engines-mixed.html > > * igt@gem_exec_capture@pi@rcs0: > - shard-skl: [PASS][5] -> [INCOMPLETE][6] ([i915#2369] / [i915#2502]) > [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl2/igt@gem_exec_capture@pi@rcs0.html > [6]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl2/ig > t@gem_exec_capture@pi@rcs0.html > > * igt@gem_exec_fair@basic-none-solo@rcs0: > - shard-kbl: [PASS][7] -> [FAIL][8] ([i915#2842]) > [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-kbl6/igt@gem_exec_fair@basic-none-solo@rcs0.html > [8]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl7/ig > t@gem_exec_fair@basic-none-solo@rcs0.html > > * igt@gem_exec_reloc@basic-wide-active@vcs1: > - shard-iclb: NOTRUN -> [FAIL][9] ([i915#2389]) > [9]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb4/i > gt@gem_exec_reloc@basic-wide-active@vcs1.html > > * igt@gem_render_copy@y-tiled-to-vebox-linear: > - shard-hsw: NOTRUN -> [SKIP][10] ([fdo#109271]) +158 similar issues > [10]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-hsw2/ig > t@gem_render_copy@y-tiled-to-vebox-linear.html > > * igt@gem_workarounds@suspend-resume-fd: > - shard-kbl: [PASS][11] -> [DMESG-WARN][12] ([i915#180]) > [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html > [12]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl3/ig > t@gem_workarounds@suspend-resume-fd.html > > * igt@kms_async_flips@alternate-sync-async-flip: > - shard-skl: [PASS][13] -> [FAIL][14] ([i915#2521]) > [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl2/igt@kms_async_flips@alternate-sync-async-flip.html > [14]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl2/ig > t@kms_async_flips@alternate-sync-async-flip.html > > * igt@kms_chamelium@hdmi-aspect-ratio: > - shard-hsw: NOTRUN -> [SKIP][15] ([fdo#109271] / [fdo#111827]) +11 similar issues > [15]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-hsw2/ig > t@kms_chamelium@hdmi-aspect-ratio.html > > * igt@kms_color_chamelium@pipe-a-ctm-green-to-red: > - shard-skl: NOTRUN -> [SKIP][16] ([fdo#109271] / [fdo#111827]) +2 similar issues > [16]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/ig > t@kms_color_chamelium@pipe-a-ctm-green-to-red.html > > * igt@kms_cursor_crc@pipe-b-cursor-64x64-sliding: > - shard-skl: NOTRUN -> [FAIL][17] ([i915#54]) > [17]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/ig > t@kms_cursor_crc@pipe-b-cursor-64x64-sliding.html > > * igt@kms_cursor_crc@pipe-c-cursor-64x21-random: > - shard-skl: [PASS][18] -> [FAIL][19] ([i915#54]) +12 similar issues > [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@kms_cursor_crc@pipe-c-cursor-64x21-random.html > [19]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl9/ig > t@kms_cursor_crc@pipe-c-cursor-64x21-random.html > > * igt@kms_draw_crc@draw-method-rgb565-render-xtiled: > - shard-skl: [PASS][20] -> [DMESG-WARN][21] ([i915#1982]) > [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@kms_draw_crc@draw-method-rgb565-render-xtiled.html > [21]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl9/ig > t@kms_draw_crc@draw-method-rgb565-render-xtiled.html > > * igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2: > - shard-glk: [PASS][22] -> [FAIL][23] ([i915#2122]) > [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk1/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2.html > [23]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk3/ig > t@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2.htm > l > > * igt@kms_flip@bo-too-big@a-hdmi-a1: > - shard-glk: [PASS][24] -> [DMESG-WARN][25] ([i915#118] / [i915#95]) > [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk6/igt@kms_flip@bo-too-big@a-hdmi-a1.html > [25]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk1/ig > t@kms_flip@bo-too-big@a-hdmi-a1.html > > * igt@kms_flip@flip-vs-suspend-interruptible@a-edp1: > - shard-skl: [PASS][26] -> [INCOMPLETE][27] ([i915#198] / [i915#1982]) > [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl10/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html > [27]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl1/ig > t@kms_flip@flip-vs-suspend-interruptible@a-edp1.html > > * igt@kms_flip@flip-vs-suspend@a-dp1: > - shard-apl: [PASS][28] -> [DMESG-WARN][29] ([i915#180]) +2 similar issues > [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-apl1/igt@kms_flip@flip-vs-suspend@a-dp1.html > [29]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-apl6/ig > t@kms_flip@flip-vs-suspend@a-dp1.html > > * igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1: > - shard-skl: [PASS][30] -> [FAIL][31] ([i915#2122]) +4 similar issues > [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl5/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html > [31]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl4/ig > t@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html > > * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt: > - shard-skl: NOTRUN -> [SKIP][32] ([fdo#109271]) +26 similar issues > [32]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/ig > t@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt.html > > * igt@kms_pipe_crc_basic@read-crc-pipe-a: > - shard-glk: [PASS][33] -> [FAIL][34] ([i915#53]) > [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk6/igt@kms_pipe_crc_basic@read-crc-pipe-a.html > [34]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk1/ig > t@kms_pipe_crc_basic@read-crc-pipe-a.html > > * igt@kms_plane_alpha_blend@pipe-a-alpha-7efc: > - shard-skl: NOTRUN -> [FAIL][35] ([fdo#108145] / [i915#265]) > [35]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/ig > t@kms_plane_alpha_blend@pipe-a-alpha-7efc.html > > * igt@kms_psr@psr2_suspend: > - shard-iclb: [PASS][36] -> [SKIP][37] ([fdo#109441]) +2 similar issues > [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb2/igt@kms_psr@psr2_suspend.html > [37]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb1/i > gt@kms_psr@psr2_suspend.html > > > #### Possible fixes #### > > * igt@feature_discovery@psr2: > - shard-iclb: [SKIP][38] ([i915#658]) -> [PASS][39] > [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb6/igt@feature_discovery@psr2.html > [39]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb2/i > gt@feature_discovery@psr2.html > > * igt@gem_ctx_persistence@close-replace-race: > - shard-glk: [TIMEOUT][40] ([i915#2918]) -> [PASS][41] > [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk4/igt@gem_ctx_persistence@close-replace-race.html > [41]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk6/ig > t@gem_ctx_persistence@close-replace-race.html > > * igt@gem_exec_fair@basic-flow@rcs0: > - shard-tglb: [FAIL][42] ([i915#2842]) -> [PASS][43] > [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-tglb6/igt@gem_exec_fair@basic-flow@rcs0.html > [43]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-tglb3/i > gt@gem_exec_fair@basic-flow@rcs0.html > > * igt@gem_exec_fair@basic-none-share@rcs0: > - shard-iclb: [FAIL][44] ([i915#2842]) -> [PASS][45] > [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb7/igt@gem_exec_fair@basic-none-share@rcs0.html > [45]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb3/i > gt@gem_exec_fair@basic-none-share@rcs0.html > > * igt@gem_exec_fair@basic-none@vcs0: > - shard-kbl: [FAIL][46] ([i915#2842]) -> [PASS][47] +2 similar issues > [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-kbl2/igt@gem_exec_fair@basic-none@vcs0.html > [47]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl3/ig > t@gem_exec_fair@basic-none@vcs0.html > > * {igt@gem_exec_fair@basic-none@vecs0}: > - shard-apl: [FAIL][48] ([i915#2842]) -> [PASS][49] > [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-apl8/igt@gem_exec_fair@basic-none@vecs0.html > [49]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-apl7/ig > t@gem_exec_fair@basic-none@vecs0.html > > * {igt@gem_exec_fair@basic-pace-share@rcs0}: > - shard-glk: [FAIL][50] ([i915#2842]) -> [PASS][51] +1 similar issue > [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html > [51]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk1/ig > t@gem_exec_fair@basic-pace-share@rcs0.html > > * {igt@gem_exec_schedule@u-fairslice@rcs0}: > - shard-skl: [DMESG-WARN][52] ([i915#1610] / [i915#2803]) -> [PASS][53] > [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl10/igt@gem_exec_schedule@u-fairslice@rcs0.html > [53]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/ig > t@gem_exec_schedule@u-fairslice@rcs0.html > > * igt@kms_color@pipe-a-ctm-0-5: > - shard-skl: [DMESG-WARN][54] ([i915#1982]) -> [PASS][55] > [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@kms_color@pipe-a-ctm-0-5.html > [55]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl9/ig > t@kms_color@pipe-a-ctm-0-5.html > > * igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen: > - shard-skl: [FAIL][56] ([i915#54]) -> [PASS][57] +3 similar issues > [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen.html > [57]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/ig > t@kms_cursor_crc@pipe-b-cursor-128x42-offscreen.html > > * igt@kms_cursor_edge_walk@pipe-a-64x64-top-edge: > - shard-glk: [DMESG-WARN][58] ([i915#118] / [i915#95]) -> [PASS][59] > [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk6/igt@kms_cursor_edge_walk@pipe-a-64x64-top-edge.html > [59]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk1/ig > t@kms_cursor_edge_walk@pipe-a-64x64-top-edge.html > > * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1: > - shard-skl: [FAIL][60] ([i915#79]) -> [PASS][61] > [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html > [61]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/ig > t@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html > > * igt@kms_flip@flip-vs-expired-vblank@c-dp1: > - shard-apl: [FAIL][62] ([i915#79]) -> [PASS][63] > [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-apl2/igt@kms_flip@flip-vs-expired-vblank@c-dp1.html > [63]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-apl1/ig > t@kms_flip@flip-vs-expired-vblank@c-dp1.html > > * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc: > - shard-skl: [FAIL][64] ([fdo#108145] / [i915#265]) -> [PASS][65] > [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html > [65]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl3/ig > t@kms_plane_alpha_blend@pipe-a-coverage-7efc.html > > * igt@kms_psr@psr2_sprite_render: > - shard-iclb: [SKIP][66] ([fdo#109441]) -> [PASS][67] +1 similar issue > [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb6/igt@kms_psr@psr2_sprite_render.html > [67]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb2/i > gt@kms_psr@psr2_sprite_render.html > > * igt@perf@short-reads: > - shard-skl: [FAIL][68] ([i915#51]) -> [PASS][69] > [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl2/igt@perf@short-reads.html > [69]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl2/ig > t@perf@short-reads.html > > > #### Warnings #### > > * igt@i915_pm_rc6_residency@rc6-fence: > - shard-iclb: [WARN][70] ([i915#2684]) -> [WARN][71] ([i915#2681] / [i915#2684]) > [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb2/igt@i915_pm_rc6_residency@rc6-fence.html > [71]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb1/i > gt@i915_pm_rc6_residency@rc6-fence.html > > * igt@i915_pm_rc6_residency@rc6-idle: > - shard-iclb: [WARN][72] ([i915#1804] / [i915#2684]) -> [WARN][73] ([i915#2684]) > [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb4/igt@i915_pm_rc6_residency@rc6-idle.html > [73]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb2/i > gt@i915_pm_rc6_residency@rc6-idle.html > > * igt@runner@aborted: > - shard-kbl: [FAIL][74] ([i915#2295] / [i915#2505]) -> ([FAIL][75], [FAIL][76], [FAIL][77]) ([i915#2292] / [i915#2295]) > [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-kbl6/igt@runner@aborted.html > [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl3/igt@runner@aborted.html > [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl2/igt@runner@aborted.html > [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl3/igt@runner@aborted.html > - shard-skl: ([FAIL][78], [FAIL][79], [FAIL][80]) ([i915#2029] / [i915#2295] / [i915#2426]) -> [FAIL][81] ([i915#2295]) > [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl5/igt@runner@aborted.html > [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl10/igt@runner@aborted.html > [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl3/igt@runner@aborted.html > [81]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl3/ig > t@runner@aborted.html > > > > ### Piglit changes ### > > #### Issues hit #### > > * spec@ext_framebuffer_multisample_blit_scaled@blit-scaled samples=2: > - pig-glk-j5005: NOTRUN -> [WARN][82] ([mesa#1797]) +1 similar issue > [82]: None > > > {name}: This element is suppressed. This means it is ignored when computing > the status of the difference (SUCCESS, WARNING, or FAILURE). > > [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 > [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 > [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 > [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 > [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099 > [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 > [i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610 > [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 > [i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804 > [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198 > [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 > [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029 > [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 > [i915#2292]: https://gitlab.freedesktop.org/drm/intel/issues/2292 > [i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295 > [i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369 > [i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389 > [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426 > [i915#2502]: https://gitlab.freedesktop.org/drm/intel/issues/2502 > [i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505 > [i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521 > [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 > [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681 > [i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684 > [i915#2803]: https://gitlab.freedesktop.org/drm/intel/issues/2803 > [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 > [i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849 > [i915#2918]: https://gitlab.freedesktop.org/drm/intel/issues/2918 > [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 > [i915#51]: https://gitlab.freedesktop.org/drm/intel/issues/51 > [i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53 > [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 > [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 > [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 > [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 > [mesa#1797]: https://gitlab.freedesktop.org/mesa/mesa/issues/1797 > > > Participating hosts (10 -> 10) > ------------------------------ > > No changes in participating hosts > > > Build changes > ------------- > > * Linux: CI_DRM_9636 -> Patchwork_19399 > > CI-20190529: 20190529 > CI_DRM_9636: f560ac388c527f2f166897c9091f7b9ad652050f @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_5960: ace82fcd5f3623f8dde7c220a825873dc53dfae4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools > Patchwork_19399: f21bd65b0c50affc5cbf3e239ff26377e129ae68 @ git://anongit.freedesktop.org/gfx-ci/linux > piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ > git://anongit.freedesktop.org/piglit > > == Logs == > > For more details see: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dp: Prevent setting the LTTPR LT mode if no LTTPRs are detected 2021-01-18 18:31 [Intel-gfx] [PATCH] drm/i915/dp: Prevent setting the LTTPR LT mode if no LTTPRs are detected Imre Deak 2021-01-18 20:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2021-01-19 1:46 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork @ 2021-01-19 6:47 ` Almahallawy, Khaled 2021-01-21 13:15 ` Imre Deak 2021-01-29 20:39 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork 3 siblings, 1 reply; 9+ messages in thread From: Almahallawy, Khaled @ 2021-01-19 6:47 UTC (permalink / raw) To: intel-gfx, Deak, Imre On Mon, 2021-01-18 at 20:31 +0200, Imre Deak wrote: > Atm, the driver programs explicitly the default transparent link > training mode (0x55) to DP_PHY_REPEATER_MODE even if no LTTPRs are > detected. > > This conforms to the spec (3.6.6.1): > "DP upstream devices that do not enable the Non-transparent mode of > LTTPRs shall program the PHY_REPEATER_MODE register (DPCD Address > F0003h) to 55h (default) prior to link training" > > however writing the default value to this DPCD register seems to > cause > occasional link training errors at least for a DELL WD19TB TBT dock, > when > no LTTPRs are detected. I think this patch is more aligned with: DP v2.0 SCR on 8b/10b DPTX and LTTPR Requirements Update to Section 3.6 The SCR made it clear that we only need to program PHY_REPEATER_MODE to transparent mode if we detect LTTPR. Quoting from SCR: “A DPTX supporting 3.2-ms AUX Reply Timeout shall issue AUX read transaction to LTTPR DPCD Capability and ID Field at DPCD F0000h ~ F0007 (refer to Section 3.6.4.1) as the first AUX transaction upon HPD signal assertion detection (1) to determine whether LTTPR’s are present in the link between itself and the downstream DPRX and (2) to put the LTTPR’s, if present, in LTTPR Transparent Mode.” Also section 3.6.6 title is updated as the following “Section 3.6.6 Link Training in LTTPR Non-transparent Mode”. This reflects it only relevant after we detect LTTPR. However it is still interesting that Dell Dock failed after setting LTTPR to transparent mode. Thank You for your effort to enable LTTPR. Khaled > > Writing to DP_PHY_REPEATER_MODE will also cause an unnecessary > timeout > on systems without any LTTPR. > > To fix the above two issues let's assume that setting the default > mode > is redundant when no LTTPRs are detected. Keep the existing behavior > and > program the default mode if more than 8 LTTPRs are detected or in > case > the read from DP_PHY_REPEATER_CNT returns an invalid value. > > References: https://gitlab.freedesktop.org/drm/intel/-/issues/2801 > Signed-off-by: Imre Deak <imre.deak@intel.com> > --- > .../drm/i915/display/intel_dp_link_training.c | 36 ++++++++--------- > -- > 1 file changed, 15 insertions(+), 21 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c > b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > index d8c6d7054d11..fad9e9874c7b 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > @@ -34,18 +34,6 @@ intel_dp_dump_link_status(const u8 > link_status[DP_LINK_STATUS_SIZE]) > link_status[3], link_status[4], link_status[5]); > } > > -static int intel_dp_lttpr_count(struct intel_dp *intel_dp) > -{ > - int count = drm_dp_lttpr_count(intel_dp->lttpr_common_caps); > - > - /* > - * Pretend no LTTPRs in case of LTTPR detection error, or > - * if too many (>8) LTTPRs are detected. This translates to > link > - * training in transparent mode. > - */ > - return count <= 0 ? 0 : count; > -} > - > static void intel_dp_reset_lttpr_count(struct intel_dp *intel_dp) > { > intel_dp->lttpr_common_caps[DP_PHY_REPEATER_CNT - > @@ -142,6 +130,17 @@ int intel_dp_lttpr_init(struct intel_dp > *intel_dp) > return 0; > > ret = intel_dp_read_lttpr_common_caps(intel_dp); > + if (!ret) > + return 0; > + > + lttpr_count = drm_dp_lttpr_count(intel_dp->lttpr_common_caps); > + /* > + * Prevent setting LTTPR transparent mode explicitly if no > LTTPRs are > + * detected as this breaks link training at least on the Dell > WD19TB > + * dock. > + */ > + if (lttpr_count == 0) > + return 0; > > /* > * See DP Standard v2.0 3.6.6.1. about the explicit disabling > of > @@ -150,17 +149,12 @@ int intel_dp_lttpr_init(struct intel_dp > *intel_dp) > */ > intel_dp_set_lttpr_transparent_mode(intel_dp, true); > > - if (!ret) > - return 0; > - > - lttpr_count = intel_dp_lttpr_count(intel_dp); > - > /* > * In case of unsupported number of LTTPRs or failing to switch > to > * non-transparent mode fall-back to transparent link training > mode, > * still taking into account any LTTPR common lane- rate/count > limits. > */ > - if (lttpr_count == 0) > + if (lttpr_count < 0) > return 0; > > if (!intel_dp_set_lttpr_transparent_mode(intel_dp, false)) { > @@ -222,11 +216,11 @@ intel_dp_phy_is_downstream_of_source(struct > intel_dp *intel_dp, > enum drm_dp_phy dp_phy) > { > struct drm_i915_private *i915 = dp_to_i915(intel_dp); > - int lttpr_count = intel_dp_lttpr_count(intel_dp); > + int lttpr_count = drm_dp_lttpr_count(intel_dp- > >lttpr_common_caps); > > - drm_WARN_ON_ONCE(&i915->drm, lttpr_count == 0 && dp_phy != > DP_PHY_DPRX); > + drm_WARN_ON_ONCE(&i915->drm, lttpr_count <= 0 && dp_phy != > DP_PHY_DPRX); > > - return lttpr_count == 0 || dp_phy == DP_PHY_LTTPR(lttpr_count - > 1); > + return lttpr_count <= 0 || dp_phy == DP_PHY_LTTPR(lttpr_count - > 1); > } > > static u8 intel_dp_phy_voltage_max(struct intel_dp *intel_dp, _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dp: Prevent setting the LTTPR LT mode if no LTTPRs are detected 2021-01-19 6:47 ` [Intel-gfx] [PATCH] " Almahallawy, Khaled @ 2021-01-21 13:15 ` Imre Deak 2021-01-28 20:22 ` Almahallawy, Khaled 0 siblings, 1 reply; 9+ messages in thread From: Imre Deak @ 2021-01-21 13:15 UTC (permalink / raw) To: Almahallawy, Khaled; +Cc: intel-gfx On Tue, Jan 19, 2021 at 08:47:25AM +0200, Almahallawy, Khaled wrote: > On Mon, 2021-01-18 at 20:31 +0200, Imre Deak wrote: > > Atm, the driver programs explicitly the default transparent link > > training mode (0x55) to DP_PHY_REPEATER_MODE even if no LTTPRs are > > detected. > > > > This conforms to the spec (3.6.6.1): > > "DP upstream devices that do not enable the Non-transparent mode of > > LTTPRs shall program the PHY_REPEATER_MODE register (DPCD Address > > F0003h) to 55h (default) prior to link training" > > > > however writing the default value to this DPCD register seems to > > cause > > occasional link training errors at least for a DELL WD19TB TBT dock, > > when > > no LTTPRs are detected. > > I think this patch is more aligned with: DP v2.0 SCR on 8b/10b DPTX and > LTTPR Requirements Update to Section 3.6 > > The SCR made it clear that we only need to program PHY_REPEATER_MODE to > transparent mode if we detect LTTPR. Yes, the updated version is clearer in this. In any case I don't see any reason now to set the default mode if there's no LTTPR on the link. > Quoting from SCR: > “A DPTX supporting 3.2-ms AUX Reply Timeout shall issue AUX read > transaction to LTTPR DPCD Capability and ID Field at DPCD F0000h ~ > F0007 (refer to Section 3.6.4.1) as the first AUX transaction upon HPD > signal assertion detection (1) to determine whether LTTPR’s are present > in the link between itself and the downstream DPRX and (2) to put the > LTTPR’s, if present, in LTTPR Transparent Mode.” > > Also section 3.6.6 title is updated as the following “Section 3.6.6 > Link Training in LTTPR Non-transparent Mode”. This reflects it only > relevant after we detect LTTPR. > > However it is still interesting that Dell Dock failed after setting > LTTPR to transparent mode. Yes, sinks should handle writing to this DPCD register regardless if there's any LTTPR on the link or not. > Thank You for your effort to enable LTTPR. > Khaled > > > > Writing to DP_PHY_REPEATER_MODE will also cause an unnecessary > > timeout > > on systems without any LTTPR. > > > > To fix the above two issues let's assume that setting the default > > mode > > is redundant when no LTTPRs are detected. Keep the existing behavior > > and > > program the default mode if more than 8 LTTPRs are detected or in > > case > > the read from DP_PHY_REPEATER_CNT returns an invalid value. > > > > References: https://gitlab.freedesktop.org/drm/intel/-/issues/2801 > > Signed-off-by: Imre Deak <imre.deak@intel.com> > > --- > > .../drm/i915/display/intel_dp_link_training.c | 36 ++++++++--------- > > -- > > 1 file changed, 15 insertions(+), 21 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c > > b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > > index d8c6d7054d11..fad9e9874c7b 100644 > > --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c > > +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > > @@ -34,18 +34,6 @@ intel_dp_dump_link_status(const u8 > > link_status[DP_LINK_STATUS_SIZE]) > > link_status[3], link_status[4], link_status[5]); > > } > > > > -static int intel_dp_lttpr_count(struct intel_dp *intel_dp) > > -{ > > -int count = drm_dp_lttpr_count(intel_dp->lttpr_common_caps); > > - > > -/* > > - * Pretend no LTTPRs in case of LTTPR detection error, or > > - * if too many (>8) LTTPRs are detected. This translates to > > link > > - * training in transparent mode. > > - */ > > -return count <= 0 ? 0 : count; > > -} > > - > > static void intel_dp_reset_lttpr_count(struct intel_dp *intel_dp) > > { > > intel_dp->lttpr_common_caps[DP_PHY_REPEATER_CNT - > > @@ -142,6 +130,17 @@ int intel_dp_lttpr_init(struct intel_dp > > *intel_dp) > > return 0; > > > > ret = intel_dp_read_lttpr_common_caps(intel_dp); > > +if (!ret) > > +return 0; > > + > > +lttpr_count = drm_dp_lttpr_count(intel_dp->lttpr_common_caps); > > +/* > > + * Prevent setting LTTPR transparent mode explicitly if no > > LTTPRs are > > + * detected as this breaks link training at least on the Dell > > WD19TB > > + * dock. > > + */ > > +if (lttpr_count == 0) > > +return 0; > > > > /* > > * See DP Standard v2.0 3.6.6.1. about the explicit disabling > > of > > @@ -150,17 +149,12 @@ int intel_dp_lttpr_init(struct intel_dp > > *intel_dp) > > */ > > intel_dp_set_lttpr_transparent_mode(intel_dp, true); > > > > -if (!ret) > > -return 0; > > - > > -lttpr_count = intel_dp_lttpr_count(intel_dp); > > - > > /* > > * In case of unsupported number of LTTPRs or failing to switch > > to > > * non-transparent mode fall-back to transparent link training > > mode, > > * still taking into account any LTTPR common lane- rate/count > > limits. > > */ > > -if (lttpr_count == 0) > > +if (lttpr_count < 0) > > return 0; > > > > if (!intel_dp_set_lttpr_transparent_mode(intel_dp, false)) { > > @@ -222,11 +216,11 @@ intel_dp_phy_is_downstream_of_source(struct > > intel_dp *intel_dp, > > enum drm_dp_phy dp_phy) > > { > > struct drm_i915_private *i915 = dp_to_i915(intel_dp); > > -int lttpr_count = intel_dp_lttpr_count(intel_dp); > > +int lttpr_count = drm_dp_lttpr_count(intel_dp- > > >lttpr_common_caps); > > > > -drm_WARN_ON_ONCE(&i915->drm, lttpr_count == 0 && dp_phy != > > DP_PHY_DPRX); > > +drm_WARN_ON_ONCE(&i915->drm, lttpr_count <= 0 && dp_phy != > > DP_PHY_DPRX); > > > > -return lttpr_count == 0 || dp_phy == DP_PHY_LTTPR(lttpr_count - > > 1); > > +return lttpr_count <= 0 || dp_phy == DP_PHY_LTTPR(lttpr_count - > > 1); > > } > > > > static u8 intel_dp_phy_voltage_max(struct intel_dp *intel_dp, _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dp: Prevent setting the LTTPR LT mode if no LTTPRs are detected 2021-01-21 13:15 ` Imre Deak @ 2021-01-28 20:22 ` Almahallawy, Khaled 0 siblings, 0 replies; 9+ messages in thread From: Almahallawy, Khaled @ 2021-01-28 20:22 UTC (permalink / raw) To: Deak, Imre; +Cc: intel-gfx On Thu, 2021-01-21 at 15:15 +0200, Imre Deak wrote: > On Tue, Jan 19, 2021 at 08:47:25AM +0200, Almahallawy, Khaled wrote: > > On Mon, 2021-01-18 at 20:31 +0200, Imre Deak wrote: > > > Atm, the driver programs explicitly the default transparent link > > > training mode (0x55) to DP_PHY_REPEATER_MODE even if no LTTPRs > > > are > > > detected. > > > > > > This conforms to the spec (3.6.6.1): > > > "DP upstream devices that do not enable the Non-transparent mode > > > of > > > LTTPRs shall program the PHY_REPEATER_MODE register (DPCD > > > Address > > > F0003h) to 55h (default) prior to link training" > > > > > > however writing the default value to this DPCD register seems to > > > cause > > > occasional link training errors at least for a DELL WD19TB TBT > > > dock, > > > when > > > no LTTPRs are detected. > > > > I think this patch is more aligned with: DP v2.0 SCR on 8b/10b DPTX > > and > > LTTPR Requirements Update to Section 3.6 > > > > The SCR made it clear that we only need to program > > PHY_REPEATER_MODE to > > transparent mode if we detect LTTPR. > > Yes, the updated version is clearer in this. In any case I don't see > any > reason now to set the default mode if there's no LTTPR on the link. > > > Quoting from SCR: > > “A DPTX supporting 3.2-ms AUX Reply Timeout shall issue AUX read > > transaction to LTTPR DPCD Capability and ID Field at DPCD F0000h ~ > > F0007 (refer to Section 3.6.4.1) as the first AUX transaction upon > > HPD > > signal assertion detection (1) to determine whether LTTPR’s are > > present > > in the link between itself and the downstream DPRX and (2) to put > > the > > LTTPR’s, if present, in LTTPR Transparent Mode.” > > > > Also section 3.6.6 title is updated as the following “Section 3.6.6 > > Link Training in LTTPR Non-transparent Mode”. This reflects it only > > relevant after we detect LTTPR. > > > > However it is still interesting that Dell Dock failed after setting > > LTTPR to transparent mode. > > Yes, sinks should handle writing to this DPCD register regardless if > there's any LTTPR on the link or not. > > > Thank You for your effort to enable LTTPR. > > Khaled > > > Writing to DP_PHY_REPEATER_MODE will also cause an unnecessary > > > timeout > > > on systems without any LTTPR. > > > > > > To fix the above two issues let's assume that setting the default > > > mode > > > is redundant when no LTTPRs are detected. Keep the existing > > > behavior > > > and > > > program the default mode if more than 8 LTTPRs are detected or in > > > case > > > the read from DP_PHY_REPEATER_CNT returns an invalid value. > > > > > > References: > > > https://gitlab.freedesktop.org/drm/intel/-/issues/2801 > > > Signed-off-by: Imre Deak <imre.deak@intel.com> > > > --- > > > .../drm/i915/display/intel_dp_link_training.c | 36 ++++++++----- > > > ---- > > > -- > > > 1 file changed, 15 insertions(+), 21 deletions(-) > > > > > > diff --git > > > a/drivers/gpu/drm/i915/display/intel_dp_link_training.c > > > b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > > > index d8c6d7054d11..fad9e9874c7b 100644 > > > --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c > > > +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > > > @@ -34,18 +34,6 @@ intel_dp_dump_link_status(const u8 > > > link_status[DP_LINK_STATUS_SIZE]) > > > link_status[3], link_status[4], link_status[5]); > > > } > > > > > > -static int intel_dp_lttpr_count(struct intel_dp *intel_dp) > > > -{ > > > -int count = drm_dp_lttpr_count(intel_dp->lttpr_common_caps); > > > - > > > -/* > > > - * Pretend no LTTPRs in case of LTTPR detection error, or > > > - * if too many (>8) LTTPRs are detected. This translates to > > > link > > > - * training in transparent mode. > > > - */ > > > -return count <= 0 ? 0 : count; > > > -} > > > - > > > static void intel_dp_reset_lttpr_count(struct intel_dp > > > *intel_dp) > > > { > > > intel_dp->lttpr_common_caps[DP_PHY_REPEATER_CNT - > > > @@ -142,6 +130,17 @@ int intel_dp_lttpr_init(struct intel_dp > > > *intel_dp) > > > return 0; > > > > > > ret = intel_dp_read_lttpr_common_caps(intel_dp); > > > +if (!ret) > > > +return 0; > > > + > > > +lttpr_count = drm_dp_lttpr_count(intel_dp->lttpr_common_caps); > > > +/* > > > + * Prevent setting LTTPR transparent mode explicitly if no > > > LTTPRs are > > > + * detected as this breaks link training at least on the Dell > > > WD19TB > > > + * dock. > > > + */ > > > +if (lttpr_count == 0) > > > +return 0; > > > > > > /* > > > * See DP Standard v2.0 3.6.6.1. about the explicit disabling > > > of > > > @@ -150,17 +149,12 @@ int intel_dp_lttpr_init(struct intel_dp > > > *intel_dp) > > > */ > > > intel_dp_set_lttpr_transparent_mode(intel_dp, true); > > > > > > -if (!ret) > > > -return 0; > > > - > > > -lttpr_count = intel_dp_lttpr_count(intel_dp); > > > - > > > /* > > > * In case of unsupported number of LTTPRs or failing to switch > > > to > > > * non-transparent mode fall-back to transparent link training > > > mode, > > > * still taking into account any LTTPR common lane- rate/count > > > limits. > > > */ > > > -if (lttpr_count == 0) > > > +if (lttpr_count < 0) > > > return 0; > > > > > > if (!intel_dp_set_lttpr_transparent_mode(intel_dp, false)) { > > > @@ -222,11 +216,11 @@ intel_dp_phy_is_downstream_of_source(struct > > > intel_dp *intel_dp, > > > enum drm_dp_phy dp_phy) > > > { > > > struct drm_i915_private *i915 = dp_to_i915(intel_dp); > > > -int lttpr_count = intel_dp_lttpr_count(intel_dp); > > > +int lttpr_count = drm_dp_lttpr_count(intel_dp- > > > > lttpr_common_caps); > > > > > > -drm_WARN_ON_ONCE(&i915->drm, lttpr_count == 0 && dp_phy != > > > DP_PHY_DPRX); > > > +drm_WARN_ON_ONCE(&i915->drm, lttpr_count <= 0 && dp_phy != > > > DP_PHY_DPRX); > > > > > > -return lttpr_count == 0 || dp_phy == DP_PHY_LTTPR(lttpr_count - > > > 1); > > > +return lttpr_count <= 0 || dp_phy == DP_PHY_LTTPR(lttpr_count - > > > 1); > > > } > > > > > > static u8 intel_dp_phy_voltage_max(struct intel_dp *intel_dp, Thank You for the patch. Reviewed-by: Khaled Almahallawy <khaled.almahallawy@intel.com> _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp: Prevent setting the LTTPR LT mode if no LTTPRs are detected 2021-01-18 18:31 [Intel-gfx] [PATCH] drm/i915/dp: Prevent setting the LTTPR LT mode if no LTTPRs are detected Imre Deak ` (2 preceding siblings ...) 2021-01-19 6:47 ` [Intel-gfx] [PATCH] " Almahallawy, Khaled @ 2021-01-29 20:39 ` Patchwork 3 siblings, 0 replies; 9+ messages in thread From: Patchwork @ 2021-01-29 20:39 UTC (permalink / raw) To: Imre Deak; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 21196 bytes --] == Series Details == Series: drm/i915/dp: Prevent setting the LTTPR LT mode if no LTTPRs are detected URL : https://patchwork.freedesktop.org/series/86007/ State : success == Summary == CI Bug Log - changes from CI_DRM_9636_full -> Patchwork_19399_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_19399_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_persistence@engines-mixed: - shard-hsw: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#1099]) +2 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-hsw2/igt@gem_ctx_persistence@engines-mixed.html * igt@gem_exec_capture@pi@rcs0: - shard-skl: [PASS][2] -> [INCOMPLETE][3] ([i915#2369] / [i915#2502]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl2/igt@gem_exec_capture@pi@rcs0.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl2/igt@gem_exec_capture@pi@rcs0.html * igt@gem_exec_fair@basic-none-solo@rcs0: - shard-kbl: [PASS][4] -> [FAIL][5] ([i915#2842]) +1 similar issue [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-kbl6/igt@gem_exec_fair@basic-none-solo@rcs0.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl7/igt@gem_exec_fair@basic-none-solo@rcs0.html * igt@gem_exec_fair@basic-pace@vcs0: - shard-glk: [PASS][6] -> [FAIL][7] ([i915#2842]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk9/igt@gem_exec_fair@basic-pace@vcs0.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk2/igt@gem_exec_fair@basic-pace@vcs0.html * igt@gem_exec_fair@basic-pace@vecs0: - shard-kbl: [PASS][8] -> [SKIP][9] ([fdo#109271]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-kbl4/igt@gem_exec_fair@basic-pace@vecs0.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl6/igt@gem_exec_fair@basic-pace@vecs0.html - shard-tglb: [PASS][10] -> [FAIL][11] ([i915#2842]) +1 similar issue [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-tglb2/igt@gem_exec_fair@basic-pace@vecs0.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-tglb8/igt@gem_exec_fair@basic-pace@vecs0.html - shard-iclb: [PASS][12] -> [FAIL][13] ([i915#2842]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb5/igt@gem_exec_fair@basic-pace@vecs0.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb7/igt@gem_exec_fair@basic-pace@vecs0.html * igt@gem_exec_reloc@basic-wide-active@vcs1: - shard-iclb: NOTRUN -> [FAIL][14] ([i915#2389]) +1 similar issue [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb4/igt@gem_exec_reloc@basic-wide-active@vcs1.html * igt@gem_render_copy@y-tiled-to-vebox-linear: - shard-hsw: NOTRUN -> [SKIP][15] ([fdo#109271]) +165 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-hsw2/igt@gem_render_copy@y-tiled-to-vebox-linear.html * igt@gem_workarounds@suspend-resume-fd: - shard-kbl: [PASS][16] -> [DMESG-WARN][17] ([i915#180]) +1 similar issue [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html * igt@i915_pm_rps@reset: - shard-snb: [PASS][18] -> [FAIL][19] ([i915#39]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-snb4/igt@i915_pm_rps@reset.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-snb4/igt@i915_pm_rps@reset.html * igt@kms_async_flips@alternate-sync-async-flip: - shard-skl: [PASS][20] -> [FAIL][21] ([i915#2521]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl2/igt@kms_async_flips@alternate-sync-async-flip.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl2/igt@kms_async_flips@alternate-sync-async-flip.html * igt@kms_chamelium@hdmi-aspect-ratio: - shard-hsw: NOTRUN -> [SKIP][22] ([fdo#109271] / [fdo#111827]) +11 similar issues [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-hsw2/igt@kms_chamelium@hdmi-aspect-ratio.html * igt@kms_color_chamelium@pipe-a-ctm-green-to-red: - shard-skl: NOTRUN -> [SKIP][23] ([fdo#109271] / [fdo#111827]) +2 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/igt@kms_color_chamelium@pipe-a-ctm-green-to-red.html * igt@kms_cursor_crc@pipe-b-cursor-64x64-sliding: - shard-skl: NOTRUN -> [FAIL][24] ([i915#54]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/igt@kms_cursor_crc@pipe-b-cursor-64x64-sliding.html * igt@kms_cursor_crc@pipe-c-cursor-64x21-random: - shard-skl: [PASS][25] -> [FAIL][26] ([i915#54]) +12 similar issues [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@kms_cursor_crc@pipe-c-cursor-64x21-random.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl9/igt@kms_cursor_crc@pipe-c-cursor-64x21-random.html * igt@kms_draw_crc@draw-method-rgb565-render-xtiled: - shard-skl: [PASS][27] -> [DMESG-WARN][28] ([i915#1982]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@kms_draw_crc@draw-method-rgb565-render-xtiled.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl9/igt@kms_draw_crc@draw-method-rgb565-render-xtiled.html * igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2: - shard-glk: [PASS][29] -> [FAIL][30] ([i915#2122]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk1/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk3/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2.html * igt@kms_flip@bo-too-big@a-hdmi-a1: - shard-glk: [PASS][31] -> [DMESG-WARN][32] ([i915#118] / [i915#95]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk6/igt@kms_flip@bo-too-big@a-hdmi-a1.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk1/igt@kms_flip@bo-too-big@a-hdmi-a1.html * igt@kms_flip@flip-vs-suspend-interruptible@a-edp1: - shard-skl: [PASS][33] -> [INCOMPLETE][34] ([i915#198] / [i915#1982]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl10/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl1/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html * igt@kms_flip@flip-vs-suspend@a-dp1: - shard-apl: [PASS][35] -> [DMESG-WARN][36] ([i915#180]) +2 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-apl1/igt@kms_flip@flip-vs-suspend@a-dp1.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-apl6/igt@kms_flip@flip-vs-suspend@a-dp1.html * igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1: - shard-skl: [PASS][37] -> [FAIL][38] ([i915#2122]) +4 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl5/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl4/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt: - shard-skl: NOTRUN -> [SKIP][39] ([fdo#109271]) +26 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt.html * igt@kms_pipe_crc_basic@read-crc-pipe-a: - shard-glk: [PASS][40] -> [FAIL][41] ([i915#53]) [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk6/igt@kms_pipe_crc_basic@read-crc-pipe-a.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk1/igt@kms_pipe_crc_basic@read-crc-pipe-a.html * igt@kms_plane_alpha_blend@pipe-a-alpha-7efc: - shard-skl: NOTRUN -> [FAIL][42] ([fdo#108145] / [i915#265]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html * igt@kms_psr@psr2_suspend: - shard-iclb: [PASS][43] -> [SKIP][44] ([fdo#109441]) +2 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb2/igt@kms_psr@psr2_suspend.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb1/igt@kms_psr@psr2_suspend.html #### Possible fixes #### * igt@feature_discovery@psr2: - shard-iclb: [SKIP][45] ([i915#658]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb6/igt@feature_discovery@psr2.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb2/igt@feature_discovery@psr2.html * igt@gem_ctx_persistence@close-replace-race: - shard-glk: [TIMEOUT][47] ([i915#2918]) -> [PASS][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk4/igt@gem_ctx_persistence@close-replace-race.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk6/igt@gem_ctx_persistence@close-replace-race.html * igt@gem_exec_fair@basic-flow@rcs0: - shard-tglb: [FAIL][49] ([i915#2842]) -> [PASS][50] [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-tglb6/igt@gem_exec_fair@basic-flow@rcs0.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-tglb3/igt@gem_exec_fair@basic-flow@rcs0.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-iclb: [FAIL][51] ([i915#2842]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb7/igt@gem_exec_fair@basic-none-share@rcs0.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb3/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-none@vcs0: - shard-kbl: [FAIL][53] ([i915#2842]) -> [PASS][54] +2 similar issues [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-kbl2/igt@gem_exec_fair@basic-none@vcs0.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl3/igt@gem_exec_fair@basic-none@vcs0.html * igt@gem_exec_fair@basic-none@vecs0: - shard-apl: [FAIL][55] ([i915#2842]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-apl8/igt@gem_exec_fair@basic-none@vecs0.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-apl7/igt@gem_exec_fair@basic-none@vecs0.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-glk: [FAIL][57] ([i915#2842]) -> [PASS][58] +1 similar issue [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk1/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_schedule@u-fairslice@rcs0: - shard-skl: [DMESG-WARN][59] ([i915#1610] / [i915#2803]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl10/igt@gem_exec_schedule@u-fairslice@rcs0.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/igt@gem_exec_schedule@u-fairslice@rcs0.html * igt@kms_color@pipe-a-ctm-0-5: - shard-skl: [DMESG-WARN][61] ([i915#1982]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@kms_color@pipe-a-ctm-0-5.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl9/igt@kms_color@pipe-a-ctm-0-5.html * igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen: - shard-skl: [FAIL][63] ([i915#54]) -> [PASS][64] +3 similar issues [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen.html * igt@kms_cursor_edge_walk@pipe-a-64x64-top-edge: - shard-glk: [DMESG-WARN][65] ([i915#118] / [i915#95]) -> [PASS][66] [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-glk6/igt@kms_cursor_edge_walk@pipe-a-64x64-top-edge.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-glk1/igt@kms_cursor_edge_walk@pipe-a-64x64-top-edge.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1: - shard-skl: [FAIL][67] ([i915#79]) -> [PASS][68] [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html * igt@kms_flip@flip-vs-expired-vblank@c-dp1: - shard-apl: [FAIL][69] ([i915#79]) -> [PASS][70] [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-apl2/igt@kms_flip@flip-vs-expired-vblank@c-dp1.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-apl1/igt@kms_flip@flip-vs-expired-vblank@c-dp1.html * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc: - shard-skl: [FAIL][71] ([fdo#108145] / [i915#265]) -> [PASS][72] [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl3/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html * igt@kms_psr@psr2_sprite_render: - shard-iclb: [SKIP][73] ([fdo#109441]) -> [PASS][74] +1 similar issue [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb6/igt@kms_psr@psr2_sprite_render.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb2/igt@kms_psr@psr2_sprite_render.html * igt@perf@short-reads: - shard-skl: [FAIL][75] ([i915#51]) -> [PASS][76] [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl2/igt@perf@short-reads.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl2/igt@perf@short-reads.html #### Warnings #### * igt@gem_exec_fair@basic-throttle@rcs0: - shard-iclb: [FAIL][77] ([i915#2842]) -> [FAIL][78] ([i915#2849]) [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@i915_pm_rc6_residency@rc6-fence: - shard-iclb: [WARN][79] ([i915#2684]) -> [WARN][80] ([i915#2681] / [i915#2684]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb2/igt@i915_pm_rc6_residency@rc6-fence.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb1/igt@i915_pm_rc6_residency@rc6-fence.html * igt@i915_pm_rc6_residency@rc6-idle: - shard-iclb: [WARN][81] ([i915#1804] / [i915#2684]) -> [WARN][82] ([i915#2684]) [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb4/igt@i915_pm_rc6_residency@rc6-idle.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb2/igt@i915_pm_rc6_residency@rc6-idle.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3: - shard-iclb: [SKIP][83] ([i915#2920]) -> [SKIP][84] ([i915#658]) +2 similar issues [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb3/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4: - shard-iclb: [SKIP][85] ([i915#658]) -> [SKIP][86] ([i915#2920]) +2 similar issues [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-iclb6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html * igt@runner@aborted: - shard-kbl: [FAIL][87] ([i915#2295] / [i915#2505]) -> ([FAIL][88], [FAIL][89], [FAIL][90]) ([i915#2292] / [i915#2295]) [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-kbl6/igt@runner@aborted.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl3/igt@runner@aborted.html [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl2/igt@runner@aborted.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-kbl3/igt@runner@aborted.html - shard-skl: ([FAIL][91], [FAIL][92], [FAIL][93]) ([i915#2029] / [i915#2295] / [i915#2426]) -> [FAIL][94] ([i915#2295]) [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl5/igt@runner@aborted.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl10/igt@runner@aborted.html [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9636/shard-skl3/igt@runner@aborted.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/shard-skl3/igt@runner@aborted.html ### Piglit changes ### #### Issues hit #### * spec@ext_framebuffer_multisample_blit_scaled@blit-scaled samples=2: - pig-glk-j5005: NOTRUN -> [WARN][95] ([mesa#1797]) +1 similar issue [95]: None [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804 [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2292]: https://gitlab.freedesktop.org/drm/intel/issues/2292 [i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295 [i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369 [i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389 [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426 [i915#2502]: https://gitlab.freedesktop.org/drm/intel/issues/2502 [i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505 [i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681 [i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684 [i915#2803]: https://gitlab.freedesktop.org/drm/intel/issues/2803 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849 [i915#2918]: https://gitlab.freedesktop.org/drm/intel/issues/2918 [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 [i915#39]: https://gitlab.freedesktop.org/drm/intel/issues/39 [i915#51]: https://gitlab.freedesktop.org/drm/intel/issues/51 [i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53 [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 [mesa#1797]: https://gitlab.freedesktop.org/mesa/mesa/issues/1797 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * Linux: CI_DRM_9636 -> Patchwork_19399 CI-20190529: 20190529 CI_DRM_9636: f560ac388c527f2f166897c9091f7b9ad652050f @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5960: ace82fcd5f3623f8dde7c220a825873dc53dfae4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_19399: f21bd65b0c50affc5cbf3e239ff26377e129ae68 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19399/index.html [-- Attachment #1.2: Type: text/html, Size: 25380 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-01-29 21:16 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-01-18 18:31 [Intel-gfx] [PATCH] drm/i915/dp: Prevent setting the LTTPR LT mode if no LTTPRs are detected Imre Deak 2021-01-18 20:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2021-01-19 1:46 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2021-01-29 20:18 ` Imre Deak 2021-01-29 21:16 ` Vudum, Lakshminarayana 2021-01-19 6:47 ` [Intel-gfx] [PATCH] " Almahallawy, Khaled 2021-01-21 13:15 ` Imre Deak 2021-01-28 20:22 ` Almahallawy, Khaled 2021-01-29 20:39 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.