* [PATCH] video: fbdev: uvesafb: constify attribute_group structures.
@ 2017-07-19 5:28 ` Arvind Yadav
0 siblings, 0 replies; 4+ messages in thread
From: Arvind Yadav @ 2017-07-19 5:16 UTC (permalink / raw)
To: spock, b.zolnierkie; +Cc: linux-fbdev, linux-kernel
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
15426 4952 187 20565 5055 drivers/video/fbdev/uvesafb.o
File size After adding 'const':
text data bss dec hex filename
15490 4888 187 20565 5055 drivers/video/fbdev/uvesafb.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/uvesafb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c
index dc0e8d9..ad05d25f 100644
--- a/drivers/video/fbdev/uvesafb.c
+++ b/drivers/video/fbdev/uvesafb.c
@@ -1666,7 +1666,7 @@ static DEVICE_ATTR(nocrtc, S_IRUGO | S_IWUSR, uvesafb_show_nocrtc,
NULL,
};
-static struct attribute_group uvesafb_dev_attgrp = {
+static const struct attribute_group uvesafb_dev_attgrp = {
.name = NULL,
.attrs = uvesafb_dev_attrs,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] video: fbdev: uvesafb: constify attribute_group structures.
@ 2017-07-19 5:28 ` Arvind Yadav
0 siblings, 0 replies; 4+ messages in thread
From: Arvind Yadav @ 2017-07-19 5:28 UTC (permalink / raw)
To: spock, b.zolnierkie; +Cc: linux-fbdev, linux-kernel
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
15426 4952 187 20565 5055 drivers/video/fbdev/uvesafb.o
File size After adding 'const':
text data bss dec hex filename
15490 4888 187 20565 5055 drivers/video/fbdev/uvesafb.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/uvesafb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c
index dc0e8d9..ad05d25f 100644
--- a/drivers/video/fbdev/uvesafb.c
+++ b/drivers/video/fbdev/uvesafb.c
@@ -1666,7 +1666,7 @@ static DEVICE_ATTR(nocrtc, S_IRUGO | S_IWUSR, uvesafb_show_nocrtc,
NULL,
};
-static struct attribute_group uvesafb_dev_attgrp = {
+static const struct attribute_group uvesafb_dev_attgrp = {
.name = NULL,
.attrs = uvesafb_dev_attrs,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] video: fbdev: uvesafb: constify attribute_group structures.
2017-07-19 5:28 ` Arvind Yadav
@ 2017-08-01 13:53 ` Bartlomiej Zolnierkiewicz
-1 siblings, 0 replies; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-08-01 13:53 UTC (permalink / raw)
To: Arvind Yadav; +Cc: spock, linux-fbdev, linux-kernel
On Wednesday, July 19, 2017 10:46:55 AM Arvind Yadav wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 15426 4952 187 20565 5055 drivers/video/fbdev/uvesafb.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 15490 4888 187 20565 5055 drivers/video/fbdev/uvesafb.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Patch queued for 4.14, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] video: fbdev: uvesafb: constify attribute_group structures.
@ 2017-08-01 13:53 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-08-01 13:53 UTC (permalink / raw)
To: Arvind Yadav; +Cc: spock, linux-fbdev, linux-kernel
On Wednesday, July 19, 2017 10:46:55 AM Arvind Yadav wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 15426 4952 187 20565 5055 drivers/video/fbdev/uvesafb.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 15490 4888 187 20565 5055 drivers/video/fbdev/uvesafb.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Patch queued for 4.14, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-01 13:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170719051736epcas5p3b707e162f6741c876a069f0eb0768fd7@epcas5p3.samsung.com>
2017-07-19 5:16 ` [PATCH] video: fbdev: uvesafb: constify attribute_group structures Arvind Yadav
2017-07-19 5:28 ` Arvind Yadav
2017-08-01 13:53 ` Bartlomiej Zolnierkiewicz
2017-08-01 13:53 ` Bartlomiej Zolnierkiewicz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.