* [Xen-devel] [PATCH] tools: fix linking hypervisor includes to tools include directory
@ 2019-09-11 6:02 Juergen Gross
2019-09-11 10:39 ` Ian Jackson
0 siblings, 1 reply; 3+ messages in thread
From: Juergen Gross @ 2019-09-11 6:02 UTC (permalink / raw)
To: xen-devel; +Cc: Juergen Gross, Ian Jackson, Wei Liu
An incremental build of tools/include won't pickup new hypervisor
headers in tools/include/xen. Fix that.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
tools/include/Makefile | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/tools/include/Makefile b/tools/include/Makefile
index 71538e1ce2..3d0192fbad 100644
--- a/tools/include/Makefile
+++ b/tools/include/Makefile
@@ -12,11 +12,14 @@ all-y:
xen-foreign:
$(MAKE) -C xen-foreign
-xen/.dir:
+XEN_PUBLIC_INCLUDES = $(wildcard $(XEN_ROOT)/xen/include/public/*.h)
+XEN_LIB_X86_INCLUDES = $(filter-out %autogen.h, $(XEN_ROOT)/xen/include/xen/lib/x86/Makefile $(wildcard $(XEN_ROOT)/xen/include/xen/lib/x86/*.h))
+
+xen/.dir: $(XEN_PUBLIC_INCLUDES) $(XEN_LIB_X86_INCLUDES)
@rm -rf xen
mkdir -p xen/libelf
ln -sf $(XEN_ROOT)/xen/include/public/COPYING xen
- ln -sf $(wildcard $(XEN_ROOT)/xen/include/public/*.h) xen
+ ln -sf $(XEN_PUBLIC_INCLUDES) xen
ln -sf $(addprefix $(XEN_ROOT)/xen/include/public/,arch-x86 arch-arm hvm io xsm) xen
ln -sf ../xen-sys/$(XEN_OS) xen/sys
ln -sf $(addprefix $(XEN_ROOT)/xen/include/xen/,libelf.h elfstructs.h) xen/libelf/
@@ -25,7 +28,7 @@ xen/.dir:
ifeq ($(CONFIG_X86),y)
ln -sf $(XEN_ROOT)/xen/include/asm-x86 xen/asm
mkdir -p xen/lib/x86
- for f in $(filter-out %autogen.h,$(patsubst $(XEN_ROOT)/xen/include/xen/lib/x86/%,%,Makefile $(wildcard $(XEN_ROOT)/xen/include/xen/lib/x86/*.h))); do \
+ for f in $(patsubst $(XEN_ROOT)/xen/include/xen/lib/x86/%,%,$(XEN_LIB_X86_INCLUDES)); do \
ln -sf $(XEN_ROOT)/xen/include/xen/lib/x86/$$f xen/lib/x86/$$f; \
done
endif
--
2.16.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Xen-devel] [PATCH] tools: fix linking hypervisor includes to tools include directory
2019-09-11 6:02 [Xen-devel] [PATCH] tools: fix linking hypervisor includes to tools include directory Juergen Gross
@ 2019-09-11 10:39 ` Ian Jackson
2019-09-20 11:18 ` Ian Jackson
0 siblings, 1 reply; 3+ messages in thread
From: Ian Jackson @ 2019-09-11 10:39 UTC (permalink / raw)
To: Juergen Gross; +Cc: xen-devel, Wei Liu
Juergen Gross writes ("[PATCH] tools: fix linking hypervisor includes to tools include directory"):
> An incremental build of tools/include won't pickup new hypervisor
> headers in tools/include/xen. Fix that.
I personally I think trying to get this kind of thing to work properly
with recursive make is too hard to be worth trying. But I won't stand
in your way.
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Xen-devel] [PATCH] tools: fix linking hypervisor includes to tools include directory
2019-09-11 10:39 ` Ian Jackson
@ 2019-09-20 11:18 ` Ian Jackson
0 siblings, 0 replies; 3+ messages in thread
From: Ian Jackson @ 2019-09-20 11:18 UTC (permalink / raw)
To: Juergen Gross, xen-devel, Wei Liu
Ian Jackson writes ("Re: [PATCH] tools: fix linking hypervisor includes to tools include directory"):
> Juergen Gross writes ("[PATCH] tools: fix linking hypervisor includes to tools include directory"):
> > An incremental build of tools/include won't pickup new hypervisor
> > headers in tools/include/xen. Fix that.
>
> I personally I think trying to get this kind of thing to work properly
> with recursive make is too hard to be worth trying. But I won't stand
> in your way.
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
And committed.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-20 11:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-11 6:02 [Xen-devel] [PATCH] tools: fix linking hypervisor includes to tools include directory Juergen Gross
2019-09-11 10:39 ` Ian Jackson
2019-09-20 11:18 ` Ian Jackson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.